| 7621506c7ade0a034f1cb77f5c1215db103768db |
|
16-Jan-2018 |
Hansong Zhang <hsz@google.com> |
OBEX Server Socket: Don't reject connection
OBEX Server socket should not reject new connection; instead, the user
should reject new connection if the user cannot handle it.
Bug: 72006198
Test: carkits MAP, PBAP; phones with OPP
Change-Id: I99a766daf4b5a17b25a652c4ef131e7ba7df26c8
/packages/apps/Bluetooth/src/com/android/bluetooth/ObexServerSockets.java
|
| c4fbd756e2645147470c486ae96f2253f5e13a52 |
|
12-Oct-2017 |
Jack He <siyuanh@google.com> |
[Script] Fix checkstyle errors (1/2)
Format code using Intellij to conform to CheckStyle requirements
Bug: 63597465
Test: make checkbuild, no manual changes, no functional changes
Change-Id: I70cd2ab8e5e6d5428ab1556658735b0d83f4fb15
/packages/apps/Bluetooth/src/com/android/bluetooth/ObexServerSockets.java
|
| 8bc413b0b749ea9df59e858493273e05087fe887 |
|
11-Oct-2017 |
Jack He <siyuanh@google.com> |
[Manual] Rename non-public non-static variables to mCamelCase
* Run "instance field naming convention" inspection in Intellij
* Rename variables that are non-public non-static to m + Camel Case
* Renaming is done through refactor tool in Intellij
* Private variables are renamed to m + Camel Case
* Non-private variables are added with public modifier to indicate that
they are accessed externally as well
Bug: 63597465
Test: make checkbuild, no functional changes
Change-Id: I88400ac99fa1ba084cdfa35600bd3c23f1dd1a33
/packages/apps/Bluetooth/src/com/android/bluetooth/ObexServerSockets.java
|
| 5ef52da260f8b4c1baed22bceb2983a694bb022c |
|
11-Oct-2017 |
Jack He <siyuanh@google.com> |
[Manual] Fix local variable names
* Run "Local variable naming convention" inspection in Intellij
* Fix warnings through automatic refactoring
* Move certain constant local variables out as a "private static final"
variable at class level
Bug: 63597465
Test: make checkbuild, no functional changes
Change-Id: Ifa97e8c8dc2c76a4456d26d5f53294efcb9955ac
/packages/apps/Bluetooth/src/com/android/bluetooth/ObexServerSockets.java
|
| d04c0a8609b39f891d5787f051b1dfb105ceee93 |
|
11-Oct-2017 |
Jack He <siyuanh@google.com> |
[Manual] Remove redundant 'public' modifier
* Remove redundant 'public' modifier from non-public classes'
constructors
* Fixes all occurances labeled as "Redundant 'public' modifier' by
CheckStyle
Bug: 63597465
Test: make checkbuild, no functional changes
Change-Id: I45ece6deafa612fee36e06877065c903815466d2
/packages/apps/Bluetooth/src/com/android/bluetooth/ObexServerSockets.java
|
| 32a94e2fdbaa66fb26bd0be2425b55151b5e493b |
|
10-Oct-2017 |
Jack He <siyuanh@google.com> |
[Script] Simplify pointless boolean expressions
* Run "Pointless boolean expression inspection" in Intellij
* Fix issues like
a == false -> !a
a == true -> a
a != true -> !a
a != false -> a
Bug: 63597465
Test: make checkbuild, no manual changes, no functional changes
Change-Id: I303e8ee7c1cb0d76ccd86edcb08c6e763e2aa7ea
/packages/apps/Bluetooth/src/com/android/bluetooth/ObexServerSockets.java
|
| dbf5c4e1c9e57fa6e5cc96ee9f442da8aa391a5d |
|
10-Oct-2017 |
Jack He <siyuanh@google.com> |
[Script] Sort modifiers according to JLS
* Correct order is:
1. public
2. protected
3. private
4. abstract
5. default
6. static
7. final
8. transient
9. volatile
10. synchronized
11. native
12. strictfp
* This is achieve through running automatic code cleanup in Intellij
using "Missorted modifiers" inspection
Bug: 63597465
Test: make checkbuild, no manual changes, no functional changes
Change-Id: Id9c8a3c6bf1195b43d986c4324da94ca8c44367f
/packages/apps/Bluetooth/src/com/android/bluetooth/ObexServerSockets.java
|
| 5a37bc407ab1b8844c3541ff4e6653635b108bed |
|
17-Feb-2017 |
Hemant Gupta <hemantg@codeaurora.org> |
PBAP: Add support for PBAP 1.2
Add changes required to do the SDP registration as
supported by 1.2, L2CAP related functionality and counter
related changes to support PBAP 1.2.
Test: Connected with Remote PBAP Client supporting PBAP 1.2 and
verified that connection and transfer happens over L2CAP.
Connected with Remote PBAP Client supporting PBAP 1.1 and
and verified that connection and transfer happens over RFCOMM.
Bug: 33011817
Change-Id: Iddace24f43a7618ccbe6a9b49bcab88dbaae0e06
/packages/apps/Bluetooth/src/com/android/bluetooth/ObexServerSockets.java
|
| 4aa5e4e2fe52c06d97481db0bf180349053dae48 |
|
16-Feb-2017 |
Hemant Gupta <hemantg@codeaurora.org> |
OPP: Add OPP 1.2 feature.
Add changes to support OPP 1.2 which uses OBEX over L2CAP.
Test: Connect with Remote OPP Client supporting OPP 1.2 and verify
that connection and transfer happens over L2CAP. Connect with Remote
OPP Client supporting OPP 1.1 and verify that connection and transfer
happens over RFCOMM.
Bug: 33010988
Change-Id: I44c2f2f01fb04f4306d0eb121d66dc08954966c0
/packages/apps/Bluetooth/src/com/android/bluetooth/ObexServerSockets.java
|
| b68b83c0463161ce65922ec606f12244446efab1 |
|
19-Aug-2016 |
Joseph Pirozzo <pirozzoj@google.com> |
MAP MCE
Message Access Profile Client code. Supports Message Notification
Service server and Message Access Service Client for sending messages
and receiving new messages and retrieving unread messages.
Bug: 30467210
Change-Id: Ia4f27f11acbbcb5975d85344f0c19be3d1975b66
(cherry picked from commit 7765761c05e1cb2231198e7b9dccba5254c0cf75)
/packages/apps/Bluetooth/src/com/android/bluetooth/ObexServerSockets.java
|
| eb7b90f5b93db1230a5b64caa3d8d05a642e33a6 |
|
10-May-2016 |
Marie Janssen <jamuraa@google.com> |
Cleanup unused requires in java files
Change-Id: I7b055c1d3d3f6a69e9f49c077853ab45fcad7106
/packages/apps/Bluetooth/src/com/android/bluetooth/ObexServerSockets.java
|
| bbb4110b455b3aa29106d5b4f0a37e1be8e09475 |
|
09-Apr-2015 |
Casper Bonde <c.bonde@samsung.com> |
Obex over L2CAP + SDP search API
Each profile had its own implementation of ObexTransport.
These implementations were implemented very similar, and
could easily be merged into a common implementation.
Additionally it will make it easier to adopt the transport
to support L2CAP.
The SDP functionality is implemented in a way that is scalable,
hence adding new record types is easy.
Intents are currently used to distribute the SDP search results,
as we have observed that the new client side profiles have been
located outside the Bluetooth package.
We strongly recommend to keep all bluetooth profiles within the
Bluetooth package, to acoid the need for exposing all bluetooth
interfaces through the Android framework. For instance this new
SDP create API is internal to Bluetooth, hence cannot be used by
the external profiles - hence they cannot use OBEX over L2CAP.
The SDP search currently supports:
- MAP both sides
- OPP server (only the server needs an SDP record)
- PBAP server (only the server needs SDP record)
The SDP create record currently supports:
- MAP both sides
- OPP server
- PBAP server
The new l2cap sockets introduces a new wrapper class for a rfcomm
and an l2cap socket.
The wrapper design:
- Creates two accept threads running while bluetooth is
turned on.
- When a connection is accepted the owner is asked wether or not
to accept the connection if rejected, the connection will be
rejected at obex level, else it will be accepted and the state
is changed to busy.
- Any further connections will be rejected at Obex level, until
the state is changed back to idle.
Notes tor executing the test cases:
Test OBEX using local pipes(no BT) or two bluetooth enabled
devices.
Test SDP using two Bluetooth enabled devices
Start server testcase first on one device, then start
the matching client test on the other device.
You cannot run all tests in one go, as they need to run
on multiple devices.
Edit the test sequesce to add/remove/modify the sequence
of OBEX operations to perform.
Use the new SDP record create interface.
Change-Id: I3941793f9843abf4afa5ffbee40d1d01c118b29b
Signed-off-by: Casper Bonde <c.bonde@samsung.com>
/packages/apps/Bluetooth/src/com/android/bluetooth/ObexServerSockets.java
|