| 65a6b0e556d87a4f749105b4e0bc9e16c23b74fd |
|
20-Feb-2018 |
Myles Watson <mylesgw@google.com> |
PBAP: Handle null contacts in the updateList
Bug: 72435402
Test: runtest bluetooth
Change-Id: I0f25bc4ce53a977c49f814692cb39bc2b1aa50ec
/packages/apps/Bluetooth/src/com/android/bluetooth/pbap/BluetoothPbapUtils.java
|
| bceb51ca01959f3871648a6f68aa9f2779f1910b |
|
26-Jan-2018 |
Myles Watson <mylesgw@google.com> |
PBAP: Use a message to signal CONTACTS_LOADED
Bug: 72435402
Test: runtest bluetooth
Connect and disconnect to a car kit
Change-Id: Ia23d18acf20d4edd090fb55eb53fd972a388a64f
/packages/apps/Bluetooth/src/com/android/bluetooth/pbap/BluetoothPbapUtils.java
|
| 84b74f21ad79819fbbabd703ebdeb6ff69f917d6 |
|
26-Jan-2018 |
Myles Watson <mylesgw@google.com> |
PBAP: Get ready to reload contacts on user switch
PbapService:
- Use ACTION string constants to avoid null checks
- Remove the parameters for savePbapParams
- Remove unnecessary try blocks
PbapUtils:
- Reduce the scope of local variables
- Rename static variables s<VariableName>
- Remove dead code
- Avoid a null-pointer exception in nameTmp mName comparison
Bug: 72435402
Test: runtest bluetooth
Connect and disconnect to a car kit
Change-Id: I15531abfe7eb9c76788eed301f9356d60c7a6829
/packages/apps/Bluetooth/src/com/android/bluetooth/pbap/BluetoothPbapUtils.java
|
| 668166cd4bcfe22a3907409ac771f41512ddbd54 |
|
01-Dec-2017 |
Hemant Gupta <hemantg@codeaurora.org> |
PBAP: Handle PBAP Disconnection when contacts are not loaded
Usecase:
1) Establish PBAP session.
2) Send Disconnect-Connect before Pbap service message handler
processes LOAD_CONTACT completely.
Issue:
Connect operation after immediate disconnect fails.
Root Cause:
stopObexServerSession is not processed as service message
handler is processing LOAD_CONTACT leading mConAccepted
to be true when next connect is recieved.
Fix:
loadAllContacts() is handled from new thread instead
of main thread.
Test: Checked if PBAP can be connected as per above usecase.
Bug: 66990891
Change-Id: If6fafe166752e5c7c4cded25a112223d4c3d0be9
/packages/apps/Bluetooth/src/com/android/bluetooth/pbap/BluetoothPbapUtils.java
|
| c4fbd756e2645147470c486ae96f2253f5e13a52 |
|
12-Oct-2017 |
Jack He <siyuanh@google.com> |
[Script] Fix checkstyle errors (1/2)
Format code using Intellij to conform to CheckStyle requirements
Bug: 63597465
Test: make checkbuild, no manual changes, no functional changes
Change-Id: I70cd2ab8e5e6d5428ab1556658735b0d83f4fb15
/packages/apps/Bluetooth/src/com/android/bluetooth/pbap/BluetoothPbapUtils.java
|
| 8bc413b0b749ea9df59e858493273e05087fe887 |
|
11-Oct-2017 |
Jack He <siyuanh@google.com> |
[Manual] Rename non-public non-static variables to mCamelCase
* Run "instance field naming convention" inspection in Intellij
* Rename variables that are non-public non-static to m + Camel Case
* Renaming is done through refactor tool in Intellij
* Private variables are renamed to m + Camel Case
* Non-private variables are added with public modifier to indicate that
they are accessed externally as well
Bug: 63597465
Test: make checkbuild, no functional changes
Change-Id: I88400ac99fa1ba084cdfa35600bd3c23f1dd1a33
/packages/apps/Bluetooth/src/com/android/bluetooth/pbap/BluetoothPbapUtils.java
|
| 1bd017d12cf16ecd52fb486722e300790bddeefc |
|
11-Oct-2017 |
Jack He <siyuanh@google.com> |
[Manual] Fix static field names
* Run 'static' field naming convention inspection in Intellij
* Use regex s[A-Z][A-Za-z\d]*, the same one in CheckStyle
* Change non-public variable names to sCamelCase
* Add final modifier to constants
Bug: 63597465
Test: make checkbuild, no functional changes
Change-Id: I395bf3e11c2932b36cda471ca088dc5345b0f378
/packages/apps/Bluetooth/src/com/android/bluetooth/pbap/BluetoothPbapUtils.java
|
| 5ef52da260f8b4c1baed22bceb2983a694bb022c |
|
11-Oct-2017 |
Jack He <siyuanh@google.com> |
[Manual] Fix local variable names
* Run "Local variable naming convention" inspection in Intellij
* Fix warnings through automatic refactoring
* Move certain constant local variables out as a "private static final"
variable at class level
Bug: 63597465
Test: make checkbuild, no functional changes
Change-Id: Ifa97e8c8dc2c76a4456d26d5f53294efcb9955ac
/packages/apps/Bluetooth/src/com/android/bluetooth/pbap/BluetoothPbapUtils.java
|
| d04c0a8609b39f891d5787f051b1dfb105ceee93 |
|
11-Oct-2017 |
Jack He <siyuanh@google.com> |
[Manual] Remove redundant 'public' modifier
* Remove redundant 'public' modifier from non-public classes'
constructors
* Fixes all occurances labeled as "Redundant 'public' modifier' by
CheckStyle
Bug: 63597465
Test: make checkbuild, no functional changes
Change-Id: I45ece6deafa612fee36e06877065c903815466d2
/packages/apps/Bluetooth/src/com/android/bluetooth/pbap/BluetoothPbapUtils.java
|
| cf92c2759b709461acf7c36c08f4eef9c8004c85 |
|
09-Mar-2017 |
Hemant Gupta <hemantg@codeaurora.org> |
PBAP: Implement Folder Version Counter(s)
Primary version counter should be updated on any change to
contact. Secondary version counter should not update when
there is change to fields other than F, FN, TEL, EMAIL or
ADDRESS. There is no default API available in android to determine
which field is updated as required for updating secondary
version counter. Implemented logic to increment the secondary
version counter by comparing updated contacts with old cached
contacts of the contact database.
Test: Verified that folder version counter gets incremented for
change(s) in fields of Contacts as per PBAP specification.
Bug: 33011817
Change-Id: I90a1ced3713c369bcde0edd627bbde57a9676708
/packages/apps/Bluetooth/src/com/android/bluetooth/pbap/BluetoothPbapUtils.java
|
| 91c7bbd92117da7f8fdde343a9a5108a14693387 |
|
10-Oct-2016 |
Marie Janssen <jamuraa@google.com> |
style: Remove commented-out code
Test: continues to compile
Change-Id: I94f3e869621bcffd1aba678894ac14fc3800184f
/packages/apps/Bluetooth/src/com/android/bluetooth/pbap/BluetoothPbapUtils.java
|
| eb7b90f5b93db1230a5b64caa3d8d05a642e33a6 |
|
10-May-2016 |
Marie Janssen <jamuraa@google.com> |
Cleanup unused requires in java files
Change-Id: I7b055c1d3d3f6a69e9f49c077853ab45fcad7106
/packages/apps/Bluetooth/src/com/android/bluetooth/pbap/BluetoothPbapUtils.java
|
| 6f1d727834316ee78c9c897965b254fa0316a065 |
|
07-Jan-2014 |
Hemant Gupta <hemantg@codeaurora.org> |
PBAP: Fix crash in com.android.bluetooth
This patch will add the changes to catch the
CursorWindowAllocationException at all the places where cursor
is used for quering operations. Without this patch, crash was
observed in com.android.bluetooth in stress test of BT On/off
multiple times.
FATAL EXCEPTION: main
android.database.CursorWindowAllocationException:
Cursor window could not be created from binder.
com.android.bluetooth.pbap.BluetoothPbapVcardManager.
getCallHistorySize(BluetoothPbapVcardManager.java)
Change-Id: I6a4fadb949969dca453cff0fe84a25d849063573
/packages/apps/Bluetooth/src/com/android/bluetooth/pbap/BluetoothPbapUtils.java
|
| c7a57f31515107366589bd6875c3cc4af1fc806e |
|
07-May-2012 |
fredc <fredc@broadcom.com> |
Added PBAP support for fetching owner vcard info from phone's profile. Added PBAP image support
Change-Id: Ieb2993c9505185d4f85cbbf6b5c554936618cff0
/packages/apps/Bluetooth/src/com/android/bluetooth/pbap/BluetoothPbapUtils.java
|