| b9222dd963d4695ce6f3b727eef4b9cbe4a978cd |
|
23-Jun-2017 |
Hemant Gupta <hemantg@codeaurora.org> |
SAP: Handle disconnect indication message type properly
Usecase:
1) Connect DUT with Mecapp PC App supporting SAP
2) When SAP is connected, remove SIM card on DUT.
Expected Behaviour:
DUT should send disconnect indication to remote device
Observed behaviour:
DUT not sending disconnect indication to remote device
Root Cause:
DUT is not handling the message type for disconnection received
from RIL layer properly.
Fix:
Use correct message type for disconnect indication from RIL in
handleRilInd() API
(SapMessage.ID_DISCONNECT_IND -> SapMessage.ID_RIL_UNSOL_DISCONNECT_IND).
Test: Checked if disconnect indication is sent out when SIM card is removed.
Bug: 62937720
Change-Id: Ib63b7290d9f7c7af57ee25401d5bcfb7ba600b07
/packages/apps/Bluetooth/src/com/android/bluetooth/sap/SapMessage.java
|
| c4fbd756e2645147470c486ae96f2253f5e13a52 |
|
12-Oct-2017 |
Jack He <siyuanh@google.com> |
[Script] Fix checkstyle errors (1/2)
Format code using Intellij to conform to CheckStyle requirements
Bug: 63597465
Test: make checkbuild, no manual changes, no functional changes
Change-Id: I70cd2ab8e5e6d5428ab1556658735b0d83f4fb15
/packages/apps/Bluetooth/src/com/android/bluetooth/sap/SapMessage.java
|
| 32a94e2fdbaa66fb26bd0be2425b55151b5e493b |
|
10-Oct-2017 |
Jack He <siyuanh@google.com> |
[Script] Simplify pointless boolean expressions
* Run "Pointless boolean expression inspection" in Intellij
* Fix issues like
a == false -> !a
a == true -> a
a != true -> !a
a != false -> a
Bug: 63597465
Test: make checkbuild, no manual changes, no functional changes
Change-Id: I303e8ee7c1cb0d76ccd86edcb08c6e763e2aa7ea
/packages/apps/Bluetooth/src/com/android/bluetooth/sap/SapMessage.java
|
| af64b66d0705f8e1f5b7d20a56f8f6997b60093a |
|
13-Feb-2017 |
Amit Mahajan <amitmahajan@google.com> |
Exception and death notification handling for ISap.
Test: Basic telephony sanity
Bug: 32020264
Change-Id: I3d710fc59a397fe0054b286d422066f9ff149262
/packages/apps/Bluetooth/src/com/android/bluetooth/sap/SapMessage.java
|
| 549c5a7e95c7934d8d3ab10a8653564e42b0c937 |
|
11-Dec-2016 |
Amit Mahajan <amitmahajan@google.com> |
Client changes for BT SAP hidl.
Test: Basic SAP sanity.
Bug: 32020264
Change-Id: If001ff221e3240a31cfbb08df11cbf6188ebd07e
/packages/apps/Bluetooth/src/com/android/bluetooth/sap/SapMessage.java
|
| eb7b90f5b93db1230a5b64caa3d8d05a642e33a6 |
|
10-May-2016 |
Marie Janssen <jamuraa@google.com> |
Cleanup unused requires in java files
Change-Id: I7b055c1d3d3f6a69e9f49c077853ab45fcad7106
/packages/apps/Bluetooth/src/com/android/bluetooth/sap/SapMessage.java
|
| 471e023da5f39d21ebcb1d3fad43a591c15f6be3 |
|
28-Aug-2015 |
Casper Bonde <c.bonde@samsung.com> |
SAP: Fix missing attribute in disconnect_ind
The internal TEST flag was removing too much code.
To make it easier to run test, and avoid future issues
with removing needed code, the TEST flag is no longer used
to remove code.
This bug was noticed when running the PTS testcases without the
PTS_TEST flag set. It is assumed that this fix will make
TC_SERVER_DCN_BV_02_I work without the PTS flag, but unless PTS
have updated their test case to accept both a gracefull disconnect
and a forced disconnect, TC_SERVER_DCN_BV_03_I will still fail in
a production build. The SAP spec suggest to use a gracefull disconnect
when initiating a disconnect from a server, hence it is not a good
idea to expose a force disconnect option to the used without first
having tried a gracefull disconnect. Hence the PTS test case
implementation is in conflict with the intented use specified in
the SAP specification.
Without this fix a build with PTS_TEST=false will not work as
intented.
PTS_TEST replaced with system property bt.sap.pts. Set it to true
to enable the force disconnect button.
Bug: 23614694
Signed-off-by: Casper Bonde <c.bonde@samsung.com>
Change-Id: I776a53d6e786c21000ef62094f9a9948ee5880b8
/packages/apps/Bluetooth/src/com/android/bluetooth/sap/SapMessage.java
|
| e377aae948e58f974c3af14360d2f6ce09b868aa |
|
28-Aug-2015 |
Casper Bonde <c.bonde@samsung.com> |
SAP: Fix logic to skip padding bytes for requests received
As per SAP spec, padding bytes can be 0-3 bytes, but the current code
has incorrect logic, that would lead to calculation of padding bytes
as 4 in case the APDU length was multiple of 4, which would lead to
incorrect parsing logic in SAP Server and can lead to issues of no
response for APDU request from SAP Server as it keeps waiting for
reading more bytes from rfcomm which are not present.
Also check added in code not to send msg to RIL if socket is null to
prevent crash in BT Sap module.
Bug: 23024598
Signed-off-by: Casper Bonde <c.bonde@samsung.com>
Change-Id: I24e4a6b850709c9c32b7e0992626a0219dacef03
/packages/apps/Bluetooth/src/com/android/bluetooth/sap/SapMessage.java
|
| d73503eb9d27edf6b942876f510d347e9c4a2970 |
|
22-Jul-2015 |
koh.changseok <koh.changseok@lge.com> |
SAP: Do not send padding when packet size is mutiple of 4
Bug: 22943799
Change-Id: I48d411f4e3a79a891360a9a855c4680bea19d748
/packages/apps/Bluetooth/src/com/android/bluetooth/sap/SapMessage.java
|
| 22fa8a39e020ff8f74b7d8ac052bddd8328cadc5 |
|
28-Apr-2015 |
Casper Bonde <c.bonde@samsung.com> |
SAP: Correct ResultCode for setTransportProtocolResp
Changed to respond with "Error, not supported" according to
the SAP specification, to pass PTS tests.
Change-Id: If4f3ddf27468d13f1162c19ab6c0a712fc81fd92
Signed-off-by: Casper Bonde <c.bonde@samsung.com>
/packages/apps/Bluetooth/src/com/android/bluetooth/sap/SapMessage.java
|
| b6791189b3c8be04b521b8520aed006f012304d1 |
|
27-Apr-2015 |
Casper Bonde <c.bonde@samsung.com> |
SAP: Shorten long lines
Change-Id: I89d5bf6d68b8aba9d9e86e891bfb1b79eb241432
Signed-off-by: Casper Bonde <c.bonde@samsung.com>
/packages/apps/Bluetooth/src/com/android/bluetooth/sap/SapMessage.java
|
| cee0d1b1f13b4401a895be650605fa307e70bdb6 |
|
19-Mar-2015 |
Casper Bonde <c.bonde@samsung.com> |
Add support for Bluetooth Sim Access Profile (3/4)
Server side of the Sim Access Profile. Enables a Bluetooth device
to take over control of the SIM. This is usefull in cars where the
internal antenna in the phone can have a low signal level.
For this profile to work, the RIL driver must allow for this feature
to be used, and it must provide the API needed. The API is based on
protoBuf.
This change includes some SAP test cases.
Change-Id: Ia46493383efed6b8a89ca270bdafa60fc1a150c1
/packages/apps/Bluetooth/src/com/android/bluetooth/sap/SapMessage.java
|