| c4fbd756e2645147470c486ae96f2253f5e13a52 |
|
12-Oct-2017 |
Jack He <siyuanh@google.com> |
[Script] Fix checkstyle errors (1/2)
Format code using Intellij to conform to CheckStyle requirements
Bug: 63597465
Test: make checkbuild, no manual changes, no functional changes
Change-Id: I70cd2ab8e5e6d5428ab1556658735b0d83f4fb15
/packages/apps/Bluetooth/src/com/android/bluetooth/sdp/SdpManager.java
|
| 76a12d7e679ae48f8ab73e01b33fb7c8f077a210 |
|
11-Oct-2017 |
Jack He <siyuanh@google.com> |
[Manual] Assorted fixes for CheckStyle
* Inner class constructor does not need private modifier to be hidden
* Fixed unused tags or mis-typed tags
* Move comments out from if-else body
* Add spaces between ';' and comments
* Simplified conditionals that were not fixed automatically by scripts
Bug: 63597465
Test: make checkbuild, no functional changes
Change-Id: Iaaebf4ab3840973e44dc3310d39961db89281d5e
/packages/apps/Bluetooth/src/com/android/bluetooth/sdp/SdpManager.java
|
| 8bc413b0b749ea9df59e858493273e05087fe887 |
|
11-Oct-2017 |
Jack He <siyuanh@google.com> |
[Manual] Rename non-public non-static variables to mCamelCase
* Run "instance field naming convention" inspection in Intellij
* Rename variables that are non-public non-static to m + Camel Case
* Renaming is done through refactor tool in Intellij
* Private variables are renamed to m + Camel Case
* Non-private variables are added with public modifier to indicate that
they are accessed externally as well
Bug: 63597465
Test: make checkbuild, no functional changes
Change-Id: I88400ac99fa1ba084cdfa35600bd3c23f1dd1a33
/packages/apps/Bluetooth/src/com/android/bluetooth/sdp/SdpManager.java
|
| 1bd017d12cf16ecd52fb486722e300790bddeefc |
|
11-Oct-2017 |
Jack He <siyuanh@google.com> |
[Manual] Fix static field names
* Run 'static' field naming convention inspection in Intellij
* Use regex s[A-Z][A-Za-z\d]*, the same one in CheckStyle
* Change non-public variable names to sCamelCase
* Add final modifier to constants
Bug: 63597465
Test: make checkbuild, no functional changes
Change-Id: I395bf3e11c2932b36cda471ca088dc5345b0f378
/packages/apps/Bluetooth/src/com/android/bluetooth/sdp/SdpManager.java
|
| d04c0a8609b39f891d5787f051b1dfb105ceee93 |
|
11-Oct-2017 |
Jack He <siyuanh@google.com> |
[Manual] Remove redundant 'public' modifier
* Remove redundant 'public' modifier from non-public classes'
constructors
* Fixes all occurances labeled as "Redundant 'public' modifier' by
CheckStyle
Bug: 63597465
Test: make checkbuild, no functional changes
Change-Id: I45ece6deafa612fee36e06877065c903815466d2
/packages/apps/Bluetooth/src/com/android/bluetooth/sdp/SdpManager.java
|
| b7461b17cad5476a7a528cbf2a0b9c9706c6faef |
|
11-Oct-2017 |
Jack He <siyuanh@google.com> |
[Manual] Rename method parameters using Java naming conventions
* Run "Method parameter naming convention" inspection in Intellij with
maximum parameter name length set to 100
* Rename method parameters using the refactor tool in Intellij based on
Java naming convention
* e.g. ind_id -> indId
Bug: 63597465
Test: make checkbuild, no functional changes
Change-Id: Id2161345524d888cbddb0ce2387e9f1aadf1e9c6
/packages/apps/Bluetooth/src/com/android/bluetooth/sdp/SdpManager.java
|
| 32a94e2fdbaa66fb26bd0be2425b55151b5e493b |
|
10-Oct-2017 |
Jack He <siyuanh@google.com> |
[Script] Simplify pointless boolean expressions
* Run "Pointless boolean expression inspection" in Intellij
* Fix issues like
a == false -> !a
a == true -> a
a != true -> !a
a != false -> a
Bug: 63597465
Test: make checkbuild, no manual changes, no functional changes
Change-Id: I303e8ee7c1cb0d76ccd86edcb08c6e763e2aa7ea
/packages/apps/Bluetooth/src/com/android/bluetooth/sdp/SdpManager.java
|
| dbf5c4e1c9e57fa6e5cc96ee9f442da8aa391a5d |
|
10-Oct-2017 |
Jack He <siyuanh@google.com> |
[Script] Sort modifiers according to JLS
* Correct order is:
1. public
2. protected
3. private
4. abstract
5. default
6. static
7. final
8. transient
9. volatile
10. synchronized
11. native
12. strictfp
* This is achieve through running automatic code cleanup in Intellij
using "Missorted modifiers" inspection
Bug: 63597465
Test: make checkbuild, no manual changes, no functional changes
Change-Id: Id9c8a3c6bf1195b43d986c4324da94ca8c44367f
/packages/apps/Bluetooth/src/com/android/bluetooth/sdp/SdpManager.java
|
| 560fb676a64f888d31e672a4b66e52a05abb5f26 |
|
21-Mar-2017 |
Hemant Gupta <hemantg@codeaurora.org> |
OPP: Remove un-supported formats from SDP
Use case:
1. Send a vcalendar file to DUT
2. Verify file is received on DUT
Result:
DUT rejects vCalendar put request with reason unsupported media type
although DUT SDP records claim support for vcalendar format. Same is valid
for vNote and vMessage formats as well.
Rootcause:
ACCEPTABLE_SHARE_INBOUND_TYPES does not have support for above MIME formats.
Fix:
Remove vCal, vNote and vMessage from OPP Server supported format list.
Reproducibiltiy:
5/5
Test: All PTS tests that were enabled because of support for different OPP MIME
formats got disabled as by default OPP Rx will not support these MIME formats
leading to no OPP failures in PTS.
Bug: 36467777
Change-Id: I2503f5c61dd28fd3cf73d10939c6d931dbe0d6ea
/packages/apps/Bluetooth/src/com/android/bluetooth/sdp/SdpManager.java
|
| 4aa5e4e2fe52c06d97481db0bf180349053dae48 |
|
16-Feb-2017 |
Hemant Gupta <hemantg@codeaurora.org> |
OPP: Add OPP 1.2 feature.
Add changes to support OPP 1.2 which uses OBEX over L2CAP.
Test: Connect with Remote OPP Client supporting OPP 1.2 and verify
that connection and transfer happens over L2CAP. Connect with Remote
OPP Client supporting OPP 1.1 and verify that connection and transfer
happens over RFCOMM.
Bug: 33010988
Change-Id: I44c2f2f01fb04f4306d0eb121d66dc08954966c0
/packages/apps/Bluetooth/src/com/android/bluetooth/sdp/SdpManager.java
|
| 1f1103e93ba7ebd48c57c9627dc7b262c6f01c77 |
|
16-Apr-2015 |
Casper Bonde <c.bonde@samsung.com> |
SAP: Change to use new SDP Api (2/4)
Added support for Sim Access Profile (SAP) in the SDPManager.
To make it easier to test, both SDP record creation and seach
is added.
Change-Id: I871eb762389e3717b8bd6bc37a8ffc09fff6f589
Signed-off-by: Casper Bonde <c.bonde@samsung.com>
/packages/apps/Bluetooth/src/com/android/bluetooth/sdp/SdpManager.java
|
| bbb4110b455b3aa29106d5b4f0a37e1be8e09475 |
|
09-Apr-2015 |
Casper Bonde <c.bonde@samsung.com> |
Obex over L2CAP + SDP search API
Each profile had its own implementation of ObexTransport.
These implementations were implemented very similar, and
could easily be merged into a common implementation.
Additionally it will make it easier to adopt the transport
to support L2CAP.
The SDP functionality is implemented in a way that is scalable,
hence adding new record types is easy.
Intents are currently used to distribute the SDP search results,
as we have observed that the new client side profiles have been
located outside the Bluetooth package.
We strongly recommend to keep all bluetooth profiles within the
Bluetooth package, to acoid the need for exposing all bluetooth
interfaces through the Android framework. For instance this new
SDP create API is internal to Bluetooth, hence cannot be used by
the external profiles - hence they cannot use OBEX over L2CAP.
The SDP search currently supports:
- MAP both sides
- OPP server (only the server needs an SDP record)
- PBAP server (only the server needs SDP record)
The SDP create record currently supports:
- MAP both sides
- OPP server
- PBAP server
The new l2cap sockets introduces a new wrapper class for a rfcomm
and an l2cap socket.
The wrapper design:
- Creates two accept threads running while bluetooth is
turned on.
- When a connection is accepted the owner is asked wether or not
to accept the connection if rejected, the connection will be
rejected at obex level, else it will be accepted and the state
is changed to busy.
- Any further connections will be rejected at Obex level, until
the state is changed back to idle.
Notes tor executing the test cases:
Test OBEX using local pipes(no BT) or two bluetooth enabled
devices.
Test SDP using two Bluetooth enabled devices
Start server testcase first on one device, then start
the matching client test on the other device.
You cannot run all tests in one go, as they need to run
on multiple devices.
Edit the test sequesce to add/remove/modify the sequence
of OBEX operations to perform.
Use the new SDP record create interface.
Change-Id: I3941793f9843abf4afa5ffbee40d1d01c118b29b
Signed-off-by: Casper Bonde <c.bonde@samsung.com>
/packages/apps/Bluetooth/src/com/android/bluetooth/sdp/SdpManager.java
|