| b06d00924123aa13086be564fee6404215fcc0d5 |
|
02-Mar-2018 |
linyuh <linyuh@google.com> |
Disable phone number formatting for devices with Argentinian SIMs.
Bug: 73718977
Test: PhoneNumberHelperTest
PiperOrigin-RevId: 187540382
Change-Id: I814ec62b2215c24b8cde3442c5dc83d98ad87164
/packages/apps/Dialer/java/com/android/dialer/dialpadview/DialpadFragment.java
|
| 76cf7e18da00545145df8a5f215f3a377d605866 |
|
01-Mar-2018 |
calderwoodra <calderwoodra@google.com> |
Some small bug fixes in NUI.
- Never show the dialpad chooser in MainActivity.
- If the call log changed while dialer was in the background, it would trigger
the content observer to fetch the new info, which would request it's parent
that wasn't there. Now we register/unregister them in onResume/onPause. This
is safe to do because we force refresh the data onResume anyways, so any
changes will still be shown.
Bug: 73972084,73975555,73995512
Test: manual
PiperOrigin-RevId: 187407058
Change-Id: Iae86dabbcb852398bb2b9df4627e234261ab8030
/packages/apps/Dialer/java/com/android/dialer/dialpadview/DialpadFragment.java
|
| 2cc8b342ff7ebefb2f97fde8b877452528f03d4e |
|
30-Jan-2018 |
calderwoodra <calderwoodra@google.com> |
Update FragUtils to encourage better readability in Activities.
Bug: 72525324
Test: existing
PiperOrigin-RevId: 183776841
Change-Id: Ia78002d3da823a228cf5a29f93cd53ad21105f94
/packages/apps/Dialer/java/com/android/dialer/dialpadview/DialpadFragment.java
|
| c1623fe219f3229bf9191afdcf0667efd0f549b8 |
|
26-Jan-2018 |
twyen <twyen@google.com> |
Remove non call log dependencies on PhoneAccountUtil
Methods moved to TelecomUtils
Test: Unit tests
PiperOrigin-RevId: 183305626
Change-Id: Idd6604e58c06a36066bd49870849dd71747969c6
/packages/apps/Dialer/java/com/android/dialer/dialpadview/DialpadFragment.java
|
| 3b735de1525313b0517473aff849914b1722a445 |
|
18-Jan-2018 |
calderwoodra <calderwoodra@google.com> |
Fixed regression with search not reacting properly to on touch events.
There are a few interesting UX niceties that we support in search:
1) When in regular search with an empty query, close the UI if the user
touches the blank space.
2) When in regular search with a non-empty query, hide the keyboard if the
user touches the the list so they can see all results.
2) When in dialpad search with an empty query, close the UI if the user
touches the blank space.
3) When in dialpad search with a non-empty query, hide the dialpad so the user
can see the full list of results.
This change also adds logic to transfer the dialpad query to the search bar.
Bug: 64655802
Test: MainActivityIntegrationTest
PiperOrigin-RevId: 182434126
Change-Id: Iabb73b0018fa20e2811010a73a35d3aa3b35343b
/packages/apps/Dialer/java/com/android/dialer/dialpadview/DialpadFragment.java
|
| 70a4b0929d8223ef0dc55b0f1b3790a892bb9043 |
|
17-Jan-2018 |
calderwoodra <calderwoodra@google.com> |
Updated toolbar and dialpad interactions in NUI.
Toolbar, Dialpad, Bottom Nav, FAB and Search now all show
and hide properly according to the state of the application.
Follow up CLs will include:
- saving/restoring state
- sending query to search fragment to display results
Bug: 181512198
Test: MainActivityIntegrationTest
PiperOrigin-RevId: 182259200
Change-Id: I1309d8df2a5425bf051e52a459a1f78e1157fe08
/packages/apps/Dialer/java/com/android/dialer/dialpadview/DialpadFragment.java
|
| 4d881e4b22e61913bd2439fba6901bf6cc0e98c5 |
|
12-Jan-2018 |
calderwoodra <calderwoodra@google.com> |
Added Dialpad to NUI.
This change adds the existing dialpad to the new UI and the animation logic
required to show/hide it along with the toolbar. A follow up CL will come
afterwards to combine these animations with the toolbar expanding/collapsing.
known issue: bottom nav appears over the dialpad.
Bug: 181512198
Test: MainActivityTest
PiperOrigin-RevId: 181777370
Change-Id: Ief1591174ebca3a709df6d1d38c8b8ecbdc1878e
/packages/apps/Dialer/java/com/android/dialer/dialpadview/DialpadFragment.java
|
| 183cb71663320f16149d83eeebaff7795a4b55f2 |
|
28-Dec-2017 |
linyuh <linyuh@google.com> |
Remove field prefixes.
Test: Existing tests
PiperOrigin-RevId: 180230450
Change-Id: I0b2589cfeeaef81e42a04efa48af24b4e4d0e95f
/packages/apps/Dialer/java/com/android/dialer/dialpadview/DialpadFragment.java
|
| 1632cfe1e3f3f94295289a62c69ec5a0489d8f13 |
|
30-Nov-2017 |
roldenburg <roldenburg@google.com> |
*** Reason for rollback ***
Copybara is fixed for AOSP export
Bug: 68665330
Test: rollback
PiperOrigin-RevId: 177480870
Change-Id: I0ba38e213bb840436fa6dafc4af0a79019ee93f4
/packages/apps/Dialer/java/com/android/dialer/dialpadview/DialpadFragment.java
|
| 295d9ad53628eba12d635b35d6b51eb3cae8a4aa |
|
28-Nov-2017 |
linyuh <linyuh@google.com> |
Disable phone number formatting on the dialpad when making domestic call to Argentina mobile numbers.
Bug: 30224215
Test: DialerPhoneNumberFormattingTextWatcherTest, DialpadFragmentIntegrationTest
PiperOrigin-RevId: 177218942
Change-Id: Id6eaaad2f6d81e591d59a1d8444f45fb06f3f8d5
/packages/apps/Dialer/java/com/android/dialer/dialpadview/DialpadFragment.java
|
| dad839d3ef89a8c58cb94eef7d282f34d86597b9 |
|
20-Nov-2017 |
calderwoodra <calderwoodra@google.com> |
Dialpad icon now remains white through device rotation.
Bug: 69463065
Test: manual
PiperOrigin-RevId: 176399153
Change-Id: I699688ab47c1ba497a0b6bb3301380a8e06f2ee2
/packages/apps/Dialer/java/com/android/dialer/dialpadview/DialpadFragment.java
|
| 8dab453962327e01c6f2e2a22d61540d1c3d6f47 |
|
15-Nov-2017 |
calderwoodra <calderwoodra@google.com> |
Dialpad FAB no longer loses it's icon on fragment resume.
There must be a bug in FloatingActionButton because when you call
setImageDrawable multiple times (possibly with the same drawable/icon), the FAB
renders with no icon present. That's why the icon would disappear in
Fragment#onResume.
Bug: 69006360
Test: manual
PiperOrigin-RevId: 175878924
Change-Id: I1c36be3f9aeb003410f0bdbb9d52b5a483262f03
/packages/apps/Dialer/java/com/android/dialer/dialpadview/DialpadFragment.java
|
| 0efc840171da8739359b326249978d0a44df540b |
|
08-Nov-2017 |
twyen <twyen@google.com> |
Hook up pre-call actions
This CL replaces all instance of CallIntentBuilder.build() with PreCall.getIntent(), which when run as an activity, will finish building the intent with user interaction.
Bug: 64216442
Test: manual
PiperOrigin-RevId: 174924323
Change-Id: If41868df4c7ed078d03bd3431fa85b8947056a01
/packages/apps/Dialer/java/com/android/dialer/dialpadview/DialpadFragment.java
|
| c2ea695927a5866cea732ea784a8ee4473b8ba19 |
|
07-Nov-2017 |
twyen <twyen@google.com> |
Unify voicemail call placing
All voicemails are called by using CallIntentBuilder.forVoicemail() so the PhoneAccountHandle can be designated. A future CL will use dialogs to customize the call (multi SIM selection, RTT, etc.)
As a result voicemail error messages and legacy voicemail notifications will call the account it is received from directly.
Bug: 64216442
Test: Unit tests
PiperOrigin-RevId: 174784322
Change-Id: Ibe1c57bc7852e3d55a39a0cc2da19b6a79954c0f
/packages/apps/Dialer/java/com/android/dialer/dialpadview/DialpadFragment.java
|
| 0cd36a6e3bfda1c8b78c0375225929f50ee408a5 |
|
31-Oct-2017 |
zachh <zachh@google.com> |
Removed helper methods in DialerExecutors.
We now use dagger everywhere for consistency and explicitness.
Test: tap
PiperOrigin-RevId: 174071122
Change-Id: I15d2f8261a7b753353be9e7d3b80692aa0c1b64d
/packages/apps/Dialer/java/com/android/dialer/dialpadview/DialpadFragment.java
|
| 6a4cebdb4ccc974d04f125847c03fddec18b2b9f |
|
25-Oct-2017 |
zachh <zachh@google.com> |
Improved dagger support for executor services.
By always creating executor services via dagger, we can now bind special versions during espresso tests that can implement idling resources. We should be using idling resources during espresso tests for threads that we create ourselves, because espresso does not know about them.
Hopefully this reduces some of the flakiness of espresso tests that we have today.
This required converting all existing calls to DialerExecutors to pass a context used to fetch the component, and also required creating new application classes for espresso tests.
Test: temporarily added a task which just slept to DialtactsActivity and verified that its integration test failed due to idling resource timeout
PiperOrigin-RevId: 173334773
Change-Id: I876a93022d235d62cfc377bf5b06687e21a34758
/packages/apps/Dialer/java/com/android/dialer/dialpadview/DialpadFragment.java
|
| e8c8389ce36a4eb10e039ffe86f8b699813ca7e3 |
|
16-Oct-2017 |
calderwoodra <calderwoodra@google.com> |
FAB is no longer visible on return to call dialog.
Bug: 67419607
Test: manual
PiperOrigin-RevId: 172349180
Change-Id: I305f8a0e5ae90b2e5e8f77772edfb0b973aca096
/packages/apps/Dialer/java/com/android/dialer/dialpadview/DialpadFragment.java
|
| 6007f5208514c4f69ca6fa75507abba92ef5372d |
|
10-Oct-2017 |
calderwoodra <calderwoodra@google.com> |
Improved FAB UX.
One of the biggest issues with the FAB is that it doesn't
scale in/out properly. It looked more like setVisibility was
being called instead. This CL migrates the FAB controller to
use the built in scale in/out methods #show and #hide and the
animation is much nicer.
Some of the other issues were:
- Now scaling animation is correct and visible.
- No longer flashes when going in/out of search.
- No longer shows on top of the return to call controller.
- No longer bugs when switching between VVM TOS and contacts.
- No longer shows FAB over VVM TOS when entering/exiting search
Bug: 62588192,35359563,64116334,27458212,37991480,67419607
Test: manual
PiperOrigin-RevId: 171608105
Change-Id: I9b3f61df35abf3659a432adf411b1b7d20eba683
/packages/apps/Dialer/java/com/android/dialer/dialpadview/DialpadFragment.java
|
| 48cce92eeaf16280b48987da4e020d1e09f96289 |
|
14-Sep-2017 |
calderwoodra <calderwoodra@google.com> |
Dialpad chooser now properly shows when in a call.
Bug: 65212837
Test: DialpadFragmentTest
PiperOrigin-RevId: 168745371
Change-Id: I62da45cdac58e3387343589b952e5d6bce7a4ee2
/packages/apps/Dialer/java/com/android/dialer/dialpadview/DialpadFragment.java
|
| 50715261119b30e6e23aaf58fcf3e28f16430f3d |
|
08-Sep-2017 |
calderwoodra <calderwoodra@google.com> |
This is a rollforward of cl/167332236
Improved behavior of back button in search ui.
Pressing the back button in the search UI now functions as follows:
- If the keyboard is opened, the keyboard is minimized
- If the dialpad is opened, the dialpad is closed
- If the keyboard and dialpad is closed, the search ui is closed
Our existing behavior was dependent on whether a query had been built yet.
basically, if the user pressed back with no query selected, the search ui
was closed.
From the bugbash:
7. No scroll bar in the search results if the results do not fill the entire
view. The keyboard overlaps the results and there is no way to get to the
enter list without dismissing the keyboard.
10. Dismiss the keyboard on tapping the down arrow on the keyboard. Arrow
points down but works like back button
Bug: 62685859,63691995,63939331,64137632,64902476
Test: manual
PiperOrigin-RevId: 168004913
Change-Id: Ia566fce6d90454a3eae6ecccfa81ce7e909e878f
/packages/apps/Dialer/java/com/android/dialer/dialpadview/DialpadFragment.java
|
| ed4e11ddafece1d308b87955880f4f153dbfc8e2 |
|
06-Sep-2017 |
calderwoodra <calderwoodra@google.com> |
Automated g4 rollback of changelist 167332236.
*** Reason for rollback ***
Based off a CL that needs to be rolled back.
*** Original change description ***
Improved behavior of back button in search ui.
Pressing the back button in the search UI now functions as follows:
- If the keyboard is opened, the keyboard is minimized
- If the dialpad is opened, the dialpad is closed
- If the keyboard and dialpad is closed, the search ui is closed
Our existing behavior was dependent on whether a query had been built yet.
basically, if the user pressed back with no query selected, the search ui
was closed.
From the bugbash:
7. No scroll bar in the search...
***
Bug: 64902476,64137632,62685859,63691995,63939331
Test: n/a
PiperOrigin-RevId: 167661409
Change-Id: I0627d54af33fb55c64b5edcd459dde6a73d93266
/packages/apps/Dialer/java/com/android/dialer/dialpadview/DialpadFragment.java
|
| ee5bce98231b96bc7f3ecf2d12276571786863f5 |
|
02-Sep-2017 |
calderwoodra <calderwoodra@google.com> |
Improved behavior of back button in search ui.
Pressing the back button in the search UI now functions as follows:
- If the keyboard is opened, the keyboard is minimized
- If the dialpad is opened, the dialpad is closed
- If the keyboard and dialpad is closed, the search ui is closed
Our existing behavior was dependent on whether a query had been built yet.
basically, if the user pressed back with no query selected, the search ui
was closed.
From the bugbash:
7. No scroll bar in the search results if the results do not fill the entire
view. The keyboard overlaps the results and there is no way to get to the
enter list without dismissing the keyboard.
10. Dismiss the keyboard on tapping the down arrow on the keyboard. Arrow
points down but works like back button
Bug: 64902476,64137632,62685859,63691995,63939331
Test: manual
PiperOrigin-RevId: 167332236
Change-Id: I1c0b5b429316dae119b5fb21be4303d7fe052e35
/packages/apps/Dialer/java/com/android/dialer/dialpadview/DialpadFragment.java
|
| fff6fcfc6887e113e25cfb7a8e07b8b73af0c62c |
|
01-Sep-2017 |
wangqi <wangqi@google.com> |
Use TelecomManager#isInManagedCall starting from O.
The TelecomManager#isInCall method returns true anytime the user is in a call.
Starting in O, the APIs include support for self-managed ConnectionServices so that other apps like Duo can tell Telecom about its calls. So, if the user is in a Duo call, isInCall would return true.
Dialer uses this to determine whether to show the "return to call in progress" when Dialer is launched.
Instead, Dialer should use TelecomManager#isInManagedCall, which only returns true if the device is in a managed call which Dialer would know about.
Bug: 36991070
Test: none
PiperOrigin-RevId: 167200903
Change-Id: I12ac7b893dcbfa2fc842ca5ab356fbbc490a098b
/packages/apps/Dialer/java/com/android/dialer/dialpadview/DialpadFragment.java
|
| cc2cde0555bd49362f7631c64d24221b24ed71c8 |
|
31-Aug-2017 |
zachh <zachh@google.com> |
Added logging to aid debugging of issue where dialer shows blank screen.
Bug: 64129606
Test: none
PiperOrigin-RevId: 167174480
Change-Id: I4b5a494b0b334b42ee053c4d4d1e81d7699461d0
/packages/apps/Dialer/java/com/android/dialer/dialpadview/DialpadFragment.java
|
| 2ca4318cc1ee57dda907ba2069bd61d162b1baef |
|
31-Aug-2017 |
Eric Erfanian <erfanian@google.com> |
Update Dialer source to latest internal Google revision.
Previously, Android's Dialer app was developed in an internal Google
source control system and only exported to public during AOSP drops.
The Dialer team is now switching to a public development model similar
to the telephony team.
This CL represents all internal Google changes that were committed to
Dialer between the public O release and today's tip of tree on internal
master. This CL squashes those changes into a single commit.
In subsequent changes, changes will be exported on a per-commit basis.
Test: make, flash install, run
Merged-In: I45270eaa8ce732d71a1bd84b08c7fa0e99af3160
Change-Id: I529aaeb88535b9533c0ae4ef4e6c1222d4e0f1c8
PiperOrigin-RevId: 167068436
/packages/apps/Dialer/java/com/android/dialer/dialpadview/DialpadFragment.java
|