b93a594671bf057c5b84cd5e9ca28204054462fd |
|
17-Jan-2018 |
Steve McKay <smckay@google.com> |
Remove Guava Preconditions uses. These accidentally found way in during selection code refactoring. Test: n/a Change-Id: I3d85a6961dc1a204c79a1dc4199bf18fb9fd4f9d
/packages/apps/DocumentsUI/src/com/android/documentsui/selection/GestureRouter.java
|
5bf51ec2ce8ba84ab56ab866ac8539c42d87a2f0 |
|
29-Sep-2017 |
Steve McKay <smckay@google.com> |
Recycler+Selection documentation and API fixups. This *should* be the last in-situ code review for the RecyclerView selection API. My main goal with this change: Ensure support lib folks are happy with the basic shape of the API. If not, no worries, let's reshaping the API here where the code lives in DocumetnsUI. That'll help ensure any changes will retain the capabilities necessary to accommodate the more nuanced behaviors defined in DocumentsUI, and help provide more detailed example usage to support-lib folks prior to our pulling the code over to support-lib for final review. Note that there is fairly substantial, though informal, documentation on each class and its role in SelectionDemoActivity. That's a great place to start for reviewer. Once folks are generally happy w/ the shape. I'll pull a copy of the code over to the support lib package where we can continue the reivew. I'll polish off documentation (especially adding package docs) at that time. Demo video at: https://drive.google.com/a/google.com/file/d/0B1OqiAcKh66ZTHJhU0xSa1lobmM/view?usp=sharing Bug: 64847011 Test: Added new GestureSelectionHelper coverage. All else passing. Change-Id: I86f268ce92929cfc490d92100b7bcf158cd4a7dd
/packages/apps/DocumentsUI/src/com/android/documentsui/selection/GestureRouter.java
|
0aa720752bc87d2d387b41a3016f0d533a8fc7f1 |
|
29-Sep-2017 |
Steve McKay <smckay@google.com> |
Selection code isolation. Collapse the "addons" package into it's parent since it doesn't have a distinct role. Eliminate remaining testing deps on non-selection code. Bug: 64847011 Test: Passing. Change-Id: I60260777b6fc55df78a523b82f5c40a39490ace1
/packages/apps/DocumentsUI/src/com/android/documentsui/selection/GestureRouter.java
|