| 3a5c306e5b6bf2285980aa34cb8eb00fbcf5ea2c |
|
27-Sep-2016 |
Philip P. Moltmann <moltmann@google.com> |
If the permission dialog would stick out, move it.
Also scroll the whole dialog if the screen is too small to for the
dialog.
Test: Executed steps in the bug. Dialog looks fine. Also toyed around
with display scaling and font scaling to make sure dialog always looks
ok (but might scroll) on very small displays.
Fixes: 31442798
Change-Id: I74328afde38ec2170a14aaa8e77675ad2164460e
/packages/apps/PackageInstaller/src/com/android/packageinstaller/permission/ui/ManualLayoutFrame.java
|
| 9199155a7f5643e6a07a626973f892e05c7c5bd7 |
|
21-Jan-2016 |
Svetoslav Ganov <svetoslavganov@google.com> |
Make the permission request dialog's layout robust
The old implementation was relying on a fixed window size
where the content is positioned by a custom layout manager.
It is possible however that subsequent permissions requests
do not fit in the window as its size is computed based on
the content of the first permissions request. There were
also cases where the content is chopped after a rotation
as the dialog size width was not re-evaluated while it should
be. Further, animation from one permission request state
to another was not properly done resulting in content
being chopped off in some cases.
The current approach is to have a dialog width for the
content activity but the height is as tall as the screen
allowing us to fit arbitrary large permission request
content. Also we are resetting the fixed width on a
configuration change so the dialog is robust to adjust
size as needed.
bug:24679384
bug:25755378
Change-Id: I4d23f81d8e59ce23bf9a27155ebb5ec6e2e6752c
(cherry picked from commit c6dc4bb52b07886346b02b326c5c32a8299ed73e)
/packages/apps/PackageInstaller/src/com/android/packageinstaller/permission/ui/ManualLayoutFrame.java
|
| 3ed860add8b83a9d69d7726bc636b8486a70039f |
|
15-Jan-2016 |
Brian Carlstrom <bdc@google.com> |
Revert "Make request permissions dialog layout robost"
This reverts commit ecaeae17f52d6562d23dfec91e44bc3c0b4a6d13.
/packages/apps/PackageInstaller/src/com/android/packageinstaller/permission/ui/ManualLayoutFrame.java
|
| ecaeae17f52d6562d23dfec91e44bc3c0b4a6d13 |
|
13-Jan-2016 |
Svet Ganov <svetoslavganov@google.com> |
Make request permissions dialog layout robost
If the min width of a dialog changes in portrait vs landscape
it was possible that a part of the request permissions dialog
is chopped off. The custom content layout manager was using a
fixed width and changing orientation may lead to a dialog
width lesser than the fixed width of the layout manager.
Another problem was that if the above occurs and the window
width changes then the window may not be tall enough to fit
the content. To address this we have to do a gross move and
re-add the window to the window manager, so it can be resized.
Another issue was that if the "Don't ask again" checkbox is
shown not for the first but say the second permission request
(in the case of multi-permission request in one API call) the
content was chopped off as the height measurement for how much
the content needs to be was restricted by the parent measure
spec. Now we measure with no restrictions to accommodate the
whole content.
The way reqeust permissions dialog is implemented is problematic
as it is a dialog styled activity which means we may need to
resize its window. It is better to implement it as a fullscreen
activity that has a custom content layout mangar that makes
the content look like a dialog. Since this is risky at this
point we do targeted fixes to address the above issues.
bug:24679384
Change-Id: If51a360ba17dfb71b66dcf841ea47c17606eba27
/packages/apps/PackageInstaller/src/com/android/packageinstaller/permission/ui/ManualLayoutFrame.java
|
| df01cfe5c469be42a5122df134da0d1105611de3 |
|
20-Jul-2015 |
Jason Monk <jmonk@google.com> |
Keep the permissions dialog width consistent
Bug: 22532807
Change-Id: Ie89b4287094bc6525463c6238b53d8ee68395e38
/packages/apps/PackageInstaller/src/com/android/packageinstaller/permission/ui/ManualLayoutFrame.java
|
| bfaa53e0b09b255e1ba44017052041e435c6f5e0 |
|
17-Jun-2015 |
Jason Monk <jmonk@google.com> |
Fix animating between very different heights
- Expand ViewHeightController so it can expand up or down
- Control the height of all containers in the hierarchy
- Intercept touch events and compensate for any top offset
on the root view, since we expand upwards
- Remove the current description from the description container
so that it can shrink in relayout if necessary.
Bug: 21879037
Bug: 21784297
Change-Id: I3ad562158013b75c5e9150cbd91c96c6ff4941c9
/packages/apps/PackageInstaller/src/com/android/packageinstaller/permission/ui/ManualLayoutFrame.java
|
| 2bcb3ddd1c25d422e80cde57f6db392866a07674 |
|
06-May-2015 |
Jason Monk <jmonk@google.com> |
Add animation for multiple permission checks
- DialogFragment was removed and just use the dialog-themed activity
instead. The previously GrantPermissionFragment, now acts as a
helper class.
- The dialog always tells the window its the same size, but then
draws at whatever height is required for the current permission.
(this allows it to stay in one position)
- Touching outside now does nothing so that the user must respond
to the permission request.
Change-Id: I12f27de4de5ad83e123cb9acfa062950db39f61b
/packages/apps/PackageInstaller/src/com/android/packageinstaller/permission/ui/ManualLayoutFrame.java
|