| d4e7eedfc9344abe36e6e79fc3cd7126321287cc |
|
09-May-2018 |
Beverly <beverlyt@google.com> |
DO NOT MERGE Add DND Settings suggestion
Test: SettingsSuggestionsTest, ZenOnboardingActivityTest
Change-Id: Ie78c9cf8287ee56bc4596efe20d27f8eb432ab6c
Bug: 78445134
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| 2ae92b541d6fdd59ce9615c2ee6d32cf7b7cc1d1 |
|
02-Feb-2018 |
Sean Stout <sstout@google.com> |
Improve Night Light suggestion criterion
Night Light suggestion will now show even if the user is using Night
Light in manual mode. If the user has previously tapped or dismissed the
suggestion, the suggestion will not show again.
Bug: 68938869
Test: make ROBOTEST_FILTER=\
"(NightDisplayPreferenceControllerTest|SuggestionFeatureProviderImplTest)" \
RunSettingsRoboTests
Change-Id: Iea838df043d75dfa73a1a383275dc42956374113
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| b91db421001e5130997ea653fc55d4eed687e6d7 |
|
09-Feb-2018 |
Fan Zhang <zhfan@google.com> |
Fix double search icon in wifi calling page
- Moved fragments into wifi sub-package.
- Cleaned up inheritance for WifiCallingSettings
- Attach help and search action menu controller correctly.
Change-Id: I0bc8ab99df5d8c5ea64fb64de5ae70c2c9bd6f31
Fixes: 72958674
Test: robotest
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| 0ec6b02fe44ece54e8b4d0e97fda8f2b133b50e2 |
|
31-Jan-2018 |
Fan Zhang <zhfan@google.com> |
Re-add isSuggestionEnabled check
It was accidentally removed previously
Test: robotest
Change-Id: I5b7707e746d6b825d835a007727b29c9a81a7fc1
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| caeb1720da49e89cdf9f45279b0068e6018b0170 |
|
18-Jan-2018 |
Zhizhi Liu <zhizhiliu@google.com> |
Migrate some suggestions related classes SettingsLib(II)
Remove classes from Settings.
Test: mm Settings/tests/robotests
Change-Id: I0f046d6a750bc53251deb44887e8665e6d545515
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| 28dee1f08640c66febadf0354555f032e8b0a3bd |
|
11-Jan-2018 |
Leif Hendrik Wilden <leifhendrik@google.com> |
Migrate to use instrumentation classes from settingslib.
Test: Compiles. Manually tested.
Change-Id: I70a6e76cc8440547746ecc008c32bd06a7de8161
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| 372789b46dd61296758fbd64bebdae59c68e8c71 |
|
23-Jan-2018 |
Fan Zhang <zhfan@google.com> |
Remove all gesture suggestions
They are already removed from first 14 days category, now removing
permanently.
Change-Id: I1740d3bff59ff56142c10cce3b9617009c58f47d
Fixes: 72224790
Test: robotests
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| cab0ee611d375d70a3803d857e62c745ccd98de2 |
|
22-Jan-2018 |
Leif Wilden <leifhendrik@google.com> |
Revert "Migrate to use instrumentation classes from settingslib."
This reverts commit 1546cca529bf56430332e15b05ceb6efb37e57bf.
Reason for revert: Broke fingerprint setup flow. b/72267201
Change-Id: I8321265ae64732c526325882ddea51080decddf5
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| 1546cca529bf56430332e15b05ceb6efb37e57bf |
|
11-Jan-2018 |
Leif Hendrik Wilden <leifhendrik@google.com> |
Migrate to use instrumentation classes from settingslib.
Test: Compiles. Manually tested.
Change-Id: Ie5515bb0fe3e621fc7723a9b04ba23e4bfa9c401
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| 1e27d2b28e17ff5ddabb5c10dc6bf4ca35c64913 |
|
02-Jan-2018 |
Fan Zhang <zhfan@google.com> |
Remove Suggestion v1 code.
Change-Id: Ie6e9c8f2b1b5b609d44e287accb9fbbef9054d34
Fixes: 68719093
Test: robotests
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| 3ba03815670d6d8ac7bd20e2e0c7c10fd34a5392 |
|
07-Dec-2017 |
Fan Zhang <zhfan@google.com> |
Update feature flag dashboard UI to display all features
Bug: 36222960
Test: robotests
Change-Id: I1aea8f32df9bd8ae24708374b60d173953a7c266
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| 06b0d5b564d0ee5e9fe5955c134762d54ffabed9 |
|
14-Nov-2017 |
Fan Zhang <zhfan@google.com> |
Send context object to FeatureFlagUtils.
Bug: 36222960
Test: robotests
Change-Id: I9ca2d8c679474e545988f518eaf32acf459abd2c
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| ff4da23a654f281bc67a6503d54bf8a18320ef4e |
|
09-Nov-2017 |
Fan Zhang <zhfan@google.com> |
Create a feature flag for Search v2.
Also moved all other flags in a common file so we can track them more
easily.
Bug: 68825426
Bug: 64938328
Test: rerun robotests
Change-Id: I3fc805054cb960bedd965b1b907be759df50b95d
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| f9e985d018e824c043b62691b4a8f9bd2610ca3a |
|
30-Oct-2017 |
Fan Zhang <zhfan@google.com> |
Enable suggestion v2 experiment
Bug: 68662574
Test: robotests
Change-Id: Ib8aeef45ebe1260e9c8699e231db37840a0ce3db
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| 13ce22080776c708f603e4439023942298f8e1d3 |
|
06-Oct-2017 |
Fan Zhang <zhfan@google.com> |
Log cleanup: remove unnecessary logging for suggestions
- Remove show_suggestion logging in DashboardAdapater. Showing
suggestion is logged inside SuggestionAdapter during onBind.
- Remove hide_suggestion logging. It's not used by anyone.
- Move SuggestionLogHelper into SuggestionFeatureProvider
Bug: 65065268
Test: robotests
Change-Id: I1e7929d739b79527d2ae01c25177676f6be6ddff
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| 31f699c281dfeecf9f8911a46eaf49a052d9ef90 |
|
29-Sep-2017 |
Fan Zhang <zhfan@google.com> |
Move code from SuggestionChecks to FeatureProvider
This is step one to deprecate SuggestionChecks. Moving logic into
SuggestionFeatureProvider allows potential logic override and improves
testability.
Also moved isSuggestionComplete tests to corresponding activity/pref
controller test.
Bug: 65065268
Test: robotests
Change-Id: I2071d30fc58bb84acad2083ca03cfcf7d41f10cb
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| cd7b13bba5f55b29234bf56d827cee2a919c19d3 |
|
26-Sep-2017 |
Fan Zhang <zhfan@google.com> |
Plumb SuggestionControllerMixin to DismissController.
- The SuggestionControllerMixin is needed to dismiss a suggestion.
- When swipe a suggestion, SuggestionControllerMixin is called, which
then calls API in SuggestionService to dismiss a suggestion.
Bug: 65065268
Test: robotests
Change-Id: I6a0c5823d60b995ab4a36b1c91777f5cd31a500d
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| 6598a7b4cd785477795da1d075352329c615e639 |
|
22-Sep-2017 |
Fan Zhang <zhfan@google.com> |
Let SuggestionFeatureProvider manage SuggestionService name
Bug: 65065268
Test: robotests
Change-Id: I82315a7b1565dc34b516bf685ad8e831a1e28591
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| bfb671391d099cdb39dc2e0191b73834f46da1ec |
|
20-Sep-2017 |
Christine Franks <christyfranks@google.com> |
resolve merge conflicts of 92f7794d90 to master
Test: I solemnly swer I tested this conflict resolution.
Change-Id: I2cbcd06b906904365f9257742ab1c51b67adc3af
|
| cb52e803bf5c4484bfe06eb9503bbf4a9a46a645 |
|
20-Sep-2017 |
Christine Franks <christyfranks@google.com> |
Merge "Handle night display state when timezone changes" into oc-mr1-dev
|
| 82cb5a5cc84c0dd255c7689a2d8b609987d6d1ce |
|
18-Aug-2017 |
Fan Zhang <zhfan@google.com> |
Load suggestions through SettingsIntelligence.
- Add flag to switch between old/new implementation
- Add SuggestionLoader to load using Loader (instead of AsyncTask)
- Update DashboardAdapater/SuggestionAdapter to take List<Suggestion>
- Marked old getter/setters as @Deprecated and added comment
- Update tests to cover suggestionV2 adapter changes.
TODO:
- Handler for dismissing suggestion not set up yet.
- Suggestion data structure is incomplete (missing icon, remote view, etc)
- Need to extend Suggestion data strcture to support icon and
remote view binding
Bug: 65065268
Test: robotests
Change-Id: I2378ef4c9edee972d5de93c3868068e2cde23f56
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| c6c299bdbba614a4b792f74b9b3cb5f7471edbe0 |
|
25-Aug-2017 |
Christine Franks <christyfranks@google.com> |
Handle night display state when timezone changes
Bug: 64458884
Test: make RunSettingsRoboTests -j100
Change-Id: I1f0c073b796aa6826c236757e19c6ff6d5cb7602
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| 5ba0f51bcd059a4a82e38eb621a3b6bf0ba522b5 |
|
11-Aug-2017 |
Soroosh Mariooryad <soroosh@google.com> |
Log smart settings suggestion enabled/disabled state for A/B experiments
Test: RunSettingsRoboTests
Bug: 64121058
Change-Id: Iadfa575b9a21caecb515b9975d388ee0d0480c11
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| 7fe6f50bf7df6cf638903b0e16fbe085a2afac08 |
|
11-Aug-2017 |
Soroosh Mariooryad <soroosh@google.com> |
Log smart settings suggestion enabled/disabled state for A/B experiments
Test: RunSettingsRoboTests
Bug: 64121058
Change-Id: I0cf4b4a0e8470cd40d38e8fe937cfb5f3e96f380
Merged-In: Iadfa575b9a21caecb515b9975d388ee0d0480c11
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| 0cb4c86f4ad66ff53c9675a33edda2b6b8b46b8e |
|
04-Aug-2017 |
Fan Zhang <zhfan@google.com> |
Clean up logic for dismissing suggestion
We no longer bring suggestions back after dismissing, so some logic is
no longer necessary.
Change-Id: I9d931fbbbc79bade191bebf6d057870d088a5fde
Fixes: 64297191
Test: robotests
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| e651ddf9e6c00a62338ef8c7114b5e5e9cd307ec |
|
20-Jul-2017 |
Fan Zhang <zhfan@google.com> |
Add shadow to searchbar when user scrolls vertically
Bug: 63528057
Test: robotests
Change-Id: Ib85676d78b43be38aab1eacd0820d0755a601f60
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| 1e0b51218beb7ac6b603b841f802c5ea9bf56a08 |
|
07-Jul-2017 |
Fan Zhang <zhfan@google.com> |
Disable suggestion on low memory devices
Change-Id: I9d22170845661fc8b48b116c9b09f758926c096f
Fix: 63157777
Test: make RunSettingsRoboTests
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| 20d5588a278efbc862d40a6d7ec1ae5efb33013f |
|
01-Jul-2017 |
Daniel Sheng <dsheng@google.com> |
Added suggestions for gestures.
Bug: 30986021
Test: manual + make RunSettingsRoboTests + adb shell am instrument -w
com.android.settings.tests.unit /android.support.test.runner.AndroidJUnitRunner
Change-Id: I7aed110c81ca2fb6b90e2f359b4bb941c02bc1c3
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| e199f50d65384fe6d171ed938ca356f54ac4270d |
|
28-Jun-2017 |
Fan Zhang <zhfan@google.com> |
Disable SmartSuggestion conditionally
The smart suggestion flag should be treated as false when dismissing
first impression type suggestions. Smart suggestion and first impression
suggestions have different dismiss rules.
Change-Id: Ia99d310ddea7baf58b6eadacee8ccda5bf33f311
Fix: 63094854
Test: robotests
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| 2bc94d62713df640559ea9d21a3d54eb28886f5a |
|
18-May-2017 |
Sean Stout <sstout@google.com> |
Add Night Light Suggestion and tests
Night Light settings suggestion will only show when the user
has not previously interacted with Night Light.
Bug: 37207263
Test: make ROBOTEST_FILTER=\
"(SettingsSuggestionsTest|SuggestionFeatureProviderImplTest)"\
RunSettingsRoboTests
Change-Id: I432d5fef19f5e4a52503da136b044598cb82164a
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| 9011a67431b22fa794e84202363b4966ed4534d1 |
|
01-Jun-2017 |
Fan Zhang <zhfan@google.com> |
Add a suggestion: showing new device features
- New suggestion activity
- Removed useless api SuggestionFeatureProvider.isPresent().
- Also updated support activity search indexing icon and summary
Change-Id: Ib52cf26a985f57bf0aac918606b10f75bd024639
Fix: 62034077
Fix: 62196070
Test: make RunSettingsRoboTests
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| 7551c80bc85846a951b4c0e63048badf79706f85 |
|
25-May-2017 |
Maurice Lam <yukl@google.com> |
Pass component name into SuggestionFeatureProvider
So that the provider can be used for more than one suggestion.
Test: Robolectric test for implementation of the provider
Bug: 62039057
Change-Id: Ibea41ea6d98e67c55ec157556675e854f3ea31c4
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| 59fd017ce568eb75190fdcf830c005f66cf094c0 |
|
12-May-2017 |
Fan Zhang <zhfan@google.com> |
Revert "Revert "Filter and display top 3 suggestions for exclusive type""
This reverts commit 184ae963e78bd70f15339d9a89542688881332db.
Change-Id: Iac60fc52a5b0c153945c22b97394546a529d3bb4
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| 184ae963e78bd70f15339d9a89542688881332db |
|
12-May-2017 |
Fan Zhang <zhfan@google.com> |
Revert "Filter and display top 3 suggestions for exclusive type"
This reverts commit 70b634adcff5a7d0f453ddaedfd2c772b29d8757.
Change-Id: I6de213d4c276696c6ccc9e992ff088cf507aa7ce
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| 70b634adcff5a7d0f453ddaedfd2c772b29d8757 |
|
12-May-2017 |
Fan Zhang <zhfan@google.com> |
Filter and display top 3 suggestions for exclusive type
Change-Id: Ief4c2f02fcf1064dac3659502bd7511b09a2a7df
Fix: 37947647
Test: make RunSettingsRoboTests
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| 7afbf0f3a215984415b31c63c22be37e95f90519 |
|
08-May-2017 |
Fan Zhang <zhfan@google.com> |
Add support to show first impression type suggestions
- Add FIRST_IMPRESSION type in suggestion order list.
- Make rule changes for a few suggestions.
Bug: 37947647
Test: manual
Change-Id: I2101f5e0f6424723bacc9f5febf2ffaab9398896
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| ae53f976509f4f28fb2f9afa36ab15a8ccc9dd09 |
|
27-Mar-2017 |
Doris Ling <dling@google.com> |
Fix null pointer on dismissing suggestion.
Add null check for context when getting the suggestion identifier, since
this is called from async task and context might becomes null.
Change-Id: If17036803de1634891b659a4fc6bd4b8a76ef5fb
Fix: 36605386
Test: make RunSettingsRoboTests
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| 8c8c4077fe7c4a692fb02500847f39bf0eb302dd |
|
22-Mar-2017 |
Fan Zhang <zhfan@google.com> |
Fix a monkey crash when it dismisses suggestion.
Change-Id: I300a49ed75381795b6532388f770847ed39a4c8c
Fix: 36509330
Test: make RunSettingsRoboTests
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| 264c0c2bbe6b16103774ffafa405e50a8fe68a45 |
|
16-Mar-2017 |
Fan Zhang <zhfan@google.com> |
Fix NPE when building suggestion identifier.
And refactored the getIdent logic into feature provider.
Change-Id: Id6f66a6942cbaf6d26ae4dca62037a6cf01179a5
Fix: 36314240
Test: make RunSettingsRoboTests
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| a5b620e73815834f138f8af0591ca42f45c0abd7 |
|
23-Feb-2017 |
Fan Zhang <zhfan@google.com> |
Swipe to dismiss suggestions
- Move dismiss suggestion logic into feature provider
- In DashboardData, use hashcode as suggestion's stable id. This is much
more likely to provide a truely stable id for each suggestion card.
Eventually I want to use hash for all tiles to provide stable id.
- Add a SuggestionDismissionController to handle swipe to dismiss
callbacks
Change-Id: If3770f07a90c5469a0b86fc28f3eb5e4c17227cd
Fix: 35159816
Test: make RunSettingsRoboTests
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|
| 5f375a2776950b7e511d668102e7079efc57171c |
|
23-Feb-2017 |
Soroosh Mariooryad <soroosh@google.com> |
Move suggestions package to dashboard.suggestions
Test: RunSettingsRoboTests
Change-Id: I4f9af27767c8e55d3b1a16e77c099da52d40aab5
/packages/apps/Settings/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
|