| 359a6b5c06709951e07ce7d1091b9780e35c792b |
|
11-Apr-2018 |
Rubin Xu <rubinxu@google.com> |
Do not set separate challenge flag before clearing lock
This step is redundant since clearLock() would set the flag internally anyway.
In fact setting the flag before calling clearLock() is wrong since it will
lead LockSettingsService.setLockCredential() to think that the target profile
does not have a unified challenge, causing it to use an incorrect existing
credential for password change, leading to untrusted credential change.
Bug: 77892111
Test: Create profile; set separate empty work challenge; observe no crash
Change-Id: I4d76b20706a796654f9389f31ae8c46d51d7adac
/packages/apps/Settings/src/com/android/settings/password/ChooseLockGeneric.java
|
| c548977ea179126b523a6492b8b8175adaafd530 |
|
28-Mar-2018 |
Rubin Xu <rubinxu@google.com> |
Confirm parent user's credential when setting lock for profile
When a DPC fires ACTION_SET_NEW_PASSWORD to set a work challenge
for an existing work profile with unified challenge, require the
user to confirm exisiting device lock first. This is not only for
increased security, but also a functionality requirement: the
system can only re-derive the current work profile password needed
by the password change after a fresh confirm credential operation.
Test: Add device lock, create work profile, then execute:
adb shell su 1010000 am start --user 10 -a android.app.action.SET_NEW_PASSWORD
Verify the device is prompting for current password.
Bug: 65910682
Change-Id: Ib4b4c88c1551cfff626f707d5f3182160a1ec46c
/packages/apps/Settings/src/com/android/settings/password/ChooseLockGeneric.java
|
| e0b0e9f9025038d72f8129606cc1f432afcb54e0 |
|
29-Nov-2017 |
Fan Zhang <zhfan@google.com> |
Refactor help menu stuff into a controller
This is a clean up to action bar menu item pattern, we will use the same
pattern to build search icon on all pages in a later change.
Bug: 68814716
Test: robotests
Change-Id: Iedd3ec263e8ccb63ed75ec7a95b28c00878b1de4
/packages/apps/Settings/src/com/android/settings/password/ChooseLockGeneric.java
|
| 40e187b3641ac3084c706b10d2213b91a53da5d1 |
|
11-Oct-2017 |
Pavel Grafov <pgrafov@google.com> |
Preserve old password when handling SET_NEW_PASSWORD.
Currently the only way mUserPassword can be set is when it comes
from onActivityResult. This way when the user chooses "Continue
without Pixel Imprint", and we switch ChooseLockGeneric->InternalActivity,
mUserPassword becomes null (it is not preserved in intent extras).
And then this null is used in getLockPasswordIntent which causes the issue.
Another issues is that when the user chooses to use fingerprint,
mHasChallenge is set to true and password is not forwarded to
ChooseLock(Password|Pattern). I changed the intent builders so that both
old password and challenge can be sent at the same time, so the password
is not lost when fingerprint is set.
Bug: 67672081
Test: cd packages/apps/Settings/tests/robotests/ && mma
Test: manual, adb shell am start -a android.app.action.SET_NEW_PASSWORD,
tried setting pin/password with and without fingerprint.
Test: manual, tried to change lock via Settings -> Security&Location
Test: manual, set pin + fingerprint in Setup Wizard, FBE and FDE devices
Test: manual, set pin + added account, used pin to unlock FRP in SUW
Change-Id: I38d56d84f95c63fef24c2aa1a031d629f22756a1
/packages/apps/Settings/src/com/android/settings/password/ChooseLockGeneric.java
|
| 2bb62380449da124cd36fac80d6072ad6c4d0592 |
|
16-Aug-2017 |
Maurice Lam <yukl@google.com> |
Don't launch Choose Lock again if recreating
When ChooseLockGeneric is recreated, don't automatically launch
ChooseLock[Password/Pattern] even if the corresponding intent extras
are specified, because one would have been launched in the previous
onCreate.
Test: Manual
Bug: 64605627
Change-Id: I227a14abb2f4dd6c4577186a3d8164df0bec7791
/packages/apps/Settings/src/com/android/settings/password/ChooseLockGeneric.java
|
| b49526ee282f13a83ee38358473fcb628b5727a5 |
|
01-Jun-2017 |
Maurice Lam <yukl@google.com> |
Show fingerprint text in backup screen lock
When setting up fingerprint's backup screen lock, show a different
header text that says
"To use fingerprint, set {PIN/pattern/password}" instead of
"Choose your {PIN/pattern/password}".
Test: Manual. Existing tests pass
Bug: 62187833
Change-Id: If1084e64b99291a0eda63c174793b5a091ab4bae
/packages/apps/Settings/src/com/android/settings/password/ChooseLockGeneric.java
|
| 821c83e749668b00e2760f6fd2eac289cb8912c4 |
|
18-May-2017 |
TreeHugger Robot <treehugger-gerrit@google.com> |
Merge "Default setup wizard to use PIN"
|
| 80c3a16e92e64b09d2554d2e243593c3209ef1f7 |
|
17-May-2017 |
Charles He <qiurui@google.com> |
Merge "Properly remove fingerprints when removing device lock." into oc-dev am: 98229bdf32
am: af36129ae9
Change-Id: Iffc4f16ac3301bc0fbe9b4d8a1c88b3e71ce2373
|
| edb39449842dd1360fa5f92c990785bf7c8dcdcd |
|
28-Apr-2017 |
Maurice Lam <yukl@google.com> |
Default setup wizard to use PIN
- Added "Screen lock options" button in PIN screen, controlled by
extra EXTRA_SHOW_OPTIONS_BUTTON, which will create a dialog to ask
the user to choose another screen lock type.
- Extracted ScreenLockType enum and ChooseLockGenericController that
can be shared by ChooseLockGeneric and the dialog
ChooseLockTypeDialogFragment.
- The intent extra EXTRA_SHOW_OPTIONS_BUTTON will be set if
ChooseLockGeneric screen starts ChooseLockPassword /
ChooseLockPattern without asking the user. (Although the extra is
ignored by ChooseLockPattern currently)
- Fix layout alignment for the password entry field to remove the
extra 4dp padding on the sides.
Test: cd tests/robotests && mma
Bug: 35442933
Bug: 38002299
Change-Id: I877fbe08a0c05bb97175e1cbf0260ea6dbda22e2
/packages/apps/Settings/src/com/android/settings/password/ChooseLockGeneric.java
|
| 2eb170cd6ff43db01dc0ff3c1fcac5ebba4489de |
|
29-Apr-2017 |
Maurice Lam <yukl@google.com> |
Clean up choose lock intent creation
Consolidated the many variants of ChooseLock*.createIntent, so that
it will take the same set of arguments.
Also modified SetupChooseLock*.createIntent to modifyIntentForSetup,
which will take the intent created by ChooseLock* and modify it for
use with setup.
Test: cd tests/robotests && mma
Change-Id: I5ff033f459c33ec9980872a536b3996d89f2bbbb
/packages/apps/Settings/src/com/android/settings/password/ChooseLockGeneric.java
|