| fdae46505f66759b58e7718b4706894020c8b7a5 |
|
13-Dec-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Minor GATT logging fixes
Test: compilation
Bug: 70297056
Change-Id: If71bbb19a08abbbb30b5ce5027aed97e03b3baaa
/system/bt/bta/gatt/bta_gatts_act.cc
|
| 5b790feeeb211c42bf78ca3ae9c26aa30e516765 |
|
18-Sep-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Make copyright headers consistent with Google template; remove "(C)"
Test: Comment changes only; still compiles...
Change-Id: Id699a8170112f06e4a2c9f2e0f0834d1817ace4e
/system/bt/bta/gatt/bta_gatts_act.cc
|
| 6ef9190de8be01a36a3e409e8253624326bf30ea |
|
03-Oct-2017 |
Myles Watson <mylesgw@google.com> |
Remove casts in bta/ and stack/btm
Make pointers to const structs const pointers.
Pass complete unions instead of casting smaller objects.
Test: build
Change-Id: I7d6b61183554be70ac7f58f4133a76ec68e35408
/system/bt/bta/gatt/bta_gatts_act.cc
|
| 2647452211f7beaee19610fe79442828ab2b0ee6 |
|
04-Oct-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Use LOG() macros in BTA GATT logging
Test: compilation test
Change-Id: If7676af5bf915df57ab6e876d2f27500ebf5c07d
/system/bt/bta/gatt/bta_gatts_act.cc
|
| b749ebde2c6a55569e4e480abda3a4ee3afe2d72 |
|
07-Oct-2017 |
Myles Watson <mylesgw@google.com> |
Use unary operator instead of == bool
Automatically generated with coccinelle:
@@
expression e1;
@@
-e1 == false
+!e1
@@
expression e1;
@@
-false == e1
+!e1
@@
expression e1;
@@
-e1 == true
+e1
@@
expression e1;
@@
-true == e1
+e1
Test: build
Change-Id: Ic7df0dc43b550594855e457466b6bccd8f3443a3
/system/bt/bta/gatt/bta_gatts_act.cc
|
| 50ba9031b4551b013fe5f77c8648c85a257365c5 |
|
26-Sep-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Remove unnecesary BTA redefinitions for GATT part 4
Test: compilation test
Change-Id: Ibe37a1c6506d567b68497e8c7074d90cd73ddf00
/system/bt/bta/gatt/bta_gatts_act.cc
|
| e9ef00c3fb2de5077a8ffdb728f1996cc1e9a155 |
|
26-Sep-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Remove unnecesary BTA redefinitions for GATT part 2
Test: compilation test
Change-Id: Iaf81188596c33b92f79f163dc95187ed5c6f52a4
/system/bt/bta/gatt/bta_gatts_act.cc
|
| 819e2ecb84a22d6e03ec9ed67b3260c0dd7e8aba |
|
10-Jul-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Use one type for UUID (1/5)
Currently, we have few different representations for UUID in stack:
tBT_UUID, tSDP_UUID, bt_uuid_t, bluetooth:UUID, or uint8_t*.
Additionally, tBT_UUID and bt_uuid_t are used to hold UUID as 128bit
as Little Endian or Big Endian, depending on which part of stack (GATT
or SDP) is using it.
This patch is creating one type, bluetooth::Uuid, that will replace all
other types.
Bug: 66912853
Test: all sl4a tests for GATT and RFCOMM
Merged-In: Ia42d3233146db0488728ed6f878f99b368fe8838
Change-Id: Ia42d3233146db0488728ed6f878f99b368fe8838
/system/bt/bta/gatt/bta_gatts_act.cc
|
| 5b96667c28d868a3c93edec0b9d7242532fcfb78 |
|
08-Sep-2017 |
Jeremy Klein <jlklein@google.com> |
Ensure that services are cleaned from the GattServer HandleMap.
The incorrect service handle was being plumbed up to onServiceDeleted.
This was causing stale entries to stick around forever in the HandleMap,
which could later cause failures to find callback references in
ContextMap if the connection ID changed for a given device.
Bug: 65463237
Test: unit tests modified and run
Change-Id: I2e22858b447f4e6b5a4fbceee4c406191c84a67d
/system/bt/bta/gatt/bta_gatts_act.cc
|
| a484a888196ddf8bcbf1ad3226d6451bc735a94b |
|
25-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Rename bt_bdaddr_t into RawAddress (3/3)
Test: compilation test
Change-Id: I4571721a0c6165a66450ee157a53d8d15bfc45d0
/system/bt/bta/gatt/bta_gatts_act.cc
|
| c752e135d66f80c0b2efc35292ab8ddfd8227d61 |
|
16-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Replace BT_ADDR with bd_addr_t in bta_sys related code
Test: compilation test
Change-Id: Idab6e9c03621c5540b4a3a7fa537dff71a25ce3f
/system/bt/bta/gatt/bta_gatts_act.cc
|
| c2276b06572ab6fc1f900fbb1f41087e77d47e2a |
|
10-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Use bt_bdaddr_t instead of BD_ADDR
Test: compilation test, sl4a GattReadTest
Change-Id: I8d1bd6914aec55bb53495b1d0d5e3d37b86865e6
/system/bt/bta/gatt/bta_gatts_act.cc
|
| b5ba4fdbc433544de3806f8e82976898e444b491 |
|
24-Mar-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Expose connection update callback (1/3)
Test: manual
Bug: 30622771
Change-Id: I94d25f6f22b42fb1432a9288c97b82503d57db86
/system/bt/bta/gatt/bta_gatts_act.cc
|
| eafd45d08653bb1621c82a2f3cf922a43a0b1bc5 |
|
23-Mar-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Set preferred PHY and read PHY implementation (3/3)
Test: manual
Bug: 30622771
Change-Id: I4267238a0b5c7bc373ae1846ebd19a716881a4ec
/system/bt/bta/gatt/bta_gatts_act.cc
|
| f33b6f434f086b20fabe5913016bc423ac975057 |
|
23-Nov-2016 |
Marie Janssen <jamuraa@google.com> |
readability fix: No assigns in if conditionals
Coccinelle-assisted:
@@
variable i;
expression E;
statement S1, S2;
@@
+ i = E;
if (
(
- (i = E)
+ i
!= ...
|
- (i = E)
+ i
== ...
|
- (i = E)
+ i
< ...
|
- (i = E)
+ i
> ...
|
- (i = E)
+ i
<= ...
|
- (i = E)
+ i
>= ...
|
- (i = E)
+ i
)
) S1 else S2
for file in $(find . -name "*.cc"); do
spatch --sp no-if-assigns.cocci --in-place $file
done
clang-format --style=file -i bta/**/*.cc
Test: mma -j37 and basic sanity testing on angler, sailfish
Change-Id: I41a2964afac347c24e13869b6c172e321e646091
/system/bt/bta/gatt/bta_gatts_act.cc
|
| 9979121f0865e07432215529f9b157792ae3ef21 |
|
18-Nov-2016 |
Myles Watson <mylesgw@google.com> |
Remove BTA_GATT_INCLUDED
Test: Connect to a BLE Keyboard
Change-Id: I00393e2bf09fb65533e953896563e69aab5a22dc
/system/bt/bta/gatt/bta_gatts_act.cc
|
| 1baaae3f34a667058e7f0c5f778357d98320cf38 |
|
09-Nov-2016 |
Myles Watson <mylesgw@google.com> |
bta: Fix comment formatting after clang-format
Test: mma -j32
Change-Id: Ic945ac421b1918527105c59674eda89afd3d4126
/system/bt/bta/gatt/bta_gatts_act.cc
|
| cd1fd07f1306e08fe048682dd5918987e579f937 |
|
09-Nov-2016 |
Myles Watson <mylesgw@google.com> |
bta: Apply clang-format
clang-format -i --style=file bta/*/*
(twice)
Test: mma -j32
Change-Id: Ib118b1dfb6a34f9a5bfe153d65841e9041165264
/system/bt/bta/gatt/bta_gatts_act.cc
|
| 8af480e24549ba51a3f6858d9d9af504715e0bea |
|
09-Nov-2016 |
Myles Watson <mylesgw@google.com> |
bta: Remove double asterisks in comments
Double asterisks at the beginning of the line
sed -i s,"^[*][*]"," *", bta/*/*
Double asterisks after a space
sed -i s,"^ [*][*]\([^*]\)"," *\1", bta/*/*
sed -i s,"^ [*][*]$"," *", bta/*/*
Test: mma -j32
Change-Id: Ib83b802c7000176683b4e7f24d1255b3c2c6c01c
/system/bt/bta/gatt/bta_gatts_act.cc
|
| 2e8c421ddce1dae511a39b8e89415e8eb1944bfd |
|
29-Oct-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
Remove advertise whitelist functionality
Advertise filtering is never used. It is not finished - adding device to
whitelist can never succed. It is also making advertising API unification
hard.
Bug: 30622771
Test: no tests necessary
Change-Id: I9df9ea18b265a580c2fcdb28a6d6ce4be43f0a24
/system/bt/bta/gatt/bta_gatts_act.cc
|
| d7ffd64accbd50a27289a388856e56244ccbb5da |
|
27-Oct-2016 |
Myles Watson <mylesgw@google.com> |
Remove deprecated UNUSED macro (5/5)
Include osi.h for UNUSED_ATTR.
Test: mma -j32
Change-Id: I43260669dc1f54639e46cc9620093d727ee86276
/system/bt/bta/gatt/bta_gatts_act.cc
|
| d35a648d39710bbc5ac59f8add85166455af5af7 |
|
27-Oct-2016 |
Myles Watson <mylesgw@google.com> |
Remove deprecated UNUSED macro (1/5)
Generated automatically with coccinelle
/* This rule matches functions with arguments
* that have an UNUSED(arg) in the body.
*/
@r1@
identifier arg;
identifier fn;
type t;
parameter list[n] P;
@@
fn(P, const t arg) { ...
UNUSED(arg);
...
}
/* This rule removes the UNUSED line, and adds
* UNUSED_ATTR to the parameter list.
*/
@depends on r1@
identifier r1.arg;
identifier r1.fn;
type r1.t;
parameter list[r1.n] r1.P;
typedef UNUSED_ATTR;
@@
fn(P,
- const t arg
+ UNUSED_ATTR GETRIDOFTHISCOMMA, const t arg
) { ...
-UNUSED(arg);
...
}
Test: mma -j32
Change-Id: Idcaadd688d669d484e557becd050e69454508f3c
/system/bt/bta/gatt/bta_gatts_act.cc
|
| 109891d07f7946c69070a01e0ebef56ee3eb7707 |
|
18-Jul-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
Make gatt_attr use opportunistic connection
This patch creates new connection mode - opportunistic connection. When
such connection is made, no call to gatt_update_app_hold_link_status
will be made when it's started.
This means that connecting and disconnecting in this mode won't trigger
disconnect timer. When other, app creates regular connection and then
disconnects, the physical connection might get disconnected.
Opportunistic connection is used only for code setting CCC right now.
Bug: 30186455
Change-Id: Ia5be7682b6c3dcb4993060f818dee603aef3e19e
/system/bt/bta/gatt/bta_gatts_act.cc
|
| a641b6fa2a25e1b5382945d13c4fa49d36084a78 |
|
26-Mar-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
GATT Server refactoring (4/4)
Right now in order to add gatt service, we need to add it piece by
piece - each characteristic and descriptor separately. This causes lots
of concurrency errors in higher layers. Instead accept whole service
definition and start whole service at once.
Also, use handles to identify GATT server attributes. It's already done
on clinet side.
Bug: 27999121
Change-Id: I42c796809423d116fe6755ef8b1c40da270427a5
/system/bt/bta/gatt/bta_gatts_act.cc
|
| e9e58ced195ec2c983c7723c9cbdabd45eb0f2fd |
|
17-Jun-2016 |
Marie Janssen <jamuraa@google.com> |
bta: use standard types
Use standard types everywhere.
Use standard style for #if statements:
- #if (VAR_NAME == TRUE)
- #if (VAR_NAME1 == TRUE && VAR_NAME2 == TRUE)
Use __func__ instead of __FUNCTION__
Fix some debug statements to use __func__
Change-Id: Ib86de4de9f14529ecaa4f71597260e3b5785360b
/system/bt/bta/gatt/bta_gatts_act.cc
|
| 19117701657073f3b8ba03620c081a8976b318a6 |
|
26-May-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
Convert GATT related BTA code to C++
Change-Id: I9c36d0ebeb1143395b3b38b3d179d12a9503d28a
/system/bt/bta/gatt/bta_gatts_act.cc
|