| 812d20dfd8512cfb3ce2f69f5e5d38a5be71b186 |
|
12-Jan-2018 |
Hemant Gupta <hemantg@codeaurora.org> |
Revert "HID: Update condition for checking LE HID handle validity"
This reverts commit af94891aa6e66b0d4b495d60aeac2aa8091c9d33 as changes to
fix same issue already merged via commit 2e3c3d782993c475e608291896db73b0960fa9dd
so this patch is not longer required.
Test: Code analysis for aosp master
Fixes: 71842479
Change-Id: Ifbc2375ad6df7231c85ef30c5e2c5b5d8dde16f0
/system/bt/bta/hh/bta_hh_int.h
|
| af94891aa6e66b0d4b495d60aeac2aa8091c9d33 |
|
11-Jan-2018 |
Hemant Gupta <hemantg@codeaurora.org> |
HID: Update condition for checking LE HID handle validity
1) Pair and connect with BR/EDR HID devices and LE devices
such that the total number of connected paired devices
becomes 7. It is not required that connection to all devices be
maintained, they can be disconnected as well afterwards.
2) Pair and connect with a new LE device. Connection fails
3) Retry connecting to same LE device. Connection does not go through
4) Turn BT off
Observed Result:
1) LE device cannot be connected in step 2
2) Tombstone in BT while switching off BT with below signature
backtrace:
#00 pc 0000000000092438 /system/lib64/libc.so (ifree+88)
#01 pc 000000000009298c /system/lib64/libc.so (je_free+120)
#02 pc 00000000001b266c /system/lib64/hw/bluetooth.default.so (_Z18osi_free_and_resetPPv+84)
#03 pc 0000000000062f84 /system/lib64/hw/bluetooth.default.so
(_Z17bta_hh_sm_executeP14tBTA_HH_DEV_CBtP12tBTA_HH_DATA+880)
#04 pc 0000000000063120 /system/lib64/hw/bluetooth.default.so (_Z16bta_hh_hdl_eventP6BT_HDR+296)
#05 pc 000000000007bbc4 /system/lib64/hw/bluetooth.default.so (_Z13bta_sys_eventP6BT_HDR+60)
#06 pc 00000000001b4d88 /system/lib64/hw/bluetooth.default.so (_ZL22internal_dequeue_readyPv+80)
#07 pc 00000000001b96f4 /system/lib64/hw/bluetooth.default.so (_ZL11run_reactorP9reactor_ti+312)
#08 pc 00000000001b9590 /system/lib64/hw/bluetooth.default.so (_Z13reactor_startP9reactor_t+80)
#09 pc 00000000001baf24 /system/lib64/hw/bluetooth.default.so (_ZL10run_threadPv+256)
#10 pc 0000000000067bc4 /system/lib64/libc.so (_ZL15__pthread_startPv+36)
#11 pc 000000000001f264 /system/lib64/libc.so (__start_thread+68)
Root Cause:
Wrong conditional check in macro BTA_HH_IS_LE_DEV_HDL_VALID which ignores the condition that max
14 HID devices can be connected and all of them can be LE as well.
Fix:
Update the condition in macro BTA_HH_IS_LE_DEV_HDL_VALID to compare with BTA_HH_MAX_DEVICE instead of
BTA_HH_LE_MAX_KNOWN
Test: Not yet performed, only code and log analysis
Fixes: 71842479
Change-Id: I2b56b6f109787608e25c340150be313f0f5397be
/system/bt/bta/hh/bta_hh_int.h
|
| 2e3c3d782993c475e608291896db73b0960fa9dd |
|
11-Sep-2017 |
Ruina Liu <ruina.liu@mediatek.com> |
Fix Bluetooth crash when pairing with 8th HOGP device
In function bta_hh_hdl_event, when handling with
the event of BTA_HH_API_GET_DSCP_EVT after bonded
with 8th HOGP device, no correct p_cb will be found,
due to mapping error between the device handle and
dev cb for HOGP. Then NPE happen.
Change to map le_cb_index into the device handle for
HOGP, so that HOGP and HID can be separately maintained
maximum to 14 device
Test: Pair with 14 HOGP devices
Change-Id: I8556f1ffea160862c2e52f874ef334f68c17050e
/system/bt/bta/hh/bta_hh_int.h
|
| 5b790feeeb211c42bf78ca3ae9c26aa30e516765 |
|
18-Sep-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Make copyright headers consistent with Google template; remove "(C)"
Test: Comment changes only; still compiles...
Change-Id: Id699a8170112f06e4a2c9f2e0f0834d1817ace4e
/system/bt/bta/hh/bta_hh_int.h
|
| e9ef00c3fb2de5077a8ffdb728f1996cc1e9a155 |
|
26-Sep-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Remove unnecesary BTA redefinitions for GATT part 2
Test: compilation test
Change-Id: Iaf81188596c33b92f79f163dc95187ed5c6f52a4
/system/bt/bta/hh/bta_hh_int.h
|
| a484a888196ddf8bcbf1ad3226d6451bc735a94b |
|
25-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Rename bt_bdaddr_t into RawAddress (3/3)
Test: compilation test
Change-Id: I4571721a0c6165a66450ee157a53d8d15bfc45d0
/system/bt/bta/hh/bta_hh_int.h
|
| 011a61951975849b23a10d2be87e5268008d3407 |
|
10-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Use bt_bdaddr_t instead of BD_ADDR in HID related code
Test: compilation test, sl4a GattReadTest
Change-Id: I4e91375746fbd966608a830ff71de79be2b99e6c
/system/bt/bta/hh/bta_hh_int.h
|
| 9979121f0865e07432215529f9b157792ae3ef21 |
|
18-Nov-2016 |
Myles Watson <mylesgw@google.com> |
Remove BTA_GATT_INCLUDED
Test: Connect to a BLE Keyboard
Change-Id: I00393e2bf09fb65533e953896563e69aab5a22dc
/system/bt/bta/hh/bta_hh_int.h
|
| 84baa7f16e830394408278dbb8c508dd9fa02887 |
|
14-Nov-2016 |
Myles Watson <mylesgw@google.com> |
Remove BLE_INCLUDED define
Test: Connect to a BLE Keyboard
Change-Id: I5f8f4017c90c3c404004632fd10e6c2b93bd7783
/system/bt/bta/hh/bta_hh_int.h
|
| cd1fd07f1306e08fe048682dd5918987e579f937 |
|
09-Nov-2016 |
Myles Watson <mylesgw@google.com> |
bta: Apply clang-format
clang-format -i --style=file bta/*/*
(twice)
Test: mma -j32
Change-Id: Ib118b1dfb6a34f9a5bfe153d65841e9041165264
/system/bt/bta/hh/bta_hh_int.h
|
| 8af480e24549ba51a3f6858d9d9af504715e0bea |
|
09-Nov-2016 |
Myles Watson <mylesgw@google.com> |
bta: Remove double asterisks in comments
Double asterisks at the beginning of the line
sed -i s,"^[*][*]"," *", bta/*/*
Double asterisks after a space
sed -i s,"^ [*][*]\([^*]\)"," *\1", bta/*/*
sed -i s,"^ [*][*]$"," *", bta/*/*
Test: mma -j32
Change-Id: Ib83b802c7000176683b4e7f24d1255b3c2c6c01c
/system/bt/bta/hh/bta_hh_int.h
|
| 24ea892320ca85c7f6cdd77343da50818fe29002 |
|
14-May-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
Add callbacks to GATT read/write operation
There is no need for read/write callback to be a global event. It should
execute local callback instead.
Change-Id: Id7e915af9d30092d2f754eddc7c3aed4970eeb2f
/system/bt/bta/hh/bta_hh_int.h
|
| 25984b0d221cf48cd4dd606b881674ce7b29bf44 |
|
24-Jun-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
Get rid of unused BTA_DYNAMIC_MEMORY
Change-Id: Idc7fcddfecac9ab7d9800b496e2380ae277f357f
/system/bt/bta/hh/bta_hh_int.h
|
| e9e58ced195ec2c983c7723c9cbdabd45eb0f2fd |
|
17-Jun-2016 |
Marie Janssen <jamuraa@google.com> |
bta: use standard types
Use standard types everywhere.
Use standard style for #if statements:
- #if (VAR_NAME == TRUE)
- #if (VAR_NAME1 == TRUE && VAR_NAME2 == TRUE)
Use __func__ instead of __FUNCTION__
Fix some debug statements to use __func__
Change-Id: Ib86de4de9f14529ecaa4f71597260e3b5785360b
/system/bt/bta/hh/bta_hh_int.h
|
| 19117701657073f3b8ba03620c081a8976b318a6 |
|
26-May-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
Convert GATT related BTA code to C++
Change-Id: I9c36d0ebeb1143395b3b38b3d179d12a9503d28a
/system/bt/bta/hh/bta_hh_int.h
|
| c3fe5a04a926672d3b363d88e6bd67eb46ba230c |
|
12-May-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
Remove dead HID code
This patch removes dead code in HID related to setting scan parameters
on remote device.
Change-Id: I96e0036b65d2ebb3b099d817683ed3d5a11b6bb7
/system/bt/bta/hh/bta_hh_int.h
|
| e8187e565382ae9afb52a7992e9a6ab1e3108999 |
|
15-Mar-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
HID service discovery refactor
This patch changes how HID is initialized.
Up till now, HID discovery was intricately chained,
to make sure two operations are not scheduled at same time.
From now on, all discovery is done and all operations are
scheduled for execution right away. There is separate set
of functions making sure all operations will be executed
without collisions.
This patch also removes BTA_HH_SCPP_INST_DEF, which was
used as hardcoded service id.
Bug: 27698756
Change-Id: I30a7388e129844c5e4727b2ed2b7c05867cc73a8
/system/bt/bta/hh/bta_hh_int.h
|
| 22aaded594fab42d5b30354a94c51d0b8666089b |
|
08-Mar-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
HID multi-device refactoring
We don't really support multiple HID services in same device.
We shouldn't use default value 0 for service id.
We shouldn't merge service id and characteristic id into one field,
as it's done not right right now.
Bug: 27455533
Change-Id: I46cc1b62bb2c7393e62f3b1a8e4650706954a066
/system/bt/bta/hh/bta_hh_int.h
|
| 0de22670c178b2e70c4d12ab94507d8f6b5a4f4d |
|
10-Mar-2014 |
Nitin Arora <niarora@codeaurora.org> |
Fix macro for maximum allowed HOGP devices
This checks HOGP dev handle count less than or equal to maximum
allowed HOGP devices.
Change-Id: I63e6c3bc64a8c305b739b5eade0e846315e1ad1d
/system/bt/bta/hh/bta_hh_int.h
|
| 794f3b5f126fffc3dd1129a710187591348bbf23 |
|
01-Oct-2014 |
Chris Manton <cmanton@google.com> |
Removal of bd.[c|h]
Consolidate legacy types into bt_types.h
/system/bt/bta/hh/bta_hh_int.h
|
| f37767a17b2d80828f7ac4fa170859cb9e2f0bc6 |
|
05-Nov-2014 |
Andre Eisenbach <eisenbach@google.com> |
HOGP: Do not remove device from whitelist on encryption failure
If the encryption times out during the re-connect process for a HOGP
device, the device is removed from the whitelist and thus will not
reconnect until it is added back to the list. On platforms that do not
have a way to reconnect to a device manually, this means the device will
never reconnect again until the stack is restarted.
This patch checks the reason for the encryption failure and does not
remove the device from the whitelist if the encryption failed to a non
authentication/key related error.
Bug: 18233442
Change-Id: Ifaec4a9224ff9281956715b38d34c2d7c3fecb01
/system/bt/bta/hh/bta_hh_int.h
|
| 433fe016392c7ae003033530f1b3994f2ddad313 |
|
17-Oct-2014 |
Chaojing Sun <cjsun@broadcom.com> |
Cache HOGP HID report map
HID reports from a bonded device can be missed when Bluetooth is
restarted HOGP report discovery is still active. Caching the
report information and loading it back when the stack resets
will ensure incoming HID reports can be processed immediately.
Bug: 17999991
Change-Id: I4608935f8749537d6b05625b894445a21f844ee0
/system/bt/bta/hh/bta_hh_int.h
|
| ac1d544eac1b849dd4105bd69e59ffeca00a43a6 |
|
19-Dec-2013 |
Zhihai Xu <zhihaixu@google.com> |
need to increase maximum number HID report for HOGP
The Mat mouse have more than 10 report (11),
which exceed our limitation
bug:12214036
Change-Id: Id578bf7959f73dc3bd57664eccf49ab5580ec76b
/system/bt/bta/hh/bta_hh_int.h
|
| 7051db3a486aae771d9b5a81c3546790f86ede34 |
|
13-Nov-2013 |
Zhihai Xu <zhihaixu@google.com> |
BLE HID device connection failure due to security error.
When HID BLE device start encryption, if some other GATT application
already start encryption(but not finished yet) by calling
gatt_security_check_start. The HID BLE device will be failed to start
encryption, which will cause it to disconnect the BLE HID connection.
The solution is to check whether we already started the encryption
, If the encryption is already started, wait until the encryption
finished, then continue to start security check for BLE HID device.
add encrytion complete event to notify all GATT client encryption done.
filter the event just for BTA HH LE GATT client.
bug:11636246
Change-Id: If58e57c623cc8cfa05208587b010bec68c71306c
/system/bt/bta/hh/bta_hh_int.h
|
| 36b686527892172cb44091d160b7d2806d49fc76 |
|
23-Oct-2013 |
Zhihai Xu <zhihaixu@google.com> |
Do not deregister HH GATT IF in bta_gattc_disable for hid over GATT
The root cause is bta_gattc_disable de-register the HH GATT IF
which cause bta_hh_cleanup_disable called
before we receive BTA_HH_INT_CLOSE_EVT.
The fix is "don't deregister HH GATT IF in bta_gattc_disable and
let HH module to de-register the HH GATT IF by bta_hh_le_deregister".
because HH GATT IF is a special GATT IF
which won't be exposed to uplayer and
HH GATT IF belong to BTA HH module, it should be managed by BTA HH.
bug:11284861
Change-Id: Ia14cd2be3f3548a4d1e2dcfbc89fa3a75d9651db
/system/bt/bta/hh/bta_hh_int.h
|
| 2e7fa68bfd9723b7ec7b6b0b128d89f31a2e06ee |
|
09-Aug-2013 |
Andre Eisenbach <andre@broadcom.com> |
LE: Add support for the HID-over-GATT profile (1/3)
bug:8330048
Change-Id: I5727161b0a87700487bee96cdffa8fd169034204
/system/bt/bta/hh/bta_hh_int.h
|
| ead3cde4bac0c3e32cd31f149093f004eef8ceeb |
|
06-Feb-2013 |
Ganesh Ganapathi Batta <ganeshg@broadcom.com> |
Initial version of BLE support for Bluedroid
Change-Id: I9825a5cef9be2559c34c2a529b211b7d471147cf
/system/bt/bta/hh/bta_hh_int.h
|
| 5738f83aeb59361a0a2eda2460113f6dc9194271 |
|
13-Dec-2012 |
The Android Open Source Project <initial-contribution@android.com> |
Snapshot cdeccf6fdd8c2d494ea2867cb37a025bf8879baf
Change-Id: Ia2de32ccb97a9641462c72363b0a8c4288f4f36d
/system/bt/bta/hh/bta_hh_int.h
|