| 362b4041f3162ef3d219d6bcebdd5170ae28a662 |
|
10-May-2017 |
Josh Gao <jmgao@google.com> |
adb: fix darwin build break.
Fix the following build breakage:
system/core/adb/client/usb_osx.cpp:433:13: error: static declaration of 'usb_cleanup' follows non-static declaration
static void usb_cleanup() NO_THREAD_SAFETY_ANALYSIS {
^
system/core/adb/usb.h:48:5: note: previous declaration is here
ADB_USB_INTERFACE(native::usb_handle*);
Bug: http://b/38203892
Test: mma on linux, darwin
Change-Id: I1c042e4d64ddcc0713f329202bc2037e590a9b4f
/system/core/adb/client/usb_dispatch.cpp
|
| 01b7bc43e90b951675cabe88313b96f57b2da712 |
|
09-May-2017 |
Josh Gao <jmgao@google.com> |
adb: move all cleanup to a function with defined ordering.
We want to explicitly define the order in which we teardown adb, so
move all of the at_quick_exits sprinkled throughout into one function
containing all of the cleanup functions.
Bug: http://b/37104408
Test: adb kill-server; adb start-server
Change-Id: I394f5782eb147e394d4b87df1ba364c061de4b90
/system/core/adb/client/usb_dispatch.cpp
|
| ef3d343254405cc360b4df843c6e4a843c335012 |
|
03-May-2017 |
Josh Gao <jmgao@google.com> |
adb: use the actual wMaxPacketSize for usb endpoints.
Previously, adb was assuming a fixed maximum packet size of 1024 bytes
(the value for an endpoint connected via USB 3.0). When connected to an
endpoint that has an actual maximum packet size of 512 bytes (i.e.
every single device over USB 2.0), the following could occur:
device sends amessage with 512 byte payload
client reads amessage
client tries to read payload with a length of 1024
In this scenario, the kernel will block, waiting for an additional
packet which won't arrive until something else gets sent across the
wire, which will result in the previous read failing, and the new
packet being dropped.
Bug: http://b/37783561
Test: python test_device.py on linux/darwin, with native/libusb
Change-Id: I556f5344945e22dd1533b076f662a97eea24628e
/system/core/adb/client/usb_dispatch.cpp
|
| 5d1756ceb58246a721e10464f788e81cdcdc455a |
|
23-Feb-2017 |
Josh Gao <jmgao@google.com> |
adb: add `adb host-features`, report libusb status.
Add a 'host-features' command to get the features of the currently
running host adb server. Abuse it to report libusb status.
Bug: http://b/34983123
Test: adb host-features; adb kill-server; ADB_LIBUSB=1 adb start-server; adb host-features
Change-Id: I0e8d503a2dbdff9002ebb6ce8a298498a9421422
/system/core/adb/client/usb_dispatch.cpp
|
| aced420f20538eb64137e154b1b5e9a00551ffce |
|
01-Feb-2017 |
Nick Kralevich <nnk@google.com> |
usb_dispatch.cpp: Lower severity of logging statement.
The first time you run adb, it starts the adbd server and annoyingly
generates the following message:
adb I 02-01 11:57:58 99717 99717 usb_dispatch.cpp:30] using native
backend
Drop the severity of the message to avoid visible spammy messages only
intended for debugging.
Test: code compiles and no more log message in normal adb use
Change-Id: I882092a6cd14bc67980d88416397d51ab8393b1b
/system/core/adb/client/usb_dispatch.cpp
|
| 1c70e1bcbcced190b351d4fb418f32b4e428f496 |
|
28-Sep-2016 |
Josh Gao <jmgao@google.com> |
adb: add libusb implementation for Linux/Darwin.
Add a libusb-based implementation alongside the existing native
implementations, controlled by the ADB_LIBUSB environment variable.
Windows will need more work for the usb driver.
Bug: http://b/31321337
Test: python test_device.py on linux/darwin, with ADB_LIBUSB=0 and 1
Change-Id: Ib68fb2c6c05475eae3ff4cc19f55802a6f489bb7
/system/core/adb/client/usb_dispatch.cpp
|