da225498d97565b6f25ed28ebdf0fecdf3a5ca5c |
|
09-Jul-2014 |
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> |
pm8001: Cleaning up uninitialized variables There is a risk that the variable will be used without being initialized. This was largely found by using a static code analysis program called cppche Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Acked-by: Suresh Thiagarajan <Suresh.Thiagarajan@pmcs.com> Acked-by: Jack Wang <xjtuwjp@gmail.com> Signed-off-by: Christoph Hellwig <hch@lst.de>
|
5533abca06e07121697ed1d30863ce03e7c518e5 |
|
09-Jul-2014 |
Tomas Henzl <thenzl@redhat.com> |
pm8001: honor return value The driver ignores the return value in a lot of places, fix it at least somewhere (and release the resources in such cases), to avoid that bad things happen. Signed-off-by: Tomas Henzl <thenzl@redhat.com> Acked-by: Suresh Thiagarajan <Suresh.Thiagarajan@pmcs.com> Acked-by: Jack Wang <xjtuwjp@gmail.com> Signed-off-by: Christoph Hellwig <hch@lst.de>
|
2b01d816f5f884d5ea16ab2498736b1221bc027c |
|
16-Jan-2014 |
Suresh Thiagarajan <Suresh.Thiagarajan@pmcs.com> |
[SCSI] pm80xx: Spinlock fix spin_lock_irqsave for the HBA lock is called in one function where flag is local to that function. Another function is called from the first function where lock has to be released using spin_unlock_irqrestore for calling task_done of libsas. In the second function also flag is declared and used. For calling task_done there is no need to enable the irq. So instead of using spin_lock_irqsave and spin_unlock_irqrestore, spin_lock and spin_unlock is used now. This also avoids passing the flags across all the functions where HBA lock is being used. Also removed redundant code. Reported-by: Jason Seba <jason.seba42@gmail.com> Signed-off-by: Oleg Nesterov <oleg@redhat.com> Signed-off-by: Suresh Thiagarajan <Suresh.Thiagarajan@pmcs.com> Signed-off-by: Viswas G <viswas.g@pmcs.com> Acked-by: Jack Wang <xjtuwjp@gmail.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
|
cf370066ac5c7d5fdf384fef24b8ba48a481ffa5 |
|
10-Dec-2013 |
Viswas G <Viswas.G@pmcs.com> |
[SCSI] pm80xx: Fixed return value issue pm80xx_get_gsm_dump() was returning "1" in error case instead of negative error value. Signed-off-by: Viswas G <Viswas.G@pmcs.com> Reviewed-by: Jack Wang <jinpu.wang@profitbricks.com> Reviewed-by: Tomas Henzl <thenzl@redhat.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
|
7d029005484a6125a91a075518b9cfde830bc709 |
|
30-Oct-2013 |
Nikith Ganigarakoppal <Nikith.Ganigarakoppal@pmcs.com> |
[SCSI] pm80xx: Resetting the phy state. Setting the phy state for hard reset response. After sending hard reset for a device ,phy down event sets the phy state to zero but for phy up event it will not set the phy state again.This will cause problem to successive hard resets. Signed-off-by: Nikith.Ganigarakoppal@pmcs.com Signed-off-by: Anandkumar.Santhanam@pmcs.com Reviewed-by: Jack Wang <jinpu.wang@profitbricks.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
|
d078b5117f18dce57b895df640d9bf2614864829 |
|
03-Sep-2013 |
Anand Kumar Santhanam <AnandKumar.Santhanam@pmcs.com> |
[SCSI] pm80xx: Firmware logging support. Supports below logging facilities, Inbound outbound queues dump. Non fatal dump in case of IO failures. Fatal dump in case of firmware failure. [jejb: checkpatch spacing fixes] Signed-off-by: Anandkumar.Santhanam@pmcs.com Reviewed-by: Jack Wang <jinpu.wang@profitbricks.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
|
279094079a442c19ff7e7c0fd9511d9404cb2518 |
|
18-Sep-2013 |
Anand Kumar Santhanam <AnandKumar.Santhanam@pmcs.com> |
[SCSI] pm80xx: Phy settings support for motherboard controller. Phy profile implementation to support phy settings feature for motherboard controllers. [jejb: checkpatch fixes] Signed-off-by: Anandkumar.Santhanam@pmcs.com Reviewed-by: Jack Wang <jinpu.wang@profitbricks.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
|
06f12f22cefdc2737b54fc986d9b82ec358cdbb8 |
|
17-Sep-2013 |
Anand Kumar Santhanam <AnandKumar.Santhanam@pmcs.com> |
[SCSI] pm80xx: IButton security feature support for motherboard controllers. Signed-off-by: Anandkumar.Santhanam@pmcs.com Reviewed-by: Jack Wang <jinpu.wang@profitbricks.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
|
cb269c26ed027bea67f5961619ae43f480a4dd3d |
|
17-Sep-2013 |
Anand Kumar Santhanam <AnandKumar.Santhanam@pmcs.com> |
[SCSI] pm80xx: Print SAS address of IO failed device. [jejb: checkpatch fixes] Signed-off-by: Anandkumar.Santhanam@pmcs.com Reviewed-by: Jack Wang <jinpu.wang@profitbricks.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
|
0ecdf00ba6e50eaa452356d0d4e79657dab702a4 |
|
18-Sep-2013 |
Anand Kumar Santhanam <AnandKumar.Santhanam@pmcs.com> |
[SCSI] pm80xx: 4G boundary fix. Firmware is having an issue. When a single IO request crosses 4G boundary, system will crash. To avoid the issue single sg is converted into extended sg. Signed-off-by: Anandkumar.Santhanam@pmcs.com Reviewed-by: Jack Wang <jinpu.wang@profitbricks.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
|
f9cd6cbd80d1d5963ffd0eab3970235cd4205984 |
|
18-Sep-2013 |
Anand Kumar Santhanam <AnandKumar.Santhanam@pmcs.com> |
[SCSI] pm80xx: Queue rotation logic for inbound and outbound queues. Signed-off-by: Anandkumar.Santhanam@pmcs.com Reviewed-by: Jack Wang <jinpu.wang@profitbricks.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
|
cb993e5d50dd82e3d675225e2eff3c77951682b0 |
|
17-Sep-2013 |
Anand Kumar Santhanam <AnandKumar.Santhanam@pmcs.com> |
[SCSI] pm80xx: Indirect SMP request fix. Fix for indirect data transfer mode in case of SMP request. Signed-off-by: Anandkumar.Santhanam@pmcs.com Reviewed-by: Jack Wang <jinpu.wang@profitbricks.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
|
a9a923e55ede94ddbf5b870b0f057da8b7cee1b9 |
|
03-Sep-2013 |
Anand Kumar Santhanam <AnandKumar.Santhanam@pmcs.com> |
[SCSI] pm80xx: Device id changes to support series 8 controllers. Updated pci id table with device, vendor, subdevice and subvendor ids for 8074, 8076, 8077 SAS/SATA 12G controllers. Added 12G related macros. Signed-off-by: Anandkumar.Santhanam@pmcs.com Reviewed-by: Jack Wang <jinpu.wang@profitbricks.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
|
9504a923924d663e1953f872f0a828e6454a6cfc |
|
26-Jul-2013 |
Hans Verkuil <hverkuil@xs4all.nl> |
[SCSI] pm80xx: fix Adaptec 71605H hang The IO command size is 128 bytes for these new controllers as opposed to 64 for the old 8001 controller. The Adaptec out-of-tree driver did this correctly. After comparing the two this turned out to be the crucial difference. So don't hardcode the IO command size, instead use pm8001_ha->iomb_size as that is the correct value for both old and new controllers. Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Acked-by: Anand Kumar Santhanam <AnandKumar.Santhanam@pmcs.com> Acked-by: Jack Wang <xjtuwjp@gmail.com> Cc: stable@vger.kernel.org # for v3.10 and up Signed-off-by: James Bottomley <JBottomley@Parallels.com>
|
e73823f7a2c921dcf068d34ea03bd682498d9e42 |
|
08-May-2013 |
James Bottomley <JBottomley@Parallels.com> |
[SCSI] libsas: implement > 16 byte CDB support Remove the arbitrary expectation in libsas that all SCSI commands are 16 bytes or less. Instead do all copies via cmd->cmd_len (and use a pointer to this in the libsas task instead of a copy). Note that this still doesn't enable > 16 byte CDB support in the underlying drivers because their internal format has to be fixed and the wire format of > 16 byte CDBs according to the SAS spec is different. the libsas drivers (isci, aic94xx, mvsas and pm8xxx are all updated for this change. Cc: Lukasz Dorau <lukasz.dorau@intel.com> Cc: Maciej Patelczyk <maciej.patelczyk@intel.com> Cc: Dave Jiang <dave.jiang@intel.com> Cc: Jack Wang <xjtuwjp@gmail.com> Cc: Lindar Liu <lindar_liu@usish.com> Cc: Xiangliang Yu <yuxiangl@marvell.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
|
8b513d0cf603c0a9ccf86a92cb22931f05a7bc86 |
|
21-May-2013 |
Masanari Iida <standby24x7@gmail.com> |
treewide: Fix typo in printk Correct spelling typo in various part of drivers Signed-off-by: Masanari Iida <standby24x7@gmail.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
|
aa9f8328fc51460e15da129caf622b6560fa8c99 |
|
07-May-2013 |
James Bottomley <JBottomley@Parallels.com> |
[SCSI] sas: unify the pointlessly separated enums sas_dev_type and sas_device_type These enums have been separate since the dawn of SAS, mainly because the latter is a procotol only enum and the former includes additional state for libsas. The dichotomy causes endless confusion about which one you should use where and leads to pointless warnings like this: drivers/scsi/mvsas/mv_sas.c: In function 'mvs_update_phyinfo': drivers/scsi/mvsas/mv_sas.c:1162:34: warning: comparison between 'enum sas_device_type' and 'enum sas_dev_type' [-Wenum-compare] Fix by eliminating one of them. The one kept is effectively the sas.h one, but call it sas_device_type and make sure the enums are all properly namespaced with the SAS_ prefix. Signed-off-by: James Bottomley <JBottomley@Parallels.com>
|
a6cb3d012b983b350ae3892cff2e692665df0e1e |
|
19-Mar-2013 |
Sakthivel K <Sakthivel.SaravananKamalRaju@pmcs.com> |
[SCSI] pm80xx: thermal, sas controller config and error handling update Modified thermal configuration to happen after interrupt registration Added SAS controller configuration during initialization Added error handling logic to handle I_T_Nexus errors and variants [jejb: fix up tabs and spaces issues] Signed-off-by: Anand Kumar S <AnandKumar.Santhanam@pmcs.com> Acked-by: Jack Wang <jack_wang@usish.com> Reviewed-by: Hannes Reinecke <hare@suse.de> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
|
c6b9ef5779c3e1edfa9de949d2a51252bc347663 |
|
19-Mar-2013 |
Sakthivel K <Sakthivel.SaravananKamalRaju@pmcs.com> |
[SCSI] pm80xx: NCQ error handling changes Handled NCQ errors in the low level driver as the FW is not providing the faulty tag for NCQ errors for libsas to recover. [jejb: fix checkpatch issues] Signed-off-by: Anand Kumar S <AnandKumar.Santhanam@pmcs.com> Acked-by: Jack Wang <jack_wang@usish.com> Reviewed-by: Hannes Reinecke <hare@suse.de> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
|
f5860992db55c9e36b0f120dff73f0c34abe510d |
|
17-Apr-2013 |
Sakthivel K <Sakthivel.SaravananKamalRaju@pmcs.com> |
[SCSI] pm80xx: Added SPCv/ve specific hardware functionalities and relevant changes in common files Implementation of SPCv/ve specific hardware functionality and macros. Changing common functionalities wrt SPCv/ve operations. Conditional checks for SPC specific operations. Signed-off-by: Sakthivel K <Sakthivel.SaravananKamalRaju@pmcs.com> Signed-off-by: Anand Kumar S <AnandKumar.Santhanam@pmcs.com> Acked-by: Jack Wang <jack_wang@usish.com> Reviewed-by: Hannes Reinecke <hare@suse.de> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
|