| e31981a13dcef28fcbe18d274375a8cc081843d6 |
|
29-Sep-2014 |
Heena Sirwani <heenasirwani@gmail.com> |
Staging: bcm: Removed unnecessary else.
The following patch fixes the checkpatch.pl warning:
WARNING: else is not generally useful after a break or return.
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 0fb591632c36d46d0ca2bd147db59068ff4345e1 |
|
28-Sep-2014 |
Yeliz Taneroglu <yeliztaneroglu@gmail.com> |
staging: bcm: Fix quoted string split across lines warning
The following patch the checkpatch.pl warning:
drivers/staging/bcm/InterfaceIdleMode.c:215: warning:quoted string split across lines
Signed-off-by: Yeliz Taneroglu <yeliztaneroglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 4764ca981b040048766e4f39a45a4b9c5cecff9c |
|
26-May-2014 |
Peter Senna Tschudin <peter.senna@gmail.com> |
drivers/staging: Remove useless return variables
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.
Verified by compilation only.
The coccinelle script that find and fixes this issue is:
// <smpl>
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 8b80448d478f8cbaeb9deac10731f06db94c69d6 |
|
20-Dec-2013 |
Gokulnath Avanashilingam <Gokulnath.Avanashilingam@in.bosch.com> |
staging: bcm: fixed warning about no and prohibited space in InterfaceIdleMode.c.
This patch fixes all the warning related to spacing issues
found by checkpatch.pl script in InterfaceIdleMode.c
Signed-off-by: Gokulnath Avanashilingam <Gokulnath.Avanashilingam@in.bosch.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| e42ff08dd9626e1cbb824837734e3c3c633d5ad1 |
|
20-Dec-2013 |
Gokulnath Avanashilingam <Gokulnath.Avanashilingam@in.bosch.com> |
staging: bcm: using time_after and time_before in InterfaceIdleMode.c
Used the time_after and time_before insted of comparing
the jiffies directly.This will fix the warnings and errors
found by the checkpatch.pl script.
Signed-off-by: Gokulnath Avanashilingam <Gokulnath.Avanashilingam@in.bosch.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 786bdddc36ba707f9f60de499199e3835e8911f3 |
|
20-Dec-2013 |
Gokulnath Avanashilingam <Gokulnath.Avanashilingam@in.bosch.com> |
staging: bcm: line over 80 characters in InterfaceIdleMode.c
Fixed all the line over 80 characters warning found by
checkpatch.pl script.
Signed-off-by: Gokulnath Avanashilingam <Gokulnath.Avanashilingam@in.bosch.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| d52dd37e19b6dada6cfeace4784346497357fa24 |
|
20-Dec-2013 |
Gokulnath Avanashilingam <Gokulnath.Avanashilingam@in.bosch.com> |
staging: bcm: Remove Developer Debug prints in InterfaceIdleMode.c
Removed the developer debug prints BCM_DEBUG_PRINT()
as per the TODO list, also removed braces for the
if-statement to match coding style
Signed-off-by: Gokulnath Avanashilingam <Gokulnath.Avanashilingam@in.bosch.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| f70c8a91cd0e743d0531a158d939bbdb6c0874dc |
|
28-Oct-2013 |
Lisa Nguyen <lisa@xenapiadmin.com> |
staging: bcm: Replace FALSE with false
Replace user-defined type FALSE with C defined false keyword.
Signed-off-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| db95f150b98691bc2a6e8673d7802bb6ee1b5447 |
|
15-May-2013 |
Tülin İzer <tulinizer@gmail.com> |
Staging: bcm: Fixed warning 'space required before the open parenthesis '(''.
This patch fixes warning 'space required before the open parenthesis '(''
found by checkpacth.pl in driver bcm.
Signed-off-by: Tülin İzer <tulinizer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 461c8d2423fc9c00e8834f379ee80f79c1d6fb9f |
|
15-May-2013 |
Tülin İzer <tulinizer@gmail.com> |
Staging: bcm: Fixed error 'else should follow close brace '}''.
This patch fixes error 'else should follow close brace '}''
found by checkpatch in driver bcm.
Signed-off-by: Tülin İzer <tulinizer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 3b5ecbab99c9ed10b30c18f984ef144167b2c3fc |
|
15-May-2013 |
Tülin İzer <tulinizer@gmail.com> |
Staging: bcm: Fixed warning 'braces {} are not necessary for single statement blocks'.
This patch fixes warning: 'braces {} are not necessary for single
statement blocks' found by checkpatch.pl in driver bcm.
Signed-off-by: Tülin İzer <tulinizer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| ec8451372b8612f7595a3c9f70961aaa1c85a0c2 |
|
15-May-2013 |
Tülin İzer <tulinizer@gmail.com> |
Staging: bcm: Fixed error 'that open brace { should be on the previous line'.
This patch fixes error 'that open brace { should be on the previous line'
found by checkpatch in driver bcm.
Signed-off-by: Tülin İzer <tulinizer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 3a92a697e41e62da0c6d4f292e6cc3f5c20bd4ea |
|
15-May-2013 |
Tülin İzer <tulinizer@gmail.com> |
Staging: bcm: Fixed warning 'space required around '=''.
This patch fixes warning 'space required around '='' found by
checkpatch in driver bcm.
Signed-off-by: Tülin İzer <tulinizer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 8546681507d1c93e87b78dfe11fb94a47846e46c |
|
15-May-2013 |
Tülin İzer <tulinizer@gmail.com> |
Staging: bcm: Fixed warning about C99 comments.
Fixed warning 'C99 comments' found by checkpatch in driver bcm.
Signed-off-by: Tülin İzer <tulinizer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| b73f2290b44dd77fc94f781699902fa3f1880dfb |
|
12-May-2013 |
Tülin İzer <tulinizer@gmail.com> |
Staging: bcm: Fixed warning about pointer position.
This patch fixes warning about pointer position in driver bcm.
Signed-off-by: Tülin İzer <tulinizer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| ebf8c6a35dcb43fa25e483a56d02fb18fb27c641 |
|
11-May-2013 |
Tülin İzer <tulinizer@gmail.com> |
Staging: bcm: fixed warning 'space reqires around '==' '
This patch fixes warning found by checkpatch.pl in driver bcm.
Signed-off-by: Tülin İzer <tulinizer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| d5922e6ffc670e4f0f7b5f4996b3d82d88518927 |
|
11-May-2013 |
Tülin İzer <tulinizer@gmail.com> |
Staging: bcm: fixed warning 'space required after ',' '
This patch fixes warning found by checkpatch.pl in driver bcm.
Signed-off-by: Tülin İzer <tulinizer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| d6861cfef2e42fecd5f0d51554493e45df6612a6 |
|
02-Nov-2012 |
Kevin McKinney <klmckinney1@gmail.com> |
Staging: bcm: Remove typedef for _S_INTERFACE_ADAPTER and call directly.
This patch removes typedef for
_S_INTERFACE_ADAPTER, changes the
name of the struct to bcm_interface_adapter.
In addition, any calls to typedefs
S_INTERFACE_ADAPTER, or *PS_INTERFACE_ADAPTER
are changed to call the struct directly.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 2979460d7aba1dac3452edcacd7b8c4cfcf06067 |
|
26-May-2012 |
Kevin McKinney <klmckinney1@gmail.com> |
Staging: bcm: Remove typedef for _MINI_ADAPTER and call directly.
This patch removes typedef for _MINI_ADAPTER, changes the
name of the struct from _MINI_ADAPTER to bcm_mini_adapter.
In addition, any calls to the following typedefs
"MINI_ADAPTER, *PMINI_ADAPTER" are changed to call
the struct directly.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 41c7b7c0fa2f68afb1154e88597ff6b9b97334cf |
|
06-Nov-2011 |
Kevin McKinney <klmckinney1@gmail.com> |
Staging: bcm: Fix information leak in ioctl: IOCTL_BCM_REGISTER_READ_PRIVATE, IOCTL_BCM_EEPROM_REGISTER_READ
This patch fixes an information leak in ioctl
IOCTL_BCM_REGISTER_READ_PRIVATE and
IOCTL_BCM_EEPROM_REGISTER_READ when determining
the number of bytes to copy to user space. Function,
usb_control_msg, returns the correct number of
bytes from the hardware. Instead of using
this value, we were using a value derived from
user space. In this case, this value could be more
than the hardware allocated. Therefore, this
patch copies the proper number of bytes from
the hardware, and uses this value as the maximum
number of bytes for user space.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
| 25985edcedea6396277003854657b5f3cb31a628 |
|
31-Mar-2011 |
Lucas De Marchi <lucas.demarchi@profusion.mobi> |
Fix common misspellings
Fixes generated by 'codespell' and manually reviewed.
Signed-off-by: Lucas De Marchi <lucas.demarchi@profusion.mobi>
|
| 9dd47ee7dd535649a2c32d509631c7a3d793f2e1 |
|
01-Nov-2010 |
Stephen Hemminger <stephen.hemminger@vyatta.com> |
beceem: make local functions static
Use namespace tool from kernel scripts to identify dead code and
functions that should be static.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
|
| 3644c1a2f12b15e1c8bfb9ebfaacbd177011a72d |
|
01-Nov-2010 |
Stephen Hemminger <stephen.hemminger@vyatta.com> |
beceem: remove dead code
Remove commented out with '#if 0'
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
|
| 44a17eff844d92421c8b568c84df29735e1e45f9 |
|
30-Sep-2010 |
Arnd Bergmann <arnd@arndb.de> |
staging/bcm: add sparse annotations
This marks up the code where sparse complains in most cases.
Most of the changes are in the ioctl handling code, which
gets __user annotations, finding one unchecked user access.
The rest is mostly about marking functions static when they
are only used in one file.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
| f8942e07a3db9d82e8fb11d3d494876b8bae9ff9 |
|
08-Sep-2010 |
Stephen Hemminger <stephen.hemminger@vyatta.com> |
staging: Beeceem USB Wimax driver
The Sprint 4G network uses a Wimax dongle with Beecem
chipset. The driver is typical of out of tree drivers, but
maybe useful for people, and the hardware is readily available.
Here is a staging ready version (i.e warts and all)
0. Started with Rel_5.2.7.3P1_USB from Sprint4GDeveloperPack-1.1
1. Consolidated files in staging
2. Remove Dos cr/lf
3. Remove unnecessary ioctl from usbbcm_fops
Applied patches that were in the developer pack, surprising
there were ones for 2.6.35 already.
This is compile tested only, see TODO for what still needs
to be done.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|