| a01a56bdb3b31dd38b515cc6b208061d39d41458 |
|
17-Jul-2014 |
Michalis Pappas <mpappas@fastmail.fm> |
staging: gdm72xx: remove debug code
Removed dump_eth_packet() and helper functions called upon packet tx/rx.
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| c835a677331495cf137a7f8a023463afd9f032f8 |
|
14-Jul-2014 |
Tom Gundersen <teg@jklm.no> |
net: set name_assign_type in alloc_netdev()
Extend alloc_netdev{,_mq{,s}}() to take name_assign_type as argument, and convert
all users to pass NET_NAME_UNKNOWN.
Coccinelle patch:
@@
expression sizeof_priv, name, setup, txqs, rxqs, count;
@@
(
-alloc_netdev_mqs(sizeof_priv, name, setup, txqs, rxqs)
+alloc_netdev_mqs(sizeof_priv, name, NET_NAME_UNKNOWN, setup, txqs, rxqs)
|
-alloc_netdev_mq(sizeof_priv, name, setup, count)
+alloc_netdev_mq(sizeof_priv, name, NET_NAME_UNKNOWN, setup, count)
|
-alloc_netdev(sizeof_priv, name, setup)
+alloc_netdev(sizeof_priv, name, NET_NAME_UNKNOWN, setup)
)
v9: move comments here from the wrong commit
Signed-off-by: Tom Gundersen <teg@jklm.no>
Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
|
| 1aa8ae70432f0b2f54d41497ffdea8c8184608c6 |
|
09-Jul-2014 |
Michalis Pappas <mpappas@fastmail.fm> |
staging: gdm72xx: reorder functions and remove forward declarations
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 7ba58220ee2d305de89d725c19de351898f8ed06 |
|
09-Jul-2014 |
Michalis Pappas <mpappas@fastmail.fm> |
staging: gdm72xx: move T_CAPABILITY definitions to hci.h
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| cd687a4073d58b5763ed085b942302714f0fa73d |
|
08-Jul-2014 |
Tobias Klauser <tklauser@distanz.ch> |
staging: gdm72xx: Remove unnecessary memset of netdev private data
The memory for struct net_device private data is allocated using
kzalloc/vzalloc in alloc_netdev_mqs, thus there is no need to zero it
again in the driver.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| b92274e78a587dde4e4cf87228c4dc4d1ad5039d |
|
08-Jul-2014 |
Tobias Klauser <tklauser@distanz.ch> |
staging: gdm72xx: Use net_device_stats from struct net_device
Instead of using an own copy of struct net_device_stats in struct nic,
use stats from struct net_device. Also remove the thus unnecessary
.ndo_get_stats function, as it would now just return netdev->stats,
which is the default in dev_get_stats().
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 9b34519040a268d70a5f8538e6fbc11e0b420440 |
|
01-Jul-2014 |
Michalis Pappas <mpappas@fastmail.fm> |
staging: gdm72xx: remove unused code
Remove code surrounded by otherwise unused #define LOOPBACK_TEST
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| a8a175d9fc2ddb513baf5f043c1e9de512f886f7 |
|
01-Jul-2014 |
Ben Chan <benchan@chromium.org> |
staging: gdm72xx: clean up endianness conversions
This patch cleans up the endianness conversions in the gdm72xx driver:
- Directly use the generic byte-reordering macros for endianness
conversion instead of some custom-defined macros.
- Convert values on the constant side instead of the variable side when
appropriate.
- Add endianness annotations.
Signed-off-by: Ben Chan <benchan@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| e7d374e700638728cfe3c6066e6a2678ebbbc19c |
|
24-Jun-2014 |
Ben Chan <benchan@chromium.org> |
staging: gdm72xx: fix block comment style
This patch fixes the following checkpatch warnings, which are issued
when the gdm72xx driver is moved out of staging into drivers/net/wimax:
WARNING: networking block comments don't use an empty /* line, use /* Comment...
WARNING: networking block comments start with * on subsequent lines
WARNING: networking block comments put the trailing */ on a separate line
Signed-off-by: Ben Chan <benchan@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| a29b18573a23571daf6610eb95ce9d3efaa47f0e |
|
25-Jun-2014 |
Ben Chan <benchan@chromium.org> |
staging: gdm72xx: check return value of sscanf
Signed-off-by: Ben Chan <benchan@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| a3709f7a143d9522ede046d23ed46b7f4fe67102 |
|
23-May-2014 |
Davide Gianforte <davide@gengisdave.org> |
staging: gdm72xx: code cleanup
Checkpatch.pl cleanup
Thanks again to Greg KH and Dan Carpenter for the patience :)
Signed-off-by: Davide Gianforte <davide@gengisdave.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 8a5e7b012d761e85ed8703412e53d1ef997b43ff |
|
23-May-2014 |
Gengis Dave <root@gengisdave.org> |
staging: gdm72xx: return values cleanup
Return values cleanup
Signed-off-by: Davide Gianforte <davide@gengisdave.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| ac1a3bfafb66d51be061c341f05f283d38d2e22f |
|
09-May-2014 |
Michalis Pappas <mpappas@fastmail.fm> |
staging: gdm72xx: Indentation and other whitespace fixes
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 39c511f8cb90be18f12575e5bdaf566a5e9a56b5 |
|
09-May-2014 |
Michalis Pappas <mpappas@fastmail.fm> |
staging: gdm72xx: Whitespace fixes to conform to coding standards
Fixes the following checkpatch.pl issues:
WARNING: unnecessary whitespace before a quoted newline
CHECK: Alignment should match open parenthesis
CHECK: No space is necessary after a cast
Also some additional, whitespace related, readability issues.
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| b268666f6b25e4b09a612d69f4cb9a2089d7adb5 |
|
09-May-2014 |
Michalis Pappas <mpappas@fastmail.fm> |
staging: gdm72xx: Removed commented-out code
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 71fd11e1a0b585934b1b7af8114971979b0142c8 |
|
09-May-2014 |
Michalis Pappas <mpappas@fastmail.fm> |
staging: gdm72xx: Fix braces to conform with coding style
Fixes the following checkpatch.pl issue:
CHECK: braces {} should be used on all arms of this statement
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 8943a92fc257c439ffe55fb0f9896be57c58c56b |
|
15-Mar-2014 |
Kristina Martšenko <kristina.martsenko@gmail.com> |
staging: gdm72xx: replace printk() and debug macros with dynamic debugging
Replace printk(KERN_DEBUG ...) with netdev_dbg and dev_dbg. Remove
debug macros which become unnecessary.
This removes the following types of checkpatch warnings from the driver:
drivers/staging/gdm72xx/gdm_sdio.c:461: WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ...
Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
|
| 4db02435652dad3233d347c0ba6d9dece8ff791a |
|
15-Mar-2014 |
Kristina Martšenko <kristina.martsenko@gmail.com> |
staging: gdm72xx: use print_hex_dump_debug and remove debug macros
Since the kernel already has a function for hex dumps, use that instead
of the driver's own versions. The function supports dynamic debugging,
so also remove some unnecessary debug macros.
Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
|
| f10490e1b3a168968215619e8749c60b35fd8e50 |
|
05-Mar-2014 |
Monam Agarwal <monamagarwal123@gmail.com> |
Staging: gdm72xx: Fix incorrect type in assignment in gdm_wimax.c
This patch fixes following sparse warnings:
drivers/staging/gdm72xx/gdm_wimax.c:543:37: warning: incorrect type in argument 1 (different address spaces)
drivers/staging/gdm72xx/gdm_wimax.c:543:37: expected void [noderef] <asn:1>*to
drivers/staging/gdm72xx/gdm_wimax.c:543:37: got void *buf
drivers/staging/gdm72xx/gdm_wimax.c:566:41: warning: incorrect type in argument 2 (different address spaces)
drivers/staging/gdm72xx/gdm_wimax.c:566:41: expected void const [noderef] <asn:1>*from
drivers/staging/gdm72xx/gdm_wimax.c:566:41: got void *buf
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| b9225ca71a70ecb3984d3f9e4f65ea9989f4cd6f |
|
05-Mar-2014 |
Himangi Saraogi <himangi774@gmail.com> |
staging:gdm72xx: Fix unnecessary brace errors
This patch fixes the following warning for gdm_wimax.c
WARNING: braces {} are not necessary for any arm of this statement
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 9ef4090385a0c35192229ca77c9de273824040b4 |
|
22-May-2013 |
Xenia Ragiadakou <burzalodowa@gmail.com> |
gdm72xx: remove unnecessary cast in gdm_wimax.c
This patch removes an unnecessary cast on the return value
of alloc_netdev(), since alloc_netdev() returns a pointer
to the allocated struct net_device anyway.
Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 0df1a84e0ec875d1bc12ac6aca325cb3543a7ad6 |
|
28-Nov-2012 |
Shan Wei <davidshan@tencent.com> |
staging: gdm72xx: use %pI4 format to print IPv4 address and remove last usage of NIP6
commit cf4ca4874fc45 removed the definition of NIPQUAD and NIPQUAD_FMT,
and NIP6 also is out of date.
commit 2874762b31d8d replace deprecated NIPQUAD marco to C code, but we can use %pI4 to
print IPv4 address more simply. And remove constant condition judge.
Because DEBUG_SDU is not defined in gdm_wimax.h, no error message when compiling.
Signed-off-by: Shan Wei <davidshan@tencent.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| f57cee11374a0e3056313e0818e3ff2ebd0f496d |
|
29-Oct-2012 |
YAMANE Toshiaki <yamanetoshi@gmail.com> |
staging/gdm72xx: Use netdev_ or pr_ printks in gdm_wimax.c
fixed below checkpatch warnings.
- WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
- WARNING: Prefer netdev_emerg(netdev, ... then dev_emerg(dev, ... then pr_emerg(... to printk(KERN_EMERG ...
- WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
and add pr_fmt.
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 2874762b31d8d0eebcfdf189ec9906be9c1460f6 |
|
29-Sep-2012 |
Macpaul Lin <macpaul.from.taiwan@gmail.com> |
staging/gdm72xx: gdm_wimax: fix compile error when enable debug
Fix compile error when enable DEBUG_SDU and DEBUG_HCI.
Replace deprecated NIPQUAD marco to C code.
Signed-off-by: Macpaul Lin <macpaul.from.taiwan@gmail.com>
Cc: Macpaul Lin <macpaul@gmail.com>
Cc: Paul Stewart <pstew@chromium.org>
Cc: Ben Chan <benchan@chromium.org>
Cc: Sage Ahn <syahn@gctsemi.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 472aba5f91fd6413c9c75e71366f133aa8c7f2f2 |
|
24-Jul-2012 |
Ben Chan <benchan@chromium.org> |
staging: gdm72xx: fix reference counting in gdm_wimax_event_init
This patch fixes the commit "staging/gdm72xx: cleanup little at
gdm_wimax_event_rcv" (8df858ea76b76dde9a39d4edd9aaded983582cfe),
which mishandles the reference counting of wm_event.
Signed-off-by: Ben Chan <benchan@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 8df858ea76b76dde9a39d4edd9aaded983582cfe |
|
12-Jul-2012 |
Devendra Naga <devendra.aaru@gmail.com> |
staging/gdm72xx: cleanup little at gdm_wimax_event_rcv
the event sock check is done at the netlink_init itself.
Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| e7ecb0fb40a5358646888720848787da34cfa33d |
|
06-Jul-2012 |
Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
staging: gdm72xx: use %pM for MAC
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Ben Chan <benchan@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 02fd3b3670fb99017b17757d33a0a17e2405920c |
|
27-May-2012 |
Devendra Naga <devendra.aaru@gmail.com> |
staging/gdm72xx: Remove version.h includes
Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 54bc1ff1daa86353ab07191b7fdde05e6b3844b1 |
|
17-May-2012 |
Paul Stewart <pstew@chromium.org> |
staging: gdm72xx: Set up parent link in sysfs for gdm72xx devices
This patch uses SET_NETDEV_DEV to set up a 'device' parent link in sysfs
(e.g. /sys/class/net/wm0/device) for a gdm72xx device.
Signed-off-by: Paul Stewart <pstew@chromium.org>
Signed-off-by: Ben Chan <benchan@chromium.org>
Cc: Sage Ahn <syahn@gctsemi.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 247e9cffdce024fec5f55f76a8592f2fa8b3aa7b |
|
15-May-2012 |
Sage Ahn <syahn@gctsemi.com> |
staging: gdm72xx: Add GCT GDM72xx WiMAX driver.
This patch provides the kernel driver for the GDM72xx WiMAX chips
developed by GCT Semiconductor, Inc., which enables mobile WiMAX
connection on the Linux host.
Signed-off-by: Sage Ahn <syahn@gctsemi.com>
Cc: Ben Chan <benchan@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|