History log of /drivers/staging/media/omap4iss/iss_csi2.c
Revision Date Author Comments
4571c4f6f61730c4f3624b6d3cb9ab042297949b 02-Oct-2014 Yeliz Taneroglu <yeliztaneroglu@gmail.com> staging: media: Fixed else after return or break warning

The following patch fixes the checkpatch.pl warning:

drivers/staging/media/omap4iss/iss_csi2.c:811 warning: else is not generally useful after a break or return

Signed-off-by: Yeliz Taneroglu <yeliztaneroglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9d374b2c7a7d4cc8ab302d15939cfd0af9ab0467 21-Sep-2014 Gulsah Kose <gulsah.1004@gmail.com> staging: media: omap4iss: Fixes missing blank line warning.

Fixes "Missing a blank line after declarations" checkpatch.pl warning in
iss_csi2.c

Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
aecfa5af1e2e282404fc56285d494701ed040a5d 19-Jun-2014 Heinrich Schuchardt <xypron.glpk@gmx.de> [media] v4l: omap4iss: configuration using uninitialized variable

Variable reg is not initialized.
Random values are written to OMAP4 ISS registers if !ctx->eof_enabled.

Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
fa7014f569b2a38b926792a9b9021df0af0556e9 21-Apr-2014 Laurent Pinchart <laurent.pinchart@ideasonboard.com> [media] omap4iss: Relax usleep ranges

Allow the system to merge CPU wakeups by specifying different minimum
and maximum usleep values.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
05b1b986b540fe48f98a09b087b054754d67ef41 28-Mar-2014 Laurent Pinchart <laurent.pinchart@ideasonboard.com> [media] omap4iss: Use a common macro for all sleep-based poll loops

Instead of implementing usleep_range-based poll loops manually (and
slightly differently), create a generic iss_poll_wait_timeout() macro
and use it through the driver.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
eaf95eeec47e41f30139eaad8c0f3d33c5059d22 16-Dec-2013 Dan Carpenter <dan.carpenter@oracle.com> [media] v4l: omap4iss: use snprintf() to make smatch happy

Smatch complains here because name is a 32 character buffer and we
adding the "OMAP4 ISS " prefix as well for a total of 42 characters.
The sd->name buffer can only hold 32 characters. I've changed it to use
snprintf() to silence the overflow warning.

Also I have removed the call to strlcpy() which is a no-op.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
216814fb0167673c6417b5db83ade84e58031e2c 10-Oct-2013 Laurent Pinchart <laurent.pinchart@ideasonboard.com> [media] v4l: omap4iss: csi2: Replace manual if statement with a subclk field

Instead of manually checking whether the CSI2 module is CSI2a or CSI2b
in order to select the right subclock to enable/disable, add a subclk
field to the iss_csi2 structure, initialize it with the corresponding
subclock value and use it at runtime.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
6016498f2b9d72b4f813d7349f0621ccc92c4f5a 09-Oct-2013 Laurent Pinchart <laurent.pinchart@ideasonboard.com> [media] v4l: omap4iss: Propagate stop timeouts from submodules to the driver core

Return an error from the s_stream handlers when stopping the stream
failed instead of just logging the error and ignoring it. While we're
at it, move the logging code from submodules to the driver code.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
3c4ee96b5fd5bb0223965fda97918fdd353d240c 04-Sep-2013 Laurent Pinchart <laurent.pinchart@ideasonboard.com> [media] v4l: omap4iss: Convert hexadecimal constants to lower case

The Linux kernel recommends lower case for hexadecimal constants.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
97059524ba6fd6c7dc77fa97e6957501b85af3be 31-Aug-2013 Laurent Pinchart <laurent.pinchart@ideasonboard.com> [media] v4l: omap4iss: csi: Create and use register access functions

Replace the direct readl/writel calls with helper functions.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
cd782f9d6d6c4a713b5cc5ccc0bb65f86e294b2f 28-Aug-2013 Laurent Pinchart <laurent.pinchart@ideasonboard.com> [media] v4l: omap4iss: Fix operators precedence in ternary operators

The ternary operator ? : has a low precedence. Use parenthesis where
needed.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
499226fb196fef838fa38700b96448a2ec41b704 04-Dec-2013 Laurent Pinchart <laurent.pinchart@ideasonboard.com> [media] v4l: omap4iss: Don't split log strings on multiple lines

Non-split strings help grepping for messages.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
4cd89e91bb8dbefe54743df6a5c4437812c96e3a 04-Dec-2013 Laurent Pinchart <laurent.pinchart@ideasonboard.com> [media] v4l: omap4iss: Replace printk by dev_err

dev_err is preferred over printk(KERN_ERR) when a device pointer is
available.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
b4a0477c0b87c5b7a20a84df8cf81311d1efb226 24-Jan-2011 Sergio Aguirre <sergio.a.aguirre@gmail.com> [media] v4l: omap4iss: Add support for OMAP4 camera interface - CSI receivers

This adds a very simplistic driver to utilize the CSI2A interface inside
the ISS subsystem in OMAP4, and dump the data to memory.
Check Documentation/video4linux/omap4_camera.txt for details.
This commit adds CSI receivers support.

Signed-off-by: Sergio Aguirre <sergio.a.aguirre@gmail.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>