History log of /drivers/staging/rtl8188eu/core/rtw_cmd.c
Revision Date Author Comments
33dc85c3c667209c930b2dac5ccbc2a365e06b7a 12-Nov-2014 Larry Finger <Larry.Finger@lwfinger.net> staging: r8188eu: Fix scheduling while atomic error introduced in commit fadbe0cd

In commit fadbe0cd5292851608e2e01b91d9295fa287b9fe entitled "staging:
rtl8188eu:Remove rtw_zmalloc(), wrapper for kzalloc()", the author failed
to note that the original code in the wrapper tested whether the caller
could sleep, and set the flags argument to kzalloc() appropriately.
After the patch, GFP_KERNEL is used unconditionally. Unfortunately, several
of the routines may be entered from an interrupt routine and generate
a BUG splat for every such call. Routine rtw_sitesurvey_cmd() is used in the
example below:

BUG: sleeping function called from invalid context at mm/slub.c:1240
in_atomic(): 1, irqs_disabled(): 0, pid: 756, name: wpa_supplicant
INFO: lockdep is turned off.
CPU: 2 PID: 756 Comm: wpa_supplicant Tainted: G WC O 3.18.0-rc4+ #34
Hardware name: TOSHIBA TECRA A50-A/TECRA A50-A, BIOS Version 4.20 04/17/2014
ffffc90005557000 ffff880216fafaa8 ffffffff816b0bbf 0000000000000000
ffff8800c3b58000 ffff880216fafac8 ffffffff8107af77 0000000000000001
0000000000000010 ffff880216fafb18 ffffffff811b06ce 0000000000000000
Call Trace:
[<ffffffff816b0bbf>] dump_stack+0x4e/0x71
[<ffffffff8107af77>] __might_sleep+0xf7/0x120
[<ffffffff811b06ce>] kmem_cache_alloc_trace+0x4e/0x1f0
[<ffffffffa0888226>] ? rtw_sitesurvey_cmd+0x56/0x2a0 [r8188eu]
[<ffffffffa0888226>] rtw_sitesurvey_cmd+0x56/0x2a0 [r8188eu]
[<ffffffffa088f00d>] rtw_do_join+0x22d/0x370 [r8188eu]
[<ffffffffa088f6e8>] rtw_set_802_11_ssid+0x218/0x3d0 [r8188eu]
[<ffffffffa08c3ca5>] rtw_wx_set_essid+0x1e5/0x410 [r8188eu]
[<ffffffffa08c3ac0>] ? rtw_wx_get_rate+0x50/0x50 [r8188eu]
[<ffffffff816938f1>] ioctl_standard_iw_point+0x151/0x3f0
[<ffffffff81693d52>] ioctl_standard_call+0xb2/0xe0
[<ffffffff81597df7>] ? rtnl_lock+0x17/0x20
[<ffffffff816945a0>] ? iw_handler_get_private+0x70/0x70
[<ffffffff81693ca0>] ? call_commit_handler+0x40/0x40
[<ffffffff81693256>] wireless_process_ioctl+0x176/0x1c0
[<ffffffff81693e79>] wext_handle_ioctl+0x69/0xc0
[<ffffffff8159fe79>] dev_ioctl+0x309/0x5e0
[<ffffffff810be9c7>] ? call_rcu+0x17/0x20
[<ffffffff8156a472>] sock_ioctl+0x142/0x2e0
[<ffffffff811e0c70>] do_vfs_ioctl+0x300/0x520
[<ffffffff81101514>] ? __audit_syscall_entry+0xb4/0x110
[<ffffffff81101514>] ? __audit_syscall_entry+0xb4/0x110
[<ffffffff810102bc>] ? do_audit_syscall_entry+0x6c/0x70
[<ffffffff811e0f11>] SyS_ioctl+0x81/0xa0
[<ffffffff816ba1d2>] system_call_fastpath+0x12/0x17

Additional routines that generate this BUG are rtw_joinbss_cmd(),
rtw_dynamic_chk_wk_cmd(), rtw_lps_ctrl_wk_cmd(), rtw_rpt_timer_cfg_cmd(),
rtw_ps_cmd(), report_survey_event(), report_join_res(), survey_timer_hdl(),
and rtw_check_bcn_info().

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Cc: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
16e614e85025d69c87e9ce80b9e1b5238f0f4479 20-Sep-2014 Gulsah Kose <gulsah.1004@gmail.com> staging: rtl8188eu: core: Fixed wrong space error.

This patch fixes "foo * bar" should be "foo *bar" checkpatch.pl error in rtw_cmd.c

Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
708a7ec873d38f6ebd938b623d349b747152c052 03-Sep-2014 Luca Ceresoli <luca@lucaceresoli.net> staging: rtl8188eu: fix missing blank lines after declarations

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Greg Kroah-Hartman <gregkh@linux.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
45c2fc821d7c0b0b5e69ab6c9417b587f5b1bd50 25-Jul-2014 Jeff Oczek <jeffoczek@gmail.com> staging: rtl8188eu: Fix static symbol sparse warnings

Fix sparse warnings:
drivers/staging/rtl8188eu/core/rtw_cmd.c:52:5: warning:
symbol '_rtw_enqueue_cmd' was not declared. Should it be static?
drivers/staging/rtl8188eu/core/rtw_wlan_util.c:1225:5: warning:
symbol 'wifirate2_ratetbl_inx' was not declared. Should it be static?
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c:25:4: warning:
symbol 'ODM_GetRightChnlPlaceforIQK' was not declared. Should it be static?
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3109:5: warning:
symbol 'rtw_ioctl' was not declared. Should it be static?

Signed-off-by: Jeff Oczek <jeffoczek@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
4dfeb7beb371a211d3d5eeac436cecfec7c71043 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove dummy function rtw_free_cmd_priv()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
faf427665d1e693f030d314b624b10f5724018ad 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove cmd_seq from struct cmd_priv

Value stored in cmd_seq isn't used by driver.

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1aef69ecacdaed16865d92dc702b4125a14cc95a 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove function rtw_setdatarate_cmd()

rtw_setdatarate_cmd() enqueue _SetDataRate command but there is not
handler mapped in wlancmds[] to handle this command.

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
88263a066adb5aec9515be90d21e081ceeab28f5 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove function rtw_getbbrfreg_cmdrsp_callback()

rtw_getbbrfreg_cmdrsp_callback() is a callback for _Read_BBREG and _Read_RFREG
commands but these commands are never issued by driver.

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
caeadfb0219e5fb6d4a1ee8ce5b61301560a014b 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove members cmd_[allocated,]_buf from struct cmd_priv

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ce7780eda02f3febfbfc8ba5558d3b7cd774452e 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove unused members rsp_[allocated, ]_buf from struct cmd_priv

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
4b55f02b4a96d761c57e9a6b1959f2b254f7ef8f 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove unused member cmd_done_cnt from struct cmd_priv

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8edacacfc2e7275b75e5841acbf4bc3126818ba9 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove unused member cmd_issued_cnt from struct cmd_priv

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
e6f33afca7392ad2d574a89c27450f98bae47aa8 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove unused member rsp_cnt from struct cmd_priv

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
4680f1589d43be642ec8985309ce26414a44d0e9 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Rename _rtw_dequeue_cmd() to rtw_dequeue_cmd()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11431bdb5769afc8bc57e63d81966796dd5e6056 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Rename _rtw_free_cmd_priv() to rtw_free_cmd_priv()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
b6d423025a962bf0013a47bf1bd190609a991c95 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Rename _rtw_init_cmd_priv() to rtw_init_cmd_priv()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
4690d2da85ad893cf346230efc21203744a194cd 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove wrapper function power_saving_wk_hdl()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
a117c12475e102d02b6af84be68eb66cd7ac9526 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove header file cmd_osdep.h

cmd_osdep.h is not required.

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
4ef0fa7500de04916611cf9059f355c2b886c992 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove unused function rtw_cmd_clr_isr()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
a4112c77d034a68b5bb9263e967d86b3e3ed65c2 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove unused function rtw_createbss_cmd_ex()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
968675d880f7ac05725e015bab332328bb014364 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove unused function rtw_setstandby_cmd()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1469534c0d2105ec67fcd4ca9d46616843537fb8 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove unused function rtw_setassocsta_cmd()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
444881028c4831961f4c9b8c19cbc5f4fb8767e2 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove dummy function rtw_tdls_cmd()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6c7e40ea16f6e75f01ce2f8db81a76fb80580cb4 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove unused function rtw_set_csa_cmd()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
81ee7567464acd94d05a5830686d11d41eaed389 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove unused function rtw_set_ch_cmd()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
faf3c4bf2fd8a55eb8296998235314b5a1d66d69 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove unused function rtw_setrttbl_cmd()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
844c1308089212262d7ef83df476d3963fb34ad5 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove unused function rtw_[set, get]rfreg_cmd()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
0bf14722c0042d30f6d22040ce925ba276c393eb 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove unused function rtw_getbbreg_cmd()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
298c7d35e83bc1ac07903950e34cc2a22a769b7a 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove unused function rtw_setbbreg_cmd()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
c87166299fd00e85c14c6dee1a4df40a4500d656 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove unused function rtw_setphy_cmd()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2f3c7d5362fb54876a274bcdf9d91d3d02caa4bd 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove unused function rtw_setbasicrate_cmd()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
0b96f324c089c4a2db25423bc2161170ea16c47f 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove unused function rtw_c2h_wk_cmd()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7b71cf432089e91232e2dbda4437b1accd7a65cc 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove unused function rtw_getrttbl_cmd()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
b9f64e0c552b452388a6d8f6b61c08842d007c7e 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove function c2h_evt_hdl()

c2h_evt_hdl() calls a dummy function rtw_hal_c2h_handler() to handle events,
so no use of keeping it.

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
20334b5e72f77cb037a81a6b64ec202d7899fc20 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove struct evt_priv and its uses

c2h_wk (work_struct) is naver scheduled to handle events,
so no use of keeping event data.
And also function rtw_hal_c2h_handler() responsible for handling c2h events,
is a dummy function.

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2454e79ac22da26c5ef42a0db0aef8d968d55d0f 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove P2P support

We've already removed non-standard ioctl handlers used by driver
to support P2P mode.

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
0cccd45f0ac066d11d5ae3e64afb7e70c621ffd1 10-Jul-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove mp( mesh point) mode support

We've already removed non-standard ioctl handlers, used by driver
to support mp mode.

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11306d1f20ca4ef8a0f383618423e0ee7979e94a 08-Jul-2014 Dan Carpenter <dan.carpenter@oracle.com> staging: rtl8188eu: use GFP_ATOMIC under spinlock

We're holding a spinlock here so we can't do sleeping allocations.
The call tree is:
rtw_sta_flush() <-- takes spin_lock_bh(&pstapriv->asoc_list_lock);
--> ap_free_sta()
--> rtw_clearstakey_cmd()

Originally these calls were rtw_zmalloc() and then we switched them to
kzalloc() in fadbe0cd5292 ('staging: rtl8188eu:Remove rtw_zmalloc(),
wrapper for kzalloc()') and that made the bugs show up for my static
checker. The original code was buggy as well but my static checker
couldn't parse it.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5aa8b9aeb8f6763299ee0b700ab7ab5f06044409 22-Jun-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Replace _cancel_timer() with del_timer_sync()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7062775b2c360a50b4c878efb49c6041f56463fc 22-Jun-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove function flush_signals_thread()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6e5ca0daa28b5cd022ce05a0d8a437e177b73042 22-Jun-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove function thread_enter()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
eab5d5438a626b33d1ea6d3ce07303bee0f27f76 22-Jun-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Use round_up() instead of _RND4()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
dee7c7f8f0d58ef1740a960bbf966cbd1a43e5fa 22-Jun-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Replace _cancel_workitem_sync() with cancel_work_sync()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8d5bdece42d9cb0daf7d0ab1cd7b263adb365f7a 22-Jun-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Replace rtw_list_delete() with list_del_init()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fadbe0cd5292851608e2e01b91d9295fa287b9fe 22-Jun-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu:Remove rtw_zmalloc(), wrapper for kzalloc()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
aa3f5ccb010a1496b616a27a81e8ee1722f25a72 22-Jun-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove _rtw_init_listhead(), wrapper for INIT_LIST_HEAD()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9c4b0e70af4850f6209440b1e8e4f1bd39dc0aae 22-Jun-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove rtw_is_list_empty(), wrapper for list_emty()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ae6787ad4ae8871b5bd7ede35aea86249e0fc2f3 22-Jun-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove rtw_list_insert_tail(), wrapper for list_add_tail()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1ce39848e17c34d494e46d50ec3cfa249b0342a7 22-Jun-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove function _rtw_memset()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2b3cffc9314d1c3e60a0ebccc366df1ada6e524e 16-Jun-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove file rtw_br_ext.h

driver doesn't need rtw_br_ext.h any more.

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
dc69f11cf1daecd6b602b6c49001207bef459ce4 16-Jun-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove function nat25_db_cleanup()

We've removed the code which was responsible for building NAT table,
so no use of keeping nat_db_cleanup().

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
0d9c69b747f99e544d747a1c87d24d4591183d9f 29-May-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove function rtw_hal_sreset_xmit_status_check()

rtw_hal_sreset_xmit_status_check() is a wrapper to call
rtl8188e_sreset_xmit_status_check(), which calls
rtl8188e_silentreset_for_specific_platform() in case of transmission has
stopped to do a silent reset and restore the transmission but
rtl8188e_silentreset_for_specific_platform() has empty defination,
so we can remove rtw_hal_sreset_xmit_status_check() because it doesn't
serve its purpose.

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
105dec7db1836e1f6f6c15fd62290176f71aa506 20-Apr-2014 navin patidar <navin.patidar@gmail.com> staging: rtl8188eu: Remove rtw_led_blink_cmd() function.

rtw_led_blink_cmd() isn't being used by driver.

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
792f32ac6495e168521182ab96d7816c927b7413 18-Mar-2014 Chi Pham <fempsci@gmail.com> staging: rtl8188eu: Reduced nesting and improved coding style.

Signed-off-by: Chi Pham <fempsci@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fb0a1bb293885075f2cd4e2fefd9e04519782900 09-Mar-2014 Chi Pham <fempsci@gmail.com> staging:rtl8188eu: Removed assignments in if statements.

Fixed some indentation to silence (some) checkpatch errors.
The following coccinelle script found the match:

@@
expression E0, E1, E2;
statement S0, S1;
@@
- if ((E1 = E2) != E)
+ E1 = E2;
+ if (E1 != E)
S1 else S2

Signed-off-by: Chi Pham <fempsci@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
b6657bfb48983908cb70eb69a7898309e56f0134 09-Mar-2014 Elena Oat <oat.elena@gmail.com> Staging: rtl8188eu: Replace rtw_zmalloc with kzalloc.

This patch replaces rtw_zmalloc with kzalloc in function
rtw_setstandby_cmd. There are no locks, hence GFP_KERNEL flag is used.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ba5be646783a101fc1e9af81b9c804901e13d597 06-Mar-2014 Elena Oat <oat.elena@gmail.com> Staging: rtl8188eu: Fix warning of prefer ether_addr_copy.

This patch fixes the warning of "Prefer ether_addr_copy() over memcpy()
if the Ethernet addresses are __aligned(2)" in file rtw_cmd.c. Pahole
shows that the addresses are 2-byte aligned.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
dc29fcae7a1178e76e20c38a12823ab8fa58f67f 06-Mar-2014 Elena Oat <oat.elena@gmail.com> Staging: rtl8188eu: Fix warning of suspect code indent.

This patch fixes the warning of "suspect code indent for conditional
statements" in file rtw_cmd.c. I have removed the conditional statements
in two places altogether, as it didn't bring any value.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
719e897cf1f98a77bb48c45cd0b996c2f57afe48 06-Mar-2014 Elena Oat <oat.elena@gmail.com> Staging: rtl8188eu: Fix warning of space prohibited before semicolon.

This patch fixes the warning of "space prohibited before semicolon" in file rtw_cmd.c.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
440dacdf6c0c05fc63214db604210a9c7e85ab41 06-Mar-2014 Elena Oat <oat.elena@gmail.com> Staging: rtl8188eu: Fix warning of unnecessary parentheses.

This patch fixes the warning of "unnecessary parentheses" in file rtw_cmd.c.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
cc96a428914cdab9d08feffb034f0ed793d0fe0b 06-Mar-2014 Elena Oat <oat.elena@gmail.com> Staging: rtl8188eu: Fix warning of space before tabs.

This patch fixes the warning of "please, no space before tabs" in file
rtw_cmd.c. I have also removed couple of lines of code that was
commented and probably left from the previous version.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7c3000c3773cdb62400ccba3be09fe257255eb67 06-Mar-2014 Elena Oat <oat.elena@gmail.com> Staging: rtl8188eu: Fix warning of spaces at the start of a line.

This patch fixes the warning of "please, no spaces at the start of a
line" in file rtw_cmd.c.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8ee6421b6c82157ff25b98a4e8b0a5f6764edc0f 06-Mar-2014 Elena Oat <oat.elena@gmail.com> Staging: rtl8188eu: Fix warning braces {} are not necessary.

This patch fixes the warning of "braces {} are not necessary for single
statement blocks" in file rtw_cmd.c.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
73e183426f8f3c2a3e030bf63c2112f7a080ded8 03-Mar-2014 Elena Oat <oat.elena@gmail.com> Staging: rtl8188eu: Fix warning of kfree check is not required.

This patch fixes the warning produced by checkpatch in the file
rtw_cmd.c "kfree(NULL) is safe this check is probably not required". The
patch fixes it in two places for this file.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
138050a2d78a2bad6f24b6396f38fcc3b73b49c2 03-Mar-2014 Elena Oat <oat.elena@gmail.com> Staging: rtl8188eu: Fix warning of no space before tabs.

This patch fixes the warning of "Please, no space before tab" produced
by checkpatch.pl. The modified file: rtw_cmd.c.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
867892f372632ead9d367cc21e69edbd7e04a33e 03-Mar-2014 Elena Oat <oat.elena@gmail.com> Staging: rtl8188eu: Fix the warning of space before parenthesis.

This patch fixes the warning of "space prohibited between function name
and open parenthesis '('". The modified file: rtw_cmd.c. The patch also
removes some strange spaces that were generated probably by some editor.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1781709bc3b69ed759165f2f59edf6bb6e48bfd1 14-Feb-2014 Larry Finger <Larry.Finger@lwfinger.net> staging: r8188eu: Remove wrapper routine _init_workitem()

This is simply another name for INIT_WORK().

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
f578b5d33ee721461921c8e79e5f8b309b2e604d 09-Feb-2014 Larry Finger <Larry.Finger@lwfinger.net> staging: r8188eu: Remove _func_enter and _func_exit macros

These debugging macros are seldom used for debugging once the driver
is working. If routine tracing is needed, it can be added on an
individual basis.

In a few cases, removal of the exit macro left a bare label. In these
cases, a go to that label was replaced by a return.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
c44e5e39c3d168d094cfe91334fd9e826de7d51f 09-Feb-2014 Larry Finger <Larry.Finger@lwfinger.net> staging: r8188eu: Eliminate macro to get next list item

The driver contains a macro that gets the next item in a linked list.
Replace it with a simple copy of the pointer.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
bea8810043b9a66c46b8c76bfbb5c8572530788d 09-Feb-2014 Larry Finger <Larry.Finger@lwfinger.net> staging: r8188eu: Replace misspelled local container macro

This driver has its own implementation of a "container_of" macro. It
is replaced with the standard container_of version. Most of these
are a straight one-to-one replacement; however, a few of the instances
referred to the member of a union. Those were replaced with the
struct that is part of that union.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2ca4ab5324062e70393e9a37a8db1ea94d6e2f99 23-Dec-2013 Larry Finger <Larry.Finger@lwfinger.net> staging: r8188eu: Remove wrappers _rtw_free_sema, _rtw_up_sema, and _rtw_mutex_init

Any routines that are empty as a result of these changes are also removed.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
efbef10095bf4915a136c10d66ff96a60f2d0df8 23-Dec-2013 Larry Finger <Larry.Finger@lwfinger.net> staging: r8188eu: Replace wrapper around sema_init

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fac4ed8cfb19c6b6fd23ed4f5359e6d85d694814 23-Dec-2013 Larry Finger <Larry.Finger@lwfinger.net> staging: r8188eu: Replace wrapper around atomic_set()

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
0da46e6bb1ac0b311d0ef47e5f723f330e144d37 20-Dec-2013 Larry Finger <Larry.Finger@lwfinger.net> staging: r8188eu: Replace wrappers ODM_sleep_ms() and rtw_msleep_os() with a simple msleep

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
c01fb49636b65ceea513c00966c58b8bdb095c8f 20-Dec-2013 Larry Finger <Larry.Finger@lwfinger.net> staging: r8188eu: Replace rtw_get_current_time() with jiffies

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
03f4a957e6fd5046a93aefad8c78d8307c1371a4 20-Dec-2013 Larry Finger <Larry.Finger@lwfinger.net> staging: r8188eu: Remove calls to _rtw_spinlock_free

This wrapper does nothing on Linux. When calls to it were removed, a number of
routines became empty and could also be removed.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
597794f53ebc75bda795c171bd9d88f577bd7218 20-Dec-2013 Larry Finger <Larry.Finger@lwfinger.net> staging: r8188eu: Remove wrappers around spin_unlock_irqrestore

Again there are two - _exit_critical() and _exit_critical_ex().

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
f937886ba9f05e6736aaddabe1a1240d7796ca1f 20-Dec-2013 Larry Finger <Larry.Finger@lwfinger.net> staging: r8188eu: Remove wrappers for spin_lock_irqsave

There are two such wrappers - _enter_critical() and _enter_critical_ex().

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
e02bcf6126fa59914ca3705183444fdc867b984b 20-Dec-2013 Larry Finger <Larry.Finger@lwfinger.net> staging: r8188eu: Remove wrapper around spin_unlock_bh

With this change, a number of variables for storing flags are no longer used.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7057dcb3afa29499c40ae404a616122fdd196d1b 20-Dec-2013 Larry Finger <Larry.Finger@lwfinger.net> staging: r8188eu: Remove wrapper around spin_lock_bh

Some comment lines that mentioned spin_lock_bh() are also removed.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
dfa5e81e59d95ea3ec1a3fc227165715b5f6f406 20-Dec-2013 Larry Finger <Larry.Finger@lwfinger.net> staging: r8188eu: Remove pointless thread_exit macro

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7552d72a5c34a8d55037ce0c1a8cd8c3a7e86341 09-Oct-2013 Valentina Manea <valentina.manea.m@gmail.com> staging: r8188eu: Fix sparse warnings regarding static functions

This fixes the following sparse warnings:
* drivers/staging/rtl8188eu/core/rtw_cmd.c:221:5: warning:
symbol 'rtw_cmd_filter' was not declared. Should it be static?
* drivers/staging/rtl8188eu/core/rtw_cmd.c:1670:6: warning:
symbol 'dynamic_chk_wk_hdl' was not declared. Should it be static?

Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
08c64f932b04f62f48ca6c991c54264800e8e0b8 26-Sep-2013 Masanari Iida <standby24x7@gmail.com> staging: rtl8188eu: Fix typo in rtl8188eu/core

Correct spelling typo in rtl8188eu/core

Signed-off-by: Masanari Iida <standby24x7@gmail.com>

# Please enter the commit message for your changes. Lines starting
# with '#' will be kept; you may remove them yourself if you want to.
# An empty message aborts the commit.
# On branch rtl8188eu-typo2
# Changes to be committed:
# modified: drivers/staging/rtl8188eu/core/rtw_ap.c
# modified: drivers/staging/rtl8188eu/core/rtw_br_ext.c
# modified: drivers/staging/rtl8188eu/core/rtw_cmd.c
# modified: drivers/staging/rtl8188eu/core/rtw_efuse.c
# modified: drivers/staging/rtl8188eu/core/rtw_ieee80211.c
# modified: drivers/staging/rtl8188eu/core/rtw_mlme.c
# modified: drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
# modified: drivers/staging/rtl8188eu/core/rtw_security.c
#
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
955fae6fd7d77264a788441586515b75948c7985 29-Aug-2013 Dan Carpenter <dan.carpenter@oracle.com> staging: r8188eu: off by one bugs

These should be "<" instead of "<=". Also we can use the ARRAY_SIZE()
macro.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9a7fe54ddc3a70a25a773cb1e275cb7f7d2c6526 22-Aug-2013 Larry Finger <Larry.Finger@lwfinger.net> staging: r8188eu: Add source files for new driver - part 1

This commit adds core/rtw_ap.c, core/rtw_br_ext.c, and core/rtw_cmd.c

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>