| 45c2fc821d7c0b0b5e69ab6c9417b587f5b1bd50 |
|
25-Jul-2014 |
Jeff Oczek <jeffoczek@gmail.com> |
staging: rtl8188eu: Fix static symbol sparse warnings
Fix sparse warnings:
drivers/staging/rtl8188eu/core/rtw_cmd.c:52:5: warning:
symbol '_rtw_enqueue_cmd' was not declared. Should it be static?
drivers/staging/rtl8188eu/core/rtw_wlan_util.c:1225:5: warning:
symbol 'wifirate2_ratetbl_inx' was not declared. Should it be static?
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c:25:4: warning:
symbol 'ODM_GetRightChnlPlaceforIQK' was not declared. Should it be static?
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3109:5: warning:
symbol 'rtw_ioctl' was not declared. Should it be static?
Signed-off-by: Jeff Oczek <jeffoczek@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 1aef69ecacdaed16865d92dc702b4125a14cc95a |
|
10-Jul-2014 |
navin patidar <navin.patidar@gmail.com> |
staging: rtl8188eu: Remove function rtw_setdatarate_cmd()
rtw_setdatarate_cmd() enqueue _SetDataRate command but there is not
handler mapped in wlancmds[] to handle this command.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 2454e79ac22da26c5ef42a0db0aef8d968d55d0f |
|
10-Jul-2014 |
navin patidar <navin.patidar@gmail.com> |
staging: rtl8188eu: Remove P2P support
We've already removed non-standard ioctl handlers used by driver
to support P2P mode.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 0cccd45f0ac066d11d5ae3e64afb7e70c621ffd1 |
|
10-Jul-2014 |
navin patidar <navin.patidar@gmail.com> |
staging: rtl8188eu: Remove mp( mesh point) mode support
We've already removed non-standard ioctl handlers, used by driver
to support mp mode.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 6609ed9a3313f1d1ad66de4c265c25a35c175d2a |
|
10-Jul-2014 |
navin patidar <navin.patidar@gmail.com> |
staging: rtl8188eu: Remove files rtw_mp_ioctl.[c,h]
files are not required after removal of private ioctl handlers.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 42ec30efb4096f25017f13154b6ffff10d5e0b7d |
|
10-Jul-2014 |
navin patidar <navin.patidar@gmail.com> |
staging: rtl8188eu: Remove WEXT_PRIV private ioctl handlers
Remove WEXT_PRIV (non-standard) ioctl handlers.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 57373690dba28abf483cc62da0963e9e990f3657 |
|
10-Jul-2014 |
Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
staging: rtl8188eu: re-use hex_to_bin() instead of custom code
hex_to_bin could be used to convert hexdecimal digit to its binary
representation.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 529a929912ac9b23faa243ee624e2177f13e0774 |
|
10-Jul-2014 |
Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
staging: rtl8188eu: substitute custom hex2bin()
Instead of using custom code to convert hexdecinal strings to their binary
represantation let's use kernel's library function.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 79374daf9890d47a31da3eca765be50b916cad42 |
|
10-Jul-2014 |
Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
staging: rtl8188eu: re-use mac_pton() helper
The helper mac_pton() validates and converts MAC address from string format to
a number. Originally code uses simple code to do that. With mac_pton() the
driver now validates input as well.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| c495fc9eba67ca2c009fef7a02ae0da1aa17b9a7 |
|
22-Jun-2014 |
navin patidar <navin.patidar@gmail.com> |
staging: rtl8188eu: Replace _cancel_timer_ex() with del_timer_sync()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 8d5bdece42d9cb0daf7d0ab1cd7b263adb365f7a |
|
22-Jun-2014 |
navin patidar <navin.patidar@gmail.com> |
staging: rtl8188eu: Replace rtw_list_delete() with list_del_init()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| fadbe0cd5292851608e2e01b91d9295fa287b9fe |
|
22-Jun-2014 |
navin patidar <navin.patidar@gmail.com> |
staging: rtl8188eu:Remove rtw_zmalloc(), wrapper for kzalloc()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| a733e46751002208755c0cb40f5eda0e9c939ad2 |
|
22-Jun-2014 |
navin patidar <navin.patidar@gmail.com> |
staging: rtl8188eu: Use kstrtoul() for string to long conversion
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| aa3f5ccb010a1496b616a27a81e8ee1722f25a72 |
|
22-Jun-2014 |
navin patidar <navin.patidar@gmail.com> |
staging: rtl8188eu: Remove _rtw_init_listhead(), wrapper for INIT_LIST_HEAD()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 9c4b0e70af4850f6209440b1e8e4f1bd39dc0aae |
|
22-Jun-2014 |
navin patidar <navin.patidar@gmail.com> |
staging: rtl8188eu: Remove rtw_is_list_empty(), wrapper for list_emty()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 84660700807cbcd649c58ff8ce7f65021765b15c |
|
22-Jun-2014 |
navin patidar <navin.patidar@gmail.com> |
staging: rtl8188eu: Remove function rtw_end_of_queue_search()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 1ce39848e17c34d494e46d50ec3cfa249b0342a7 |
|
22-Jun-2014 |
navin patidar <navin.patidar@gmail.com> |
staging: rtl8188eu: Remove function _rtw_memset()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 17452ee9d3e3c20eb009423fc3dd02d67882e4bb |
|
21-Jun-2014 |
navin patidar <navin.patidar@gmail.com> |
staging: rtl8188eu: Merge usb_ops.h into usb_ops_linux.h
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 800072c67eac0967f1cf430ffa2aa6baf73eebae |
|
20-Jun-2014 |
navin patidar <navin.patidar@gmail.com> |
staging: rtl8188eu: Remove function rtw_BT_efuse_map_read()
rtl8188eu is not a wifi/bluetooth combo device, so remove bluetooth
related code.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 052deb5d1f6b706b8c50407656cda8a32cd7b784 |
|
20-Jun-2014 |
navin patidar <navin.patidar@gmail.com> |
staging: rtl8188eu: Remove function rtw_BT_efuse_map_write()
rtl8188eu is not a wifi/bluetooth combo device, so remove bluetooth
related code.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 9dec254a80f9839a4d765d0339c412a6ff62f616 |
|
20-Jun-2014 |
navin patidar <navin.patidar@gmail.com> |
staging: rtl8188eu: Rename rtl8188e_EFUSE_GetEfuseDefinition()
Rename rtl8188e_EFUSE_GetEfuseDefinition() to EFUSE_GetEfuseDefinition()
and remove original EFUSE_GetEfuseDefinition() function,
so that driver can call rtl8188e_EFUSE_GetEfuseDefinition() directly
without going through EFUSE_GetEfuseDefinition().
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| c7b2e995a1226a09a30ad0f9dd6e922f21b3dd28 |
|
11-Jun-2014 |
navin patidar <navin.patidar@gmail.com> |
staging: rtl8188eu: Remove function _rtw_read8()
_rtw_read8() is a wrapper function, being used to call usb_read8().
Call usb_read8() directly and drop _rtw_read8().
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 551a397227e34e9f895182946365f63fbd8e4b8d |
|
11-Jun-2014 |
navin patidar <navin.patidar@gmail.com> |
staging: rtl8188eu: Remove function _rtw_read16()
_rtw_read16() is a wrapper function, being used to call usb_read16().
Call usb_read16() directly and drop _rtw_read16().
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 99ecfb06f83ec7eaa9110fa887cef3f55d031bf4 |
|
11-Jun-2014 |
navin patidar <navin.patidar@gmail.com> |
staging: rtl8188eu: Remove function _rtw_read32()
_rtw_read32() is a wrapper function, being used to call usb_read32().
Call usb_read32() directly and drop _rtw_read32().
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| e76484d00c5147d2959e673faa858e7ace4567dd |
|
11-Jun-2014 |
navin patidar <navin.patidar@gmail.com> |
staging: rtl8188eu: Remove function _rtw_write8()
_rtw_write8() is a wrapper function, being used to call usb_write8().
Call usb_write8() directly and drop _rtw_write8().
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 9764ed0405eab479d227a6bef7955876f667266a |
|
11-Jun-2014 |
navin patidar <navin.patidar@gmail.com> |
staging: rtl8188eu: Remove function _rtw_write16()
_rtw_write16() is a wrapper function, being used to call usb_write16().
Call usb_write16() directly and drop _rtw_write16().
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| fc1580795654c2011ee4c886a71900c1f3ce1365 |
|
11-Jun-2014 |
navin patidar <navin.patidar@gmail.com> |
staging: rtl8188eu: Remove function _rtw_write32()
_rtw_write32() is a wrapper function, being used to call usb_write32().
Call usb_write32() directly and drop _rtw_write32().
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| fdc953747445bb44ab360f0ec2b42733c4ea8538 |
|
01-Jun-2014 |
navin patidar <navin.patidar@gmail.com> |
staging: rtl8188eu: Remove header file rtw_version.h
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| b9e91a578bcfbcccfd8ce3962315c67bd894df1b |
|
29-May-2014 |
navin patidar <navin.patidar@gmail.com> |
staging: rtl8188eu: Remove function rtw_hal_sreset_reset()
rtw_hal_sreset_reset() is a wrapper to call
rtl8188e_silentreset_for_specific_platform(), which has empty defination.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| e0e2c5cde57d4b0c3af2998c3a591f3db75ce7eb |
|
07-May-2014 |
Christian Engelmayer <cengelma@gmx.at> |
staging: rtl8188eu: fix potential leak in rtw_mp_pwrtrk()
Function rtw_mp_pwrtrk() dynamically allocates a temporary buffer that
is not freed in all error paths. Use a centralized exit path and make sure
that all memory is freed correctly. Detected by Coverity - 1077715.
Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| c98acd000bc578f4a53c4879760d2d1ccdc794a9 |
|
07-May-2014 |
Christian Engelmayer <cengelma@gmx.at> |
staging: rtl8188eu: fix potential leak in rtw_mp_SetRFPath()
Function rtw_mp_SetRFPath() dynamically allocates a temporary buffer that
is not freed in all error paths. Use a centralized exit path and make sure
that all memory is freed correctly. Detected by Coverity - CID 1077714.
Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 3dad0d1e40285fb8a5c6b878c5ac5eb556f9dd9e |
|
07-May-2014 |
Christian Engelmayer <cengelma@gmx.at> |
staging: rtl8188eu: fix potential leak in rtw_mp_QueryDrv()
Function rtw_mp_QueryDrv() dynamically allocates a temporary buffer that
is not freed in all error paths. Use a centralized exit path and make sure
that all memory is freed correctly. Detected by Coverity - CID 1077713.
Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 5d57f1e8f6699653f2e5b7c9dfad6b0dd0c8dcd3 |
|
07-May-2014 |
Christian Engelmayer <cengelma@gmx.at> |
staging: rtl8188eu: fix potential leak in rtw_wx_set_enc_ext()
Function rtw_wx_set_enc_ext() dynamically allocates a temporary buffer that
is not freed in all error paths. Use a centralized exit path and make sure
that all memory is freed correctly. Detected by Coverity - CID 1077712.
Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| d6a6c916189e4ef0512a1620afc3c88a114e825d |
|
07-May-2014 |
Christian Engelmayer <cengelma@gmx.at> |
staging: rtl8188eu: fix potential leak in rtw_wx_read32()
Function rtw_wx_read32() dynamically allocates a temporary buffer that is not
freed in all error paths. Use a centralized exit path and make sure that all
memory is freed correctly. Detected by Coverity - CID 1077711.
Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| ec03ab77cc2c39d115118fcd4fc11a5801cbb70e |
|
25-Mar-2014 |
Wilfried Klaebe <w-lkml@lebenslange-mailadresse.de> |
staging: rtl8188eu: remove spaces, correct counts to unbreak P2P ioctls
staging: rtl8188eu: remove spaces, correct counts to unbreak P2P ioctls
It looks like someone did a search-and-replace on that driver, putting
spaces before "=" characters, without checking this is OK everywhere.
Also, in some places, there's memcpm()s/strncmp()s checking for some
different length than the fixed string argument.
These things result in code not working as intended. Fix that.
Signed-off-by: Wilfried Klaebe <w-lkml@lebenslange-mailadresse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 160eaf20a8de747c32881b52f08eeb4394f8d9a6 |
|
11-Mar-2014 |
Elena Oat <oat.elena@gmail.com> |
Staging: rtl8188eu: Fix sparse warnings.
This patch fixes following warnings produced by sparse:
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3867:31: expected void
const *<noident>
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3867:31: got void
[noderef] <asn:1>*pointer
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3869:38: warning:
incorrect type in argument 1 (different address spaces)
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3869:38: expected void
const *<noident>
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3869:38: got void
[noderef] <asn:1>*pointer
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3871:38: warning:
incorrect type in argument 1 (different address spaces)
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3871:38: expected void
const *<noident>
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3871:38: got void
[noderef] <asn:1>*pointer
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3873:38: warning:
incorrect type in argument 1 (different address spaces)
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3873:38: expected void
const *<noident>
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3873:38: got void
[noderef] <asn:1>*pointer
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3875:38: warning:
incorrect type in argument 1 (different address spaces)
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3875:38: expected void
const *<noident>
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3875:38: got void
[noderef] <asn:1>*pointer
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3878:38: warning:
incorrect type in argument 1 (different address spaces)
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3878:38: expected void
const *<noident>
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3878:38: got void
[noderef] <asn:1>*pointer
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3880:38: warning:
incorrect type in argument 1 (different address spaces)
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3880:38: expected void
const *<noident>
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3880:38: got void
[noderef] <asn:1>*pointer
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3883:38: warning:
incorrect type in argument 1 (different address spaces)
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3883:38: expected void const *<noident>
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3883:38: got void
[noderef] <asn:1>*pointer
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3897:9: warning: cast
removes address space of expression
While at it, I have also fixed the warnings of lines over 80 characters.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
|
| 2a8efee2c77986c455d0b46168cacd409fd1de76 |
|
11-Mar-2014 |
Elena Oat <oat.elena@gmail.com> |
Staging: rtl8188eu: Fix warning of unchecked sscanf return value.
This patch fixes the warnings produced by checkpatch "unchecked sscanf
return value" in file ioctl_linux.c.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
|
| cf867c3930b9b685364ec4fda20ff8a5a1e06ad6 |
|
12-Feb-2014 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: r8188eu: Fix more Smatch warnings and errors
After updating Smatch, the following new errors and warnings are reported:
drivers/staging/rtl8188eu/core/rtw_recv.c:368 recvframe_chkmic() warn: variable dereferenced before check 'psecuritypriv' (see line 364)
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:2642 rtw_wps_start() warn: variable dereferenced before check 'pdata' (see line 2636)
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:4461 rtw_dbg_port() error: we previously assumed 'pregpriv' could be null (see line 4453)
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:4473 rtw_dbg_port() error: we previously assumed 'pregpriv' could be null (see line 4469)
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| f578b5d33ee721461921c8e79e5f8b309b2e604d |
|
09-Feb-2014 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: r8188eu: Remove _func_enter and _func_exit macros
These debugging macros are seldom used for debugging once the driver
is working. If routine tracing is needed, it can be added on an
individual basis.
In a few cases, removal of the exit macro left a bare label. In these
cases, a go to that label was replaced by a return.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| c44e5e39c3d168d094cfe91334fd9e826de7d51f |
|
09-Feb-2014 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: r8188eu: Eliminate macro to get next list item
The driver contains a macro that gets the next item in a linked list.
Replace it with a simple copy of the pointer.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| bea8810043b9a66c46b8c76bfbb5c8572530788d |
|
09-Feb-2014 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: r8188eu: Replace misspelled local container macro
This driver has its own implementation of a "container_of" macro. It
is replaced with the standard container_of version. Most of these
are a straight one-to-one replacement; however, a few of the instances
referred to the member of a union. Those were replaced with the
struct that is part of that union.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| d249db9e5a82ed9ee49b6b7afb04878ba1fde5ea |
|
08-Feb-2014 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: r8188eu: Fix missing header
Commit 2397c6e0927675d983b34a03401affdb64818d07 entitled "staging: r8188eu:
Remove wrappers around vmalloc and vzalloc" and
commit: 03bd6aea7ba610a1a19f840c373624b8b0adde0d entitled "staging: r8188eu:
Remove wrappers around vfree" failed to add the header file needed
to provide vzalloc and vfree.
This problem was reported by the kbuild test robot.
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| e6ff3f4e6d258021fe041d7acf5d013c26bf387b |
|
03-Feb-2014 |
Dan Carpenter <dan.carpenter@oracle.com> |
staging: r8188eu: overflow in rtw_p2p_get_go_device_address()
The go_devadd_str[] array is two characters too small to hold the
address so we corrupt memory.
I've changed the user space API slightly and I don't have a way to test
if this breaks anything. In the original code we truncated away the
last digit of the address and the NUL terminator so it was already a bit
broken.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 893134b084e137b92476ec11ce90790b5f568bb9 |
|
03-Feb-2014 |
Dan Carpenter <dan.carpenter@oracle.com> |
staging: r8188eu: array overflow in rtw_mp_ioctl_hdl()
MAX_MP_IOCTL_SUBCODE (35) and mp_ioctl_hdl (32 elements) are no longer
in sync. It leads to a bogus pointer dereference.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 03bd6aea7ba610a1a19f840c373624b8b0adde0d |
|
07-Feb-2014 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: r8188eu: Remove wrappers around vfree
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 2397c6e0927675d983b34a03401affdb64818d07 |
|
07-Feb-2014 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: r8188eu: Remove wrappers around vmalloc and vzalloc
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 17d41165956423ecf022a2b2db050ae313543b9b |
|
20-Dec-2013 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: r8188eu: Fix unused variable warnings
A previous set of patches were test compiled with one of the configuration
variables not set. As a result, a number of unused variables were left in the
code.
In several instances, declaration of the unused variable was the only statement
inside ifdef .. endif pairs. In those cases, the entire block was removed.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 0da46e6bb1ac0b311d0ef47e5f723f330e144d37 |
|
20-Dec-2013 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: r8188eu: Replace wrappers ODM_sleep_ms() and rtw_msleep_os() with a simple msleep
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| e02bcf6126fa59914ca3705183444fdc867b984b |
|
20-Dec-2013 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: r8188eu: Remove wrapper around spin_unlock_bh
With this change, a number of variables for storing flags are no longer used.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 7057dcb3afa29499c40ae404a616122fdd196d1b |
|
20-Dec-2013 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: r8188eu: Remove wrapper around spin_lock_bh
Some comment lines that mentioned spin_lock_bh() are also removed.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 1f9d82d29345b0bf6a4ce4eec13e63236b739272 |
|
07-Nov-2013 |
Teodora Baluta <teobaluta@gmail.com> |
staging: rtl8188eu: correct code alignment
This patch fixes incorrect code alignment due to mixed indenting with
spaces and tabs. This patch was detected using coccinelle and
silences the following warnings:
drivers/staging/rtl8188eu/core/rtw_io.c:297:2-29: code aligned with following code on line 299
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4420:2-29: code aligned with following code on line 4422
drivers/staging/rtl8188eu/os_dep/osdep_service.c:54:2-17: code aligned with following code on line 55
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:7229:2-17: code aligned with following code on line 7231
Signed-off-by: Teodora Baluta <teobaluta@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 7efc02ca94c350fe6f77203fd87394e9dc2874d9 |
|
26-Sep-2013 |
Masanari Iida <standby24x7@gmail.com> |
staging: rtl8188eu: Fix typo in rtl8188eu/os_dep
Correct spelling typo in rtl8188eu/os_dep
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 5a2d8292f1051c1d1c08fc1732c74ac12ef61452 |
|
19-Sep-2013 |
Thomas Meyer <thomas@m3y3r.de> |
staging: r8188eu: Cocci spatch "noderef"
sizeof when applied to a pointer typed expression gives the size of the
pointer.
Found by coccinelle spatch "misc/noderef.cocci"
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 22fd8b772c93df1073decd1dcb7477c87481ee54 |
|
04-Sep-2013 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: r8188eu: Fix smatch warning in os_dep/ioctl_linux.c
Smatch reports the following:
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:4891 set_group_key() warn: missing break? reassigning 'keylen'
As it suggests, there is a missing break statement.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| dc14a626e423f6adc193a677423c259f93a74e57 |
|
04-Sep-2013 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: r8188eu: Fix smatch warnings in os_dep/ioctl_linux.c
Smatch reports the following:
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:941 rtw_wx_set_pmkid() warn: add some parenthesis here?
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:1042 rtw_wx_get_range() warn: assigning (-78) to unsigned variable 'range->avg_qual.level'
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:2629 rtw_get_ap_info() warn: add some parenthesis here?
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:4043 rtw_rereg_nd_name() warn: add some parenthesis here?
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:4052 rtw_rereg_nd_name() warn: add some parenthesis here?
The warnings calling for adding parentheses all have "if (!memcmp() == true)" and
are fixed by removing the "==true" part.
The warning where a negative number is stored in an unsigned variable is fixed
by biasing the result by 256.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 6554f313d105097aca9ce3d0b6df96d426226e2c |
|
28-Aug-2013 |
Sachin Kamat <sachin.kamat@linaro.org> |
staging: rtl8188eu: Remove duplicate header inclusion in ioctl_linux.c
Removed the header files included twice.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| d33b128ea9076b32804af62dda433bc71512c01f |
|
25-Aug-2013 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: r8188eu: Fix build errors for allyesconfig
This driver has some global names that are the same as found in
driver r8712. Fix the allyesconfig build errors by changing the
names of those routines.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| a2c60d42d97cdbeee3c7371cd3502fca77f07d39 |
|
22-Aug-2013 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: r8188eu: Add files for new driver - part 16
This commit adds files os_dep/ioctl_linux.c, os_dep/mlme_linux.c, and
os_dep/osdep_service.c.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|