| 95c0bab252b69c5aff447712c833fd897d952388 |
|
28-Sep-2014 |
Georgiana Chelu <georgiana.chelu93@gmail.com> |
staging: rtl8192u: Add blank line after variable declarations
Fix the following checkpatch.pl warning:
WARNING: Missing a blank line after declarations
Signed-off-by: Georgiana Chelu <georgiana.chelu93@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| c4d6b8fbea3895973eb6153c27cb2bc015a17fdd |
|
11-Aug-2014 |
Ovidiu Toader <ovi@phas.ubc.ca> |
drivers/staging/rtl8192u/r8192U_wx.c: fix warnings issued by sparse
This minor patch motivated by eudyptula challenge fixes the following warnings issued
by `sparse' in drivers/staging/rtl8192u/r8192U_wx.c:
.../r8192U_wx.c:27:5: warning: symbol 'rtl8180_rates' was not declared. Should it be static?
.../r8192U_wx.c:961:22: warning: symbol 'r8192_get_wireless_stats' was not declared. Should it be static?
.../r8192U_wx.c:990:24: warning: symbol 'r8192_wx_handlers_def' was not declared. Should it be static?
Signed-off-by: Ovidiu Toader <ovi@phas.ubc.ca>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| a2581a4a65d4263238c995c436debfffa2477a96 |
|
20-Jun-2014 |
Chaitanya Hazarey <c@24.io> |
Staging: rtl8192u: r8192U_wx.c Fixed a code-style error about trailing whitespace
Fixed the following error reported by running checkpatch.pl
ERROR: trailing whitespace
Signed-off-by: Chaitanya Hazarey <c@24.io>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 0b5b4e223a4de2a006bf58fc5303cfa75484374e |
|
20-Jun-2014 |
Chaitanya Hazarey <c@24.io> |
Staging: rtl8192u: r8192U_wx.c Fixed some more code-style warnings about spaces
Fixed the following warnings issued by checkpatch.pl
WARNING: please, no space before tabs
Signed-off-by: Chaitanya Hazarey <c@24.io>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| a08d541a26e99aff2dba8788aac948479a0cd102 |
|
20-Jun-2014 |
Chaitanya Hazarey <c@24.io> |
Staging: rtl8192u: r8192U_wx.c Fixed code-style warnings
Fixed some of the following warning generated by checkpatch.pl:
WARNING: Missing a blank line after declarations
Signed-off-by: Chaitanya Hazarey <c@24.io>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 69eb976bd980c8fe5463cfbc21d57fd7de7c0ad1 |
|
02-Jun-2014 |
Chaitanya Hazarey <c@24.io> |
Staging: rtl8192u: r8192U_wx.c Removed some more commented out dead code
Removed dead code from the file.
Signed-off-by: Chaitanya Hazarey <c@24.io>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 31c207f4afac85d1dabfb0bc98b21f2db4825ccb |
|
29-May-2014 |
Chaitanya Hazarey <c@24.io> |
Staging: rtl8192u: r8192U_wx.c Added a single space for code-style issue
Added a space around '|' to address:
ERROR: need consistent spacing around '|' (ctx:VxW)
Signed-off-by: Chaitanya Hazarey <c@24.io>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 0bb927cf40544ee8c84e3e7c7fc6e0e1497fdafd |
|
29-May-2014 |
Chaitanya Hazarey <c@24.io> |
Staging: rtl8192u: r8192U_wx.c Removed all C99 comments
To address the error -
ERROR: do not use C99 // comments
Removed all C99 comments.
Signed-off-by: Chaitanya Hazarey <c@24.io>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 2808a02332b8249324a78565421abf1059b4be9d |
|
29-May-2014 |
Chaitanya Hazarey <c@24.io> |
Staging: rtl8192u: r8192U_wx.c removed commented dead code
Removed dead code, commented out printks and DMESG.
Signed-off-by: Chaitanya Hazarey <c@24.io>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| e00b8fdca8c04eb39bd2ff8a68c7154135e4e179 |
|
29-May-2014 |
Chaitanya Hazarey <c@24.io> |
Staging: rtl8192u: r8192U_wx.c Fixed a misplaced brace
Fixed a misplaced brace in a function
Signed-off-by: Chaitanya Hazarey <c@24.io>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 28cda5ae0917a31d2e0436fe91901bc82f8e2492 |
|
28-May-2014 |
Chaitanya Hazarey <c@24.io> |
Staging: rtl8192u: r8192U_wx.c Added {} braces and newlines
Added {} braces and newlines to address the following:
ERROR: else should follow close brace '}'
ERROR: space required before the open brace '{'
ERROR: trailing statements should be on next line
ERROR: space required before the open parenthesis '('
ERROR: that open brace { should be on the previous line
Signed-off-by: Chaitanya Hazarey <c@24.io>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 654d1ce9189c60294f62cde55a231898639683f3 |
|
28-May-2014 |
Chaitanya Hazarey <c@24.io> |
Staging: rtl8192u: r8192U_wx.c Added missing spaces
Added spaces needed in the proper places to address:
WARNING: please, no spaces at the start of a line
WARNING: missing space after struct definition
ERROR: spaces required around that '!=' (ctx:WxV)
ERROR: spaces required around that '=' (ctx:WxV)
ERROR: spaces required around that '=' (ctx:VxW)
ERROR: spaces required around that '&&' (ctx:VxV)
ERROR: spaces required around that '!=' (ctx:VxV)
ERROR: spaces required around that '=' (ctx:VxV)
ERROR: spaces required around that '==' (ctx:VxV)
ERROR: spaces required around that '<' (ctx:VxV)
ERROR: space required before the open parenthesis '('
ERROR: space required before the open brace '{'
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required after that close brace '}'
ERROR: space prohibited before that '--' (ctx:WxO)
ERROR: space prohibited before that close parenthesis ')'
ERROR: space prohibited after that open parenthesis '('
Signed-off-by: Chaitanya Hazarey <c@24.io>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| f8628a47ba502ec2ec795dc0134f052f45ce2cd4 |
|
24-May-2014 |
Joe Perches <joe@perches.com> |
staging: Convert __FUNCTION__ to __func__
Use the normal mechanism for emitting a function name.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| e6c1ef6ce9dadadd1961578487f9c76fa134b020 |
|
23-May-2014 |
Joel Pelaez Jorge <joelpelaez@gmail.com> |
Staging: rtl8192u: Remove old WIRELESS_EXT support
Remove support for building against ancient WIRELESS_EXT versions,
only leaving support for the current version: 22
Signed-off-by: Joel Pelaez Jorge <joelpelaez@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 2930d0b977e6b9f66e8f090c685a18991944fca6 |
|
28-Apr-2014 |
Rui Miguel Silva <rmfrfs@gmail.com> |
staging: rtl8192u: fix checkpatch braces warning
fix some code style related to the use of braces in a one statement block
Signed-off-by: Rui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| aa0cb59cfa781d5cb44dd981153d67168d34f91b |
|
10-Oct-2013 |
Xenia Ragiadakou <burzalodowa@gmail.com> |
staging: rtl8192u: remove #ifdef JOHN_
This patch removes the guards #ifdef JOHN_HWSEC, #ifdef JOHN_DUMP_TXDESC and
because the code inside them calls some undefined functions (e.g read_rtl8225,
rtl8187_read_phy etc).
Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 559a4c318ca303880fc9f26d50711791c16ae2f3 |
|
26-Aug-2013 |
Andrea Merello <andrea.merello@gmail.com> |
staging: Update e-mail address for Andrea Merello
A lot of files contain reference to my old e-mail address.
Now I'm going not to read mail from it anymore, so update it
with my current address everywhere.
Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 93ba2a856f75aead35a043f169a49ce398afe737 |
|
26-Aug-2013 |
Andrea Merello <andrea.merello@gmail.com> |
Update e-mail address for Andrea Merello (resubmit)
A lot of files contain reference to my old e-mail address.
Now I'm going not to read mail from it anymore, so update it
with my current address everywhere.
Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
|
| b3d42bf18784607b90b0661ac43f410713ff428b |
|
06-Jun-2013 |
Xenia Ragiadakou <burzalodowa@gmail.com> |
staging: rtl8192u: fix read_nic_* functions
read_nic_*() functions are defined in r8192U_core.c.
They call internally usb_control_msg() to read the
nic registers and return the value read.
Following a remark made by Dan Carpenter, if usb_control_msg()
fails, the value returned will be invalid.
To accommodate for this, this patch changes the functions
to take a pointer as argument to set the value read and
return 0 on success and the error status on failure, so
that callers of read_nic_*() can check the return status.
Some other fixes introduced in read_nic_*() functions are:
The expressions (1<<EPROM_*_SHIFT) used to address and set
the individual bits of the eeprom register were replaced
with EPROM_*_BIT bitmasks to make the code more intuitive.
EPROM_*_BIT bitmasks were defined in r8192U_hw.h and
EPROM_*_SHIFT were removed.
In netdev_err(), which is called in case of failure,
the hardcoded function name in the error log message was
replaced with __func__ to reduce line size.
Also, from the error log message, it was omitted the word
"Timeout" and it is just reported the error code since the
failure can not only be due to timeout expiration but also
due to a memory allocation failure. In case of timeout
expiration, usb_start_wait_urb() prints an appropriate log
message when debug is enabled.
Finally, some minor fixes to the coding style were applied in
lines affected by the above changes, including the removal
of ifdef DEBUG_RX (the debugging of reads and writes of the
nic registers shall be done with explicit check on their
return status which will be added in a follow on patch).
Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| ad6384591f449026d93b136a6b5cb8b8bce6c743 |
|
12-May-2013 |
Xenia Ragiadakou <burzalodowa@gmail.com> |
STAGING: rtl8192u: fix checkpatch error by adding space after switch
This patch fixes the following checkpatch error:
ERROR: space required before the open parenthesis '('
Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| b81c2b0a3317f64f9531246014e4da18e0bccadc |
|
11-May-2013 |
Xenia Ragiadakou <burzalodowa@gmail.com> |
STAGING: rtl8192u: fix checkpatch error about pointer position in r8192U_wx.c
This patch fixes the pointer position in r8192U_wx.c
to meet the kernel coding style conventions.
Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 24fbe875256acf71ab13e869afddbc3a75d7dfbc |
|
05-Dec-2012 |
Sebastian Hahn <snsehahn@cip.cs.fau.de> |
staging/rtl8192u: use same indent for switch and case
Fix the checkpatch error "switch and case should be at the same indent"
Signed-off-by: Sebastian Hahn <snsehahn@cip.cs.fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 0db7a34e6c8e902c6fc58c2116278dd8e88fefb7 |
|
05-Dec-2012 |
Jennifer Naumann <Jennifer.Naumann@informatik.stud.uni-erlangen.de> |
staging/rtl8192u: put { on same line as struct
This fixes the checkpatch error "open brace '{' following struct go on the
same line" in staging/rtl8192u
Signed-off-by: Jennifer Naumann <Jennifer.Naumann@informatik.stud.uni-erlangen.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 35997ff0cadda701711416abf6676b77358b0008 |
|
05-Dec-2012 |
Sebastian Hahn <snsehahn@cip.cs.fau.de> |
staging/rtl8192u: cleanfile run
Run cleanfile on all files inside drivers/staging/rtl819u
Signed-off-by: Sebastian Hahn <snsehahn@cip.cs.fau.de>
Signed-off-by: Jennifer Naumann <Jennifer.Naumann@informatik.stud.uni-erlangen.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| ffae3055d23275b7b0abd4c1b0b750662b62ccf1 |
|
30-Apr-2012 |
Justin P. Mattock <justinmattock@gmail.com> |
staging: rtl8192u Fix a typo.
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 589b3d06fd159774f9f5c3639d8d5d938670c019 |
|
30-Apr-2012 |
Justin P. Mattock <justinmattock@gmail.com> |
staging: rtl8192u Fix typos.
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| b330f606ed7591dc078acd856454e3a383299fb3 |
|
11-Apr-2012 |
Jim Cromie <jim.cromie@gmail.com> |
staging: replace open-coded ARRAY_SIZEs
spatch http://coccinelle.lip6.fr/rules/array.cocci did these.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 0e7a3e7a746b5dc6ccf9896e882441c4fdbfd09a |
|
29-Nov-2010 |
David Chosrova <dada2372@gmail.com> |
Staging: rtl8192u: remove dead code to disable dot11d
This patch removes all the ENABLE_DOT11D ifdefs.
It is always defined for driver. DOT11D has to do with regulatory domains.
What prompted this patch was a warning message in Sparse.
drivers/staging/rtl8192u/r8192U_core.c:247:1: warning: "eqMacAddr"
redefined in file included from drivers/staging/rtl8192u/:81:81:
drivers/staging/rtl8192u/dot11d.h:35:1: warning: this is the location
of the previous definition
Now there are no ifdefs around dot11d.h it made no sense to have this
second definition, so I removed that macro as well. ( Thanks Dan ;-) ).
Acked-by. Dan Carpenter <error27@gmail.com>
Signed-off-by: David Chosrova <dada2372@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
| 50a09b3b099ebc8326b85b4f508fb47655e1fed3 |
|
03-Nov-2009 |
Mauro Carvalho Chehab <mchehab@infradead.org> |
Staging: rtl8192u: remove dead code
Remove #ifse against older kernel versions;
Remove codes marked with #if 0;
Remove #if 1
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
| e406322b4b963e622f41d76193d8ca9e5435adb8 |
|
03-Nov-2009 |
Mauro Carvalho Chehab <mchehab@infradead.org> |
Staging: rtl8192u: remove bad whitespaces
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
| 8fc8598e61f6f384f3eaf1d9b09500c12af47b37 |
|
03-Nov-2009 |
Jerry Chuang <jerry-chuang@realtek.com> |
Staging: Added Realtek rtl8192u driver to staging
Add Realtek linux driver for rtl8192u as provided by Realtek
rtl8192u_linux_2.6.0006.1031.2008.tar.gz, send to me C/C staging ML.
This version won't compile against upstream, doesn't follow
Linux CodingStyle and has their own ieee80211 stack.
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|