| 0a3a725adb2c421ea79089ea12004a007fb371ce |
|
14-Sep-2014 |
Roxana Blaj <roxanagabriela10@gmail.com> |
staging: speakup: fix checkpatch warning
This fixes the cheackpatch warning:
WARNING: Missing a blank line after declarations
Signed-off-by: Roxana Blaj <roxanagabriela10@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 8e69a8110686572a4b88d006faa8c3c759c4c261 |
|
09-Sep-2014 |
Domagoj Trsan <domagoj.trsan@gmail.com> |
staging: speakup: fix missing blank lines after declarations
Signed-off-by: Domagoj Trsan <domagoj.trsan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 11a18fc3d1bb5a437755fd3e90568e64f6e7583e |
|
09-Sep-2014 |
Domagoj Trsan <domagoj.trsan@gmail.com> |
staging: speakup: fix redundant return in void functions
Signed-off-by: Domagoj Trsan <domagoj.trsan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| e7027b9b2567cd3050d266bc56a2296840dd7f68 |
|
09-Sep-2014 |
Domagoj Trsan <domagoj.trsan@gmail.com> |
staging: speakup: fix warnings: line over 80 characters
Signed-off-by: Domagoj Trsan <domagoj.trsan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 3d3cb1bffde15ee6e69532457bee20b5d424952b |
|
13-Jun-2014 |
Robin Schroer <sulamiification@gmail.com> |
drivers/staging/speakup/main: fixed jiffie comparison
speakup_key() used manual comparison of jiffies to determine the time
since the last keypress, replaced it with time_after()
Signed-off-by: Robin Schroer <sulamiification@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| d7500135802ca55b3f4e01a16544e8b34082f8c3 |
|
19-May-2014 |
Ben Hutchings <ben@decadent.org.uk> |
Staging: speakup: Move pasting into a work item
Input is handled in softirq context, but when pasting we may
need to sleep. speakup_paste_selection() currently tries to
bodge this by busy-waiting if in_atomic(), but that doesn't
help because the ldisc may also sleep.
For bonus breakage, speakup_paste_selection() changes the
state of current, even though it's not running in process
context.
Move it into a work item and make sure to cancel it on exit.
References: https://bugs.debian.org/735202
References: https://bugs.debian.org/744015
Reported-by: Paul Gevers <elbrus@debian.org>
Reported-and-tested-by: Jarek Czekalski <jarekczek@poczta.onet.pl>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| ef35a4f44bdc6f8c9f99a561fd1fd318305a4d98 |
|
09-Apr-2014 |
Daeseok Youn <daeseok.youn@gmail.com> |
staging: speakup: fix misuse of kstrtol() in handle_goto()
A string of goto_buf has a number followed by x or y.
e.g. "3x" means move 3 lines down.
The kstrtol() returns an error(-EINVAL) with this string so
go_pos has unsigned a value of that error.
And also "*cp" has not expected value.
And fix sparse warnings:
drivers/staging/speakup/main.c:1901 handle_goto() warn: unsigned '(speakup_console[vc->vc_num]->go_pos)' is never less than zero.
drivers/staging/speakup/main.c:1911 handle_goto() warn: unsigned '(speakup_console[vc->vc_num]->go_pos)' is never less than zero.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 6c7b4ac9363488a5d19ea26f864f0a8866ea5b49 |
|
09-Nov-2013 |
Grygorii Strashko <grygorii.strashko@ti.com> |
mm/staging: remove unnecessary inclusion of bootmem.h
Clean-up to remove depedency with bootmem headers.
Cc: Yinghai Lu <yinghai@kernel.org>
Cc: Tejun Heo <tj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: William Hubbs <w.d.hubbs@gmail.com>
Cc: Chris Brannon <chris@the-brannons.com>
Cc: Kirk Reiser <kirk@reisers.ca>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| ab06e0f20ed4c4eb472a1e16f942d6e0150c00bc |
|
03-Oct-2013 |
Shalin Mehta <shalinmehta85@gmail.com> |
staging: speakup: str initialization replaced with NULL where it was initialized with int
Fixed warnings in all of three files where the string was initilized with an integer instead of NULL
Signed-off-by: Shalin Mehta <shalinmehta85@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 0012196c165d5158a128e2accd2e511a306a6aa7 |
|
22-May-2013 |
Sachin Kamat <sachin.kamat@linaro.org> |
Staging: speakup/main: Staticize local symbols
Symbols referenced only in this file are made static.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| ff471ea823d8cdd790759febc358c3776a90c922 |
|
22-May-2013 |
Sachin Kamat <sachin.kamat@linaro.org> |
Staging: speakup/main: Use NULL instead of 0
Use NULL instead of 0 for pointers.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| f2ae62fe336f5194c06c213a32bbce0c8bf1511d |
|
21-May-2013 |
Lisa Nguyen <lisa@xenapiadmin.com> |
staging/speakup: Changed parameters in kstrtol()
Changed parameters in the kstrtol() function inside main.c to resolve
warnings re: mismatched data types used.
Signed-off-by: Lisa Nguyen <lisa@xenapiadmin.com>
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| a87af7c58b1f5af0d6a6093465d1a5ed8054434c |
|
17-May-2013 |
Lisa Nguyen <lisa@xenapiadmin.com> |
staging/speakup: Replaced deprecated function
Replaced simple_strtol() function with kstrtol() function
in main.c
Signed-off-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 69d8ba56594a23af4901e109a5b9178105b863b3 |
|
17-May-2013 |
Lisa Nguyen <lisa@xenapiadmin.com> |
staging/speakup: Reformatted pointer variables
Reformatted pointer variables in main.c to meet kernel coding
standards.
Signed-off-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 3efe810f2322223eca3b3a1dea3ae40500cbd471 |
|
13-May-2013 |
William Hubbs <w.d.hubbs@gmail.com> |
staging: speakup: main: remove custom locking macros
Signed-off-by: William Hubbs <w.d.hubbs@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 1627ab92b2e6307525f43f775aaeac54407981ef |
|
28-Mar-2013 |
Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
staging: speakup: reuse native kernel functions
We have simple_strtoul and simple_strtol. Don't repeat their functionality
here.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| d9f5420268ca9b2bbe62f14757fac3e10eaf1ebf |
|
02-Jan-2013 |
Samuel Thibault <samuel.thibault@ens-lyon.org> |
staging: speakup: Turn some symbols static
Turn static some symbols which do not actually need to be
externally-visible
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| ca2beaf84d9678c12b17d92623f0e90829d6ca13 |
|
02-Jan-2013 |
Samuel Thibault <samuel.thibault@ens-lyon.org> |
staging: speakup: Prefix externally-visible symbols
This prefixes all externally-visible symbols of speakup with "spk_".
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 4ea418b8b2fa8a70d0fcc8231b65e67b3a72984b |
|
16-Jun-2012 |
Christopher Brannon <chris@the-brannons.com> |
Staging: speakup: fix an improperly-declared variable.
A local static variable was declared as a pointer to a string
constant. We're assigning to the underlying memory, so it
needs to be an array instead.
Signed-off-by: Christopher Brannon <chris@the-brannons.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 079c9534a96da9a85a2a2f9715851050fbfbf749 |
|
28-Feb-2012 |
Alan Cox <alan@linux.intel.com> |
vt:tackle kbd_table
Keyboard struct lifetime is easy, but the locking is not and is completely
ignored by the existing code. Tackle this one head on
- Make the kbd_table private so we can run down all direct users
- Hoick the relevant ioctl handlers into the keyboard layer
- Lock them with the keyboard lock so they don't change mid keypress
- Add helpers for things like console stop/start so we isolate the poking
around properly
- Tweak the braille console so it still builds
There are a couple of FIXME locking cases left for ioctls that are so hideous
they should be addressed in a later patch. After this patch the kbd_table is
private and all the keyboard jiggery pokery is in one place.
This update fixes speakup and also a memory leak in the original.
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
| 4afaee1561e207683dbb886b30a842ffcc22e366 |
|
22-Nov-2011 |
Christopher Brannon <chris@the-brannons.com> |
Staging: speakup: Don't try to access an unallocated struct.
In speakup_init, we have the following:
if (quiet_boot)
spk_shut_up |= 0x01;
And in spk_types.h:
This patch moves the statement in speakup_init so that
speakup_console[vc->vc_num] is guaranteed to be allocated when it
executes.
Signed-off-by: Christopher Brannon <chris@the-brannons.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
| 37ca936e1d83041ac9981bd31802b2c28f36ce93 |
|
24-Jun-2011 |
Jesper Juhl <jj@chaosbits.net> |
Remove unneeded version.h includes from drivers/staging/speakup/
It was pointed out by 'make versioncheck' that some includes of
linux/version.h are not needed in drivers/staging/speakup/.
This patch removes them.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
| 39dd3e5d7b09b5a5010ed1aef512f2d58b65cb99 |
|
13-Mar-2011 |
Ilia Mirkin <imirkin@alum.mit.edu> |
staging: speakup: Remove NULL check before kfree
This patch was generated by the following semantic patch:
// <smpl>
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);
@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;
// </smpl>
Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
| 628f34282db49359576dcb8cbaea65b4bf083ebd |
|
19-Dec-2010 |
Christopher Brannon <chris@the-brannons.com> |
staging: speakup: more fixes for init-failure handling.
We still leaked many resources when Speakup failed to initialize.
Examples of leaked resources include:
/dev/synth, keyboard or VT notifiers, and heap-allocated st_spk_t
structs.
This is fixed.
* We now use PTR_ERR to detect kthread_create failure
(thank you Dan Carpenter).
* The loop which frees members of the speakup_console array now iterates
over the whole array, not stopping at the first NULL value. Fixes
a possible memory leak. Safe because kfree(NULL) is a no-op.
* The order of some initializations was changed. The safe ones, which
will never fail, are performed first.
Signed-off-by: Christopher Brannon <chris@the-brannons.com>
Acked-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
| 7959d55679e4360205c9ebc89d40a5503c53bae2 |
|
16-Dec-2010 |
William Hubbs <w.d.hubbs@gmail.com> |
staging: speakup: fix failure handling
fix the failure handling in kobjects and the main function so that we
release the virtual keyboard if we exit due to another failure.
Signed-off-by: William Hubbs <w.d.hubbs@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
| b3495cebaaa64c9e6df9ab663dfb75e86a08f9ce |
|
17-Oct-2010 |
Vasiliy Kulikov <segooon@gmail.com> |
staging: speakup: fix memory leak
speakup_init() didn't free first_console if speakup_kobj_init() fails.
Also propagate speakup_kobj_init()'s return code.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
| 16d355156ba475c0fefb19133174cdf61a5101ba |
|
16-Oct-2010 |
William Hubbs <w.d.hubbs@gmail.com> |
staging: speakup: main.c style fixes
- fix issues reported by checkpatch.pl
- run code through Lindent
- move some prototypes to speakup.h
Signed-off-by: William Hubbs <w.d.hubbs@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
| 5b19208a5e236b26357162d6a28ff9e8d4296725 |
|
08-Oct-2010 |
Greg Kroah-Hartman <gregkh@suse.de> |
Staging: speakup: fix speakup core to build properly
The vc_data structure changed to move the tty structure off to the port,
so change the code to handle this. Now the code will build properly,
and hopefully work as well.
Cc: William Hubbs <w.d.hubbs@gmail.com>
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
| c6e3fd22cd538365bfeb82997d5b89562e077d42 |
|
07-Oct-2010 |
William Hubbs <w.d.hubbs@gmail.com> |
Staging: add speakup to the staging directory
Speakup is a kernel based screen review package for the linux operating
system. It allows blind users to interact with applications on the
linux console by means of synthetic speech.
The authors and maintainers of this code include the following:
Kirk Reiser, Andy Berdan, John Covici, Brian and
David Borowski, Christopher Brannon, Samuel Thibault and William Hubbs.
Signed-off-by: William Hubbs <w.d.hubbs@gmail.com>
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|