1f7a316f9ba5ea743c95b5fcc472fa3caf8fec98 |
|
14-Jul-2014 |
Fabian Frederick <fabf@skynet.be> |
caif: remove unnecessary break after goto Signed-off-by: Fabian Frederick <fabf@skynet.be> Signed-off-by: David S. Miller <davem@davemloft.net>
|
0c1db731bfcf3a9fd6c58132134f8b0f423552f0 |
|
05-Sep-2013 |
Dave Jones <davej@redhat.com> |
caif: Add missing braces to multiline if in cfctrl_linkup_request The indentation here implies this was meant to be a multi-line if. Introduced several years back in commit c85c2951d4da1236e32f1858db418221e624aba5 ("caif: Handle dev_queue_xmit errors.") Signed-off-by: Dave Jones <davej@fedoraproject.org> Signed-off-by: David S. Miller <davem@davemloft.net>
|
26ee65e680f4a2291f6258e11beceae0ad4eeba3 |
|
23-Apr-2013 |
sjur.brandeland@stericsson.com <sjur.brandeland@stericsson.com> |
caif: Remove my bouncing email address. Remove my soon bouncing email address. Also remove the "Contact:" line in file header. The MAINTAINERS file is a better place to find the contact person anyway. Signed-off-by: Sjur Brændeland <sjur.brandeland@stericsson.com> Signed-off-by: David S. Miller <davem@davemloft.net>
|
3bffc475f9995843fa23a4978a4c112d8c8f4a6e |
|
06-Mar-2013 |
Silviu-Mihai Popescu <silviupopescu1990@gmail.com> |
CAIF: fix indentation for function arguments This lines up function arguments on second and subsequent lines at the first column after the openning parenthesis of the first line. Signed-off-by: Silviu-Mihai Popescu <silviupopescu1990@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
|
973b1b9a454c738edbb2eb8d4596014b575dc15c |
|
20-Nov-2012 |
Sachin Kamat <sachin.kamat@linaro.org> |
caif: Remove redundant null check before kfree in cfctrl.c kfree on a null pointer is a no-op. Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Acked-by: Sjur Brændeland <sjur.brandeland@stericsson.com> Signed-off-by: David S. Miller <davem@davemloft.net>
|
f315fd355ffaec6a9ad541081975ac821404256e |
|
25-Jun-2012 |
Kim Lilliestierna XX <kim.xx.lilliestierna@stericsson.com> |
caif: Fixed potential memory leak Rearranged the allocation and packet creations to avoid potential leaks in error path. Signed-off-by: Kim Lilliestierna <kim.xx.lilliestierna@stericsson.com> Signed-off-by: Sjur Brændeland <sjur.brandeland@stericssion.com> Signed-off-by: David S. Miller <davem@davemloft.net>
|
447648128ec22e294604674ffe1064aa3ec3b767 |
|
12-Apr-2012 |
Dmitry Tarnyagin <dmitry.tarnyagin@stericsson.com> |
caif: set traffic class for caif packets Set traffic class for CAIF packets, based on socket priority, CAIF protocol type, or type of message. Traffic class mapping for different packet types: - control: TC_PRIO_CONTROL; - flow control: TC_PRIO_CONTROL; - at: TC_PRIO_CONTROL; - rfm: TC_PRIO_INTERACTIVE_BULK; - other sockets: equals to socket's TC; - network data: no change. Signed-off-by: Dmitry Tarnyagin <dmitry.tarnyagin@stericsson.com> Signed-off-by: David S. Miller <davem@davemloft.net>
|
7ac2ed0ceeafa130f85aa947b271b571c68b9e75 |
|
25-Aug-2011 |
Joe Perches <joe@perches.com> |
caif: Remove OOM messages, use kzalloc Remove per site OOM messages because they duplicate the generic mm subsystem OOM message. Use kzalloc instead of kmalloc/memset when next to the OOM message removals. Reduces object size (allyesconfig ~2%) $ size -t drivers/net/caif/built-in.o.old net/caif/built-in.o.old text data bss dec hex filename 32297 700 8224 41221 a105 drivers/net/caif/built-in.o.old 72159 1317 20552 94028 16f4c net/caif/built-in.o.old 104456 2017 28776 135249 21051 (TOTALS) $ size -t drivers/net/caif/built-in.o.new net/caif/built-in.o.new text data bss dec hex filename 31975 700 8184 40859 9f9b drivers/net/caif/built-in.o.new 70748 1317 20152 92217 16839 net/caif/built-in.o.new 102723 2017 28336 133076 207d4 (TOTALS) Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: David S. Miller <davem@davemloft.net>
|
96796ea8b6b1221c7cacf68ce056d77eff0a793d |
|
22-May-2011 |
sjur.brandeland@stericsson.com <sjur.brandeland@stericsson.com> |
caif: Fix freezes when running CAIF loopback device Fix spinlock bugs when running out of link-ids in loopback tests and avoid allocating link-id when error is set in link-setup-response. Signed-off-by: Sjur Brændeland <sjur.brandeland@stericsson.com> Signed-off-by: David S. Miller <davem@davemloft.net>
|
0e5a117441ce245b87949cc7713627a293f37227 |
|
22-May-2011 |
sjur.brandeland@stericsson.com <sjur.brandeland@stericsson.com> |
caif: Bugfix add check NULL pointer before calling functions. Add check on layer->dn != NULL before calling functions in layer below. Signed-off-by: Sjur Brændeland <sjur.brandeland@stericsson.com> Signed-off-by: David S. Miller <davem@davemloft.net>
|
c85c2951d4da1236e32f1858db418221e624aba5 |
|
13-May-2011 |
sjur.brandeland@stericsson.com <sjur.brandeland@stericsson.com> |
caif: Handle dev_queue_xmit errors. Do proper handling of dev_queue_xmit errors in order to avoid double free of skb and leaks in error conditions. In cfctrl pending requests are removed when CAIF Link layer goes down. Signed-off-by: Sjur Brændeland <sjur.brandeland@stericsson.com> Signed-off-by: David S. Miller <davem@davemloft.net>
|
73d6ac633c6c0ca703f90db0b808d9593e46aef6 |
|
11-Apr-2011 |
Stephen Hemminger <shemminger@vyatta.com> |
caif: code cleanup Cleanup of new CAIF code. * make local functions static * remove code that is never used * expand get_caif_conf() since wrapper is no longer needed * make args to comparison functions const * rename connect_req_to_link_param to keep exported names consistent Compile tested only. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> Acked-by: Sjur Brændeland <sjur.brandeland@stericsson.com> Signed-off-by: David S. Miller <davem@davemloft.net>
|
47d1ff176553fec3cb17854a7ca85036d3b0c4e7 |
|
03-Nov-2010 |
sjur.brandeland@stericsson.com <sjur.brandeland@stericsson.com> |
caif: Remove noisy printout when disconnecting caif socket Signed-off-by: Sjur Brændeland <sjur.brandeland@stericsson.com> Signed-off-by: David S. Miller <davem@davemloft.net>
|
b31fa5bad576cd8180a5ad70c648333b44320d44 |
|
05-Sep-2010 |
Joe Perches <joe@perches.com> |
net/caif: Use pr_fmt This patch standardizes caif message logging prefixes. Add #define pr_fmt(fmt) KBUILD_MODNAME ":%s(): " fmt, __func__ Add missing "\n"s to some logging messages Convert pr_warning to pr_warn This changes the logging message prefix from CAIF: to caif: for all uses but caif_socket.c and chnl_net.c. Those now use their filename without extension. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: David S. Miller <davem@davemloft.net>
|
2aa40aef9debc77d55cc87a50d335b6fe97fbeb0 |
|
17-Jun-2010 |
Sjur Braendeland <sjur.brandeland@stericsson.com> |
caif: Use link layer MTU instead of fixed MTU Previously CAIF supported maximum transfer size of ~4050. The transfer size is now calculated dynamically based on the link layers mtu size. Signed-off-by: Sjur Braendeland@stericsson.com Signed-off-by: David S. Miller <davem@davemloft.net>
|
b1c74247b9e29ae3bfdf133862328c309bc9cf14 |
|
17-Jun-2010 |
Sjur Braendeland <sjur.brandeland@stericsson.com> |
caif: Bugfix not all services uses flow-ctrl. Flow control is not used by all CAIF services. The usage of flow control is now part of the gerneal initialization function for CAIF Services. Signed-off-by: Sjur Braendeland@stericsson.com Signed-off-by: David S. Miller <davem@davemloft.net>
|
7aecf4944f2c05aafb73b4820e469c74b4ec8517 |
|
21-May-2010 |
Sjur Braendeland <sjur.brandeland@stericsson.com> |
caif: Bugfix - use standard Linux lists Discovered bug when running high number of parallel connect requests. Replace buggy home brewed list with linux/list.h. Signed-off-by: Sjur Braendeland <sjur.brandeland@stericsson.com> Signed-off-by: David S. Miller <davem@davemloft.net>
|
49afa55b5bd792cda4fca15d3238e9b6f370c856 |
|
13-May-2010 |
Julia Lawall <julia@diku.dk> |
net/caif: Use kzalloc Use kzalloc rather than the combination of kmalloc and memset. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression x,size,flags; statement S; @@ -x = kmalloc(size,flags); +x = kzalloc(size,flags); if (x == NULL) S -memset(x, 0, size); // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Acked-by: Sjur Brændeland <sjur.brandeland@stericsson.com> Signed-off-by: David S. Miller <davem@davemloft.net>
|
8d545c8f958f5f433c50a00762ce1f231ed56eee |
|
28-Apr-2010 |
Sjur Braendeland <sjur.brandeland@stericsson.com> |
caif: Disconnect without waiting for response Changes: o Function cfcnfg_disconn_adapt_layer is changed to do asynchronous disconnect, not waiting for any response from the modem. Due to this the function cfcnfg_linkdestroy_rsp does nothing anymore. o Because disconnect may take down a connection before a connect response is received the function cfcnfg_linkup_rsp is checking if the client is still waiting for the response, if not a disconnect request is sent to the modem. o cfctrl is no longer keeping track of pending disconnect requests. o Added function cfctrl_cancel_req, which is used for deleting a pending connect request if disconnect is done before connect response is received. o Removed unused function cfctrl_insert_req2 o Added better handling of connect reject from modem. Signed-off-by: Sjur Braendeland <sjur.brandeland@stericsson.com> Signed-off-by: David S. Miller <davem@davemloft.net>
|
b482cd2053e3b90a7b33a78c63cdb6badf2ec383 |
|
30-Mar-2010 |
Sjur Braendeland <sjur.brandeland@stericsson.com> |
net-caif: add CAIF core protocol stack CAIF generic protocol implementation. This layer is somewhat generic in order to be able to use and test it outside the Linux Kernel. cfctrl.c - CAIF control protocol layer cfdbgl.c - CAIF debug protocol layer cfdgml.c - CAIF datagram protocol layer cffrml.c - CAIF framing protocol layer cfmuxl.c - CAIF mux protocol layer cfrfml.c - CAIF remote file manager protocol layer cfserl.c - CAIF serial (fragmentation) protocol layer cfsrvl.c - CAIF generic service layer functions cfutill.c - CAIF utility protocol layer cfveil.c - CAIF AT protocol layer cfvidl.c - CAIF video protocol layer Signed-off-by: Sjur Braendeland <sjur.brandeland@stericsson.com> Signed-off-by: David S. Miller <davem@davemloft.net>
|