| c8d755b59ae6750150d7f351210b97ad4cce5a51 |
|
22-Aug-2011 |
Jesper Juhl <jj@chaosbits.net> |
net/wan/hdlc_ppp: use break in switch
We'll either hit one of the case labels or the default in the switch
and in all cases do we then 'goto out' and we also have a 'goto out'
after the switch that is redundant. Change to just use break in the
case statements and leave the 'goto out' after the lop for everyone to
hit.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/wan/hdlc_ppp.c
|
| 12a3bfefc8c1e43ddb50950cb74f8a11d680567a |
|
26-Jun-2011 |
Joe Perches <joe@perches.com> |
generic_hdlc: Update to current logging forms
Use pr_fmt, pr_<level> and netdev_<level> as appropriate.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/wan/hdlc_ppp.c
|
| 31f634a63de7068c6a5dcb0d7b09b24b61a5cf88 |
|
14-Apr-2010 |
Krzysztof Halasa <khc@pm.waw.pl> |
WAN: flush tx_queue in hdlc_ppp to prevent panic on rmmod hw_driver.
tx_queue is used as a temporary queue when not allowed to queue skb
directly to the hw device driver (which may sleep). Most paths flush
it before returning, but ppp_start() currently cannot. Make sure we
don't leave skbs pointing to a non-existent device.
Thanks to Michael Barkowski for reporting this problem.
Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/wan/hdlc_ppp.c
|
| 966a5d1b85c45f1b55abbc1b595e0b5ca14b87db |
|
11-Sep-2009 |
Julia Lawall <julia@diku.dk> |
drivers/net/wan: introduce missing kfree
Error handling code following a kmalloc should free the allocated data.
The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@@
x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
when != if (...) { <+...x...+> }
(
x->f1 = E
|
(x->f1 == NULL || ...)
|
f(...,x->f1,...)
)
...>
(
return \(0\|<+...x...+>\|ptr\);
|
return@p2 ...;
)
@script:python@
p1 << r.p1;
p2 << r.p2;
@@
print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/wan/hdlc_ppp.c
|
| 09640e6365c679b5642b1c41b6d7078f51689ddf |
|
01-Feb-2009 |
Harvey Harrison <harvey.harrison@gmail.com> |
net: replace uses of __constant_{endian}
Base versions handle constant folding now.
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/wan/hdlc_ppp.c
|
| 991990a12de42281f81b4e3a6471586d2d0caf6a |
|
08-Jan-2009 |
Krzysztof Hałasa <khc@pm.waw.pl> |
WAN: Convert generic HDLC drivers to netdev_ops.
Also remove unneeded last_rx update from Synclink drivers.
Synclink part mostly by Stephen Hemminger.
Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/wan/hdlc_ppp.c
|
| 93bc933524d05e3b391358e24b3666599f8ec026 |
|
26-Nov-2008 |
Krzysztof Hałasa <khc@pm.waw.pl> |
HDLC_PPP: Fix Configure-Ack to return original options as required by the standard.
Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
/drivers/net/wan/hdlc_ppp.c
|
| e022c2f07ae52bfbd92faa273db0db2f34eb28e8 |
|
14-Aug-2008 |
Krzysztof Hałasa <khc@pm.waw.pl> |
WAN: new synchronous PPP implementation for generic HDLC.
Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
/drivers/net/wan/hdlc_ppp.c
|
| 4dfce4075aa4e2eee35e52a78dbabfe37d94c908 |
|
30-Jun-2008 |
Krzysztof Hałasa <khc@pm.waw.pl> |
WAN: cosmetic changes to generic HDLC
Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
/drivers/net/wan/hdlc_ppp.c
|
| 4951704b4e23d71b99ac933d8e6993bc6225ac13 |
|
12-May-2008 |
David S. Miller <davem@davemloft.net> |
syncppp: Fix crashes.
The syncppp layer wants a mid-level netdev private pointer.
It was using netdev->priv but that only worked by accident,
and thus this scheme was broken when the device private
allocation strategy changed.
Add a proper mid-layer private pointer for uses like this,
update syncppp and all users, and remove the HDLC_PPP broken
tag from drivers/net/wan/Kconfig
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/wan/hdlc_ppp.c
|
| 40d25142f2ef27084fc317ac8bb5bae460c8ea72 |
|
01-Feb-2008 |
Krzysztof Halasa <khc@pm.waw.pl> |
Generic HDLC - remove now unneeded hdlc_device_desc
Removes now unneeded struct hdlc_device_desc
Signed-off-by: Krzysztof Halasa <khc@pm.waw.pl>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
/drivers/net/wan/hdlc_ppp.c
|
| 904584018e9ba30a3e562d86ee7dfb6239105664 |
|
22-Dec-2007 |
Al Viro <viro@ftp.linux.org.uk> |
annotate the rest of drivers/net/wan
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
/drivers/net/wan/hdlc_ppp.c
|
| 3b04ddde02cf1b6f14f2697da5c20eca5715017f |
|
09-Oct-2007 |
Stephen Hemminger <shemminger@linux-foundation.org> |
[NET]: Move hardware header operations out of netdevice.
Since hardware header operations are part of the protocol class
not the device instance, make them into a separate object and
save memory.
Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/wan/hdlc_ppp.c
|
| b5284e5aa94be2f88dc92b29e97aff3da0c45f9f |
|
03-Mar-2007 |
Krzysztof Halasa <khc@pm.waw.pl> |
[HDLC] Fix dev->header_cache_update having a random value.
Switching HDLC devices from Ethernet-framing mode caused stale ethernet
function assignments within net_device.
Signed-off-by: Krzysztof Halasa <khc@pm.waw.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/wan/hdlc_ppp.c
|
| eb2a2fd91f7c8a53b15063d6f08cf22b9a56cbfb |
|
26-Sep-2006 |
Krzysztof Halasa <khc@pm.waw.pl> |
[PATCH] Modularize generic HDLC
This patch enables building of individual WAN protocol support
routines (parts of generic HDLC) as separate modules.
All protocol-private definitions are moved from hdlc.h file
to protocol drivers. User-space interface and interface
between generic HDLC and underlying low-level HDLC drivers
are unchanged.
Signed-off-by: Krzysztof Halasa <khc@pm.waw.pl>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
/drivers/net/wan/hdlc_ppp.c
|
| 4bc83b4d409edacb33db6c71d03e963d9728476c |
|
21-Jul-2006 |
Krzysztof Halasa <khc@pm.waw.pl> |
[WAN]: Added missing netif_dormant_off() to generic HDLC
WAN: Fixed a problem with PPP/raw HDLC/X.25 protocols not doing
netif_dormant_off() at startup.
Signed-off-by: Krzysztof Halasa <khc@pm.waw.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/wan/hdlc_ppp.c
|
| ab611487d8ada506e511d2b8f22fb8e7be9939b9 |
|
12-Jul-2005 |
Alexey Dobriyan <adobriyan@gmail.com> |
[NET]: __be'ify *_type_trans()
tr_type_trans(), hippi_type_trans() left as-is.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/wan/hdlc_ppp.c
|
| 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 |
|
17-Apr-2005 |
Linus Torvalds <torvalds@ppc970.osdl.org> |
Linux-2.6.12-rc2
Initial git repository build. I'm not bothering with the full history,
even though we have it. We can create a separate "historical" git
archive of that later if we want to, and in the meantime it's about
3.2GB when imported into git - space that would just make the early
git days unnecessarily complicated, when we don't have a lot of good
infrastructure for it.
Let it rip!
/drivers/net/wan/hdlc_ppp.c
|