| 41c7b7c0fa2f68afb1154e88597ff6b9b97334cf |
|
06-Nov-2011 |
Kevin McKinney <klmckinney1@gmail.com> |
Staging: bcm: Fix information leak in ioctl: IOCTL_BCM_REGISTER_READ_PRIVATE, IOCTL_BCM_EEPROM_REGISTER_READ
This patch fixes an information leak in ioctl
IOCTL_BCM_REGISTER_READ_PRIVATE and
IOCTL_BCM_EEPROM_REGISTER_READ when determining
the number of bytes to copy to user space. Function,
usb_control_msg, returns the correct number of
bytes from the hardware. Instead of using
this value, we were using a value derived from
user space. In this case, this value could be more
than the hardware allocated. Therefore, this
patch copies the proper number of bytes from
the hardware, and uses this value as the maximum
number of bytes for user space.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/bcm/InterfaceInit.c
|
| ca45e70029b3d96923953992c05a2515dd3d9f24 |
|
11-Oct-2011 |
Kevin McKinney <klmckinney1@gmail.com> |
Staging: bcm: Remove assignment from if conditions reported by checkpatch.pl
This patch removes an assignment from three if
conditions. In all three cases, the line of code was
attempting to allocate memory, and check
if the memory was allocated in the if statement.
This issue was reported by checkpatch.pl.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/bcm/InterfaceInit.c
|
| f969f84ed92e55040dbf51398ba2d8f5d23bf498 |
|
11-Oct-2011 |
Kevin McKinney <klmckinney1@gmail.com> |
Staging: bcm: Fix coding style issues reported by checkpatch.pl
This patch cleans up several code style issues found
in InterfaceInit.c reported by checkpatch.pl.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/bcm/InterfaceInit.c
|
| 949f6711b83d2809d1ccb9d830155a65fdacdff9 |
|
11-Jan-2011 |
Linus Torvalds <torvalds@linux-foundation.org> |
Merge branch 'staging-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging-2.6
* 'staging-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging-2.6: (510 commits)
staging: speakup: fix failure handling
staging: usbip: remove double giveback of URB
Staging: batman-adv: Remove batman-adv from staging
Staging: hv: Use only one txf buffer per channel and kmalloc/GFP_KERNEL on initialize
staging: hv: remove unneeded osd_schedule_callback
staging: hv: convert channel_mgmt.c to not call osd_schedule_callback
staging: hv: convert vmbus_on_msg_dpc to not call osd_schedule_callback
staging: brcm80211: Fix WL_<type> logging macros
Staging: IIO: DDS: AD9833 / AD9834 driver
Staging: IIO: dds.h convenience macros
Staging: IIO: Direct digital synthesis abi documentation
staging: brcm80211: Convert ETHER_TYPE_802_1X to ETH_P_PAE
staging: brcm80211: Remove unused ETHER_TYPE_<foo> #defines
staging: brcm80211: Remove ETHER_HDR_LEN, use ETH_HLEN
staging: brcm80211: Convert ETHER_ADDR_LEN to ETH_ALEN
staging: brcm80211: Convert ETHER_IS<FOO> to is_<foo>_ether_addr
staging: brcm80211: Remove unused ether_<foo> #defines and struct
staging: brcm80211: Convert ETHER_IS_MULTI to is_multicast_ether_addr
staging: brcm80211: Remove unused #defines ETHER_<foo>_LOCALADDR
Staging: comedi: Fix checkpatch.pl issues in file s526.c
...
Fix up trivial conflict in drivers/video/udlfb.c
|
| 37db526463a5ad1c96cd803d49fddbf069bbf9b9 |
|
06-Dec-2010 |
Dan Carpenter <error27@gmail.com> |
Staging: Beceem: more checkpatch.pl changes to InterfaceInit.c
The only checkpatch.pl issues remaining still remaining are line length
complaints.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/bcm/InterfaceInit.c
|
| 07a7f68800a490bc1140de778e196f66ef4596d9 |
|
06-Dec-2010 |
Dan Carpenter <error27@gmail.com> |
Staging: Beceem: improve debug printk statements
These are just small changes. Some grammar and wording changes. I added
new lines to the end of all the print statements.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/bcm/InterfaceInit.c
|
| 6b74705e15d5c87181008f1ac984df7faaad55c9 |
|
06-Dec-2010 |
Dan Carpenter <error27@gmail.com> |
Staging: Beceem: use after free in bcm_exit()
We can't call class_destroy() until after the driver has been deregistered.
It leads to a NULL deref on module unload.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/bcm/InterfaceInit.c
|
| cd0b0ebfbe134b9c98fa8e628732b0e41b2cb48c |
|
06-Dec-2010 |
Dan Carpenter <error27@gmail.com> |
Staging: Beceem: remove old kernel compatibility code
This drops compatability for everything from 2.4 to 2.6.35. Now it only
works on the latest kernel.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/bcm/InterfaceInit.c
|
| c2a0b162dbce1534cf4e71914597419ae83a70d9 |
|
06-Dec-2010 |
Dan Carpenter <error27@gmail.com> |
Staging: Beceem: white space changes to InterfaceInit.c
This patch only changes:
1) spaces, tabs, and newline characters.
2) comment styles.
The compiled object file is the same before and after except for line
number changes.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/bcm/InterfaceInit.c
|
| 2a314742d300edc2010d50a006c77ceb04c75119 |
|
06-Dec-2010 |
Dan Carpenter <error27@gmail.com> |
Staging: Beceem: use lower case "int" instead of "INT"
This patch changes:
INT => int
ULONG => unsigned long
VOID => void
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/bcm/InterfaceInit.c
|
| 85c0b1760a7c259679d188bef58866fc641deca5 |
|
06-Dec-2010 |
Dan Carpenter <error27@gmail.com> |
Staging: Beceem: add USB id for BCSM250 Mobile WiMAX
Signed-off-by: Dan Carpenter <error27@gmail.com>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/bcm/InterfaceInit.c
|
| 2f15744c1d90ee2e82f8ae5724b44b1cdf31715c |
|
17-Nov-2010 |
Alan Stern <stern@rowland.harvard.edu> |
USB: fix leftover references to udev->autosuspend_delay
This patch (as1436) takes care of leftover references to
udev->autosuspend_delay that didn't get removed during the earlier
conversion to the runtime-PM autosuspend API.
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/bcm/InterfaceInit.c
|
| 859171ca92f2865453b4b2e17bf679c67044a833 |
|
15-Nov-2010 |
Joe Perches <joe@perches.com> |
drivers/staging: Remove unnecessary semicolons
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/bcm/InterfaceInit.c
|
| 16618c20e18d60b2c8908b7758228a62a450769a |
|
10-Nov-2010 |
Alejandro R. Sedeño <asedeno@MIT.EDU> |
Staging: beceem: Move ZTE TU25's USB id to the beceem module
Signed-off-by: Alejandro R. Sedeño <asedeno@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/bcm/InterfaceInit.c
|
| 4ea4f7a0d3d7a9961bf77f0860df8dd4a213b8a3 |
|
01-Nov-2010 |
Stephen Hemminger <stephen.hemminger@vyatta.com> |
beceem: change startup messages
Change the regsister/unregister routines to generate better
messages, and control arrival of new frames when USB device is
unplugged.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
/drivers/staging/bcm/InterfaceInit.c
|
| 9dd47ee7dd535649a2c32d509631c7a3d793f2e1 |
|
01-Nov-2010 |
Stephen Hemminger <stephen.hemminger@vyatta.com> |
beceem: make local functions static
Use namespace tool from kernel scripts to identify dead code and
functions that should be static.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
/drivers/staging/bcm/InterfaceInit.c
|
| 2d08748ae53bf07fe6fcaf4f3d40449b471ce351 |
|
01-Nov-2010 |
Stephen Hemminger <stephen.hemminger@vyatta.com> |
beceem: module initialization
Get rid of boot messages and put in correct place.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
/drivers/staging/bcm/InterfaceInit.c
|
| 4fd64dd0c1b9317ffe6fdaf3de788e14df880d8d |
|
01-Nov-2010 |
Stephen Hemminger <stephen.hemminger@vyatta.com> |
beceem: add network device message level control
Provide standard interface to control verbosity of debug messages
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
/drivers/staging/bcm/InterfaceInit.c
|
| 9e0a3169a34ba5fd04bde058a63fa0a36f2d7ed3 |
|
01-Nov-2010 |
Stephen Hemminger <stephen.hemminger@vyatta.com> |
beceem: create class on module installation
First step to supporting multiple devices, create device class
when module is initialized.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
/drivers/staging/bcm/InterfaceInit.c
|
| 032100f65295d594fc0481e840efe8b6c1e398af |
|
01-Nov-2010 |
Stephen Hemminger <stephen.hemminger@vyatta.com> |
beceem: remove unnecessary usb class
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
/drivers/staging/bcm/InterfaceInit.c
|
| 0980f2e8144ea0021a09be41176b736d76ca3db7 |
|
01-Nov-2010 |
Stephen Hemminger <stephen.hemminger@vyatta.com> |
beceem: reserve one queue for bit-bucket
This preserves the semantics of the original driver (unclassified packets
are dropped), but does it in a clean way; and fixes crash when packet
is sent to offline device.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
/drivers/staging/bcm/InterfaceInit.c
|
| 3644c1a2f12b15e1c8bfb9ebfaacbd177011a72d |
|
01-Nov-2010 |
Stephen Hemminger <stephen.hemminger@vyatta.com> |
beceem: remove dead code
Remove commented out with '#if 0'
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
/drivers/staging/bcm/InterfaceInit.c
|
| 937110581650eaa517f045fb7b86b9828ba693ad |
|
01-Nov-2010 |
Stephen Hemminger <stephen.hemminger@vyatta.com> |
beceem: support multiple queues
Current kernels have multi-queue support which can be used by
this device. This has the advantage that a single type of traffic
will not block other types.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
/drivers/staging/bcm/InterfaceInit.c
|
| 20f48653fcf51f6d1246b5f3f86b40ed779385b2 |
|
01-Nov-2010 |
Stephen Hemminger <stephen.hemminger@vyatta.com> |
beceem: get rid of unnecessary inline usage
Many routines were tagged with inline_ but GCC does a better
job of deciding this.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
/drivers/staging/bcm/InterfaceInit.c
|
| e614e28eac1afcdc3d1275f3e1478aa3e5acc500 |
|
01-Nov-2010 |
Stephen Hemminger <stephen.hemminger@vyatta.com> |
beceem: remove indirection to Adapter structure
Allocate Adapter structure as part of network device.
Signed-off-by: Stephen Hemminber <shemminger@vyatta.com>
/drivers/staging/bcm/InterfaceInit.c
|
| 082e889b475c46e71be6e779f15ab095f888e03f |
|
01-Nov-2010 |
Stephen Hemminger <stephen.hemminger@vyatta.com> |
beceem: remove OS wrapper library
Use native kernel functions for kmalloc/kfree directly
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
/drivers/staging/bcm/InterfaceInit.c
|
| 2564a148d5326f1d36202e497b3dd0a17422c636 |
|
29-Oct-2010 |
Stephen Hemminger <stephen.hemminger@vyatta.com> |
beceem: cleanup debug level infrastructure
Add module parameter to control debug level and do code cleanup
The whole debug stuff should eventually be removed.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
/drivers/staging/bcm/InterfaceInit.c
|
| 047a5f2b503d0ba17704c9714b296cbf06ec087e |
|
29-Oct-2010 |
Stephen Hemminger <stephen.hemminger@vyatta.com> |
beceem: eliminate unused USB stubs
USB layer does not require these reset function stubs
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
/drivers/staging/bcm/InterfaceInit.c
|
| 2e44f765dfd3a8592c2d6b6005be061eccdee137 |
|
29-Oct-2010 |
Stephen Hemminger <stephen.hemminger@vyatta.com> |
beceem: add module information
Add description and version information to the driver.
Make USB device table exported as alias so device will be
autoloaded. Get rid of useless noise message on boot.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
/drivers/staging/bcm/InterfaceInit.c
|
| 02339374cf3a28c30b5a137ab181eed358589dea |
|
08-Oct-2010 |
Dan Carpenter <error27@gmail.com> |
Staging: bcm: remove unneeded NULL check
The error handling here is wrong. If psIntfAdapter were NULL then we
would have a NULL dereference in the debug output on the error path.
But this function is only called from usbbcm_device_probe() when
psIntfAdapter is non-NULL.
Since the check isn't needed and I removed it instead of fixing it.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/bcm/InterfaceInit.c
|
| 44a17eff844d92421c8b568c84df29735e1e45f9 |
|
30-Sep-2010 |
Arnd Bergmann <arnd@arndb.de> |
staging/bcm: add sparse annotations
This marks up the code where sparse complains in most cases.
Most of the changes are in the ioctl handling code, which
gets __user annotations, finding one unchecked user access.
The rest is mostly about marking functions static when they
are only used in one file.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/bcm/InterfaceInit.c
|
| 9f1c75ac2dba752ad3734bd3ffab805a6a3fbeda |
|
30-Sep-2010 |
Arnd Bergmann <arnd@arndb.de> |
staging/bcm: fix most build warnings
This removes all warnings I get on a 64 bit build except
for those that look unfixable, where we convert a pointer
to a 32 bit integer and change its byte order!
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/bcm/InterfaceInit.c
|
| d16044cf8ce0ff6384cd80eb0abaa2ba57b19a5e |
|
30-Sep-2010 |
Arnd Bergmann <arnd@arndb.de> |
staging: make new character devices nonseekable
As a preparation for changing the default behaviour of llseek to no_llseek,
every file_operations structure should have a .llseek operation.
There are three new instances in staging now, which can all be changed
into no_llseek explicitly since the devices do not need to seek.
Add nonseekable_open where appropriate, to prevent pread/pwrite as well.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/bcm/InterfaceInit.c
|
| 5fe1f1edb916aa4f573563449ceccd1b468aedda |
|
15-Sep-2010 |
Randy Dunlap <randy.dunlap@oracle.com> |
staging/bcm: fix build for CONFIG_PM not enabled
Handle build case of CONFIG_PM not being enabled.
drivers/staging/bcm/InterfaceInit.c:280: error: 'struct usb_device' has no member named 'autosuspend_delay'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/bcm/InterfaceInit.c
|
| f8942e07a3db9d82e8fb11d3d494876b8bae9ff9 |
|
08-Sep-2010 |
Stephen Hemminger <stephen.hemminger@vyatta.com> |
staging: Beeceem USB Wimax driver
The Sprint 4G network uses a Wimax dongle with Beecem
chipset. The driver is typical of out of tree drivers, but
maybe useful for people, and the hardware is readily available.
Here is a staging ready version (i.e warts and all)
0. Started with Rel_5.2.7.3P1_USB from Sprint4GDeveloperPack-1.1
1. Consolidated files in staging
2. Remove Dos cr/lf
3. Remove unnecessary ioctl from usbbcm_fops
Applied patches that were in the developer pack, surprising
there were ones for 2.6.35 already.
This is compile tested only, see TODO for what still needs
to be done.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/bcm/InterfaceInit.c
|