41c7b7c0fa2f68afb1154e88597ff6b9b97334cf |
|
06-Nov-2011 |
Kevin McKinney <klmckinney1@gmail.com> |
Staging: bcm: Fix information leak in ioctl: IOCTL_BCM_REGISTER_READ_PRIVATE, IOCTL_BCM_EEPROM_REGISTER_READ This patch fixes an information leak in ioctl IOCTL_BCM_REGISTER_READ_PRIVATE and IOCTL_BCM_EEPROM_REGISTER_READ when determining the number of bytes to copy to user space. Function, usb_control_msg, returns the correct number of bytes from the hardware. Instead of using this value, we were using a value derived from user space. In this case, this value could be more than the hardware allocated. Therefore, this patch copies the proper number of bytes from the hardware, and uses this value as the maximum number of bytes for user space. Signed-off-by: Kevin McKinney <klmckinney1@gmail.com> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/bcm/nvm.c
|
e5969d55743c49dfca24e165a534cf5f2638e86b |
|
08-Aug-2011 |
Julia Lawall <julia@diku.dk> |
drivers/staging/bcm/nvm.c: add missing kfree Buff is only used as a temporary buffer within the function, so it should be freed before leaving the function in an error case. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @exists@ local idexpression x; statement S,S1; expression E; identifier fl; expression *ptr != NULL; @@ x = \(kmalloc\|kzalloc\|kcalloc\)(...); ... if (x == NULL) S <... when != x when != if (...) { <+...kfree(x)...+> } when any when != true x == NULL x->fl ...> ( if (x == NULL) S1 | if (...) { ... when != x when forall ( return \(0\|<+...x...+>\|ptr\); | * return ...; ) } ) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/bcm/nvm.c
|
25985edcedea6396277003854657b5f3cb31a628 |
|
31-Mar-2011 |
Lucas De Marchi <lucas.demarchi@profusion.mobi> |
Fix common misspellings Fixes generated by 'codespell' and manually reviewed. Signed-off-by: Lucas De Marchi <lucas.demarchi@profusion.mobi>
/drivers/staging/bcm/nvm.c
|
4ea4f7a0d3d7a9961bf77f0860df8dd4a213b8a3 |
|
01-Nov-2010 |
Stephen Hemminger <stephen.hemminger@vyatta.com> |
beceem: change startup messages Change the regsister/unregister routines to generate better messages, and control arrival of new frames when USB device is unplugged. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
/drivers/staging/bcm/nvm.c
|
9dd47ee7dd535649a2c32d509631c7a3d793f2e1 |
|
01-Nov-2010 |
Stephen Hemminger <stephen.hemminger@vyatta.com> |
beceem: make local functions static Use namespace tool from kernel scripts to identify dead code and functions that should be static. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
/drivers/staging/bcm/nvm.c
|
3644c1a2f12b15e1c8bfb9ebfaacbd177011a72d |
|
01-Nov-2010 |
Stephen Hemminger <stephen.hemminger@vyatta.com> |
beceem: remove dead code Remove commented out with '#if 0' Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
/drivers/staging/bcm/nvm.c
|
082e889b475c46e71be6e779f15ab095f888e03f |
|
01-Nov-2010 |
Stephen Hemminger <stephen.hemminger@vyatta.com> |
beceem: remove OS wrapper library Use native kernel functions for kmalloc/kfree directly Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
/drivers/staging/bcm/nvm.c
|
91d29ee1a82fedcd7d1bbf24007b31a49c47e90a |
|
29-Oct-2010 |
Stephen Hemminger <stephen.hemminger@vyatta.com> |
beceem: remove ifdef's There were a lot of ifdef's for driver options which have no configuration options. Choose the current value and remove the ifdef. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
/drivers/staging/bcm/nvm.c
|
44a17eff844d92421c8b568c84df29735e1e45f9 |
|
30-Sep-2010 |
Arnd Bergmann <arnd@arndb.de> |
staging/bcm: add sparse annotations This marks up the code where sparse complains in most cases. Most of the changes are in the ioctl handling code, which gets __user annotations, finding one unchecked user access. The rest is mostly about marking functions static when they are only used in one file. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/bcm/nvm.c
|
f8942e07a3db9d82e8fb11d3d494876b8bae9ff9 |
|
08-Sep-2010 |
Stephen Hemminger <stephen.hemminger@vyatta.com> |
staging: Beeceem USB Wimax driver The Sprint 4G network uses a Wimax dongle with Beecem chipset. The driver is typical of out of tree drivers, but maybe useful for people, and the hardware is readily available. Here is a staging ready version (i.e warts and all) 0. Started with Rel_5.2.7.3P1_USB from Sprint4GDeveloperPack-1.1 1. Consolidated files in staging 2. Remove Dos cr/lf 3. Remove unnecessary ioctl from usbbcm_fops Applied patches that were in the developer pack, surprising there were ones for 2.6.35 already. This is compile tested only, see TODO for what still needs to be done. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/bcm/nvm.c
|