| 201320435d017e8ebd449034547ef0518ec4d056 |
|
30-Nov-2011 |
Xi Wang <xi.wang@gmail.com> |
staging: vt6656: integer overflows in private_ioctl()
There are two potential integer overflows in private_ioctl() if
userspace passes in a large sList.uItem / sNodeList.uItem. The
subsequent call to kmalloc() would allocate a small buffer, leading
to a memory corruption.
Reported-by: Dan Rosenberg <drosenberg@vsecurity.com>
Signed-off-by: Xi Wang <xi.wang@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/vt6656/ioctl.c
|
| 44ec5d29169426b00fe054f0a13744140de29e11 |
|
20-Oct-2011 |
Dan Carpenter <dan.carpenter@oracle.com> |
Staging: vt6656: add some range checks before memcpy()
We need to verify that we're not writing past the end of the array.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/vt6656/ioctl.c
|
| 883aeecc9ddc120e34a1157aee37738a4e96b517 |
|
20-Oct-2011 |
Dan Carpenter <dan.carpenter@oracle.com> |
Staging: vt6656: whitespace cleanups in ioctl.c
The indents on this file didn't line up so it was hard to work with.
I changed other white space issues as I came across them. I also
deleted or changed some couple comments and the comment style.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/vt6656/ioctl.c
|
| de0920b1fedb4d694fe4732cfc3cccfcd4743f84 |
|
23-Sep-2011 |
Dan Carpenter <dan.carpenter@oracle.com> |
Staging: vt6655-6: potential info leak in private_ioctl()
Smatch has a new check for Rosenberg type information leaks where
structs are copied to the user with uninitialized stack data in them.
In this path, the .uLinkRate member doesn't get initialized so I've
set it to zero.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/vt6656/ioctl.c
|
| 273f4bef1847ef69f30d7e55f8de876a92639f17 |
|
10-Apr-2011 |
Joe Perches <joe@perches.com> |
staging: Remove unnecessary semicolons when for (foo) {...};
Done via perl script:
$ cat remove_semi_for.pl
my $match_balanced_parentheses = qr/(\((?:[^\(\)]++|(?-1))*\))/;
my $match_balanced_braces = qr/(\{(?:[^\{\}]++|(?-1))*\})/;
foreach my $file (@ARGV) {
my $f;
my $text;
my $oldtext;
next if ((-d $file));
open($f, '<', $file)
or die "$P: Can't open $file for read\n";
$oldtext = do { local($/) ; <$f> };
close($f);
next if ($oldtext eq "");
$text = $oldtext;
my $count = 0;
do {
$count = 0;
$count += $text =~ s@\b(for\s*${match_balanced_parentheses}\s*)${match_balanced_braces}\s*;@"$1$3"@egx;
} while ($count > 0);
if ($text ne $oldtext) {
my $newfile = $file;
open($f, '>', $newfile)
or die "$P: Can't open $newfile for write\n";
print $f $text;
close($f);
}
}
$
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/vt6656/ioctl.c
|
| 9fc86028fa21f8831c0fdc701732cf491da1202c |
|
10-Apr-2011 |
Joe Perches <joe@perches.com> |
staging: Remove unnecessary semicolons when if (foo) {...};
Done via perl script:
$ cat remove_semi_if.pl
my $match_balanced_parentheses = qr/(\((?:[^\(\)]++|(?-1))*\))/;
my $match_balanced_braces = qr/(\{(?:[^\{\}]++|(?-1))*\})/;
foreach my $file (@ARGV) {
my $f;
my $text;
my $oldtext;
next if ((-d $file));
open($f, '<', $file)
or die "$P: Can't open $file for read\n";
$oldtext = do { local($/) ; <$f> };
close($f);
next if ($oldtext eq "");
$text = $oldtext;
my $count = 0;
do {
$count = 0;
$count += $text =~ s@\b(if\s*${match_balanced_parentheses}\s*)${match_balanced_braces}\s*;@"$1$3"@egx;
} while ($count > 0);
if ($text ne $oldtext) {
my $newfile = $file;
open($f, '>', $newfile)
or die "$P: Can't open $newfile for write\n";
print $f $text;
close($f);
}
}
$
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/vt6656/ioctl.c
|
| 465711b39d2fb326c5be27a4f69f70b2a41612cf |
|
04-Aug-2010 |
Andres More <more.andres@gmail.com> |
staging: vt6656: removed not useful comments
Removed comments about who changed/added lines, they do not seem useful.
Signed-off-by: Andres More <more.andres@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/vt6656/ioctl.c
|
| 24fe608a2d4d78cc1a5f5424a4db5c13e3a00983 |
|
12-Jul-2010 |
Andres More <more.andres@gmail.com> |
staging: vt6656: removed WPA_SM_Transtatus definition
Removed an always defined macro, perhaps used to patch the driver
Signed-off-by: Andres More <more.andres@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/vt6656/ioctl.c
|
| 5583dcf587fa59a5de10b554815f3121919f2648 |
|
26-Jun-2010 |
Andres More <more.andres@gmail.com> |
staging: vt6656: removed SndEvt_ToAPI definition
Removed an always defined macro, perhaps used to patch the driver
Signed-off-by: Andres More <more.andres@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/vt6656/ioctl.c
|
| 33d33e42b647095b01b1223c7b88718584129d2e |
|
20-May-2010 |
Andres More <more.andres@gmail.com> |
Staging: vt6656: code cleanup, fixed 'for' statements
Resolved checkpatch findings, but some long lines warnings.
ERROR: space required before the open parenthesis '('
ERROR: spaces required around that
Signed-off-by: Andres More <more.andres@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/vt6656/ioctl.c
|
| cc856e61ee4ffb150ff352e3d6940978a2f819e8 |
|
18-May-2010 |
Andres More <more.andres@gmail.com> |
Staging: vt6656: removed custom UCHAR/USHORT/UINT/ULONG/ULONGLONG typedefs
Cleared all checkpatch warnings but 'do not add new typedefs' ones.
Signed-off-by: Andres More <more.andres@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/vt6656/ioctl.c
|
| 213d2e9322ed509c2f80b07d7feb4427ebcd7b0b |
|
18-May-2010 |
Andres More <more.andres@gmail.com> |
Staging: vt6656: removed custom CHAR/SHORT/INT/LONG typedefs
Cleared all checkpatch warnings but one 'do not add new typedefs'
Signed-off-by: Andres More <more.andres@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/vt6656/ioctl.c
|
| 0cbd8d9854284d3ff38d04aaa3ae726fb1c4a958 |
|
07-May-2010 |
Andres More <more.andres@gmail.com> |
staging: vt6656: code cleanup, removed HANDLE definition in ttype.h
Checkpatch warnings about using externs in .c files were not resolved,
neither some long lines on deeply nested code.
Signed-off-by: Andres More <more.andres@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/vt6656/ioctl.c
|
| c30d7973f22ea3f8b3e5d1d7215b3f2ff8f5e934 |
|
17-Apr-2010 |
Forest Bond <forest@alittletooquiet.net> |
Staging: vt6656: Rename hostap_set_hostapd, hostap_iotctl.
The functions hostap_set_hostapd, hostap_iotctl clashed with functions of the
same name with CONFIG_HOSTAP=y and/or CONFIG_VT6655=y.
Signed-off-by: Forest Bond <forest@alittletooquiet.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/vt6656/ioctl.c
|
| 9a0e756c5280750c23bd44d2b855a1f5442ea7b4 |
|
14-Apr-2010 |
Andres More <more.andres@gmail.com> |
Staging: vt6656: incorporated ETH_ALEN macro instead of custom one
Replaced custom U_ETHER_ADDR_LEN by ETH_ALEN from <linux/if_ether.h>.
Resolved checkpatch findings on the changed lines, mostly indentation.
Signed-off-by: Andres More <more.andres@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/vt6656/ioctl.c
|
| bbc9a9916bc1cd997f3bf303e7930d5f3c804d37 |
|
14-Nov-2009 |
André Goddard Rosa <andre.goddard@gmail.com> |
Staging: fix assorted typos all over the place
Signed-off-by: André Goddard Rosa <andre.goddard@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/vt6656/ioctl.c
|
| 3e362598fd3c7b8729afd0383a4cdf08849b020e |
|
12-Aug-2009 |
Jim Lieb <lieb@canonical.com> |
Staging: vt665x: Remove umem.h Part 2
Remove references to umem.h macros and refer directly to memcpy
functions. Delete the include file.
Signed-off-by: Jim Lieb <lieb@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/vt6656/ioctl.c
|
| 9d26d60f99855056a20ac7c0b68eb5ed04619831 |
|
12-Aug-2009 |
Jim Lieb <lieb@canonical.com> |
Staging: vt665x: Clean up include files, Part 1
Remove cplusplus lines from include files
Remove needless ifdefs on includes to conform with C
conventions. Remove misc commented code/includes
Update TODO
Signed-off-by: Jim Lieb <lieb@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/vt6656/ioctl.c
|
| 92b96797118e5836294a6d42a5a8e10b86f50e3f |
|
13-Jun-2009 |
Forest Bond <forest@alittletooquiet.net> |
Staging: Add pristine upstream vt6656 driver sources to drivers/staging/vt6656.
Add pristine upstream vt6656 driver sources to drivers/staging/vt6656. These
files were copied from the driver directory in the upstream source archive,
available here:
http://www.viaarena.com/Driver/VT6656_Linux_src_v1.19_12_x86.zip
After copying, trailing whitespace was stripped. This is GPL-licensed code.
Signed-off-by: Forest Bond <forest@alittletooquiet.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/vt6656/ioctl.c
|