| 23567c75286f63f77e5ec6bab7f46e0161d75356 |
|
05-Jun-2011 |
Joseph Salisbury <salisbury.joseph@googlemail.com> |
Staging: wlan-ng: fix brace coding style issue in prism2fw.c
This is a patch to the prism2fw.c file that fixes up a brace
warning found by the checkpatch.pl tool.
Signed-off-by: Joseph Salisbury <salisbury.joseph@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/wlan-ng/prism2fw.c
|
| a6f9c48fdd566e09d437e104c5b5963133db1be4 |
|
13-Mar-2011 |
Ilia Mirkin <imirkin@alum.mit.edu> |
staging: wlan-ng: Remove NULL check before kfree
This patch was generated by the following semantic patch:
// <smpl>
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);
@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;
// </smpl>
Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/wlan-ng/prism2fw.c
|
| 3d049431e08a847a222e20f406332529751b4365 |
|
02-Aug-2010 |
Edgardo Hames <ehames@gmail.com> |
Staging: wlan-ng: remove typedef in p80211hdr.h
This patch removes the only typedef in p80211hdr.h.
Signed-off-by: Edgardo Hames <ehames@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/wlan-ng/prism2fw.c
|
| b6bb56e6aa28085550179335247c649752ff2994 |
|
02-Aug-2010 |
Edgardo Hames <ehames@gmail.com> |
Staging: wlan-ng: fix checkpatch issues in headers.
This patch fix errors and warnings reported by checkpatch
in p80211meta.h and p80211metstruct.h.
Signed-off-by: Edgardo Hames <ehames@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/wlan-ng/prism2fw.c
|
| e02644184c0e925206f3cf19fd681065a507f05c |
|
22-Jul-2010 |
Edgardo Hames <ehames@gmail.com> |
Staging: wlan-ng: removed typedef from prism2fw.c
Removed multiple typedef and fixed long lines.
Signed-off-by: Edgardo Hames <ehames@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/wlan-ng/prism2fw.c
|
| 7a6cb0d5497418599d2125b670926b75e673861c |
|
13-May-2010 |
Julia Lawall <julia@diku.dk> |
Staging: Use kcalloc or kzalloc
Use kcalloc or kzalloc rather than the combination of kmalloc and memset.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression x,y,flags;
statement S;
type T;
@@
x =
- kmalloc
+ kcalloc
(
- y * sizeof(T),
+ y, sizeof(T),
flags);
if (x == NULL) S
-memset(x, 0, y * sizeof(T));
@@
expression x,size,flags;
statement S;
@@
-x = kmalloc(size,flags);
+x = kzalloc(size,flags);
if (x == NULL) S
-memset(x, 0, size);
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
/drivers/staging/wlan-ng/prism2fw.c
|
| a05d08c40c0775e4691cffcfbfceeb4270987208 |
|
11-May-2010 |
Zachary Richey <zr.public@gmail.com> |
Staging: wlan-ng: Fixed non static functions in prism2fw.c
Fixed non static functions in prism2fw.c
Signed-off-by: Zachary Richey <zr.public@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/wlan-ng/prism2fw.c
|
| 5a0e3ad6af8660be21ca98a971cd00f331318c05 |
|
24-Mar-2010 |
Tejun Heo <tj@kernel.org> |
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
/drivers/staging/wlan-ng/prism2fw.c
|
| b02957d58a27525499ab10d272d3b44682a7ae50 |
|
04-Mar-2010 |
Greg Kroah-Hartman <gregkh@suse.de> |
Staging: Merge two branches of coding style fixes together
Turns out that multiple people sent pretty much the same patch
for the same staging drivers. Commit these in two different
branches and merge them together to get a more complete coverage
of the cleanup and properly credit everyone for the work that they
did.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
| ef1a0ed7f1793531e5fb3ee489cb1e2b627f76fd |
|
18-Feb-2010 |
Andrew Elwell <andrew.elwell@gmail.com> |
Staging: wlan-ng - checkpatch.pl fixups
Basic fixups in the staging/wlan-ng directory.
(First kernel patch - thanks to FOSDEM talk)
Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/wlan-ng/prism2fw.c
|
| 83a0f9bc658b20b06740691d9ee711c5d14b6e8a |
|
25-Feb-2010 |
Randy Dunlap <randy.dunlap@oracle.com> |
Staging: fix wlan-ng printk format warning
Fix prism2fw.c printk format warning:
drivers/staging/wlan-ng/prism2fw.c:209: warning: format '%d' expects type 'int', but argument 3 has type 'size_t'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/wlan-ng/prism2fw.c
|
| 5dd8acc8fd6b0476a2dc49bc6de4712d22c368c0 |
|
14-Feb-2010 |
Svenne Krap <svenne@krap.dk> |
Staging: wlan-ng: multiple safe style cleanups
Cleanups as suggested by checkpatch.pl utiltiy.
.o's from before and after cleanup have matching SHA1s.
Signed-off-by: Svenne Krap <svenne@krap.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/wlan-ng/prism2fw.c
|
| 5d929a71908968905331cda0d52c44570d402110 |
|
14-Jan-2010 |
Ben Hutchings <ben@decadent.org.uk> |
staging: declare MODULE_FIRMWARE in various drivers
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/wlan-ng/prism2fw.c
|
| 4068fe8b2aa3e12643db0ad5dd4bcf6755a7320f |
|
09-Dec-2009 |
Julia Lawall <julia@diku.dk> |
Staging: wlan-ng: fix Correct size given to memset
Memset should be given the size of the structure, not the size of the pointer.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
type T;
T *x;
expression E;
@@
memset(x, E, sizeof(
+ *
x))
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/wlan-ng/prism2fw.c
|
| d89505998e007f88e08e84381dcc720a8990507d |
|
19-Aug-2009 |
Karl Relton <karllinuxtest.relton@ntlworld.com> |
Staging: wlan-ng: Convert firmware loading to load binary ihex format
Convert prism2_usb firmware loading to load firmware in pre-compiled
binary 'ihex' format rather than ascii 'srec' format. This moves the
srec processing and sorting of records out of kernel space into a
pre-compiler. The driver now just works with the binary image, but
still does the 'pda plugging' of that image at runtime, as required
by the prism hardware.
Some Notes:
- The firmware is now expected to be in the same 'ihex' (.fw) format
used by other drivers.
- The now driver assumes the data records are already sorted into ascending
address order.
- Plug and crc records are still recognised by special address locations
as in original srec processing.
- The srec S7 start address record is assumed to have been converted
into a data record with another special address location (0xff400000),
with the original start address being stored as a 4 byte data word
(little endian).
Signed-off-by: Karl Relton <karllinuxtest.relton@ntlworld.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/wlan-ng/prism2fw.c
|
| 297f06cea635ea4552541a11e7fb7014425110c6 |
|
10-Jun-2009 |
Mithlesh Thukral <mithlesh@linsyssoft.com> |
staging: wlan-ng: scripts/checkpatch.pl error fixes.
scripts/checkpatch.pl error fixes. This is a TODO item.
This patch fixes most of the errors reported by checkpatch.pl in
wlan-ng directory of staging tree.
Signed-off-by: Mithlesh Thukral <mithlesh@linsyssoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/wlan-ng/prism2fw.c
|
| 75f49e07520d036c2a0903694fdc0bcfb5523b76 |
|
25-May-2009 |
Mithlesh Thukral <mithlesh@linsyssoft.com> |
Staging: wlan-ng: Lindent cleanups
Lindent script cleanups in wlan-ng driver in the staging tree.
This is a item in the TODO list.
Signed-off-by: Mithlesh Thukral <mithlesh@linsyssoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/wlan-ng/prism2fw.c
|
| 76e3e7c4095237ceeb962e3bd8bdc0797fb943e1 |
|
17-Apr-2009 |
Karl Relton <karllinuxtest.relton@ntlworld.com> |
Staging: wlan-ng: Move firmware loading into driver
Move prism2 firmware loading from userspace into driver, using linux
request_firmware(). Firmware is now loaded (if available) on device
probing, before it is registered as a netdevice and advertised to userspace.
Signed-off-by: Karl Relton <karllinuxtest.relton@ntlworld.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/wlan-ng/prism2fw.c
|