| 6a915c2bf073743dd31229f1ec2eaa7a2b13c1c3 |
|
29-Oct-2010 |
Kyle McMartin <kyle@mcmartin.ca> |
parisc-agp: fix missing slab.h include
Commit 338e4fab added a missing kfree if the alloc_pci_dev failed
but forgot to include <linux/slab.h> for the definition of
kfree.
Signed-off-by: Kyle McMartin <kyle@redhat.com>
|
| 338e4fab3d41aa14264e10ce505a7c908633cdad |
|
21-Oct-2010 |
Julia Lawall <julia@diku.dk> |
drivers/char/agp/parisc-agp.c: eliminate memory leak
alloc_pci_dev allocates some memory, so that memory should be freed before
leaving the function in an error case.
A simplified version of the semantic match that finds this problem is:
(http://coccinelle.lip6.fr/)
// <smpl>
@r exists@
local idexpression x;
expression E;
identifier f1;
iterator I;
@@
x = alloc_pci_dev(...);
<... when != x
when != true (x == NULL || ...)
when != if (...) { <+...x...+> }
when != I (...) { <+...x...+> }
(
x == NULL
|
x == E
|
x->f1
)
...>
* return ...;
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Dan Carpenter <error27@gmail.com>
Dave Airlie <airlied@linux.ie>
Cc: Helge Deller <deller@gmx.de>
Cc: "James E.J. Bottomley" <jejb@parisc-linux.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Kyle McMartin <kyle@redhat.com>
|
| 4ef8774cb45c3cf78c7a2d7a1a42f6aee7eda3b2 |
|
27-Sep-2009 |
Helge Deller <deller@gmx.de> |
agp: parisc-agp.c - use correct page_mask function
This commit:
Commit 2a4ceb6d3e6a566cb4a9dc8f974177f031d27cd7
Author: David Woodhouse <David.Woodhouse@intel.com>
Date: Mon Jul 27 10:27:29 2009 +0100
agp: Switch mask_memory() method to take address argument again, not page
broke the parisc AGP driver (again). This patch fixes it.
Signed-off-by: Helge Deller <deller@gmx.de>
Acked-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Kyle McMartin <kyle@mcmartin.ca>
|
| 2a4ceb6d3e6a566cb4a9dc8f974177f031d27cd7 |
|
27-Jul-2009 |
David Woodhouse <David.Woodhouse@intel.com> |
agp: Switch mask_memory() method to take address argument again, not page
In commit 07613ba2 ("agp: switch AGP to use page array instead of
unsigned long array") we switched the mask_memory() method to take a
'struct page *' instead of an address. This is painful, because in some
cases it has to be an IOMMU-mapped virtual bus address (in fact,
shouldn't it _always_ be a dma_addr_t returned from pci_map_xxx(), and
we just happen to get lucky most of the time?)
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
|
| c43962321e8af5309dd3ffcd78743c89581265e5 |
|
02-Aug-2009 |
Helge Deller <deller@gmx.de> |
parisc: parisc-agp.c - use correct page_mask function
Fix those compiler warnings, which indeed point to a bug:
drivers/char/agp/parisc-agp.c:228: warning: initialization from incompatible pointer type
drivers/char/agp/parisc-agp.c:201: warning: 'parisc_agp_page_mask_memory' defined but not used
Signed-off-by: Helge Deller <deller@gmx.de>
|
| 07613ba2f464f59949266f4337b75b91eb610795 |
|
12-Jun-2009 |
Dave Airlie <airlied@redhat.com> |
agp: switch AGP to use page array instead of unsigned long array
This switches AGP to use an array of pages for tracking the
pages allocated to the GART. This should enable GEM on PAE to work
a lot better as we can pass highmem pages to the PAT code and it will
do the right thing with them.
Signed-off-by: Dave Airlie <airlied@redhat.com>
|
| bfe4f4f800ccbb499a1120735016a20d3feacd4f |
|
10-Jan-2009 |
James Bottomley <James.Bottomley@HansenPartnership.com> |
parisc: remove klist iterators
commit 11c3b5c3e08f4d855cbef52883c266b9ab9df879
Author: Greg Kroah-Hartman <gregkh@suse.de>
Date: Tue Dec 16 12:24:56 2008 -0800
driver core: move klist_children into private structure
Broke our parisc build pretty badly because we touch the klists directly
in three cases (AGP, SBA and GSC). Although GregKH will revert this
patch, there's no reason we should be using the iterators directly, we
can just move to the standard device_for_each_child() API.
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Tested-by: Helge Deller <deller@gmx.de>
Tested-by: Kyle McMartin <kyle@mcmartin.ca>
Signed-off-by: Kyle McMartin <kyle@mcmartin.ca>
|
| 98f172b257725de516a792b810b08639d6293d4d |
|
28-Jul-2008 |
Kyle McMartin <kyle@mcmartin.ca> |
parisc: parisc-agp - fix <asm-parisc/*> -> <asm/*>
|
| 5f310b63781f6777bf4e812570560ec0f8ea42d8 |
|
21-Aug-2008 |
Rene Herman <rene.herman@keyaccess.nl> |
agp: enable optimized agp_alloc_pages methods
The pageattr-array patch that you currently have in tip/master only
enables it for intel-agp, not the others. The attached enables it for
all drivers currently directly using agp_generic_alloc_page() and
agp_generic_destroy_page() (ocal driver is amd-k7-agp).
The new agp_generic_alloc_pages() interface uses the also new
pageattr array interface API. This makes all AGP drivers that
up to now used generic_{alloc,destroy}_page() use it.
Signed-off-by: Rene Herman <rene.herman@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
|
| c72580129209aaa509ace81c1f2ee1caa9c9774b |
|
26-Mar-2008 |
Joe Perches <joe@perches.com> |
drivers/char/agp - use bool
Use boolean in AGP instead of having own TRUE/FALSE
--
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
|
| e57aa839cea13852e07ecb495692b602b11136c9 |
|
17-Oct-2007 |
Fengguang Wu <fengguang.wu@gmail.com> |
convert ill defined log2() to ilog2()
It's *wrong* to have
#define log2(n) ffz(~(n))
It should be *reversed*:
#define log2(n) flz(~(n))
or
#define log2(n) fls(n)
or just use
ilog2(n) defined in linux/log2.h.
This patch follows the last solution, recommended by Andrew Morton.
Cc: <linux-ext4@vger.kernel.org>
Cc: Mingming Cao <cmm@us.ibm.com>
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Chris Ahna <christopher.j.ahna@intel.com>
Cc: David Mosberger-Tang <davidm@hpl.hp.com>
Cc: Kyle McMartin <kyle@parisc-linux.org>
Cc: Dave Airlie <airlied@linux.ie>
Cc: Dave Jones <davej@codemonkey.org.uk>
Signed-off-by: Fengguang Wu <wfg@mail.ustc.edu.cn>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
|
| bab41e9be75121c473b00df2ffa33af3c44066a7 |
|
05-Apr-2007 |
Michael Ellerman <michael@ellerman.id.au> |
PCI: Convert to alloc_pci_dev()
Convert code that allocs a struct pci_dev to use alloc_pci_dev().
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
| fb55a0debee81280684b68713024d0c5e62e8aa5 |
|
27-Feb-2007 |
Kyle McMartin <kyle@mako.i.cabal.ca> |
[PARISC] parisc-agp: Fix thinko const-ifying
Can't really blame davej for mucking this up... static-ify
it while we're at it, which would have prevented this...
Signed-off-by: Kyle McMartin <kyle@parisc-linux.org>
|
| e5524f355a0d272ba5233537a896a668db1f3008 |
|
23-Feb-2007 |
Dave Jones <davej@redhat.com> |
[AGPGART] Further constification.
Make agp_bridge_driver->aperture_sizes and ->masks const.
Also agp_bridge_data->driver
Signed-off-by: Dave Jones <davej@redhat.com>
|
| bf1e5989aa5783726c6a94931f92b34aa387ec30 |
|
05-Feb-2007 |
Thomas Hellstrom <thomas@tungstengraphics.com> |
[AGPGART] Add agp-type-to-mask-type method missing from some drivers.
Signed-off-by: Dave Jones <davej@redhat.com>
|
| 423c8ece2941a7ee9b003564d5aab789b9b330d8 |
|
24-Oct-2006 |
Matthew Wilcox <matthew@wil.cx> |
[PARISC] parisc-agp: Fix integer/pointer warning
Signed-off-by: Matthew Wilcox <matthew@wil.cx>
Signed-off-by: Kyle McMartin <kyle@parisc-linux.org>
|
| 08a6436816f7a16113c73be767ee8d50440e494e |
|
25-Aug-2006 |
Kyle McMartin <kyle@parisc-linux.org> |
[PARISC] Add support for Quicksilver AGPGART
Signed-off-by: Kyle McMartin <kyle@parisc-linux.org>
|