History log of /drivers/hid/hid-roccat-koneplus.c
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
901e64dbdb5998b9248c372a401c921bbdf662f6 12-Jun-2011 Stefan Achatz <erazor_de@users.sourceforge.net> HID: roccat: fix NULL pointer dereference, add range checks

On rare occassions raw events can be triggered before drvdata gets set up
which leads to NULL pointer dereferences. This was only observed with pyra on
2.6.39, but is fixed for all devices now to play it save.
kovaplus returned wrong actual values when profile change was initiated from host.
Added range checks for setting actual profile on all devices.

Signed-off-by: Stefan Achatz <erazor_de@users.sourceforge.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
/drivers/hid/hid-roccat-koneplus.c
1edd5b42a6631b1b1f147e9018e309bde8d96a05 01-Jun-2011 Stefan Achatz <erazor_de@users.sourceforge.net> HID: roccat: correction and cleanup of HID feature reports

Removed analog feature report enums and modified code in roccat_common
to reflect this. Non standard conform Kone got its own copy of the old
code. That helps extracting more generalizations for newer devices.

Signed-off-by: Stefan Achatz <erazor_de@users.sourceforge.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
/drivers/hid/hid-roccat-koneplus.c
6d1dec85afa7306e66fff633689ff06195ad079a 29-May-2011 Stefan Achatz <erazor_de@users.sourceforge.net> HID: roccat: Add "Roccat Talk" support for koneplus

Added binary sysfs attribute to support new functionality the manufacturer
added to koneplus.

Signed-off-by: Stefan Achatz <erazor_de@users.sourceforge.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
/drivers/hid/hid-roccat-koneplus.c
b50f315cbb865079a16a12fd9ae6083f98fd592c 13-Apr-2011 Stefan Achatz <erazor_de@users.sourceforge.net> HID: roccat: fix actual/startup profile sysfs attribute in koneplus

startup_profile and actual_profile didn't work as expected. Also
as the actual profile is persistent, the distinction between the
two was ambiguous, so both use the same code now and startup_profile
has been deprecated. Also the event is now propagated through
chardev. The userland tool has been updated to support this change.

Signed-off-by: Stefan Achatz <erazor_de@users.sourceforge.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
/drivers/hid/hid-roccat-koneplus.c
61c29f5b1856f90bf0a87d83cfa035a11986d2c5 14-Mar-2011 Stefan Achatz <erazor_de@users.sourceforge.net> HID: roccat-koneplus: vorrect mode of sysfs attr 'sensor'

Mode of sysfs attribute 'sensor' was wrongly set to writeonly.
Corrected this to readwrite.

Signed-off-by: Stefan Achatz <erazor_de@users.sourceforge.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
/drivers/hid/hid-roccat-koneplus.c
5dc0c9835fb96c75c8dbf657393764bd0abbac04 03-Feb-2011 Stefan Achatz <erazor_de@users.sourceforge.net> HID: roccat: Rename header roccat.h -> hid-roccat.h

It was desired that the header roccat.h should be named hid-roccat.h

Signed-off-by: Stefan Achatz <erazor_de@users.sourceforge.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
/drivers/hid/hid-roccat-koneplus.c
74b643dac475e29f53f4132d2349ec1dba3c9e44 30-Jan-2011 Stefan Achatz <erazor_de@users.sourceforge.net> HID: roccat: Fix NULL pointer dereference when unloading module

Class was destroyed before starting the unregistering driver chain.
Disconnecting a device from roccat chardev in this process then
raised a NULL pointer dereference.
Fixed this by destroying class after unregistering driver.

Signed-off-by: Stefan Achatz <erazor_de@users.sourceforge.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
/drivers/hid/hid-roccat-koneplus.c
8211e46004518c977f70f2661da961d5ba617399 30-Jan-2011 Stefan Achatz <erazor_de@users.sourceforge.net> HID: roccat: Add ioctl command to retreive report size from chardev

Roccat chardev was reworked to support only a defined report size per
device and this can be retreived by an ioctl now to enable future changes
in report definitions.
Header was moved/renamed from drivers/hid to include/linux for accessibility.

Signed-off-by: Stefan Achatz <erazor_de@users.sourceforge.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
/drivers/hid/hid-roccat-koneplus.c
432762e28b8146d0feff61cc8063b26c517acf26 30-Jan-2011 Stefan Achatz <erazor_de@users.sourceforge.net> HID: roccat: Increase waiting time for Kone[+] to prevent occasional freezes

On newer kernels the device freezes occasionally on initialization with just
70msec between reads. Increased this value to safe 100msec.

Signed-off-by: Stefan Achatz <erazor_de@users.sourceforge.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
/drivers/hid/hid-roccat-koneplus.c
5772f63613ce0a6777e82a7e8fb553e49da27719 30-Jan-2011 Stefan Achatz <erazor_de@users.sourceforge.net> HID: roccat: Introduce module hid-roccat-common

Module hid-roccat-common contains functions used by roccat device driver
modules to reduce code duplication.
At the moment it contains just two wrapper methods for usb_control_msg
that ensure that the buffer used for transfer is dma capable which wasn't
the case before.
The kconfig option is not visible to the user but will be selected by the
device specific drivers.

Signed-off-by: Stefan Achatz <erazor_de@users.sourceforge.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
/drivers/hid/hid-roccat-koneplus.c
a28764ef80dd5aef657f810a9c295ccda421c823 30-Jan-2011 Stefan Achatz <erazor_de@users.sourceforge.net> HID: roccat: Use new hid_err macros

Using the new hid_err macros instead of dev_err.

Signed-off-by: Stefan Achatz <erazor_de@users.sourceforge.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
/drivers/hid/hid-roccat-koneplus.c
fd82be6c0a359fc706a805a49b1f167af21e63ea 06-Jan-2011 Stefan Achatz <erazor_de@users.sourceforge.net> HID: roccat: Fix an error message when reading more data from bin attributes

Using cat or something to read from binary attributes would try to do an
additional read with offset equal to filesize. This resulted in an invalid
attribute error. This is fixed by giving the right answer instead of EINVAL.

Signed-off-by: Stefan Achatz <erazor_de@users.sourceforge.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
/drivers/hid/hid-roccat-koneplus.c
dacfecdbf3a0a5072984ff8b3c224a48c8461008 17-Jan-2011 Vasiliy Kulikov <segoon@openwall.com> HID: hid-roccat-koneplus: potential NULL dereference

kmalloc() may fail, if so return -ENOMEM.
Also koneplus_init_koneplus_device_struct() should check return code
of koneplus_get_startup_profile() and propagate its return code.

Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
/drivers/hid/hid-roccat-koneplus.c
47dbdbffe15b9582a41727766d43f1d4208e977e 26-Nov-2010 Stefan Achatz <erazor_de@users.sourceforge.net> HID: roccat: Add support for Roccat Kone[+] v2

This patch adds support for Roccat Kone[+] gaming mouse. Kone[+] is an enhanced version
of the old Kone with more memory for macros, a better sensor and more functionality.
This driver is conceptual similar to the existing Kone and Pyra drivers.
Userland tools can soon be found at http://sourceforge.net/projects/roccat

Signed-off-by: Stefan Achatz <erazor_de@users.sourceforge.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
/drivers/hid/hid-roccat-koneplus.c