| 1b92c1cf6b638e7cbe9fdaac3f6efb8874f5cc02 |
|
17-Mar-2012 |
Axel Lin <axel.lin@gmail.com> |
Input: convert I2C drivers to use module_i2c_driver()
This patch converts the drivers in drivers/input/* to use the
module_i2c_driver() macro which makes the code smaller and a bit
simpler.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
/drivers/input/misc/pcf8574_keypad.c
|
| 10ee2ded629b1571cef1182728d6f65dbe4c7f79 |
|
11-Nov-2010 |
Dmitry Torokhov <dmitry.torokhov@gmail.com> |
Input: pcf_keypad - convert to dev_op_ops
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
/drivers/input/misc/pcf8574_keypad.c
|
| 17d01f28e160f8a9c9ecda2e335d0047ec9e7388 |
|
11-Nov-2010 |
Dan Carpenter <error27@gmail.com> |
Input: pcf8574_keypad - fix error handling in pcf8574_kp_probe
It is not allowed to call input_free_device() after calling
input_unregister_device() because input devices are refcounted and
unregister will free the device if we were holding he last referenc.
The preferred style in input/ is to make input_register_device() the
last function in the probe which can fail. That way we don't need to
call input_unregister_device().
Also do not need to call input_set_drvdata() as nothing in the driver
uses the data.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
/drivers/input/misc/pcf8574_keypad.c
|
| 0e789314f8c0b50bd19bf08dc5624b9604d60183 |
|
22-Jun-2010 |
Dmitry Torokhov <dmitry.torokhov@gmail.com> |
Merge commit 'v2.6.35-rc3' into for-linus
|
| 0b75f775288b90a83a8708a5af663a03d4bbc9ce |
|
05-Jun-2010 |
Dan Carpenter <error27@gmail.com> |
Input: pcf8574_keypad - fix off by one in pcf8574_kp_irq_handler()
If nextstate == ARRAY_SIZE(lp->btncode), then we read one past the end of
the array on the next line.
This fixes a smatch warning:
drivers/input/misc/pcf8574_keypad.c +74 pcf8574_kp_irq_handler(8)
error: buffer overflow 'lp->btncode' 17 <= 17
Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
/drivers/input/misc/pcf8574_keypad.c
|
| fbae3fb1546e199ab0cd185348f8124411a1ca9d |
|
03-Jun-2010 |
Wolfram Sang <w.sang@pengutronix.de> |
i2c: Remove all i2c_set_clientdata(client, NULL) in drivers
I2C drivers can use the clientdata-pointer to point to private data. As I2C
devices are not really unregistered, but merely detached from their driver, it
used to be the drivers obligation to clear this pointer during remove() or a
failed probe(). As a couple of drivers forgot to do this, it was agreed that it
was cleaner if the i2c-core does this clearance when appropriate, as there is
no guarantee for the lifetime of the clientdata-pointer after remove() anyhow.
This feature was added to the core with commit
e4a7b9b04de15f6b63da5ccdd373ffa3057a3681 to fix the faulty drivers.
As there is no need anymore to clear the clientdata-pointer, remove all current
occurrences in the drivers to simplify the code and prevent confusion.
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
Acked-by: Richard Purdie <rpurdie@linux.intel.com>
Acked-by: Dmitry Torokhov <dtor@mail.ru>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
/drivers/input/misc/pcf8574_keypad.c
|
| b91c4be730668e801aa6a2ea95f467cd9a1e0983 |
|
20-Mar-2010 |
Bryan Wu <cooloney@kernel.org> |
Input: add PCF8574 I2C keypad input device driver
Signed-off-by: Bryan Wu <cooloney@kernel.org>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
/drivers/input/misc/pcf8574_keypad.c
|