History log of /drivers/media/dvb/frontends/drxd_hard.c
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
3caaa20121495145cd8fef274d6eea5d90ee7182 07-Mar-2012 Santosh Nayak <santoshprasadnayak@gmail.com> [media] dvb: negative value assigned to unsigned int in CDRXD()

In CDRXD(), Negative number is assigned to unsigned variable
'state->noise_cal.tdCal2.

Members of 'SNoiseCal' should be 'signed short'.

Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
/drivers/media/dvb/frontends/drxd_hard.c
7581e61d8d7a3ed89a3fdac2235231cd36548f78 01-Jan-2012 Mauro Carvalho Chehab <mchehab@redhat.com> [media] dvb: Remove ops->info.type from frontends

Now that this field is deprecated, and core generates it for
DVBv3 calls, remove it from the drivers.

It also adds .delsys on the few drivers where this were missed.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
/drivers/media/dvb/frontends/drxd_hard.c
9f97c288c0656346c984594a6ffc5af8546f47be 26-Dec-2011 Mauro Carvalho Chehab <mchehab@redhat.com> [media] drxd: convert set_fontend to use DVBv5 parameters

Instead of using dvb_frontend_parameters struct, that were
designed for a subset of the supported standards, use the DVBv5
cache information.

Also, fill the supported delivery systems at dvb_frontend_ops
struct.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
/drivers/media/dvb/frontends/drxd_hard.c
a689e3657d7e82c2271008553c709fc79fb2e038 22-Dec-2011 Mauro Carvalho Chehab <mchehab@redhat.com> [media] dvb-core: add support for a DVBv5 get_frontend() callback

Creates a DVBv5 get_frontend call, renaming the DVBv3 one to
get_frontend_legacy(), while not all frontends are converted.

After the conversion for all drivers, get_frontend_legacy()
will be removed.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
/drivers/media/dvb/frontends/drxd_hard.c
bc9cd2736b34619b58961d506210fe0e6dfaa27d 20-Dec-2011 Mauro Carvalho Chehab <mchehab@redhat.com> [media] Rename set_frontend fops to set_frontend_legacy

Passing DVBv3 parameters to set_frontend is not fun, as the
core doesn't have any way to know if the driver is using the
v3 or v5 parameters. So, rename the callback and add a new
one to allow distinguish between a mixed v3/v5 paramenter call
from a pure v5 call.

After having all frontends to use the new way, the legacy
call can be removed.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
/drivers/media/dvb/frontends/drxd_hard.c
14d24d148c7521b2b88b396652e36f55d061e195 24-Dec-2011 Mauro Carvalho Chehab <mchehab@redhat.com> [media] tuners: remove dvb_frontend_parameters from set_params()

This is a big patch, yet trivial: now that all tuners use the DVBv5
way to pass parameters (e. g. via fe->dtv_property_cache), the
extra parameter can be removed from set_params() call.

After this change, very few DVBv3 specific stuff are left at the
tuners.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
/drivers/media/dvb/frontends/drxd_hard.c
53090aada474fe10052602ca3f46701591b666a5 17-Nov-2011 Thomas Meyer <thomas@m3y3r.de> [media] drxd: Use kmemdup rather than duplicating its implementation

The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
/drivers/media/dvb/frontends/drxd_hard.c
23aefb7e0e5e8b3766545af51b88fc3eb07532ba 25-Aug-2011 Hans Verkuil <hans.verkuil@cisco.com> [media] drxd_hard: fix compiler warnings

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
/drivers/media/dvb/frontends/drxd_hard.c
f8a26f052a5f62c7555d09680c1fe8cbfcac590f 26-Aug-2011 Edward Sheldrake <ejsheldrake@gmail.com> [media] drxd: fix divide error

Fix division by zero in drxd triggered by running "femon" before any DVB
tuning has been done (by "scandvb" or anything else).

Signed-off-by: Edward Sheldrake <ejsheldrake@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
/drivers/media/dvb/frontends/drxd_hard.c
8afe9119e25809b044d9b5afbe2fb2853a5bd10c 13-Jul-2011 Jesper Juhl <jj@chaosbits.net> [media] media, Micronas dvb-t: Fix mem leaks, don't needlessly zero mem, fix spelling

In drivers/media/dvb/frontends/drxd_hard.c::load_firmware() I see 3
small issues:

1) When the 'fw' variable goes out of scope we'll leak the memory
allocated to it by request_firmware() by neglecting to call
release_firmware().

2) After a successful request_firmware() we allocate fw->size bytes
of memory using kzalloc() only to immediately overwrite all that
memory with memcpy(), so asking for zeroed memory seems like wasted
effort - just use kmalloc().

3) In one of the error messages "no memory" lacks a space and is
written as "nomemory".

This patch fixes all 3 issues.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
/drivers/media/dvb/frontends/drxd_hard.c
b01fbc10e3c789763b2c953984bc4b80f59bcdf3 03-Jul-2011 Mauro Carvalho Chehab <mchehab@redhat.com> [media] drxd/drxk: Don't export MulDiv32 symbol

/home/v4l/v4l/patchwork/drivers/media/dvb/frontends/drxk_hard.c:181: multiple definition of `MulDiv32'
drivers/media/dvb/frontends/drxd.o:/home/v4l/v4l/patchwork/drivers/media/dvb/frontends/drxd_hard.c:236: first defined here

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
/drivers/media/dvb/frontends/drxd_hard.c
d35ebf9558e692299b764163d61420fe5f526c02 25-Jun-2011 Mauro Carvalho Chehab <mchehab@redhat.com> [media] drxd, siano: Remove unused include linux/version.h

Both drxd and siano drivers were including linux/version.h without
any reason. Probably, this is due to some compatibility code that
used to exist before having their support added into the Linux
Kernel.

Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
/drivers/media/dvb/frontends/drxd_hard.c
63952e8c4ae7f3272cd37321a71428f3637f650f 20-May-2011 Andreas Oberritter <obi@linuxtv.org> [media] DVB: drxd_hard: handle new bandwidths by returning -EINVAL

drivers/media/dvb/frontends/drxd_hard.c: In function ‘DRX_Start’:
drivers/media/dvb/frontends/drxd_hard.c:2327: warning: enumeration value ‘BANDWIDTH_5_MHZ’ not handled in switch
drivers/media/dvb/frontends/drxd_hard.c:2327: warning: enumeration value ‘BANDWIDTH_10_MHZ’ not handled in switch
drivers/media/dvb/frontends/drxd_hard.c:2327: warning: enumeration value ‘BANDWIDTH_1_712_MHZ’ not handled in switch

[mchehab@redhat.com: removed the status = status assignment after the switch]
Signed-off-by: Andreas Oberritter <obi@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
/drivers/media/dvb/frontends/drxd_hard.c
834751d4365822f769d8af2fd37dc674997a313c 25-Mar-2011 Mauro Carvalho Chehab <mchehab@redhat.com> [media] drxd: use mutex instead of semaphore

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
/drivers/media/dvb/frontends/drxd_hard.c
9999daf446b9fa43b5301af423b6798a600e36bc 25-Mar-2011 Mauro Carvalho Chehab <mchehab@redhat.com> [media] drxd: CodingStyle cleanups

There are still lots of 80-columns warnings and a few errors
at some tables, but changing them would require more work and
with probably not much gain.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
/drivers/media/dvb/frontends/drxd_hard.c
58d5eaec9f877a9bcfa9b6dca0ea51850975c49f 25-Mar-2011 Mauro Carvalho Chehab <mchehab@redhat.com> [media] drxd: Don't use a macro for CHK_ERROR with a break inside

The macro is defined as:
#define CHK_ERROR(s) if( (status = s)<0 ) break

This sucks, as makes harder to debug if something got wrong and
there are more than one level of loops. Also, violates CodingStyle.

Fixed by this simple perl script:

while (<>) { $f.=$_; };

$f=~ s,\n\#define CHK_ERROR[^\n]+\n,\n,;

$f=~ s=(CHK_ERROR\(.*\,)\n\s+=\1 =g;
$f=~ s=(CHK_ERROR\(.*\,)\n\s+=\1 =g;
$f=~ s=(CHK_ERROR\(.*\,)\n\s+=\1 =g;
$f=~ s=(CHK_ERROR\(.*)\s+(\,)\n\s+=\1\2 =g;
$f=~ s=(CHK_ERROR\(.*)\s+(\,)\n\s+=\1\2 =g;
$f=~ s=(CHK_ERROR\(.*)\s+(\,)\n\s+=\1\2 =g;

$f=~ s,\n(\t+)CHK_ERROR\((.*)\)\;,\n\1status = \2;\n\1if (status < 0)\n\1\tbreak;,g;

print $f;

Plus a few manual adjustments

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
/drivers/media/dvb/frontends/drxd_hard.c
7fc7356f4eafa953197e1c4e2d236e199a51db28 25-Mar-2011 Mauro Carvalho Chehab <mchehab@redhat.com> [media] drxd: Fix some CodingStyle issues

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
/drivers/media/dvb/frontends/drxd_hard.c
6cacdd46e23826c0591238f5f11b1bfa6490797d 24-Mar-2011 Devin Heitmueller <dheitmueller@kernellabs.com> [media] drxd: Run lindent across sources

Take a first cleanup pass over the sources to bring them closer to the
Linux coding style.

Signed-off-by: Devin Heitmueller <dheitmueller@kernellabs.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
/drivers/media/dvb/frontends/drxd_hard.c
8f19f27e3e0e055aed877a07198cfbaf9d784105 13-Mar-2011 Devin Heitmueller <dheitmueller@kernellabs.com> [media] drxd: move firmware to binary blob

Abstract out the firmware for the drx-d so that it can be loaded by the
request_firmware() interface.

The firmware licensing permits free redistribution, and can be found here:

http://kernellabs.com/firmware/drxd

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
/drivers/media/dvb/frontends/drxd_hard.c
6b142b3c81e6e532dfad7256fcc7e75fded49245 13-Mar-2011 Devin Heitmueller <dheitmueller@kernellabs.com> [media] drxd: provide ability to disable the i2c gate control function

If the tuner is not actually behind an i2c gate, using the i2c gate control
function can wedge the i2c bus. Provide the ability to control on a per-board
basis whether it should be used.

Problem was noticed on the HVR-900 R2, where it resulted in the first tuning
attempt succeeding, and then all subsequent attempts to access the xc3028
being treated as failures (including the call to sleep the tuner).

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
/drivers/media/dvb/frontends/drxd_hard.c
ba96796544f3bfc53a3269f0cf65651e349f8033 13-Mar-2011 Devin Heitmueller <dheitmueller@kernellabs.com> [media] drxd: provide ability to control rs byte

Provide the ability for the board configuration to specify whether to insert
the RS byte into the TS interconnect to the bridge, while not required for
the ngene in fact is required for the em28xx.

Signed-off-by: Devin Heitmueller <dheitmueller@kernellabs.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
/drivers/media/dvb/frontends/drxd_hard.c
126f1e61887085aa2c2cfa7644aee8295a94e1f7 13-Mar-2011 Ralph Metzler <rjkm@metzlerbros.de> drx: add initial drx-d driver

These are the original drx-d sources, extracted from Ralph Metzler's GPL'd
ngene driver. No modifications/cleanup have yet been made. In fact, no
measures have been taken to see if the code even compiles.

Signed-off-by Ralph Metzler <rjkm@metzlerbros.de>
Signed-off-by: Devin Heitmueller <dheitmueller@kernellabs.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
/drivers/media/dvb/frontends/drxd_hard.c