| 23677ce3172fcb93522a1df077d21019e73ee1e3 |
|
09-Feb-2012 |
Joe Perches <joe@perches.com> |
drivers/net: Remove boolean comparisons to true/false
Booleans should not be compared to true or false
but be directly tested or tested with !.
Done via cocci script:
@@
bool t;
@@
- t == true
+ t
@@
bool t;
@@
- t != true
+ !t
@@
bool t;
@@
- t == false
+ !t
@@
bool t;
@@
- t != false
+ t
Signed-off-by: Joe Perches <joe@perches.com>
Reviewed-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/phy/broadcom.c
|
| bfb9035c98906aafcd3cf22694fba2550997bf53 |
|
17-Aug-2011 |
Joe Perches <joe@perches.com> |
treewide: Correct spelling of successfully in comments
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
/drivers/net/phy/broadcom.c
|
| cf93c94581bab447a5634c6d737c1cf38c080261 |
|
04-Oct-2010 |
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> |
net/phy: fix many "defined but unused" warnings
MODULE_DEVICE_TABLE only expands to something if it's compiled
for a module. So when building-in support for the phys, the
mdio_device_id tables are unused. Marking them with __maybe_unused
fixes the following warnings:
drivers/net/phy/bcm63xx.c:134: warning: 'bcm63xx_tbl' defined but not used
drivers/net/phy/broadcom.c:933: warning: 'broadcom_tbl' defined but not used
drivers/net/phy/cicada.c:162: warning: 'cicada_tbl' defined but not used
drivers/net/phy/davicom.c:222: warning: 'davicom_tbl' defined but not used
drivers/net/phy/et1011c.c:114: warning: 'et1011c_tbl' defined but not used
drivers/net/phy/icplus.c:137: warning: 'icplus_tbl' defined but not used
drivers/net/phy/lxt.c:226: warning: 'lxt_tbl' defined but not used
drivers/net/phy/marvell.c:724: warning: 'marvell_tbl' defined but not used
drivers/net/phy/micrel.c:234: warning: 'micrel_tbl' defined but not used
drivers/net/phy/national.c:154: warning: 'ns_tbl' defined but not used
drivers/net/phy/qsemi.c:141: warning: 'qs6612_tbl' defined but not used
drivers/net/phy/realtek.c:82: warning: 'realtek_tbl' defined but not used
drivers/net/phy/smsc.c:257: warning: 'smsc_tbl' defined but not used
drivers/net/phy/ste10Xp.c:135: warning: 'ste10Xp_tbl' defined but not used
drivers/net/phy/vitesse.c:195: warning: 'vitesse_tbl' defined but not used
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/phy/broadcom.c
|
| 7a938f80264f2cbfb0c0841b450eab42a8093281 |
|
17-Jun-2010 |
Dmitry Baryshkov <dbaryshkov@gmail.com> |
broadcom: Add 5241 support
This patch adds the 5241 PHY ID to the broadcom module.
Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/phy/broadcom.c
|
| fcb26ec5b18d88bb22366799d056dc3630d0e895 |
|
17-Jun-2010 |
Dmitry Baryshkov <dbaryshkov@gmail.com> |
broadcom: move all PHY_ID's to header
Move all PHY IDs to brcmphy.h header for completeness and unification of code.
Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/phy/broadcom.c
|
| 4e4f10f6498bc5038c0a110b5f21682fcb5578d7 |
|
02-Apr-2010 |
David Woodhouse <dwmw2@infradead.org> |
phylib: Add module table to all existing phy drivers
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/phy/broadcom.c
|
| 6a443a0f72ad7706345412dbd2e4d4981fdfce39 |
|
17-Feb-2010 |
Matt Carlson <mcarlson@broadcom.com> |
tg3: Push phylib definitions to phylib
This patch pushes phylib definitions out to phylib headers. For phy
IDs, this removes some code duplication.
Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
Reviewed-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/phy/broadcom.c
|
| 7ec4e7d3cfee9d7846dbd02ad442c40cb58512e8 |
|
30-Dec-2009 |
roel kluin <roel.kluin@gmail.com> |
broadcom: Fix &&/|| confusion in bcm54xx_adjust_rxrefclk()
This always evaluates to true.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/phy/broadcom.c
|
| 5ee6f6a17cfde9c3141e4d57cf88b5cdf638b463 |
|
19-Dec-2009 |
Roel Kluin <roel.kluin@gmail.com> |
broadcom: bcm54xx_shadow_read() errors ignored in bcm54xx_adjust_rxrefclk()
If not signed read errors are ignored.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Matt Carlson <mcarlson@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/phy/broadcom.c
|
| 52fae0837153e86e4dabaf5df517a0b8b7a20bd7 |
|
02-Nov-2009 |
Matt Carlson <mcarlson@broadcom.com> |
tg3 / broadcom: Optionally disable TXC if no link
This patch adds code to disable the TXC and RXC reference clocks if link
is not available.
Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
Reviewed-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/phy/broadcom.c
|
| c704dc23cac0e433796bfe0a1fe2f1a64da11ac7 |
|
02-Nov-2009 |
Matt Carlson <mcarlson@broadcom.com> |
tg3 / broadcom: Add APD support for GPHYs
This patch adds an RXC auto power-down feature to the code that supports
the gphys.
Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
Reviewed-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/phy/broadcom.c
|
| 32e5a8d651c0dbb02bf82ca954206282e44c4b11 |
|
02-Nov-2009 |
Matt Carlson <mcarlson@broadcom.com> |
tg3 / broadcom: Add code to disable rxc refclk
The 5785 does not use the RXC reference clock. Turning it off is
desirable as it saves power.
By default, the 50610 enables the RXC reference clock and the 50610M
disables it. Presumably this is one of the reasons why the hardware
architect chose one over the other.
Adding a "rx reference clock disable" flag is not the ideal way to
describe the option, as it would force the MAC using a 50610M to set
the flag. Ideally we want the flags to represent opt-in behavior that
deviates from hardware defaults. Furthermore, the lack of a
"disable" flag implies that the requester wants the rx reference clock
enabled, which doesn't necessarily follow.
By presenting the option as a passive statement (rx reference clock
unused) rather than a command, I hope to convey an opt-in option to
disable the rx reference clock that falls back to hardware defaults if
not set. A secondary benefit of this is that it keeps the
intelligence about phy defaults in the broadcom module where it belongs
and allows the broadcom module more latitude should a bug arise.
Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
Reviewed-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/phy/broadcom.c
|
| cdd4e09d692bd4f3457b3789279005e112b7696d |
|
02-Nov-2009 |
Matt Carlson <mcarlson@broadcom.com> |
tg3 / broadcom: Refine AC131 APD support
Auto power-down (APD) support is a power-saving feature. It should be
selectively enabled since it might expose MAC bugs. This patch changes
the code to enable APD only if the PHY_BRCM_AUTO_PWRDWN_ENABLE flag is
set. The tg3 driver was changed to set this bit.
Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
Reviewed-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/phy/broadcom.c
|
| 63a14ce449dd6d647de2725809159eb072b2c44f |
|
02-Nov-2009 |
Matt Carlson <mcarlson@broadcom.com> |
tg3 / broadcom: Add PHY_BRCM_CLEAR_RGMII_MODE flag
Broadcom 50610M parts changed the default definitions of the RGMII mode
shadow register. The 5785 needs the RGMII mode selection bits [4:3]
cleared.
The default value of the remaining bits in this register are zero.
Rather than unnecessarily burn an extra bit in the dev_flags member in
an attempt to enumerate all possible combinations, this patch take a
more course grained approach and labels the option as "clear all bits".
Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
Reviewed-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/phy/broadcom.c
|
| 8649f13d2d810406da444a6101906041b796fbde |
|
02-Nov-2009 |
Matt Carlson <mcarlson@broadcom.com> |
broadcom: Consolidate dev_flags definitions
This patch moves all the dev_flags enumerations outside the broadcom.c
file to include/linux/brcmphy.h. The existing flags were not used yet
and have been re-enumerated to avoid conflicts.
Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
Reviewed-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/phy/broadcom.c
|
| 219c6efefaa3f5cd05db52cda50402b2e1c9ae21 |
|
02-Nov-2009 |
Matt Carlson <mcarlson@broadcom.com> |
broadcom: Fix slow link problem
When a 50610 or 50610M is paired against particular remote partners,
link is slow to come up. This patch works around the problem.
Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
Reviewed-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/phy/broadcom.c
|
| 47b1b53b41d63f27b308981fde307d415e514431 |
|
02-Nov-2009 |
Matt Carlson <mcarlson@broadcom.com> |
broadcom: Isolate phy dsp accesses
This patch consolidates the code that requires the SMDSP clock to be
enabled into a single function that (hopefully) makes the dependency
obvious.
Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
Reviewed-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/phy/broadcom.c
|
| d9221e66002a7f24fb71b73132aa46c40079745f |
|
25-Aug-2009 |
Matt Carlson <mcarlson@broadcom.com> |
broadcom: Make the 57780 IEEE compliant
This brings the 57780's phy into IEEE compliance by suppressing the
common mode oscillation.
Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
Reviewed-by: Michael Chan <mchan@broadcom.com>
Reviewed-by: Benjamin Li <benli@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/phy/broadcom.c
|
| d7a2ed9248a3c3ec6afe3be0c351bd1ca9e981f3 |
|
25-Aug-2009 |
Matt Carlson <mcarlson@broadcom.com> |
broadcom: Add AC131 phy support
This patch adds support for the AC131 fast ethernet transceiver.
Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
Reviewed-by: Michael Chan <mchan@broadcom.com>
Reviewed-by: Benjamin Li <benli@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/phy/broadcom.c
|
| 4f4598fd0a87f39955e71bcb7447f403dafc20ba |
|
25-Aug-2009 |
Matt Carlson <mcarlson@broadcom.com> |
broadcom: Add BCM50610M support
This patch adds support for the BCM50610M phy ID.
Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
Reviewed-by: Michael Chan <mchan@broadcom.com>
Reviewed-by: Benjamin Li <benli@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/phy/broadcom.c
|
| 2fbb69aa576f4392c4a04e6874fa429b8bde0f68 |
|
22-Nov-2008 |
Matt Carlson <mcarlson@broadcom.com> |
broadcom: Add 57780 support
This patch adds the 57780 PHY ID to the broadcom module.
Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/phy/broadcom.c
|
| 772638b6c87da7043c50914dbb033c08155508dd |
|
04-Nov-2008 |
Matt Carlson <mcarlson@broadcom.com> |
broadcom: Add support for BCM50610
This patch adds the BCM50610 to the list of phys supported by the
broadcom driver.
Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/phy/broadcom.c
|
| 042a75b99fbda6bf7c7bf4496e205e3e7acc953a |
|
04-Nov-2008 |
Matt Carlson <mcarlson@broadcom.com> |
broadcom: Refine expansion register access routine
This patch makes the expansion register access routines a little more
formal. They will be used by the following bcm50610 support patch.
Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/phy/broadcom.c
|
| 5e0c676c717316f315dcf76da52dc0002c43632a |
|
04-Nov-2008 |
Matt Carlson <mcarlson@broadcom.com> |
broadcom: Add flow control support
This patch adds flow control support to Broadcom phys.
Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/phy/broadcom.c
|
| cd9af3dac6d1ad001b2d5d912dbd49e184d23b9d |
|
17-May-2008 |
Nate Case <ncase@xes-inc.com> |
PHYLIB: Add 1000Base-X support for Broadcom bcm5482
Configure the BCM5482S secondary SerDes for 1000Base-X mode when the
appropriate dev_flags are passed in to phy_connect(). This is
needed when the PHY is used for fiber and backplane connections.
Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
/drivers/net/phy/broadcom.c
|
| b1394f961a90a7195ea177ee56d54fe5c37181ca |
|
15-Apr-2008 |
Paul Gortmaker <paul.gortmaker@windriver.com> |
PHY: add BCM5464 support to broadcom PHY driver
The BCM5464 can be used with the current broadcom PHY driver
by just adding the appropriate chip ID and using the existing
support within.
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
/drivers/net/phy/broadcom.c
|
| 57bb7e222804c68066e3e995dffbedda5b1ec1ea |
|
04-Mar-2008 |
Anton Vorontsov <avorontsov@ru.mvista.com> |
phy/broadcom: add support for BCM5481 PHY
This patch adds support for BCM5481 PHY. Unfortunately it's hard to
get specifications for this PHY, so its special register 0x18 isn't
annotated properly (but we know it's used to set up the delays).
I've kept the magic numbers, so we'll not forget to fix it at the
first opportunity, and will name that register and its bits correctly.
p.s. also fixed the line with broken indention, introduced by
commit 03157ac31eb4a8883382a212b161d2e6c5059fbf
PHYLIB: Add BCM5482 PHY support
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
/drivers/net/phy/broadcom.c
|
| 03157ac31eb4a8883382a212b161d2e6c5059fbf |
|
29-Jan-2008 |
Nate Case <ncase@xes-inc.com> |
PHYLIB: Add BCM5482 PHY support
This Broadcom PHY is similar to other bcm54xx devices.
Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
/drivers/net/phy/broadcom.c
|
| c4b41c9f077392803cd548000f3a2312dcd4a122 |
|
03-Oct-2006 |
Maciej W. Rozycki <macro@linux-mips.org> |
[PATCH] 2.6.18: sb1250-mac: Broadcom PHY support
This patch adds support for interrupt-driven operation of the Broadcom
Gigabit Ethernet PHYs. I have included device IDs for the parts used on
Broadcom SiByte evaluation boards; more can be added as a need arises.
They are apparently generally software-compatible with one another.
Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
patch-mips-2.6.18-20060920-broadcom-phy-15
Signed-off-by: Jeff Garzik <jeff@garzik.org>
/drivers/net/phy/broadcom.c
|