History log of /drivers/net/wireless/iwlegacy/3945-mac.c
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
883a649b737cdbe3ede7e50f3f939fd706ed5c4e 13-Mar-2012 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: do not nulify il->vif on reset

This il->vif is dereferenced in different part of iwlegacy code, so do
not nullify it. This should fix random crashes observed in companion
with microcode errors i.e. crash in il3945_config_ap().

Additionally this should address also
WARNING: at drivers/net/wireless/iwlegacy/common.c:4656 il_mac_remove_interface
at least one of the possible reasons of that warning.

Cc: stable@vger.kernel.org
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
4da0bd736552e6377b407b3c3d3ae518ebbdd269 19-Mar-2012 David S. Miller <davem@davemloft.net> Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
210787e82a0ac1ffb5d7be1c796f0c51050849ad 08-Mar-2012 Stanislaw Gruszka <sgruszka@redhat.com> iwl3945: fix possible il->txq NULL pointer dereference in delayed works

On il3945_down procedure we free tx queue data and nullify il->txq
pointer. After that we drop mutex and then cancel delayed works. There
is possibility, that after drooping mutex and before the cancel, some
delayed work will start and crash while trying to send commands to
the device. For example, here is reported crash in
il3945_bg_reg_txpower_periodic():
https://bugzilla.kernel.org/show_bug.cgi?id=42766#c10

Patch fix problem by adding il->txq check on works that send commands,
hence utilize tx queue.

Reported-by: Clemens Eisserer <linuxhippy@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
bc269a8e2701aaa6c53553eaef9f0866ef03e703 13-Feb-2012 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: s/S_RF_KILL_HW/S_RFKILL/g

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
775ed8abde9420afc955ca7540aacdce721be6c1 13-Feb-2012 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: do not grab nic access if rfkill

If rfkill is on il_grab_nic_access() fail and we can not write to the
various registers during stop procedure. Write to those registers
unconditionally instead.

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
c37281a076604937ec2403f3cfec71362f93c7d8 13-Feb-2012 Stanislaw Gruszka <sgruszka@redhat.com> iwleagcy: fix ident code damage

Using ident is not always good.

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
9ce7b73c76ca872cb5b42e835f8e683a4051fbd9 13-Feb-2012 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: improve mac operation debuggability a bit

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
288f9954132cd64f60fbb8051e31d62d8c35875f 13-Feb-2012 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: get rid of tx/rx traffic log

The same data can be gathered using monitor mode.

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
1600b87542ce93e3dc094f6b108d8c2953e2ca0e 13-Feb-2012 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: merge il_lib_ops into il_ops

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
f03ee2a87e21f76928c10d822639ec437113d312 13-Feb-2012 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: remove il_apm_ops

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
93b7654ec563a929a62da70324e834eeb18a2778 13-Feb-2012 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: move debugfs_ops to il_priv

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
a5f16137ab8aff1208d3ea013033d0d38f15a61f 13-Feb-2012 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: use writeb,writel,readl directly

That change will save us some CPU cycles at run time. Having
port-based I/O seems to be not possible for PCIe devices.

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
00ea99e1d86b05e7ba90d66673b536b731af87cd 03-Feb-2012 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: remove struct il_tx_info

It's just wrapper to sk_buff pointers ...

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
c39ae9fd505ae314a7a4a159a41e3e022cfa317f 03-Feb-2012 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: move ops out of config

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
83007196037cc2d0bffd9f7afbe56d675779a6cb 03-Feb-2012 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: get rid of ctx structure

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
8c9c48d5a9ca5e1426372f8a747846bd0609dc08 03-Feb-2012 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: remove ctx interface_modes

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
6aa0c25435e6383d4a4af88fae8d128200dcd471 03-Feb-2012 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: get rid of ctxid

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
0f8b90f526f097a5c897f52b3595e9af55fc9b59 03-Feb-2012 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: get rid of *_devtype

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
b16db50a6dc486c3a6c32cd7982a75452cb785c2 03-Feb-2012 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: move bcast_sta_id to hw_params

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
8f9e56455310a3d75e8239db9729acb2b31dbdad 03-Feb-2012 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: get rid of ap_sta_id

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
d98e294231a29699848fd0e923d91fe979e13802 03-Feb-2012 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: get rid of wep_key_cmd

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
b96ed60cd0c352891fd04f4aa748f4d36a6cec5b 03-Feb-2012 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: get rid of qos_cmd

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
5e349f02963acc2c3607119e6e64f0cbc8d23e17 03-Feb-2012 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: get rid of rxon_assoc_cmd

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
63d0f0c5512e29f87ed2e1612bb637d857f3b345 03-Feb-2012 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: get rid of ctx->rxon_timing_cmd

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
6122d18236837ed7f264632e6b27d5cb3005add2 03-Feb-2012 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: get rid of ctx->rxon_cmd

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
c8b03958d4b23dc48932ec095a391f3d6447e0e9 03-Feb-2012 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: move rxon commands out of ctx structure

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
68acc4afb040d98ddfd2cae0de09e2f4e1ee127f 23-Dec-2011 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: 3945: fix hw passive scan on radar channels

Patch fix firmware error on "iw dev wlan0 scan passive" for
hardware scanning (with disable_hw_scan=0 module parameter).

iwl3945 0000:03:00.0: Microcode SW error detected. Restarting 0x82000008.
iwl3945 0000:03:00.0: Loaded firmware version: 15.32.2.9
iwl3945 0000:03:00.0: Start IWL Error Log Dump:
iwl3945 0000:03:00.0: Status: 0x0002A2E4, count: 1
iwl3945 0000:03:00.0: Desc Time asrtPC blink2 ilink1 nmiPC Line
iwl3945 0000:03:00.0: SYSASSERT (0x5) 0041263900 0x13756 0x0031C 0x00000 764
iwl3945 0000:03:00.0: Error Reply type 0x000002FC cmd C_SCAN (0x80) seq 0x443E ser 0x00340000
iwl3945 0000:03:00.0: Command C_SCAN failed: FW Error
iwl3945 0000:03:00.0: Can't stop Rx DMA.

We have disable ability to change passive scanning to active on
particular channel when traffic is detected on that channel. Otherwise
firmware will report error, when we try to do passive scan on radar
channels.

Reported-and-debugged-by: Pedro Francisco <pedrogfrancisco@gmail.com>
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
81fb46139504f72a92243245df878e1a1af35f89 23-Dec-2011 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: 3945: simplify calculations of retry limit

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
1722f8e12a9c6117d872bd19ec5919460ccdfb4e 15-Nov-2011 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: checkpatch.pl fixes

Fix most checkpatch.pl ERRORs and some WARNINGs.

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
e7392364fcd1004a5e495f15cf21b1e0ef874215 15-Nov-2011 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: indentions and whitespaces

Process iwlegacy source files using:

indent -npro -l500 -nhnl
indent -npro -kr -i8 -ts8 -sob -l80 -nbbo -ss -ncs -cp1 -il0 -psl

Plus manual compilation fixes.

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
53143a1809db521ff34371f066bfd8f1619ec2c9 31-Aug-2011 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: use FH39_ prefix in 3945 code

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
e94a4099adb2ec148776975bcd953a01c6bec992 31-Aug-2011 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: merge common header files

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
98613be06e9de8acd20841d2d85b99c39b3b7814 15-Nov-2011 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: rename iwl-core.h to common.h

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
6278ddab9f859b8d6311879d35f2b1f74a789964 31-Aug-2011 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: remove il_ieee80211_get_hw_conf

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
d4459a99c41e0e4fe7e36b3816b461c42827fb80 31-Aug-2011 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: rename iwl-commands.h to commands.h

On the way remove also not needed iwl-fh.h include.

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
d2dfb33ec9a8da257bb0e6ed2872af2fdf85260c 15-Nov-2011 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: rename other handlers

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
6e9848b496cf256ba820094e88e78cc4f8304008 30-Aug-2011 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: s/rx_reply/hdl/

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
d0c72347bece3299a90351151c69c0f721f964ff 30-Aug-2011 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: s/rx_handler/handler/

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
4d69c7521a90cba945b4720672b4511b1e541189 30-Aug-2011 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: rename REPLY_ to N_ or C_

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
db7746f78cab25ee39dd20f61d9b2e6b5993d8fa 15-Nov-2011 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: s/STATISTICS/STATS/

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
a6766ccdaf9cc80d565672516d429a562d1a732d 15-Nov-2011 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: s/STATUS_/S_/

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
6bbb1370c3083190cae8487c2c61c0d24f869e68 30-Aug-2011 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: move iwl-3945-{,hw,fh,debugfs}.h to 3945.h

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
/drivers/net/wireless/iwlegacy/3945-mac.c
61fe55f61fb48b691251e0f75505674db77f5d29 15-Nov-2011 Stanislaw Gruszka <sgruszka@redhat.com> iwlegacy: rename base 4965 and 3945 file names

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
/drivers/net/wireless/iwlegacy/3945-mac.c