480491889f684662a95234f2205ed4d70afe7a10 |
|
25-Feb-2012 |
Peter Huewe <peterhuewe@gmx.de> |
staging: asus_oled: Remove superfluous loop This patch removes a superfluous loop in asus_oled.c The code is equivalent to do{...} while (0) and thus executes the code exactly once -> so we can simply remove the loop. Signed-off-by: Peter Huewe <peterhuewe@gmx.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
/drivers/staging/asus_oled/asus_oled.c
|
3589e74595a4332ebf77b5ed006f3c6686071ecd |
|
22-Jan-2012 |
Pekka Paalanen <pq@iki.fi> |
Staging: asus_oled: fix NULL-ptr crash on unloading Asus_oled triggers the following bug on module unloading: usbcore: deregistering interface driver asus-oled BUG: unable to handle kernel NULL pointer dereference at 0000000000000038 IP: [<ffffffff8111292b>] sysfs_delete_link+0x30/0x66 Call Trace: [<ffffffff81225373>] device_remove_class_symlinks+0x6b/0x70 [<ffffffff812256a8>] device_del+0x9f/0x1ab [<ffffffff812257c5>] device_unregister+0x11/0x1e [<ffffffffa000cb82>] asus_oled_disconnect+0x4f/0x9e [asus_oled] [<ffffffff81277430>] usb_unbind_interface+0x54/0x103 [<ffffffff812276c4>] __device_release_driver+0xa2/0xeb [<ffffffff81227794>] driver_detach+0x87/0xad [<ffffffff812269e9>] bus_remove_driver+0x91/0xc1 [<ffffffff81227fb4>] driver_unregister+0x66/0x6e [<ffffffff812771ed>] usb_deregister+0xbb/0xc4 [<ffffffffa000ce87>] asus_oled_exit+0x2f/0x31 [asus_oled] [<ffffffff81068365>] sys_delete_module+0x1b8/0x21b [<ffffffff810ae3de>] ? do_munmap+0x2ef/0x313 [<ffffffff813699bb>] system_call_fastpath+0x16/0x1b This is due to an incorrect destruction sequence in asus_oled_exit(). Fix the order, fixes the bug. Tested on an Asus G50V laptop only. Cc: Jakub Schmidtke <sjakub@gmail.com> Signed-off-by: Pekka Paalanen <pq@iki.fi> Cc: stable <stable@vger.kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/asus_oled/asus_oled.c
|
635032cb397b396241372fa0ff36ae758e658b23 |
|
22-Jan-2012 |
Pekka Paalanen <pq@iki.fi> |
Staging: asus_oled: fix image processing Programming an image was broken, because odev->buf_offs was not advanced for val == 0 in append_values(). This regression was introduced in: commit 1ff12a4aa354bed093a0240d5e6347b1e27601bc Author: Kevin A. Granade <kevin.granade@gmail.com> Date: Sat Sep 5 01:03:39 2009 -0500 Staging: asus_oled: Cleaned up checkpatch issues. Fix the image processing by special-casing val == 0. I have tested this change on an Asus G50V laptop only. Cc: Jakub Schmidtke <sjakub@gmail.com> Cc: Kevin A. Granade <kevin.granade@gmail.com> Signed-off-by: Pekka Paalanen <pq@iki.fi> Cc: stable <stable@vger.kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/asus_oled/asus_oled.c
|
67d6baa401e2485f6d12658b836befe1df247a04 |
|
19-Nov-2011 |
Ken O'Brien <kernel@kenobrien.org> |
Staging: asus_oled: Fixed use of obsolete function. Removed use of obsolete function "strict_strtoul". Replaced with "kstrtoul" as suggested by checkpatch.pl Signed-off-by: Ken O'Brien <kernel@kenobrien.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/asus_oled/asus_oled.c
|
ea3398a1ae54cd3403f3cc0f6aa498c7452c681a |
|
07-Dec-2010 |
Greg Kroah-Hartman <gregkh@suse.de> |
Staging: Merge 2.6.37-rc5 into staging-next This was done to handle a number of conflicts in the batman-adv and winbond drivers properly. It also now allows us to fix up the sysfs attributes properly that were not in the .37 release due to them being only in this tree at the time. Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
515b4987ccd097cdf5416530b05fdf9e01afe95a |
|
18-Nov-2010 |
Greg Kroah-Hartman <gregkh@suse.de> |
Staging: asus_oled: fix up my fixup for some sysfs attribute permissions They should be writable by root, not readable. Doh, stupid me with the wrong flags. Reported-by: Jonathan Cameron <jic23@cam.ac.uk> Cc: Jakub Schmidtke <sjakub@gmail.com> Cc: stable <stable@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/asus_oled/asus_oled.c
|
590b0b9754bd8928926bae7194b6da7ead9bda3b |
|
16-Nov-2010 |
Greg Kroah-Hartman <gregkh@suse.de> |
Staging: asus_oled: fix up some sysfs attribute permissions They should not be writable by any user Reported-by: Linus Torvalds <torvalds@linux-foundation.org> Cc: Jakub Schmidtke <sjakub@gmail.com> Cc: stable <stable@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/asus_oled/asus_oled.c
|
9f027eb6871335f6e16633df796263f983f08844 |
|
06-Nov-2010 |
Johan Meiring <johanmeiring@gmail.com> |
Staging: asus_oled: fix coding style issue in asus_oled.c This is a patch to the asus_oled.c file that fixes up brace and enum warning found by the checkpatch.pl tool Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/asus_oled/asus_oled.c
|
631dd1a885b6d7e9f6f51b4e5b311c2bb04c323c |
|
18-Oct-2010 |
Justin P. Mattock <justinmattock@gmail.com> |
Update broken web addresses in the kernel. The patch below updates broken web addresses in the kernel Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> Cc: Maciej W. Rozycki <macro@linux-mips.org> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Finn Thain <fthain@telegraphics.com.au> Cc: Randy Dunlap <rdunlap@xenotime.net> Cc: Matt Turner <mattst88@gmail.com> Cc: Dimitry Torokhov <dmitry.torokhov@gmail.com> Cc: Mike Frysinger <vapier.adi@gmail.com> Acked-by: Ben Pfaff <blp@cs.stanford.edu> Acked-by: Hans J. Koch <hjk@linutronix.de> Reviewed-by: Finn Thain <fthain@telegraphics.com.au> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
/drivers/staging/asus_oled/asus_oled.c
|
e67fdbc3ed1522c2594bf5040eaaeed5027e8ccb |
|
01-Mar-2010 |
Andrea Gelmini <andrea.gelmini@gelma.net> |
Staging: asus_oled: asus_oled.c: Checkpatch cleanup drivers/staging/asus_oled/asus_oled.c:774: ERROR: code indent should use tabs where possible Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/asus_oled/asus_oled.c
|
0933e2d98d1b170ef62d48e18157f5dc43b58217 |
|
05-Jan-2010 |
Andi Kleen <andi@firstfloor.org> |
driver core: Convert some drivers to CLASS_ATTR_STRING Convert some drivers who export a single string as class attribute to the new class_attr_string functions. This removes redundant code all over. Signed-off-by: Andi Kleen <ak@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/asus_oled/asus_oled.c
|
28812fe11a21826ba4c97c6c7971a619987cd912 |
|
05-Jan-2010 |
Andi Kleen <andi@firstfloor.org> |
driver-core: Add attribute argument to class_attribute show/store Passing the attribute to the low level IO functions allows all kinds of cleanups, by sharing low level IO code without requiring an own function for every piece of data. Also drivers can extend the attributes with own data fields and use that in the low level function. This makes the class attributes the same as sysdev_class attributes and plain attributes. This will allow further cleanups in drivers. Full tree sweep converting all users. Signed-off-by: Andi Kleen <ak@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/asus_oled/asus_oled.c
|
a457732b836b970c82c7ba35b4cfc938c9c543f9 |
|
10-Jan-2010 |
Németh Márton <nm127@freemail.hu> |
staging: make USB device id constant The id_table field of the struct usb_device_id is constant in <linux/usb.h> so it is worth to make the initialization data also constant. The semantic match that finds this kind of pattern is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ disable decl_init,const_decl_init; identifier I1, I2, x; @@ struct I1 { ... const struct I2 *x; ... }; @s@ identifier r.I1, y; identifier r.x, E; @@ struct I1 y = { .x = E, }; @c@ identifier r.I2; identifier s.E; @@ const struct I2 E[] = ... ; @depends on !c@ identifier r.I2; identifier s.E; @@ + const struct I2 E[] = ...; // </smpl> Signed-off-by: Németh Márton <nm127@freemail.hu> Cc: Julia Lawall <julia@diku.dk> Cc: cocci@diku.dk Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/asus_oled/asus_oled.c
|
0df28be06e08b9a53c26a53974bf3afea4928b3e |
|
07-Jan-2010 |
Peter Huewe <peterhuewe@gmx.de> |
Staging: asus_oled: Add NULL test for kmalloc This patch adds a NULL test to check wether kmalloc was successful or not. Signed-off-by: Peter Huewe <peterhuewe@gmx.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/asus_oled/asus_oled.c
|
e89230ec9154870a165de7e4acc411e1e7eec345 |
|
15-Dec-2009 |
Peter Huewe <peterhuewe@gmx.de> |
Staging: asus_oled: Add defines for asus vendor_id and device_id to be consistent with hid-ids.h This almost trivial patch replaces the hardcoded values for the vendor and device ids with defines, as they are used in drivers/hid/hid-ids.h For me this seems to be more consistent, however as drivers/hid/hid-ids.h is not within the default include directory I had to redefine the defines here (maybe move the hid-ids.h to include/linux ?) Signed-off-by: Peter Huewe <peterhuewe@gmx.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/asus_oled/asus_oled.c
|
20633bf0141c5e93e3396770d5eb7d200ee4068a |
|
23-Dec-2009 |
Eugeni Dodonov <eugeni@mandriva.com> |
Staging: asus_oled: fix oops in 2.6.32.2 After updating to 2.6.32 kernel, I started experiencing Oopses caused by the asus_oled module. After quick investigation, I wrapped this simple patch which fixes an Oops in by asus_oled module on 2.6.32.2 kernel, caused by incorrect usage of strict_strtoul function call within set_enabled and set_disabled functions. This can be triggered by simple running the userspace client for asus_old (e.g., 'asusoled -e' or 'asusoled -d'). Signed-off-by: Eugeni Dodonov <eugeni@mandriva.com> Cc: stable <stable@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/asus_oled/asus_oled.c
|
1ff12a4aa354bed093a0240d5e6347b1e27601bc |
|
05-Sep-2009 |
Kevin A. Granade <kevin.granade@gmail.com> |
Staging: asus_oled: Cleaned up checkpatch issues. Signed-off-by: Kevin A. Granade <kevin.granade@gmail.com> Cc: Belisko Marek <marek.belisko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/asus_oled/asus_oled.c
|
0d99b6eb851fbea9e31ad23f70c8f9fbefd6e4e8 |
|
04-Jun-2009 |
Greg Kroah-Hartman <gregkh@suse.de> |
Staging: asus_oled: fix build warnings This fixes some build warnings in the asus_oled driver. Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/asus_oled/asus_oled.c
|
94aa5b44cc0c2e6ba76098cfca800ee3d901c9a3 |
|
19-Jan-2009 |
Andre Haupt <andre@bitwigglers.org> |
Staging: asus_oled: do not use assignment in if condition This fixes some errors reported by checkpatch.pl Signed-off-by: Andre Haupt <andre@bitwigglers.org> Cc: Jakub Schmidtke <sjakub@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/asus_oled/asus_oled.c
|
118015c4d4796df499e8779ff4d581fad6565d81 |
|
19-Jan-2009 |
Andre Haupt <andre@bitwigglers.org> |
Staging: asus_oled: fix various checkpatch.pl issues regarding missing or obsolete spaces Signed-off-by: Andre Haupt <andre@bitwigglers.org> Cc: Jakub Schmidtke <sjakub@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/asus_oled/asus_oled.c
|
526fd20a351cd8ab598969f38d1c38cd869cd104 |
|
19-Jan-2009 |
Andre Haupt <andre@bitwigglers.org> |
Staging: asus_oled: trailing statements should be on next line fix the following error reported by checkpatch.pl ERROR: trailing statements should be on next line Signed-off-by: Andre Haupt <andre@bitwigglers.org> Cc: Jakub Schmidtke <sjakub@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/asus_oled/asus_oled.c
|
b0e5ca810ae532153c9a44dbaeff529ee5028383 |
|
19-Jan-2009 |
Andre Haupt <andre@bitwigglers.org> |
Staging: asus_oled: do not initialise statics to 0 or NULL fix the following error reported by checkpatch.pl ERROR: do not initialise statics to 0 or NULL Signed-off-by: Andre Haupt <andre@bitwigglers.org> Cc: Jakub Schmidtke <sjakub@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/asus_oled/asus_oled.c
|
ccdb24592f850c4951e76f95f8b4365be3c4e742 |
|
19-Jan-2009 |
Andre Haupt <andre@bitwigglers.org> |
Staging: asus_oled: fix sparse warnings about using plain integer as NULL pointer Signed-off-by: Andre Haupt <andre@bitwigglers.org> Cc: Jakub Schmidtke <sjakub@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/asus_oled/asus_oled.c
|
fb53440b187f0cfc1f116e580e9c7e9931191f9c |
|
05-Nov-2008 |
Jakub Schmidtke <sjakub@gmail.com> |
Staging: add asus_oled driver Driver for the OLED tiny display on some Asus laptops. From: Jakub Schmidtke <sjakub@gmail.com> Cc: Cyrill Gorcunov <gorcunov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/asus_oled/asus_oled.c
|