| 337503431ac94ab2651af63f40623aa7eccf263b |
|
13-Feb-2012 |
Jesper Juhl <jj@chaosbits.net> |
Staging, rtl8192e, softmac: remove redundant memset and fix mem leak
In drivers/staging/rtl8192e/rtllib_softmac.c::rtllib_rx_assoc_resp()
we allocate memory for 'network' with kzalloc() and then proceed to
zero the already zeroed mem we got from kzalloc() with
memset(). That's redundant, so remove the memset()
We also fail to kfree() the memory we allocated for 'network' if we do not enter
if (ieee->current_network.qos_data.supported == 1) {
and the variable then goes out of scope.
To fix that I simply moved the kfree() that was inside that 'if'
statement to instead be just after it. It then covers both the case
where we take the branch and when we don't.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| 3b148be0df8e45a0259d7e84001cf02e897af614 |
|
20-Dec-2011 |
Sean MacLennan <seanm@seanm.ca> |
staging/rtl8192e: Register against lib80211
Convert rtllib from registering the crypt drivers against rtllib_crypt
and instead register the against lib80211. The crypto functions have
R- prepended (R-CCMP, R-TKIP, R-WEP) so they will not clash with the
lib80211 versions.
We cannot use the lib80211 crypt drivers since the rtl8192e has some
hardware support that is not handled by the lib80211 crypt drivers.
Signed-off-by: Sean MacLennan <seanm@seanm.ca>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| 0ddcf5fdfac6bd80e153ee5c405bdfc9cb868b95 |
|
20-Dec-2011 |
Sean MacLennan <seanm@seanm.ca> |
staging/rtl8192e: Convert to lib80211_crypt_info
Convert rtllib to use lib80211_crypt_info.
Signed-off-by: Sean MacLennan <seanm@seanm.ca>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| 32c44cb5b9fdc6eaa445bd622008dd672a3dd1a7 |
|
20-Dec-2011 |
Sean MacLennan <seanm@seanm.ca> |
staging/rtl8192e: Convert to lib80211_crypt_data and lib80211_crypt_ops
Convert rtllib_crypt_data to lib80211_crypt_data and
rtllib_crypt_ops to lib80211_crypt_ops.
This is almost a 1:1 replacement, only extra_prefix_len and
extra_postfix_len changed.
Signed-off-by: Sean MacLennan <seanm@seanm.ca>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| 184f1938b29310a0df4298b57a7241832cb0813c |
|
20-Dec-2011 |
Sean MacLennan <seanm@seanm.ca> |
staging/rtl8192e: Add lib80211.h to rtllib.h
Add lib80211.h header file to rtllib.h and get it compiling.
Signed-off-by: Sean MacLennan <seanm@seanm.ca>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| e0ec8a67089762b29071e879388986ab7370d330 |
|
13-Dec-2011 |
Devendra Naga <devendra.aaru@gmail.com> |
staging: remove version.h includes in rtl8192e
Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| 3b28499c5519e59fbe9c2dea49ece5a3665be787 |
|
29-Nov-2011 |
Sean MacLennan <seanm@seanm.ca> |
rtl8192e: Export symbols
The rtl8192e driver had a natural split between the more generic
rtllib code and the more specific rtl8192e code. This patch exports
all the symbols needed by the r8192 specific code from the rtllib
generic code.
Signed-off-by: Sean MacLennan <seanm@seanm.ca>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| ea74fedced8235fb01fc317bcb8cd98d8aa71436 |
|
29-Nov-2011 |
Sean MacLennan <seanm@seanm.ca> |
rtl8192e: create generic rtllib_debug.h
Rename rtl_debug.h to rtllib_debug.h. Source files should include
rtllib.h if they are generic and rtl_core.h if they are r8192e
specific. Files should never include both.
Signed-off-by: Sean MacLennan <seanm@seanm.ca>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| d9317533c54836887d64bba973ae5c9c341b36a0 |
|
08-Nov-2011 |
Thomas Meyer <thomas@m3y3r.de> |
staging: rtl8192e: Use kmemdup rather than duplicating its implementation
Use kmemdup rather than duplicating its implementation
The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.
More information about semantic patching is available at
http://coccinelle.lip6.fr/
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| 929fa2a42e75e0c6ded89c450bd0f668e32190d7 |
|
10-Nov-2011 |
Thomas Meyer <thomas@m3y3r.de> |
staging: rtl8192e: Use kzalloc rather than kmalloc v2
Use kzalloc rather than kmalloc followed by memset with 0
This considers some simple cases that are common and easy to validate
Note in particular that there are no ...s in the rule, so all of the
matched code has to be contiguous
The semantic patch that makes this change is available
in scripts/coccinelle/api/alloc/kzalloc-simple.cocci.
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| 6f03053b6810c7ca315afb30b31b63d9f5863faf |
|
07-Nov-2011 |
Jesper Juhl <jj@chaosbits.net> |
rtl8192e: Don't copy huge struct by value (and make it const).
rtllib_is_shortslot() takes one argument - a struct that's more than a
kilobyte large. It should take a pointer instead of copying such a
huge struct - and the argument might as well be declared 'const' now
that we are at it, since it is not modified. This patch makes these
changes.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| d7613e535e9892ff12aa31b3c62f1be839546ff9 |
|
01-Sep-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Fix various problems noted by smatch
Smatch reports the following problems:
CHECK drivers/staging/rtl8192e/rtllib_softmac.c
drivers/staging/rtl8192e/rtllib_softmac.c +3143 rtllib_softmac_free(4) info: redundant null check on ieee->pDot11dInfo calling kfree()
CHECK drivers/staging/rtl8192e/rtllib_module.c
drivers/staging/rtl8192e/rtllib_module.c +198 free_rtllib(6) info: redundant null check on ieee->pHTInfo calling kfree()
CHECK drivers/staging/rtl8192e/rtl819x_TSProc.c
drivers/staging/rtl8192e/rtl819x_TSProc.c +280 SearchAdmitTRStream(52) error: potential null derefence 'pRet'.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| ec0dc6beea5436c037707dc0f501cf07878a8e2a |
|
25-Aug-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Fix sparse (non-endian) messages - Part I
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| ac50ddaaeeca4f649c53ce31175aa68d26420138 |
|
25-Aug-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove MAC_FMT and MAC_ARG for %pM
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| 9d92ece80d38a6fbf098bd924cf6db146c08f817 |
|
25-Aug-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Cleanup checkpatch -f errors - Part XIV
With this patch, all of the checkpatch errors are fixed; however, only
some of the lines that are too long were fixed. To complete the fixing
of these warnings, the file rtllib_softmac.c will need refactoring. In addition,
some of the variables may need renaming. Those changes can be deferred.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| 0dd565069b21ae20f4916cf305b64268bb3f9d3f |
|
25-Aug-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Modify time handling
In several places, the driver keeps times (in jiffies) in two 32-bit
quantities. In the rtl8192_hw_to_sleep(), there is an error in the
calculation of the difference between two 64-bit quantities. Rather
than fix that error, I have converted to a single 64-bit number. That
makes the code be much cleaner and clearer.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| 3b83db43ccbb26863f38caccc1e7fae370f31e57 |
|
19-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Convert typedef cb_desc to struct cb_desc
Remove typedef from struct.
Rename struct.
Rename uses.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| ca9900116fb3b758d226d08c1f5c792285941fb9 |
|
19-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Convert typedef RT_POWER_SAVE_CONTROL to struct rt_pwr_save_ctrl
Remove typedef from struct.
Rename struct.
Rename uses.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| 8310b6c05c65dfe699dd62be5d71c246ddaefd96 |
|
19-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Convert typedef OCTET_STRING to struct octet_string
Remove typedef from struct.
Rename struct.
Rename uses.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| 7796d93eae46054d5a3bb5411fde735801998dc5 |
|
19-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Convert typedef RT_HIGH_THROUGHPUT to struct rt_hi_throughput
Remove typedef from struct.
Rename struct.
Rename uses.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| ce403a6ac41ff2e745ddb415d83275eaf2207082 |
|
14-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove dead code associated with CUSTOMER_ID_INTEL_CMPC and CONFIG_CRDA
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| d32ddcba9d67b7d647576df9f8f62934956c60b9 |
|
14-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove dead code associated with FOR_ANDROID_X86 and FOR_MOBLIN
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| 07f432338accafb2002911a34309d822e168074a |
|
14-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove dead code associated with ADHOC_11N
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| f1c22567693a8c01a0bda0e3e29243eff3e5f196 |
|
14-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove dead code associated with WIFI_TEST
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| 6e2c538f8fbca87276a83eec5ac9212bbbfa13fa |
|
14-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove dead code associated with RTK_DMP_PLATFORM
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| 02525969666f1fe4718705d372afaafa9d12b612 |
|
14-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove dead code associated with SUPPORT_USPD
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| bf474281e98171b7491a8b759491f400bd6b1863 |
|
13-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove dead code associated with USB_TX_DRIVER_AGGREGATION_ENABLE
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| 2b259bd38fdfdf6a4103234172eafc13d7f774b6 |
|
13-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove ifdefs that depend on ENABLE_DOT11D
This configuration parameter is selected in the Makefile, thus the
conditional code can be removed.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| e755463c216b76f07692a83c6cd7197fa31e5d89 |
|
13-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove dead code from removal of ENABLE_TKIP11N
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| 0e3b1830591d7d5460e2346cdb535d209de2cab9 |
|
13-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove dead code associated with PF_SYNCTHREAD
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| 4ebba6d6e34796bdc5ead494111fb19c619eb599 |
|
13-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove dead code associated with COMPATIBLE_WITH_RALINK_MESH
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| a97dc3afc0d1f33fb8fff8e57f3644b3d09bacd0 |
|
13-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove dead code associated with USB_USE_ALIGNMENT
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| d064307a1a67c564caf69e1555d1aa62662217fb |
|
13-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove dead code involved with TO_DO
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| 15e7650e880b410d0a4c80aa586b5b2f96be3a61 |
|
13-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove dead code involved with TO_DO_LIST
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| 1e71e6d0cf764841cdf60dec4a40849ff41be75c |
|
12-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove dead code associated with RTL8192SE
The vendor code will generate several different drivers. As the RTL8192SE
is covered by a mac80211 driver in mainline, eliminate that code heere.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| 175159c537312f95150508655256645c8daa86a0 |
|
12-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove code dependent on RTL8190P
The vendor code can conditionally generate drivers for a number of
devices. Remove any code that depends on RTL8190P being set.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| 4f6807e8d2e972393009830d305ecec2d80c0449 |
|
11-Jul-2011 |
Mike McCormack <mikem@ring3k.org> |
rtl8192e: Remove occurences of #if 1
Signed-off-by: Mike McCormack <mikem@ring3k.org>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| cb76215448947ddcc133c4b1c2ff2d4a77e851e0 |
|
11-Jul-2011 |
Mike McCormack <mikem@ring3k.org> |
rtl8192e: Remove extra ifdefs
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Mike McCormack <mikem@ring3k.org>
/drivers/staging/rtl8192e/rtllib_softmac.c
|
| 94a799425eee8225a1e3fbe5f473d2ef04002577 |
|
24-Aug-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
From: wlanfae <wlanfae@realtek.com>
[PATCH 1/8] rtl8192e: Import new version of driver from realtek
Signed-off-by: wlanfae <wlanfae@realtek.com>
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
/drivers/staging/rtl8192e/rtllib_softmac.c
|