History log of /drivers/usb/serial/metro-usb.c
Revision Date Author Comments
b46b5ba5e79e61732af41dde4a9fd302a5f3184d 02-Jul-2012 Johan Hovold <jhovold@gmail.com> USB: metro-usb: fix tty_flip_buffer_push use

commit b7d28e32c93801d60c1a7a817f774a02b7bdde43 upstream.

Do not set low_latency flag at open as tty_flip_buffer_push must not be
called in IRQ context with low_latency set.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
3a450850e2bb0f92cacb12da90fe98eccd105468 19-Mar-2012 Aleksey Babahin <tamerlan311@gmail.com> USB: serial: metro-usb: Fix idProduct for Uni-Directional mode.

The right idProduct for Metrologic Bar Code Scanner
in Uni-Directional Serial Emulation mode is 0x0700.

Also rename idProduct for Bi-Directional mode to be a bit more informative.

Signed-off-by: Aleksey Babahin <tamerlan311@gmail.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5db51b50c10f3bf56d5c636832c5556ead90562d 08-Mar-2012 Greg Kroah-Hartman <gregkh@linuxfoundation.org> USB: serial: metro-usb: move to use dev_dbg() instead of dbg()

This properly ties the driver into the dynamic debug system and provides
the needed device identification when the messages are printed out.

It also removes a ton of checkpatch warnings as well, which is always a
nice validation that it's the correct thing to do.

Cc: Aleksey Babahin <tamerlan311@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8111e4ecf9373f6d76504416b0e76b18372f3598 08-Mar-2012 Greg Kroah-Hartman <gregkh@linuxfoundation.org> USB: serial: metro-usb: remove unneeded cast and function call

We should use kzalloc() instead of kmalloc() and memset(), and remove an
unneeded void * cast as well.

Cc: Aleksey Babahin <tamerlan311@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
dd63b0b4d6d036e1d5f7008c97c30789415489de 08-Mar-2012 Greg Kroah-Hartman <gregkh@linuxfoundation.org> USB: serial: metro-usb: remove function header comments

They aren't needed, make the checkpatch tool unhappy, and in some
places, aren't even correct. So just remove them, they get in the way
and are messy.

Cc: Aleksey Babahin <tamerlan311@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9fbd1649d54edc614c64ab075f7485622fd6450a 08-Mar-2012 Greg Kroah-Hartman <gregkh@linuxfoundation.org> USB: serial: metro-usb: remove function prototypes

By rearranging the functions a bit, we can remove all function
prototypes.

Note, this also deleted the _close function, as it wasn't needed, it was
doing the same thing the cleanup function did, so just call that
instead.

Cc: Aleksey Babahin <tamerlan311@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
d4cbd6e990a798d21577ee2f42a3880da09edf3a 08-Mar-2012 Greg Kroah-Hartman <gregkh@linuxfoundation.org> USB: serial: metro-usb: fix up coding style errors

This fixes up all of the coding style errors, and removes the initial,
unneeded comments on how to load the module and the old changelog which
are no longer needed.

There are still a number of coding style warnings left, I'll get to them
later.

Cc: Aleksey Babahin <tamerlan311@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
159d4d8d5e9416dba78b84d4be10d7b1172728ee 08-Mar-2012 Greg Kroah-Hartman <gregkh@linuxfoundation.org> USB: serial: metro-usb: remove the .h file

A driver doesn't need a .h file just for simple things like vendor ids
and a private structure. So move it into the .c file instead, saving
some overall lines.

Cc: Aleksey Babahin <tamerlan311@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1935e357bb2a3031772730293a3725e3cca07778 08-Mar-2012 Greg Kroah-Hartman <gregkh@linuxfoundation.org> USB: serial: metro-usb: convert to use module_usb_serial_driver

Now that we aren't doing anything special in the init function, move to
use the easier module_usb_serial_driver() call instead, saving a lot of
lines of unnecessary code.

Cc: Aleksey Babahin <tamerlan311@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fdac0f647a2cf12e7152dc1d94dd08a1af4a2a82 08-Mar-2012 Greg Kroah-Hartman <gregkh@linuxfoundation.org> USB: serial: metro-usb: remove vendor and product module parameters

All new usb serial drivers should be using the dynamic id function, not
having module parameters for this type of thing. So remove them before
anyone gets used to them being there.

Cc: Aleksey Babahin <tamerlan311@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11a4f40064f38dcc369d716bea2020f6b5e290ff 08-Mar-2012 Greg Kroah-Hartman <gregkh@linuxfoundation.org> USB: serial: metro-usb: fix up usb_serial_register calls

The usb serial core has changed how the driver is to be registered and
unregistered recently. Make these changes to the driver so that it will
properly build and work.

Cc: Aleksey Babahin <tamerlan311@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
43d186fe992da93bb1dd34a7dd4534719624431c 08-Mar-2012 Aleksey Babahin <tamerlan311@gmail.com> USB: serial: add metro-usb driver to the tree

This driver is for the Metrologic barcode scanner.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>