• Home
  • History
  • Annotate
  • only in /hardware/interfaces/audio/effect/2.0/
History log of /hardware/interfaces/audio/effect/2.0/
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
5abb15e9872a203bf2e5a8b879ac4842c8cac789 01-Jun-2017 Mikhail Naganov <mnaganov@google.com> VTS Audio Effect: Do not check the result of IEffect::offload method

HAL may not support offloading, and a call to IEffect::offload
is allowed to return an error code.

Update the test to only check that the call to the method doesn't
crash.

Bug: 38437110
Test: still passes
Change-Id: I6cfd25998edb9c68d2e585e572ba8ba3a3427e98
ts/functional/VtsHalAudioEffectV2_0TargetTest.cpp
76cfb841405a7884519181dd924459c142ac43dd 20-May-2017 Steven Moreland <smoreland@google.com> Update makefiles. (2/2)

Adds default configuration for all hals.

Bug: 38415912
Test: pass
Change-Id: Idd1f3a2b7b16ad956d31784a513e93a066cdd02e
ndroid.bp
c11724572e7604bd0c8390d83fd506a772d8d6cd 19-May-2017 Mikhail Naganov <mnaganov@google.com> VTS Audio Effect: Allow 'NOT_SUPPORTED' from IEffect::offload method

HAL may not support offloading, and a call to IEffect::offload
is allowed to return an error code.

Update the test to accept either OK or NOT_SUPPORTED.

Bug: 38437110
Test: still passes
Change-Id: I1822010eed73f61bb0e0ae1852739b47fa72eade
ts/functional/VtsHalAudioEffectV2_0TargetTest.cpp
bc7112412076c403b4cb0d5c7316f9ef39b7a20d 10-May-2017 Steven Moreland <smoreland@google.com> Update makefiles for c++-sources and c++-headers. (2/2)

Test: pass
Bug: 38174080
Change-Id: Icad451f9f9ad5f46412356a4171a8a1222f8e545
ndroid.bp
c8c6a81f0f0f0074260ee84b30df16dc480c4ee7 27-Apr-2017 Mikhail Naganov <mnaganov@google.com> audiohal: Support stateful downmixer effects

Fraunhofer's downmixer has additional buffering, this is incompatible
with how DownmixerBufferProvider used to process incomplete buffers.

Now the effects HIDL wrapper delivers frameCount updates in
audiobuffers to the server side. This fixes playback of multichannel
sound streams.

Bug: 36181621
Test: play 5.1 track from Play Music
Change-Id: Iffe3327c6eedef85151eec2b41e0aedfb7ffa6dc
efault/AudioBufferManager.cpp
95344ba2f5ae886f4f3c81903a456d1749b31a03 27-Apr-2017 Mikhail Naganov <mnaganov@google.com> Merge "audiohal: Fix handling of invalid arguments in 'debugDump' methods" into oc-dev
3e6fe754f647db202a7a455adcf1ab5d686105d3 24-Apr-2017 Mikhail Naganov <mnaganov@google.com> audiohal: Fix handling of invalid arguments in 'debugDump' methods

Add checks for validity of the passed in native handle.

Bug: 37590777
Change-Id: If906f0086c3442819e1844cc521215d5b74af015
Test: VTS
(cherry picked from commit 7bae6a0b635b142cfba9d4c4612e1e114f85b842)
efault/EffectsFactory.cpp
ts/functional/VtsHalAudioEffectV2_0TargetTest.cpp
3a2470f82dc9e5d27ecb68b8ed64d1413f4f6d3a 25-Apr-2017 Mikhail Naganov <mnaganov@google.com> audiohal: Fix typos in comments, add missing comments

These changes are in comments only, no ABI breaking changes.

Bug: 32238101
Test: make
Change-Id: Iead4ba01dae1a1c05d8fbed7f194182128e9e6ad
DownmixEffect.hal
EnvironmentalReverbEffect.hal
PresetReverbEffect.hal
VisualizerEffect.hal
a8a9cc660688cdd4b40a4dd1091d65bf29c0e423 17-Apr-2017 Steven Moreland <smoreland@google.com> audio hal: explicitly import headers

Test: works with BOARD_VNDK_VERSION := current
Bug: 33241851
Change-Id: I34983a5527a16e8e9f5a6a87edac0b741aeb67d6
efault/Android.mk
6fa374ad303ad4478014d175298222ca92a43593 13-Apr-2017 Andreas Huber <andih@google.com> Changed the naming scheme for Treble java libraries (both static and dynamic)

android.hardware.foo@1.0-java => android.hardware.foo-V1.0-java

Bug: 37207894
Test: make
Change-Id: I177f4cfd42f635aaf096107af8309d1a82ed41c0
Merged-In: I8b91881dfaf507c0d852d56ebbb53ff0987e5a34
ndroid.mk
3b36a83a2e2f96e4cbcc9d022bebd0e59205c5af 11-Apr-2017 Steven Moreland <smoreland@google.com> Update makefiles (2/2).

Test: pass
Change-Id: Ic7e6289c7b69785491708ce0acbb657f4c704229
ndroid.bp
40d3a9bd8c62714ee58f9363c4456f764aa5a95d 29-Mar-2017 Andreas Huber <andih@google.com> Convert all comments into "doxygen-ready" comments.

Bug: 36453077
Test: mma
Change-Id: I0b1f77dfae5d2258969e33d85ecf45401ffbdfaa
AcousticEchoCancelerEffect.hal
AutomaticGainControlEffect.hal
BassBoostEffect.hal
Effect.hal
EffectBufferProviderCallback.hal
EffectsFactory.hal
EnvironmentalReverbEffect.hal
EqualizerEffect.hal
LoudnessEnhancerEffect.hal
NoiseSuppressionEffect.hal
VirtualizerEffect.hal
VisualizerEffect.hal
ypes.hal
561b602a9984624c8459bbd3d7b8bd74853fc18d 27-Mar-2017 Steven Moreland <smoreland@google.com> Update makefiles for hwtypes.h

Test: pass
Change-Id: I8e17eb8fec5d2f04c526476a866c8dd54ccb556c
ndroid.bp
8b624737d79db808124303bdf684ab3fa3e3bb77 27-Mar-2017 TreeHugger Robot <treehugger-gerrit@google.com> Merge "audiohal: Add crash tests for some methods of IEffect"
05fa0d0312e8702b90944c522a95f98d67044bc2 25-Mar-2017 Mikhail Naganov <mnaganov@google.com> audiohal: Add crash tests for some methods of IEffect

For methods that can't be meaningfully tested, add tests
verifying that they at least don't crash.

Bug: 32022706
Change-Id: I234c2ae4b6bc173450cf50e8749ea966cbc2d2a2
Test: this is a test
ts/functional/VtsHalAudioEffectV2_0TargetTest.cpp
b0dd076c60fb9d4860ef4bdd8865f1f21eb92af8 22-Mar-2017 Mikhail Naganov <mnaganov@google.com> audiohal: Remove stale TODOs

Bug: 34109709
Change-Id: I9b30ffa2ed06be8cf31cdbfbcc0f4cb0dac7be54
Test: make
EffectBufferProviderCallback.hal
efault/Effect.cpp
9f2890458a2e0b9fa09ceeba64c869bf3f1560c3 23-Feb-2017 Mikhail Naganov <mnaganov@google.com> Add VTS tests for audio effects

Added tests covering IEffect, IEqualizerEffect, and
ILoudnessEnhancer interfaces.

Minor corrections in the interface definitions and implementations:

- fixed descriptions and @callflow annotations in IEffect;

- fixed type used for band levels in IEqualizerEffect;

- fixed specification of frequencies in IEqualizerEffect;

- fixed some bugs in previously non-execrices Effects code;

- warning messages changed to error messages.

Test: this is a test
Bug: 32022706
Change-Id: I0e0bc111b07d944ad8a0321e8b1ec703f8d1a73e
Effect.hal
EqualizerEffect.hal
efault/Effect.cpp
efault/Effect.h
efault/EffectsFactory.cpp
efault/EqualizerEffect.cpp
efault/EqualizerEffect.h
efault/LoudnessEnhancerEffect.cpp
ts/functional/Android.bp
ts/functional/VtsHalAudioEffectV2_0TargetTest.cpp
ed2bb4e8f851688c09f7639a9183b1285aa0967c 10-Mar-2017 Yuexi Ma <yuexima@google.com> Change vts target base test class name

Test: make vts succeed, vts kernel tests and nfc hal tests passed
Change-Id: I95f10ad7a66f261c9030357edd411fe6d94150e8
ts/functional/Android.bp
ts/functional/VtsHalAudioEffectV2_0TargetTest.cpp
48c52249e47a4d742faf037d6de7811f57de85e1 09-Mar-2017 Steven Moreland <smoreland@google.com> hidl_default to all targets.

find hardware/interfaces -type f -not -path "*/.git/*" \
-exec sed -i -e '/cc_[A-Za-z_]\+/ { N; s/$/\n defaults:
\["hidl_defaults"\],/ }' {} \;
./hardware/interfaces/update-makefiles.sh

Test: pass
Bug: 35840847
Change-Id: If10c464d2f000b85c8d698fe11a4f3fc4cfad282
ts/functional/Android.bp
50d7e27b3c13885d2bd90dc0f0f2366cd0523f77 28-Feb-2017 Yuexi Ma <yuexima@google.com> change all vts hidl tests to use VtsHalHidlTargetBaseTest (internal master)

Bug: 33385836
Test: mma
Change-Id: Ide3ebc4a9db76257f33bcfb0c1f13d2ee33eeaa8
ts/functional/Android.bp
ts/functional/VtsHalAudioEffectV2_0TargetTest.cpp
7e73d5b90831df7fdbced22792e5198fcae897af 24-Feb-2017 Steven Moreland <smoreland@google.com> Remove viral dependency on libhwbinder. (2/2)

find hardware/interfaces -name Android.mk -exec sed -i -e '/libhwbinder
\\/d' {} \;
find hardware/interfaces -name Android.bp -exec sed -i -e
'/"libhwbinder"/d' {} \;
./hardware/interfaces/update-makefiles.sh

Note, automotive has some actual dependencies on libhwbinder, filed
b/35758626 for this.

Test: everything links
Test: (sanity) booted marlin on internal master with these changes
Bug: 35710429
Change-Id: I6d0726c8130d00684b978efbdd48e3ae396f12e5
efault/Android.mk
ts/functional/Android.bp
8422f6aa046e86ccd06e62dcbd611073355cfa08 18-Feb-2017 Zhuoyao Zhang <zhuoyao@google.com> Update the test binary and source file name on master.

* To confirm with Vts naming convention.

Bug: 35273456
Test: mma
Change-Id: I845da64085253cd02480465479618308045a52ed
ts/functional/Android.bp
ts/functional/VtsHalAudioEffectV2_0TargetTest.cpp
ts/functional/audio_effect_hidl_hal_test.cpp
549ca2bbe8bf333a3dcadcae9605bc8b0d237910 24-Jan-2017 Chris Phoenix <cphoenix@google.com> audio_effect HAL uses "default" service name

The getService() and registerAsService() methods of interface objects
now have default parameters of "default" for the service name. HALs
will not have to use any service name unless they want to register
more than one service.

Test: builds; VTS HalAudioEffectHidlTargetBasicTest passes

Bug: 33844934
Change-Id: I7796982c4cad976aeeabf7708ec0104505332cad
ts/functional/audio_effect_hidl_hal_test.cpp
a0da1a1c3dadac195e598890360c7b9226874ba8 13-Feb-2017 Steven Moreland <smoreland@google.com> Move hidl shims to the vendor partition. (2/2)

We need google shims on the vendor partition because they are providing
an implementation of a vendor defined interface. They were written by
google just as a courtesy/to make the transition easier. They're
basically a set for vendors to assemble their hal implementations
from.

Bug: 34135607
Test: marlin persist.hal.binderization on/off
Change-Id: I2e2af5af39264cf290259755bb9b2eb9827a21f5
efault/Android.mk
86fa244c1219ef92e949f6cf47562031d79a0466 11-Feb-2017 TreeHugger Robot <treehugger-gerrit@google.com> Merge "Update makefiles to use filgroup syntax."
b2e8954c7c4c5279931e3e357ddc0261c3d96bf7 11-Feb-2017 TreeHugger Robot <treehugger-gerrit@google.com> Merge "audio: Remove timeout from waits on event flags in HAL driver threads"
85120c9490dfc53421a0eeee648acf65ac96cefb 10-Feb-2017 Tri Vo <trong@google.com> Update makefiles to use filgroup syntax.

Test: mmma hardware/interfaces
Change-Id: I9f4457c78b7820c242d46359f0debe05d1b3e482
ndroid.bp
e867456982c1ee68e884294f5655abb6212ab533 10-Feb-2017 Mikhail Naganov <mnaganov@google.com> audio: Remove timeout from waits on event flags in HAL driver threads

This fixes a power regression caused by periodic wakeups of
the driver threads even when the device is idle.

The timeout is really not needed, it used to be there to ensure that
the thread exits its loop, but then an explicit wake-up call before
closing the thread had been added for this purpose.

Bug: 34682579
Test: Follow repro steps from the bug, compare power consumption
to the legacy version of the audio HAL.

Change-Id: I0bfc2079a449894c5d0bd6ef19b53ca425795a9e
efault/Effect.cpp
d38f147c357a9a39ae923bff1786070faf7ba751 09-Feb-2017 Andreas Huber <andih@google.com> Updated makefiles

Java intermediates are now created in the common rather than the device-
specific generated sources subdirectory.

Bug: 33842609
Test: make
Change-Id: I16af4cd19bf0b24baa0ad9ebfdb86b4d959c8672
ndroid.mk
ce608bec74a947ebd9875004dc5dc4594629c440 08-Feb-2017 Tri Vo <trong@google.com> Migrate driver/profiler to test/vts-testcase/hal.

Bug: 34893894
Test: mmma hardware/interfaces

Change-Id: Ic72716577a5f93700c5056986aff55a76b170b5d
ndroid.bp
9bb90a55d6ddc81d40556f05a3f2e3f4612b9b8b 06-Feb-2017 Mikhail Naganov <mnaganov@google.com> Merge "audiohal: Make closing of effects and streams fast"
7b9b6ca18f182e66c35afc0ca4838175a406838b 03-Feb-2017 Keun Soo Yim <yim@google.com> move VTS stub files and non-functional tests

Test: mma
Bug: 34976004
Change-Id: I20273bdc3a05e2986fcf921f65d2afd6d72781e4
ts/functional/Android.mk
ts/functional/vts/Android.mk
ts/functional/vts/testcases/Android.mk
ts/functional/vts/testcases/hal/Android.mk
ts/functional/vts/testcases/hal/audio/Android.mk
ts/functional/vts/testcases/hal/audio/effect/Android.mk
ts/functional/vts/testcases/hal/audio/effect/hidl/Android.mk
ts/functional/vts/testcases/hal/audio/effect/hidl/target/Android.mk
ts/functional/vts/testcases/hal/audio/effect/hidl/target/AndroidTest.xml
ts/functional/vts/testcases/hal/audio/effect/hidl/target_profiling/Android.mk
ts/functional/vts/testcases/hal/audio/effect/hidl/target_profiling/AndroidTest.xml
e9b43bbe2d58dd1ae652eeff339771b01cec7d29 03-Feb-2017 Zhuoyao Zhang <zhuoyao@google.com> Update Andriod.bp for hals.

* Add driver/profiler build rule for all hals.

Test: mma
Change-Id: I98325f7af14fec7dd1bb64b1668de8c7c20ace92
ndroid.bp
b0abafbf0a6174e8c8933cc5fb19501a2d22c53b 01-Feb-2017 Mikhail Naganov <mnaganov@google.com> audiohal: Make closing of effects and streams fast

There were two problems:

1. Joining of reader / writer / process threads (the threads that
interact with HAL) was taking up to 1 second because the thread
was usually waiting for an event flag to be toggled, or a 1s
timeout.

2. Calling IStream.close or IEffect.close shouldn't tax the caller.
Changed the code so a call to close only signals the thread that
it's time to exit, and then the thread is only joined in the
effect or stream destructor.

Bug: 34800063
Bug: 34499806
Test: see repro steps in the bugs
Change-Id: Ife20524a1eba4ec9a78152e89862526e8cd5c960
efault/Effect.cpp
ypes.hal
b21bdc8b9f296a616181cf1eedcc35c758d6b609 25-Jan-2017 Keun Soo Yim <yim@google.com> use the device's default binder/passthrough mode in vts tests

Test: mma
Change-Id: I3f2775873f5b6c091f70413adbdf7b7ae298ff44
ts/functional/audio_effect_hidl_hal_test.cpp
f4f2ff39746a36b3d657e34ec1724589051b1ec8 19-Jan-2017 Mikhail Naganov <mnaganov@google.com> audiohal: Fix volume changes handling

Some legacy implementations of the effects HAL use the condition
of the reply buffer being NULL as an indication that they shouldn't
apply attenuation to the input audio data. Therefore, separate
methods are needed to distinguish the use cases of delegating the
volume control to the effect, and just informing the effect of the
volume changes.

A new method added to IEffect: volumeChangeNotification that implements
the second use case. The contract of setAndGetVolume method has been
updated to indicate that it is only called in the first use case.

Also updated the wrapper for a generic IEffect commands to pass NULL
pointers to the command and reply buffers in case when the size
of the input or output data is 0, to preserve compatibility with
direct calls from the framework.

Bug: 34368451
Test: volume control works when both Bass Boost and Equalizer are
enabled in the NXP implementation of the effects

Change-Id: I3c9a5bbdff561802bc94080c51703385a8903282
Effect.hal
efault/AcousticEchoCancelerEffect.cpp
efault/AcousticEchoCancelerEffect.h
efault/AutomaticGainControlEffect.cpp
efault/AutomaticGainControlEffect.h
efault/BassBoostEffect.cpp
efault/BassBoostEffect.h
efault/DownmixEffect.cpp
efault/DownmixEffect.h
efault/Effect.cpp
efault/Effect.h
efault/EnvironmentalReverbEffect.cpp
efault/EnvironmentalReverbEffect.h
efault/EqualizerEffect.cpp
efault/EqualizerEffect.h
efault/LoudnessEnhancerEffect.cpp
efault/LoudnessEnhancerEffect.h
efault/NoiseSuppressionEffect.cpp
efault/NoiseSuppressionEffect.h
efault/PresetReverbEffect.cpp
efault/PresetReverbEffect.h
efault/VirtualizerEffect.cpp
efault/VirtualizerEffect.h
efault/VisualizerEffect.cpp
efault/VisualizerEffect.h
5d406a3a3766f7f4e4d8f9be841bd416326cb93e 19-Jan-2017 Keun Soo Yim <yim@google.com> Merge "add target-side profiling test for multimedia HIDL HALs"
e64871a894fe103b6df31cafe606db5424e1cbdb 05-Jan-2017 Keun Soo Yim <yim@google.com> add target-side profiling test for multimedia HIDL HALs

Test: mma
Change-Id: I14aeb000e2a17381c28ea2115d67a7e8eb84e375
ts/functional/vts/testcases/hal/audio/effect/hidl/target_profiling/Android.mk
ts/functional/vts/testcases/hal/audio/effect/hidl/target_profiling/AndroidTest.xml
96232e327f166061c6362adc6a24e909967b0982 14-Jan-2017 Steven Moreland <smoreland@google.com> Revert "Revert "move VTS HIDL HAL tests to the corresponding interface directories""

This reverts commit 070e8d211663bc90370cb5d84de8c66eb25200cf.

Change-Id: I66dd4e6cf875e39e58b0d91724a603b37d32c0ac
ts/Android.mk
ts/functional/Android.mk
ts/functional/vts/Android.mk
ts/functional/vts/testcases/Android.mk
ts/functional/vts/testcases/hal/Android.mk
ts/functional/vts/testcases/hal/audio/Android.mk
ts/functional/vts/testcases/hal/audio/effect/Android.mk
ts/functional/vts/testcases/hal/audio/effect/hidl/Android.mk
ts/functional/vts/testcases/hal/audio/effect/hidl/target/Android.mk
ts/functional/vts/testcases/hal/audio/effect/hidl/target/AndroidTest.xml
070e8d211663bc90370cb5d84de8c66eb25200cf 14-Jan-2017 Ruchi Kandoi <kandoiruchi@google.com> Revert "move VTS HIDL HAL tests to the corresponding interface directories"

Test: No
This reverts commit ec7746fa808e4814b07a1b8018c7ee44f16cc9a6.

Change-Id: I9ec4493403d71419df99fe9761211eab057cdb0a
ts/Android.mk
ts/functional/Android.mk
ts/functional/vts/Android.mk
ts/functional/vts/testcases/Android.mk
ts/functional/vts/testcases/hal/Android.mk
ts/functional/vts/testcases/hal/audio/Android.mk
ts/functional/vts/testcases/hal/audio/effect/Android.mk
ts/functional/vts/testcases/hal/audio/effect/hidl/Android.mk
ts/functional/vts/testcases/hal/audio/effect/hidl/target/Android.mk
ts/functional/vts/testcases/hal/audio/effect/hidl/target/AndroidTest.xml
f276d1923efbf137546c5b716931d5ca120540c0 12-Jan-2017 Ryan Campbell <ryanjcampbell@google.com> Remove coverage from test configurations.

Remove converage from test configs or entire config if not used
to define other test params. Tested each one individually to ensure
coverage still works.

Test: run vts -m (each test affected)
Change-Id: Ic1495a38ae9d1b32e851bc646f9c8e778eee2df1
ts/functional/vts/testcases/hal/audio/effect/hidl/target/AndroidTest.xml
ts/functional/vts/testcases/hal/audio/effect/hidl/target/HalAudioEffectHidlTargetBasicTest.config
a8d358fb6313724ab1ae68c487c2006569cd5091 12-Jan-2017 TreeHugger Robot <treehugger-gerrit@google.com> Merge changes from topic 'bphwfoo'

* changes:
Bp/nFoo -> Bp/nHwFoo.
Bp/nFoo -> Bp/nHwFoo
a18049ad138a79890c79335e90822215d7df506f 11-Jan-2017 Yifan Hong <elsk@google.com> Bp/nFoo -> Bp/nHwFoo.

Test: mma
Bug: 33554989
Change-Id: I4b3f852d20fdfc49f2da671dd3c12d618ffb4140
ndroid.bp
a331de14219b34b08f4cbb462a45f1fd82a92d48 05-Jan-2017 Mikhail Naganov <mnaganov@google.com> audiohal: Re-implement effect process using FMQ and IMemory

Result: no hwbinder calls due music processing.

Added IEffect.close method for explicitly freeing up of resources
consumed by the effect before automatic server objects reaping
gets to it.

Added IEffect.setProcessBuffers method for updating the input /
output buffers on the go.

Test: make, use Play Music with effects, check traces
Bug: 30222631
Change-Id: Ia1e1bc7098fab59aa970e0ce4acdb48007409644
Effect.hal
efault/AcousticEchoCancelerEffect.cpp
efault/AcousticEchoCancelerEffect.h
efault/Android.mk
efault/AudioBufferManager.cpp
efault/AudioBufferManager.h
efault/AutomaticGainControlEffect.cpp
efault/AutomaticGainControlEffect.h
efault/BassBoostEffect.cpp
efault/BassBoostEffect.h
efault/DownmixEffect.cpp
efault/DownmixEffect.h
efault/Effect.cpp
efault/Effect.h
efault/EnvironmentalReverbEffect.cpp
efault/EnvironmentalReverbEffect.h
efault/EqualizerEffect.cpp
efault/EqualizerEffect.h
efault/LoudnessEnhancerEffect.cpp
efault/LoudnessEnhancerEffect.h
efault/NoiseSuppressionEffect.cpp
efault/NoiseSuppressionEffect.h
efault/PresetReverbEffect.cpp
efault/PresetReverbEffect.h
efault/VirtualizerEffect.cpp
efault/VirtualizerEffect.h
efault/VisualizerEffect.cpp
efault/VisualizerEffect.h
ypes.hal
f755f46ca8adbd31e0abc1ebbfb982932d0809fa 05-Jan-2017 Keun Soo Yim <yim@google.com> add coverage config to audio effect VTS test

Test: mma
Change-Id: I5d3854e124df2054860a1bcba65e79ce2d858694
ts/functional/vts/testcases/hal/audio/effect/hidl/target/AndroidTest.xml
ts/functional/vts/testcases/hal/audio/effect/hidl/target/HalAudioEffectHidlTargetBasicTest.config
b6438421923590b765905efe151e26129dce4094 04-Jan-2017 Steven Moreland <smoreland@google.com> Return<*> getStatus().isOk() -> isOk()

Bug: 31348667
Test: compiles
Change-Id: If8d5a23f80dbc04127635b49f1ef77398fc9f8a1
ts/functional/audio_effect_hidl_hal_test.cpp
6a56e38e08a743055cec6ed6e5262579bccc887f 22-Dec-2016 Yifan Hong <elsk@google.com> Moved operator== to be autogen'd by hidl-gen.

Test: audio_effect_hidl_hal_test
Bug: 32834072
Change-Id: I58e8eb6ed85f8f1adce8c9334f7934146174e981
ts/functional/audio_effect_hidl_hal_test.cpp
f35ee3b192f76583f7ccb170d7f1dab36cf9e06c 13-Dec-2016 Yifan Hong <elsk@google.com> Revert "Revert "Update makefiles for Java package path.""

This reverts commit a8789f27cb89496675483b83c76f271474085d62.

Change-Id: I69980b580a556188ba868bb096ae1590b01759f5
ndroid.mk
a8789f27cb89496675483b83c76f271474085d62 13-Dec-2016 Yifan Hong <elsk@google.com> Revert "Update makefiles for Java package path."

This reverts commit ab0792ccdc52958b9bd524e7025d5e38ea0bb0d6.

Change-Id: I47fc272d9fa8875e3d7ccb10cb748c738fbf8135
ndroid.mk
ab0792ccdc52958b9bd524e7025d5e38ea0bb0d6 13-Dec-2016 Yifan Hong <elsk@google.com> Update makefiles for Java package path.

use V1_0 instead of 1.0.

Bug: 33554192

Test: hidl_test_java
Change-Id: Ic2d95265df10914a60a5bb743d75e839948838c3
ndroid.mk
501839495fb4c03222ee1449b05fdee452516250 29-Nov-2016 Yifan Hong <elsk@google.com> Update makefiles for hidlizing IBase.

A new dependency android.hidl.base@1.0 is added for
all projects.

Test: mma

Change-Id: Ia70d0eb0d74de06475a339698386d383d491a43a
ndroid.bp
ndroid.mk
7bdce32513128aeee040f5ea0fcf2773f2e1e557 02-Dec-2016 Yifan Hong <elsk@google.com> Merge "Update to use the correct logging library."
f9d303435d80161fabb16cdff3b8f2f75f362480 30-Nov-2016 Yifan Hong <elsk@google.com> Update to use the correct logging library.

Test: mma compiles
Change-Id: Idb33dea5faaf1a5e54719c2a5a683d2d47e9b8e8
efault/AcousticEchoCancelerEffect.cpp
efault/AutomaticGainControlEffect.cpp
efault/BassBoostEffect.cpp
efault/DownmixEffect.cpp
efault/Effect.cpp
efault/EffectsFactory.cpp
efault/EnvironmentalReverbEffect.cpp
efault/EqualizerEffect.cpp
efault/LoudnessEnhancerEffect.cpp
efault/NoiseSuppressionEffect.cpp
efault/PresetReverbEffect.cpp
efault/VirtualizerEffect.cpp
efault/VisualizerEffect.cpp
ts/functional/audio_effect_hidl_hal_test.cpp
a9a58c150de0bdbf795e06218d1d4d19e10cf5bf 02-Dec-2016 Mikhail Naganov <mnaganov@google.com> Merge "Audio HAL: fixes for issues discovered after client conversion"
6e81e9bb3c13d8c51fde503cf8be2bfb56e1ca1d 17-Nov-2016 Mikhail Naganov <mnaganov@google.com> Audio HAL: fixes for issues discovered after client conversion

Several issues addressed:

-- added IDevice.supportsAudioPatches to query whether
create/removeAudioPatch is actually supported by HAL;

-- IStreamOutCallback proxy needs to be owned by IStreamOut
implementation. In order for the client to reset the reference,
added method IStreamOut.clearCallback;

-- IDevice.open{Input|Output}Stream need to return a "suggested" audio
config from HAL;

-- code for converting between system/audio.h and HIDL
data structures has been moved to
android.hardware.audio.common@2.0-util library for reuse;

-- added a workaround for the issue with QC effects HAL trying to write
into the input parameters buffer, which is r/o by Binder design.

Bug: 30222631
Change-Id: I64af24d79c12d6ac3b0f87d085a821913e29237b
Test: tried using with WIP HIDL client on N5X
efault/Conversions.cpp
efault/Conversions.h
efault/Effect.cpp
efault/Effect.h
efault/EffectsFactory.cpp
32094ca29f4f9314bacc9d4644966ad5ffac0673 30-Nov-2016 TreeHugger Robot <treehugger-gerrit@google.com> Merge changes I0b1a0979,I4aa89a39

* changes:
Added AOSP license headers.
Remove HIDL_GENERATED from things written by hand.
d6e4f03acf5fa1e76b75e33af7a26f248a92be9a 29-Nov-2016 Steven Moreland <smoreland@google.com> Remove HIDL_GENERATED from things written by hand.

find . -name "*.h" -exec sed -i 's/HIDL_GENERATED_\(.*\)_H_/\U\1_H/g' {}
+

They now match what would be generated by -Lc++-impl. This prevents
confusion over whether or not the files are autogenerated.

Change-Id: I4aa89a39907024aa9525df71ff3715979f431357
Similar commit: https://android-review.googlesource.com/#/c/305996/
Test: pass
efault/AcousticEchoCancelerEffect.h
efault/AutomaticGainControlEffect.h
efault/BassBoostEffect.h
efault/DownmixEffect.h
efault/Effect.h
efault/EffectsFactory.h
efault/EnvironmentalReverbEffect.h
efault/EqualizerEffect.h
efault/LoudnessEnhancerEffect.h
efault/NoiseSuppressionEffect.h
efault/PresetReverbEffect.h
efault/VirtualizerEffect.h
efault/VisualizerEffect.h
d26dc50abbad068cd1a673f204fa538c1c61bdb2 29-Nov-2016 Steven Moreland <smoreland@google.com> Always specify underlying enum type.

Bug: 33197891
Test: compiles
Change-Id: I3d4822ea9a665708302d3bd1460425fddf1dcda9
DownmixEffect.hal
NoiseSuppressionEffect.hal
PresetReverbEffect.hal
VisualizerEffect.hal
ypes.hal
bbff14d4bb5345d605fcfb8040e5bfe1f4110aa5 22-Nov-2016 Steven Moreland <smoreland@google.com> Merge "Update makefiles for logging."
b74aac81074405dbccfc8bfc20bdc33b3eff2409 22-Nov-2016 Keun Soo Yim <yim@google.com> Merge "move VTS HIDL HAL tests to the corresponding interface directories"
70b9a15df00a42b319279d903bf5923564920e3b 18-Nov-2016 Martijn Coenen <maco@google.com> Use newly introduced hidl_handle.

Bug: 32089785
Test: builds
Change-Id: I27c7d3945e1fe390661bf322987011a00fe9b3fe
efault/EffectsFactory.cpp
efault/EffectsFactory.h
8a36c0b01c6aad5fbcc238ba81337b205f897df3 18-Nov-2016 Keun Soo Yim <yim@google.com> move VTS HIDL HAL tests to the corresponding interface directories

Bug: 32783461
Test: vts-tradefed; run vts-hal-hidl
Change-Id: Iead44eaf65dcd4de2286267467c4a4a322a88205
ts/Android.mk
ts/functional/Android.mk
ts/functional/vts/Android.mk
ts/functional/vts/testcases/Android.mk
ts/functional/vts/testcases/hal/Android.mk
ts/functional/vts/testcases/hal/audio/Android.mk
ts/functional/vts/testcases/hal/audio/effect/Android.mk
ts/functional/vts/testcases/hal/audio/effect/hidl/Android.mk
ts/functional/vts/testcases/hal/audio/effect/hidl/target/Android.mk
ts/functional/vts/testcases/hal/audio/effect/hidl/target/AndroidTest.xml
f8d68ec8555a92b8f3a2f534a90a6cab8cb669c6 22-Nov-2016 Steven Moreland <smoreland@google.com> Update makefiles for logging.

Bug: 32943424
Test: pass
Change-Id: Ic88ce6adf04e0e36db53e4cc06ac2ec5a90c011c
ndroid.bp
6b920e43d379cdca8afe1831705690b95b3d71ef 16-Nov-2016 Yifan Hong <elsk@google.com> Split libhidl into base and transport.

Bug: 32756130

Test: mma
Change-Id: Id21cf23abe2910f26bb7895511862443b93dc112
ndroid.bp
efault/Android.mk
ts/functional/Android.bp
10548295023bee99108e418499aff09fe578211e 31-Oct-2016 Mikhail Naganov <mnaganov@google.com> Implement audio devices and streams HAL delegating to legacy HAL

Changes made to the .hal definition:

- introduce Effect ID returned by the IEffectsFactory that
needs to be passed to IStream.{add|remove}Effect; otherwise
it's impossible to retrieve the underlying HAL effect handle;

- change "bus address" in DeviceAddress to "string" type;

- fix signature of some methods w.r.t. returning Result;

- remove unused "struct AudioPatch".

Bug: 30222631
Test: make
Change-Id: Icb51729ef57bb2a5b0b78609735e7481bc04f95c
EffectsFactory.hal
efault/Android.mk
efault/Effect.cpp
efault/EffectsFactory.cpp
ts/functional/audio_effect_hidl_hal_test.cpp
bf39317f3793a04ab43e921ee2cbb9f72ef003c9 12-Nov-2016 Mikhail Naganov <mnaganov@google.com> Add simple target-side VTS test for IEffectFactory.hal

Bug: 32022706
Change-Id: Id8a5a3ba8d48967beba0ef2e232624ebc185e5c6
Test: build & run test
ts/functional/Android.bp
ts/functional/audio_effect_hidl_hal_test.cpp
c2f2779d9d224c0bb1b8b86d5dc44d7e7ad82f1a 08-Nov-2016 Yifan Hong <elsk@google.com> Update Android.bp to reexport dependent packages.

Test: mma
Change-Id: Iaca7300c366c2c9e860a29e6a111248d315cc5b4
ndroid.bp
0522f89c8e6293d5fec12e7c6641466e4ce28ff0 07-Nov-2016 Mikhail Naganov <mnaganov@google.com> Merge "Implement audio effects HAL delegating to legacy HAL"
b785f5b82ef2efa62ca9d7288cfff64c178080b0 04-Nov-2016 Colin Cross <ccross@android.com> Support genrules with multiple tools

To allow genrules with more than one tool, rename the tool property to
tools and make it an array, replace $tool with $(location <label>),
and use $() for other variables for consistency.

Bug: 31948427
Test: compare build.ninja
Change-Id: I3d714f70a2af0dc60faeee10e09b6ed166601f1d
ndroid.bp
7cbf2f1fb15a2a7d9b8b61ca81ad93fa9ddcaea3 28-Oct-2016 Mikhail Naganov <mnaganov@google.com> Implement audio effects HAL delegating to legacy HAL

Changes made to the .hal definition:

- added missing generated Result for methods implemented via legacy
"command" function;

- fixed Aux Channels feature definition;

- added "size" parameter for reply data in cases where the wrapper
needs to allocate a reply buffer;

- added method for generic support of feature configs;

- added new Result type;

- use arrays instead of strings in effect descriptor to ease
conversion from / to legacy HAL;

- added missing method to the Preset Reverb interface;

- fixed names of the Visualizer enums to avoid clashes with defines
from the legacy HAL file.

The implementation isn't hooked up to the server yet. Need to implement
devices and streams first.

Bug: 30222631
Change-Id: I75bb42f19ac3303759e918b6d6a91646b1555f8c
Test: make
Effect.hal
EnvironmentalReverbEffect.hal
VisualizerEffect.hal
efault/AcousticEchoCancelerEffect.cpp
efault/AcousticEchoCancelerEffect.h
efault/Android.mk
efault/AutomaticGainControlEffect.cpp
efault/AutomaticGainControlEffect.h
efault/BassBoostEffect.cpp
efault/BassBoostEffect.h
efault/Conversions.cpp
efault/Conversions.h
efault/DownmixEffect.cpp
efault/DownmixEffect.h
efault/Effect.cpp
efault/Effect.h
efault/EffectsFactory.cpp
efault/EffectsFactory.h
efault/EnvironmentalReverbEffect.cpp
efault/EnvironmentalReverbEffect.h
efault/EqualizerEffect.cpp
efault/EqualizerEffect.h
efault/LoudnessEnhancerEffect.cpp
efault/LoudnessEnhancerEffect.h
efault/NoiseSuppressionEffect.cpp
efault/NoiseSuppressionEffect.h
efault/PresetReverbEffect.cpp
efault/PresetReverbEffect.h
efault/VirtualizerEffect.cpp
efault/VirtualizerEffect.h
efault/VisualizerEffect.cpp
efault/VisualizerEffect.h
ypes.hal
fcd74ebcdc21e8b20a4556c4795f857247957398 02-Nov-2016 Steven Moreland <smoreland@google.com> Running update makefiles.

https://android-review.googlesource.com/#/c/298160/

Test: pass
Change-Id: I14fcde2d3aacc8f8cd9221f2d69e2feae9ae1226
ndroid.bp
69727778a74baacb880dffbd1c6692457932bf57 26-Oct-2016 Steven Moreland <smoreland@google.com> Stop all these merge conflicts.

Test: mma -j64
Change-Id: I319198af32adf1fef180c5c2c22ba4b360fa7609
ndroid.bp
ndroid.mk
c1158951544817f1433c68aaef3e1f42ab6e780e 11-Oct-2016 Mikhail Naganov <mnaganov@google.com> Remove redundant prefixes from enums in audio common types and effects HAL

Since in generated C++ code class enums are used, the names of enum
values are scoped anyway, thus carrying the prefix only clutters
code.

For C enums, newly introduced "value_prefix" annotation is used
to add the required prefix.

Added annotations for effects HAL types are just informational,
but can be used would C headers generation ever be required.

Also:

- renamed AudioInputFlags -> AudioInputFlag for consistency;

- moved AUDIO_INTERLEAVE_... constants into their own enum.

Bug: 31800672
Change-Id: I5b325f3440e0057ca98c4617040c7e5a89d2283d
Test: make
ypes.hal
40be06cdf3a34856144574cf5e70b60e4ad4940c 28-Sep-2016 Mikhail Naganov <mnaganov@google.com> Define HAL for audio effects

Created after hardware/audio_effect.h with the following changes:

- names changed to satisfy HAL style guide;

- defined an interface per effect, an interface method
per command, and getter / setter methods for properties;

- retained methods for executing proprietary commands
and accessing proprietary properties, only to be used
for third-party software effects;

- HIDL vector type is used instead of count / array pairs;

- provider callback changed to be used over RPC;

- 'dump' is method is already defined by generated code.

Note that audio data is currently transferred using AudioBuffers,
which is not effective due to memory copy and HwBinder transaction
involved. The transfer method will be changed to FastMessageQueue.

Bug: 30222631
Test: make
Change-Id: Ic8ea5c19688610ebe642c7597d2bcfa3226977e7
ndroid.bp
AcousticEchoCancelerEffect.hal
AutomaticGainControlEffect.hal
BassBoostEffect.hal
DownmixEffect.hal
Effect.hal
EffectBufferProviderCallback.hal
EffectsFactory.hal
EnvironmentalReverbEffect.hal
EqualizerEffect.hal
LoudnessEnhancerEffect.hal
NoiseSuppressionEffect.hal
PresetReverbEffect.hal
VirtualizerEffect.hal
VisualizerEffect.hal
ypes.hal