History log of /hardware/interfaces/audio/effect/2.0/default/EffectsFactory.cpp
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
3e6fe754f647db202a7a455adcf1ab5d686105d3 24-Apr-2017 Mikhail Naganov <mnaganov@google.com> audiohal: Fix handling of invalid arguments in 'debugDump' methods

Add checks for validity of the passed in native handle.

Bug: 37590777
Change-Id: If906f0086c3442819e1844cc521215d5b74af015
Test: VTS
(cherry picked from commit 7bae6a0b635b142cfba9d4c4612e1e114f85b842)
/hardware/interfaces/audio/effect/2.0/default/EffectsFactory.cpp
9f2890458a2e0b9fa09ceeba64c869bf3f1560c3 23-Feb-2017 Mikhail Naganov <mnaganov@google.com> Add VTS tests for audio effects

Added tests covering IEffect, IEqualizerEffect, and
ILoudnessEnhancer interfaces.

Minor corrections in the interface definitions and implementations:

- fixed descriptions and @callflow annotations in IEffect;

- fixed type used for band levels in IEqualizerEffect;

- fixed specification of frequencies in IEqualizerEffect;

- fixed some bugs in previously non-execrices Effects code;

- warning messages changed to error messages.

Test: this is a test
Bug: 32022706
Change-Id: I0e0bc111b07d944ad8a0321e8b1ec703f8d1a73e
/hardware/interfaces/audio/effect/2.0/default/EffectsFactory.cpp
7bdce32513128aeee040f5ea0fcf2773f2e1e557 02-Dec-2016 Yifan Hong <elsk@google.com> Merge "Update to use the correct logging library."
f9d303435d80161fabb16cdff3b8f2f75f362480 30-Nov-2016 Yifan Hong <elsk@google.com> Update to use the correct logging library.

Test: mma compiles
Change-Id: Idb33dea5faaf1a5e54719c2a5a683d2d47e9b8e8
/hardware/interfaces/audio/effect/2.0/default/EffectsFactory.cpp
6e81e9bb3c13d8c51fde503cf8be2bfb56e1ca1d 17-Nov-2016 Mikhail Naganov <mnaganov@google.com> Audio HAL: fixes for issues discovered after client conversion

Several issues addressed:

-- added IDevice.supportsAudioPatches to query whether
create/removeAudioPatch is actually supported by HAL;

-- IStreamOutCallback proxy needs to be owned by IStreamOut
implementation. In order for the client to reset the reference,
added method IStreamOut.clearCallback;

-- IDevice.open{Input|Output}Stream need to return a "suggested" audio
config from HAL;

-- code for converting between system/audio.h and HIDL
data structures has been moved to
android.hardware.audio.common@2.0-util library for reuse;

-- added a workaround for the issue with QC effects HAL trying to write
into the input parameters buffer, which is r/o by Binder design.

Bug: 30222631
Change-Id: I64af24d79c12d6ac3b0f87d085a821913e29237b
Test: tried using with WIP HIDL client on N5X
/hardware/interfaces/audio/effect/2.0/default/EffectsFactory.cpp
70b9a15df00a42b319279d903bf5923564920e3b 18-Nov-2016 Martijn Coenen <maco@google.com> Use newly introduced hidl_handle.

Bug: 32089785
Test: builds
Change-Id: I27c7d3945e1fe390661bf322987011a00fe9b3fe
/hardware/interfaces/audio/effect/2.0/default/EffectsFactory.cpp
10548295023bee99108e418499aff09fe578211e 31-Oct-2016 Mikhail Naganov <mnaganov@google.com> Implement audio devices and streams HAL delegating to legacy HAL

Changes made to the .hal definition:

- introduce Effect ID returned by the IEffectsFactory that
needs to be passed to IStream.{add|remove}Effect; otherwise
it's impossible to retrieve the underlying HAL effect handle;

- change "bus address" in DeviceAddress to "string" type;

- fix signature of some methods w.r.t. returning Result;

- remove unused "struct AudioPatch".

Bug: 30222631
Test: make
Change-Id: Icb51729ef57bb2a5b0b78609735e7481bc04f95c
/hardware/interfaces/audio/effect/2.0/default/EffectsFactory.cpp
7cbf2f1fb15a2a7d9b8b61ca81ad93fa9ddcaea3 28-Oct-2016 Mikhail Naganov <mnaganov@google.com> Implement audio effects HAL delegating to legacy HAL

Changes made to the .hal definition:

- added missing generated Result for methods implemented via legacy
"command" function;

- fixed Aux Channels feature definition;

- added "size" parameter for reply data in cases where the wrapper
needs to allocate a reply buffer;

- added method for generic support of feature configs;

- added new Result type;

- use arrays instead of strings in effect descriptor to ease
conversion from / to legacy HAL;

- added missing method to the Preset Reverb interface;

- fixed names of the Visualizer enums to avoid clashes with defines
from the legacy HAL file.

The implementation isn't hooked up to the server yet. Need to implement
devices and streams first.

Bug: 30222631
Change-Id: I75bb42f19ac3303759e918b6d6a91646b1555f8c
Test: make
/hardware/interfaces/audio/effect/2.0/default/EffectsFactory.cpp