History log of /external/webrtc/webrtc/base/scoped_ptr.h
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
daef292e03c8d7d32e650495612f336c1830013a 15-Jan-2016 Alex Luebs <aluebs@google.com> Merge upstream SHA 04cb763

* git merge 04cb763
* See all upstream changes since the previous merge in branch aosp/upstream-master: git diff cb3f9bd..04cb763
* Modify webrtc/.gitignore to keep *.mk files.
* Removed old files from *.mk files:
- thread.cc
- thread_posix.cc
* Add new files to *.mk files:
- event_tracer.cc
* Android relevant upstream changes:
- Make Beamforming dynamically settable for Android platform builds
- Remove additional channel constraints when Beamforming is enabled in AudioProcessing
- Use an explicit identifier in Config

Change-Id: I384a4e8f6982c31c5bc70eef521bb2d90800b9a4
36220ae24f8f5d34b660d6c4c91dd4260886dcb9 12-Jan-2016 kwiberg <kwiberg@webrtc.org> Slap deprecation notices on Pass methods

There's no reason not to use std::move instead now that we can use the
C++11 standard library.

BUG=webrtc:5373

Review URL: https://codereview.webrtc.org/1531013003

Cr-Commit-Position: refs/heads/master@{#11225}
/external/webrtc/webrtc/base/scoped_ptr.h
cea7c2f7839eef81ecbd6dd10d103190ef68875c 07-Jan-2016 kwiberg <kwiberg@webrtc.org> Replace manual casting to rvalue reference with calls to std::move

Review URL: https://codereview.webrtc.org/1570473002

Cr-Commit-Position: refs/heads/master@{#11163}
/external/webrtc/webrtc/base/scoped_ptr.h
9390f84a4a0ccaca7f3eeec55e3b111158583665 17-Dec-2015 kwiberg <kwiberg@webrtc.org> Use std::nullptr_t instead of decltype(nullptr)

Review URL: https://codereview.webrtc.org/1531173003

Cr-Commit-Position: refs/heads/master@{#11068}
/external/webrtc/webrtc/base/scoped_ptr.h
0eb15ed7b806125774bd13fb214aeb403e2c6857 17-Dec-2015 kwiberg <kwiberg@webrtc.org> Don't call the Pass methods of rtc::Buffer, rtc::scoped_ptr, and rtc::ScopedVector

We can now use std::move instead!

This CL leaves the Pass methods in place; a follow-up CL will add deprecation annotations to them.

Review URL: https://codereview.webrtc.org/1460043002

Cr-Commit-Position: refs/heads/master@{#11064}
/external/webrtc/webrtc/base/scoped_ptr.h
675d4373f87b2468a334f2ed48bfa4e6946d80f1 05-Nov-2015 Chih-Hung Hsieh <chh@google.com> WIP: Changes after merge commit 'cb3f9bd'

Changes after "git merge cb3f9bd"

* git mv old Android.mk from src/ to webrtc/
* Remove old unused files in src/*.
* Modify webrtc/.gitignore to keep *.mk files.
* Copy old files from master, lost in auto-merge.
src/modules/audio_processing/test/unit_test.cc
src/modules/audio_coding/codecs/isac/fix/test/{Android.mk,kenny.c}
to webrtc, but most of the old test code do not compile with new
webrtc API and are commented out.
* Move src/modules/audio_processing/test/android/apmtest/jni/*.mk to
webrtc/... but the Android.mk files does not work.
Commented out its build target.
* Changes to Android.mk files:
* Change references of src/ to webrtc/.
* Fix include path
* Fix source file list, remove old non-existing files,
add new source files to resolve link errors.
* Add new Android.mk files to build some new static libraries
to link into current Android webrtc .so files.
* Remove unnecessary LOCAL_SHARED_LIBRARIES in Android.mk files
that build static libraries.
* Remove old unnecessary clang workarounds like
-Wno-tautological-pointer-compare
-no-integrated-as
* Fix include path of debug.pb.h in some source files.
* Add -DWEBRTC_POSIX in android-webrtc.mk
* Manually merge Android specific changes in
src/typedefs.h to webrtc/typedefs.h
* Fix trivial syntax error in scoped_ptr.h, calling static_assert.
* Use -std=c++0x in webrtc/system_wrappers/source/Android.mk
* #undef getchaar in spreadsort.hpp
* Verified and not to carry old Android hacks from src/... to webrtc/...
src/system_wrappers/source/android/cpu-features.c
src/modules/interface/module.h
src/modules/audio_coding/codecs/isac/fix/source/filters_neon.c
src/system_wrappers/source/trace_posix.cc
src/typedefs.h

More pathes from Alex Luebs:
* Use new unit test kenny.cc.
Delete old kenny.cc.
Comment out unessential code in kenny.cc to fix link error for now.
* Replace old unit test files with new ones in
webrtc/modules/audio_processing/Android.mk.
Delete old audio_processing/test/unit_test.cc.
* Fix compilation errors in
webrtc/modules/audio_processing/test/audio_processing_unittest.cc

Change-Id: I7bbf776eeb9dcfa21a82dd1f2dec378235cbbc3e
/external/webrtc/webrtc/base/scoped_ptr.h
3c089d751ede283e21e186885eaf705c3257ccd2 16-Sep-2015 henrikg <henrikg@webrtc.org> Add RTC_ prefix to contructormagic macros.

We must remove dependency on Chromium, i.e. we can't use Chromium's base/logging.h. That means we need to define these macros in WebRTC also when doing Chromium builds. And this causes redefinition.

* DISALLOW_ASSIGN -> RTC_DISALLOW_ASSIGN
* DISALLOW_COPY_AND_ASSIGN -> RTC_DISALLOW_COPY_AND_ASSIGN
* DISALLOW_IMPLICIT_CONSTRUCTORS -> RTC_DISALLOW_IMPLICIT_CONSTRUCTORS

Related CL: https://codereview.webrtc.org/1335923002/

BUG=chromium:468375
NOTRY=true

Review URL: https://codereview.webrtc.org/1345433002

Cr-Commit-Position: refs/heads/master@{#9953}
/external/webrtc/webrtc/base/scoped_ptr.h
a8e285d1934f2dc739d8a9f810fb4372d8d782b1 22-Apr-2015 Karl Wiberg <kwiberg@webrtc.org> Remove webrtc/base/move.h, and make types move-only manually

In days of yore, move.h contained complicated macros for approximating
move-only behavior in C++03. But since we live in the future now, and
can rely on C++11 features---including real move semantics!---it makes
more sense to just write the handful of required lines by hand in each
move-only class.

(We only live in the near future, though, not in some sci-fi
intergalactic civilization singularity type future, so we have to
define Pass() methods for these classes since we're not allowed to use
std::move().)

R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/45099004

Cr-Commit-Position: refs/heads/master@{#9060}
/external/webrtc/webrtc/base/scoped_ptr.h
9478437fdea4eb31b92ffe0c10368fe5bc9b9e16 20-Apr-2015 Karl Wiberg <kwiberg@webrtc.org> rtc::Buffer improvements

1. Constructors, SetData(), and AppendData() now accept uint8_t*,
int8_t*, and char*. Previously, they accepted void*, meaning that
any kind of pointer was accepted. I think requiring an explicit
cast in cases where the input array isn't already of a byte-sized
type is a better compromise between convenience and safety.

2. data() can now return a uint8_t* instead of a char*, which seems
more appropriate for a byte array, and is harder to mix up with
zero-terminated C strings. data<int8_t>() is also available so
that callers that want that type instead won't have to cast, as
is data<char>() (which remains the default until all existing
callers have been fixed).

3. Constructors, SetData(), and AppendData() now accept arrays
natively, not just decayed to pointers. The advantage of this is
that callers don't have to pass the size separately.

4. There are new constructors that allow setting size and capacity
without initializing the array. Previously, this had to be done
separately after construction.

5. Instead of TransferTo(), Buffer now supports swap(), and move
construction and assignment, and has a Pass() method that works
just like std::move(). (The Pass method is modeled after
scoped_ptr::Pass().)

R=jmarusic@webrtc.org, tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/42989004

Cr-Commit-Position: refs/heads/master@{#9033}
/external/webrtc/webrtc/base/scoped_ptr.h
11426dc719f24ece3246fd8fb24ae073c49b42ed 11-Feb-2015 kwiberg@webrtc.org <kwiberg@webrtc.org> Don't rely on webrtc/base/scoped_ptr.h to include stuff for you

webrtc/base/scoped_ptr.h doesn't need to include webrtc/base/common.h
anymore, but a couple of its users were relying on it to pull in other
things for them. Fix that, and remove the now really unnecessary
webrtc/base/common.h include.

R=andrew@webrtc.org, pthatcher@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/37169004

Cr-Commit-Position: refs/heads/master@{#8333}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8333 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/scoped_ptr.h
73ca1945eccf8e52d2a237a6ef7d3352a4d11d4d 29-Jan-2015 kwiberg@webrtc.org <kwiberg@webrtc.org> Update base/scoped_ptr.h from system_wrappers/interface/scoped_ptr.h

The latter file was more up-to-date. The files are now identical
with the following exceptions:

* The namespace used (rtc vs. webrtc).

* The name of the include guard.

* base/scoped_ptr.h still has two extra methods, accept() and use().

* base/scoped_ptr.h still includes webrtc/base/common.h even though
it doesn't need it itself, since several .cc files expect to get
it for free by incuding base/scoped_ptr.h. This is of course bad
manners, and the "unused" include will be removed in a future CL.

A later CL will remove system_wrappers/interface/scoped_ptr.h.

R=andrew@webrtc.org

Committed: https://code.google.com/p/webrtc/source/detail?r=8147
And reverted again, because out-of-tree code using this file was defining nullptr to 0: https://code.google.com/p/webrtc/source/detail?r=8149

Review URL: https://webrtc-codereview.appspot.com/36919004

Cr-Commit-Position: refs/heads/master@{#8196}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8196 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/scoped_ptr.h
6f200b5b87d6cd941f19c01f4ca83d91d13ebef0 26-Jan-2015 kwiberg@webrtc.org <kwiberg@webrtc.org> Temporarily revert r8147 ("Update base/scoped_ptr.h from system_wrappers/interface/scoped_ptr.h")

Some out-of-tree code that uses base/scoped_ptr.h is defining nullptr
to 0, which causes an obvious compilation error and perhaps other
subtle problems. I'm hoping to get that sorted out and re-land this CL
soon.

TBR=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/34839004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@8149 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/scoped_ptr.h
19eb4e4b86516550a6917589fe559ebc3324dcd8 26-Jan-2015 kwiberg@webrtc.org <kwiberg@webrtc.org> Update base/scoped_ptr.h from system_wrappers/interface/scoped_ptr.h

The latter file was more up-to-date. The files are now identical
with the following exceptions:

* The namespace used (rtc vs. webrtc).

* The name of the include guard.

* base/scoped_ptr.h still has two extra methods, accept() and use().

* base/scoped_ptr.h still includes webrtc/base/common.h even though
it doesn't need it itself, since several .cc files expect to get
it for free by incuding base/scoped_ptr.h. This is of course bad
manners, and the "unused" include will be removed in a future CL.

A later CL will remove system_wrappers/interface/scoped_ptr.h.

R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/36919004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@8147 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/scoped_ptr.h
2ebfac5649a5e48fbbc501b42a4336ff979c03e6 14-Jan-2015 kwiberg@webrtc.org <kwiberg@webrtc.org> Remove COMPILE_ASSERT and use static_assert everywhere

COMPILE_ASSERT is no longer needed now that we have C++11's
static_assert.

R=aluebs@webrtc.org, andrew@webrtc.org, hellner@chromium.org, henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/39469004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@8058 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/scoped_ptr.h
aa21f2765bf45da671c3a3ca637df2949243b861 19-Dec-2014 kwiberg@webrtc.org <kwiberg@webrtc.org> Unify the two copies of move.h

This patch basically deletes webrtc/base/move.h (which is the more
outdated copy) and moves webrtc/system_wrappers/source/move.h to take
its place.

R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/35549004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7963 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/scoped_ptr.h
f048872e915a3ee229044ec4bc541f6cbf9e4de1 13-May-2014 henrike@webrtc.org <henrike@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> Adds a modified copy of talk/base to webrtc/base. It is the first step in
migrating talk/base to webrtc/base.

BUG=N/A
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/17479005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/scoped_ptr.h
e9a604accd54ab14dbf98f99ccdcf3ae1c54d27c 13-May-2014 perkj@webrtc.org <perkj@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> Revert 6107 "Adds a modified copy of talk/base to webrtc/base. I..."

This breaks Chromium FYI builds and prevent roll of webrtc/libjingle to Chrome.

http://chromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Win%20Builder/builds/457


> Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base.
>
> BUG=N/A
> R=andrew@webrtc.org, wu@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/12199004

TBR=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14479004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6116 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/scoped_ptr.h
2c7d1b39b9374d2bc9bda4755fd4813db66a135c 12-May-2014 henrike@webrtc.org <henrike@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base.

BUG=N/A
R=andrew@webrtc.org, wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12199004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6107 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/scoped_ptr.h