3708f024b1118a73f0e6b3080234311c6647663b |
|
15-Feb-2018 |
Mike Reed <reed@google.com> |
use conservative bounds to disable clipping Bug: skia:6754 Change-Id: I658e7e7a176395eff7e239093fbad8038a4141ad Reviewed-on: https://skia-review.googlesource.com/107884 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkScan_Path.cpp
|
36c0b57698a2e1fd181e5f1569fbf70cd695e9b8 |
|
15-Feb-2018 |
Mike Reed <reed@google.com> |
use safe increment for edge walker Bug: oss-fuzz:6126 Change-Id: I8f6865cbbbfbe37acf940cc2d4ae93204ba7168d Reviewed-on: https://skia-review.googlesource.com/107783 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkScan_Path.cpp
|
63227ca63b09ad534b52b1b1957202ab18aa53f7 |
|
30-Jan-2018 |
Mike Reed <reed@google.com> |
handle clipping large triangles originally found by fuzzer. Bug: skia: Change-Id: I45007a619f13936153c0db8a60b3631a2c9db20c Reviewed-on: https://skia-review.googlesource.com/101741 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkScan_Path.cpp
|
8008df1080f5623bf1cf13c713082c2b732d4eb2 |
|
17-Jan-2018 |
Mike Reed <reed@google.com> |
handle large rects, rename helper To fix gm/bigrect, needed to do adjust "largest" rect so it doesn't become empty when round-tripping with SkRect/SkIRect. I renamed it after this. Bug: skia: Change-Id: I747782c8456da603cf298275d2300ea1996e7629 Reviewed-on: https://skia-review.googlesource.com/95563 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Yuqian Li <liyuqian@google.com>
/external/skia/src/core/SkScan_Path.cpp
|
274218ef0173ff6046f2258c703c1c83ea37c02f |
|
08-Jan-2018 |
Mike Reed <reed@google.com> |
move largest apis into private Related to https://skia-review.googlesource.com/c/skia/+/91860 Bug: skia: Change-Id: Ia8fd981b422bbab75541b078277d2e09e1fc9d41 Reviewed-on: https://skia-review.googlesource.com/91940 Reviewed-by: Brian Salomon <bsalomon@google.com>
/external/skia/src/core/SkScan_Path.cpp
|
c24f5a3e6e504bbb4810981dcab1583b9a8d08aa |
|
17-Oct-2017 |
Yuqian Li <liyuqian@google.com> |
Fix left shift ASAN problem This should fix our new FSAA ASAN bot: https://chromium-swarm.appspot.com/task?id=39446a25c7957710&refresh=10&show_raw=1&wide_logs=true Bug: skia:7179 Change-Id: I1fcee6f7e3d8c8e3a646c67e41d4b6c19d372835 Reviewed-on: https://skia-review.googlesource.com/60702 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
/external/skia/src/core/SkScan_Path.cpp
|
e07622386b10c158cb0cc653ace264e24c5702af |
|
10-Oct-2017 |
Mike Reed <reed@google.com> |
clone saturating cast code for doubles Bug: skia: Change-Id: I4f35413995cf73c6f130476d6b36e530120aa7ed Reviewed-on: https://skia-review.googlesource.com/57901 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Reed <reed@google.com>
/external/skia/src/core/SkScan_Path.cpp
|
1c35e571c3f041069e2b16979a733d784c7f0f4c |
|
10-Oct-2017 |
Ben Wagner <benjaminwagner@google.com> |
Revert "Revert "Fix a couple float-cast-overflow in SkScan*."" This reverts commit b6abb9b4e088abee8b8dfcce9c9f7eb759518198. Reason for revert: It doesn't make sense that this CL would affect the tests implicated in the perf regression in skia:7143, and the revert had no effect on the perf of those tests. Seems like the perf alert was either noise or due to a different CL. Original change's description: > Revert "Fix a couple float-cast-overflow in SkScan*." > > This reverts commit 3cd0bef0fd9d062bbcc313c329b4f31925e8ded7. > > Reason for revert: https://bugs.chromium.org/p/skia/issues/detail?id=7143 > > Original change's description: > > Fix a couple float-cast-overflow in SkScan*. > > > > Bug: skia:5060 > > Change-Id: I60a48993c77631aaad9354bb86b13204dc618bf4 > > Reviewed-on: https://skia-review.googlesource.com/47422 > > Commit-Queue: Ben Wagner <benjaminwagner@google.com> > > Reviewed-by: Mike Reed <reed@google.com> > > TBR=benjaminwagner@google.com,reed@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: skia:7143 > Change-Id: I0f19720a7d8344789a375bbb6b9e28bf4f4e55ae > Reviewed-on: https://skia-review.googlesource.com/57240 > Commit-Queue: Ben Wagner <benjaminwagner@google.com> > Reviewed-by: Ben Wagner <benjaminwagner@google.com> TBR=benjaminwagner@google.com,reed@google.com Change-Id: I29ac47d6665e2e52ee2a6500488dc407c8d2af1c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7143 Reviewed-on: https://skia-review.googlesource.com/57440 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
/external/skia/src/core/SkScan_Path.cpp
|
b6abb9b4e088abee8b8dfcce9c9f7eb759518198 |
|
09-Oct-2017 |
Ben Wagner <benjaminwagner@google.com> |
Revert "Fix a couple float-cast-overflow in SkScan*." This reverts commit 3cd0bef0fd9d062bbcc313c329b4f31925e8ded7. Reason for revert: https://bugs.chromium.org/p/skia/issues/detail?id=7143 Original change's description: > Fix a couple float-cast-overflow in SkScan*. > > Bug: skia:5060 > Change-Id: I60a48993c77631aaad9354bb86b13204dc618bf4 > Reviewed-on: https://skia-review.googlesource.com/47422 > Commit-Queue: Ben Wagner <benjaminwagner@google.com> > Reviewed-by: Mike Reed <reed@google.com> TBR=benjaminwagner@google.com,reed@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: skia:7143 Change-Id: I0f19720a7d8344789a375bbb6b9e28bf4f4e55ae Reviewed-on: https://skia-review.googlesource.com/57240 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
/external/skia/src/core/SkScan_Path.cpp
|
3cd0bef0fd9d062bbcc313c329b4f31925e8ded7 |
|
06-Oct-2017 |
Ben Wagner <benjaminwagner@google.com> |
Fix a couple float-cast-overflow in SkScan*. Bug: skia:5060 Change-Id: I60a48993c77631aaad9354bb86b13204dc618bf4 Reviewed-on: https://skia-review.googlesource.com/47422 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Mike Reed <reed@google.com>
/external/skia/src/core/SkScan_Path.cpp
|
7877d3237826fc4985af3e9d540cff79e408ef34 |
|
18-Jul-2017 |
Yuqian Li <liyuqian@google.com> |
Make update_edge as a member function of SkAnalyticEdge This is to prepare for future SkScan_DAAPath.cpp to use this member function (https://skia-review.googlesource.com/c/19666/). Bug: skia: Change-Id: I5fb90ac67b80f8a69a712e7e697d68dcadba5d14 Reviewed-on: https://skia-review.googlesource.com/24180 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
/external/skia/src/core/SkScan_Path.cpp
|
1c8408847cc626a34fc885b1c6313533d030e192 |
|
26-May-2017 |
Yuqian Li <liyuqian@google.com> |
Explicitly check edge count >= 2 in non-debug build We also preserve the check in debug mode that the count should never be 1 when the path is convex. Bug: skia:6684 Change-Id: I4d4c9ad9f9d704e94bbe51f10a96f8b3066afaa1 Reviewed-on: https://skia-review.googlesource.com/17983 Commit-Queue: Yuqian Li <liyuqian@google.com> Reviewed-by: Mike Reed <reed@google.com>
/external/skia/src/core/SkScan_Path.cpp
|
b8e752198dde333e71cb1a9578cd3dfd404dd06c |
|
14-Mar-2017 |
Lee Salzman <lsalzman@mozilla.com> |
fix round_asymmetric_to_int to also bias bottom and right BUG=skia:6294 Change-Id: I1ee1031f1fb7cb035916e8945ce5396759955885 Reviewed-on: https://skia-review.googlesource.com/9700 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Cary Clark <caryclark@google.com>
/external/skia/src/core/SkScan_Path.cpp
|
a33b43d796f03e2f4b5abd8060272f4f775d7390 |
|
17-Mar-2017 |
Yuqian Li <liyuqian@google.com> |
Combine some duplicate code in AA using template BUG=skia: Change-Id: Id048425e8199167feba0268f89f526bbf5b7242b Reviewed-on: https://skia-review.googlesource.com/9832 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
/external/skia/src/core/SkScan_Path.cpp
|
95acbad4fee03a2fa2c0419da70a1b85e21739ef |
|
13-Jan-2017 |
Lee Salzman <lsalzman@mozilla.com> |
ensure path bounds after rounding contain path edges when using SK_RASTERIZE_EVEN_ROUNDING BUG=skia: Change-Id: I34e93de8fd4faa44336c2698d06595e9c4de86c3 Reviewed-on: https://skia-review.googlesource.com/7040 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Cary Clark <caryclark@google.com>
/external/skia/src/core/SkScan_Path.cpp
|
b569056be7d4638598b6ae9f676f077990909931 |
|
13-Jan-2017 |
Lee Salzman <lsalzman@mozilla.com> |
simplify round_down_to_int by using ceil instead of floor BUG=skia: Change-Id: I465d98d6b0d97e1ede82670c663f9695b5a0a1de Reviewed-on: https://skia-review.googlesource.com/7041 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Cary Clark <caryclark@google.com>
/external/skia/src/core/SkScan_Path.cpp
|
99bba9ea829323a7941d4f3a9c98da7a76432d1b |
|
21-Nov-2016 |
Yuqian Li <liyuqian@google.com> |
Add missing virtual functions for SkRectClipCheckBlitter This CL is related to the issue that we tried to fix in https://skia-review.googlesource.com/c/5078/ Specifically, SkARGB32_Blitter overrides blitAntiH2 and blitAntiV2 and they're different from blitAntiRuns. Therefore, if SkRectClipCheckBlitter does not override those two functions, we're going to get different results in debug and release build. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=5082 Change-Id: I7f9565d494f0a6c45ab5a06fbedb73ef233b9a1f Reviewed-on: https://skia-review.googlesource.com/5082 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
/external/skia/src/core/SkScan_Path.cpp
|
dc940a63c4a2b5bfc8765fcdbeb097ac35e7bbe9 |
|
20-Nov-2016 |
Yuqian Li <liyuqian@google.com> |
Disable RectClipCheckBlitter for cc_unittests With RectClipCheckBlitter, the cc_unittests in Chromium will have different results for rel and dbg buidls. As far as I know, the scan converter blits the same alpha but they are somehow translated into different RGBs. I'll look into it on Monday. (RectClipCheckBlitter is added in https://skia-review.googlesource.com/c/4629/) BUG=skia: TBR=fmalita@chromium.org GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=5078 Change-Id: I537d4380a44d0194103a4fcfb2bd2e2bcef41fcb Reviewed-on: https://skia-review.googlesource.com/5078 Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
/external/skia/src/core/SkScan_Path.cpp
|
e4b8b5283f45cff6a490ee73677f75b641c22bd1 |
|
16-Nov-2016 |
Yuqian Li <liyuqian@google.com> |
Simplify the signature of sk/aaa_fill_path Previously, the clipRect is either equal to nullptr or clipRgn's bound (after necessary supersampling shift). Hence we drop one of them to make the signature simpler. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4874 Change-Id: Ied8d5313809d6cf90374365b01f2b8d52f2236e2 Reviewed-on: https://skia-review.googlesource.com/4874 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
/external/skia/src/core/SkScan_Path.cpp
|
28930b46487fc94fde206d1283623204c595b0f1 |
|
09-Nov-2016 |
Mike Reed <reed@google.com> |
add debugging wrapper blitter to ensure unclipped scan-conversion is safe BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4629 Change-Id: Ie6c35b28a6e8e87bf230e50f9940d3924d12969a Reviewed-on: https://skia-review.googlesource.com/4629 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Yuqian Li <liyuqian@google.com>
/external/skia/src/core/SkScan_Path.cpp
|
9d524f22bfde5dc3dc8f48e1be39bdebd3bb0304 |
|
29-Mar-2016 |
halcanary <halcanary@google.com> |
Style bikeshed - remove extraneous whitespace GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1842753002 Review URL: https://codereview.chromium.org/1842753002
/external/skia/src/core/SkScan_Path.cpp
|
d7dc76f7e99309cbd09a5420c22e55b951067deb |
|
10-Mar-2016 |
bungeman <bungeman@google.com> |
Remove version checks for _MSC_VER < 1800 (msvs2013). We already actively do not support older versions of the vc++ compiler and runtime, so don't check for them anymore. TBR=reed No API changes. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1777213003 Review URL: https://codereview.chromium.org/1777213003
/external/skia/src/core/SkScan_Path.cpp
|
a7b16858d51b5d9b7981087cadb1ff764632bf14 |
|
18-Feb-2016 |
caryclark <caryclark@google.com> |
remove legacy flags R=fmalita@chromium.org BUG=573166 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1707383002 Review URL: https://codereview.chromium.org/1707383002
/external/skia/src/core/SkScan_Path.cpp
|
2baa84b7baa39dd52ae6c19d22b88db50487fa1f |
|
01-Feb-2016 |
caryclark <caryclark@google.com> |
batch merge new edges Find where newly introduced edges go in the edge list once, then stitch all of them into the edge list. R=reed@google.com BUG=573166 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1647223002 Committed: https://skia.googlesource.com/skia/+/ae658e15477df86d1a864feb48d0274af2784f40 Review URL: https://codereview.chromium.org/1647223002
/external/skia/src/core/SkScan_Path.cpp
|
02a6bfaaaa077dc3738cec3713a50cc4293ac7ec |
|
30-Jan-2016 |
msarett <msarett@google.com> |
Revert of batch merge new edges (patchset #1 id:1 of https://codereview.chromium.org/1647223002/ ) Reason for revert: Breaks the roll. Original issue's description: > batch merge new edges > > Find where newly introduced edges go in the edge list once, > then stitch all of them into the edge list. > > R=reed@google.com > BUG=573166 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1647223002 > > Committed: https://skia.googlesource.com/skia/+/ae658e15477df86d1a864feb48d0274af2784f40 TBR=reed@google.com,caryclark@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=573166 Review URL: https://codereview.chromium.org/1654593002
/external/skia/src/core/SkScan_Path.cpp
|
ae658e15477df86d1a864feb48d0274af2784f40 |
|
30-Jan-2016 |
caryclark <caryclark@google.com> |
batch merge new edges Find where newly introduced edges go in the edge list once, then stitch all of them into the edge list. R=reed@google.com BUG=573166 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1647223002 Review URL: https://codereview.chromium.org/1647223002
/external/skia/src/core/SkScan_Path.cpp
|
6df611574a3cf8abf2617af0d03a5553bb17360d |
|
04-Jan-2016 |
caryclark <caryclark@google.com> |
handle halfway case in scan converter Scan edges that start at exactly -0.5 aren't trimmed by clipping or by rounding, triggering a debug assert. One way to fix this is to round the top and left down instead of up. Also, move the path initialization of gm/composeshader.cpp to make debugging other path problems easier. R=reed@google.com BUG=skia:2715 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1544873002 Review URL: https://codereview.chromium.org/1544873002
/external/skia/src/core/SkScan_Path.cpp
|
3127c99986dc932343aae5ccc575237d99c3aaec |
|
09-Dec-2015 |
caryclark <caryclark@google.com> |
ubsan shift fixes Use an inline function that does a normal shift. When built for the sanitizer, add casts so that the shift is unsigned. Also make a few fixes to do unsigned shifts or avoid the shift altogether; and add an argument spec to some macros. R=reed@google.com,mtklein@google.com BUG=skia:4633 Review URL: https://codereview.chromium.org/1503423003
/external/skia/src/core/SkScan_Path.cpp
|
96fcdcc219d2a0d3579719b84b28bede76efba64 |
|
27-Aug-2015 |
halcanary <halcanary@google.com> |
Style Change: NULL->nullptr DOCS_PREVIEW= https://skia.org/?cl=1316233002 Review URL: https://codereview.chromium.org/1316233002
/external/skia/src/core/SkScan_Path.cpp
|
41e010cb901c0da9066c4df562030808c9ccd7f8 |
|
09-Jun-2015 |
reed <reed@google.com> |
Revert[2] SkDraw and all Blitters to use pixmap instead of bitmapi This reverts commit b3f0ec9f9967da2f80f0d842cb7fd53617b48de3. BUG=skia: Review URL: https://codereview.chromium.org/1168303006
/external/skia/src/core/SkScan_Path.cpp
|
b3f0ec9f9967da2f80f0d842cb7fd53617b48de3 |
|
09-Jun-2015 |
reed <reed@chromium.org> |
Revert of change SkDraw and all Blitters to use pixmap instead of bitmap (patchset #6 id:100001 of https://codereview.chromium.org/1148793007/) Reason for revert: speculative revert to try to unblock DEPS roll Original issue's description: > change SkDraw and all Blitters to use pixmap instead of bitmap > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/c31af44336f5eb4a50e83e76e51962d46c3ed458 TBR=scroggo@google.com,jvanverth@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1164373003
/external/skia/src/core/SkScan_Path.cpp
|
c31af44336f5eb4a50e83e76e51962d46c3ed458 |
|
08-Jun-2015 |
reed <reed@google.com> |
change SkDraw and all Blitters to use pixmap instead of bitmap BUG=skia: Review URL: https://codereview.chromium.org/1148793007
/external/skia/src/core/SkScan_Path.cpp
|
36352bf5e38f45a70ee4f4fc132a38048d38206d |
|
26-Mar-2015 |
mtklein <mtklein@chromium.org> |
C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla} NOPRESUBMIT=true BUG=skia: DOCS_PREVIEW= https://skia.org/?cl=1037793002 Review URL: https://codereview.chromium.org/1037793002
/external/skia/src/core/SkScan_Path.cpp
|
edeb7a97aded2107fd6a25562e1bb7fdcb96c958 |
|
25-Feb-2015 |
bungeman <bungeman@google.com> |
Remove SK_USE_LEGACY_AA_COVERAGE guarded code. It doesn't appear anyone uses this flag anymore. Review URL: https://codereview.chromium.org/943053004
/external/skia/src/core/SkScan_Path.cpp
|
31223e0cb74f47f63b094520a9830c525b72fe87 |
|
09-Feb-2015 |
reed <reed@google.com> |
cull edges that are to the right of the clip BUG=skia: Review URL: https://codereview.chromium.org/913503002
/external/skia/src/core/SkScan_Path.cpp
|
e3ecde1205d7698eb6266cdc4d43e4034b3f30d6 |
|
09-Feb-2015 |
qiankun.miao <qiankun.miao@intel.com> |
Remove unnecessary assignment BUG=skia: Review URL: https://codereview.chromium.org/892423005
/external/skia/src/core/SkScan_Path.cpp
|
01d3319b67b1ad404006a0026803efc1573f4570 |
|
07-Feb-2015 |
reed <reed@google.com> |
Faster edge re-sort For now, disable dropping trailing edges This reverts commit 0692c5f2c1df7d1b66c62025200dd666f9ecd311. BUG=skia: TBR= Review URL: https://codereview.chromium.org/882733004
/external/skia/src/core/SkScan_Path.cpp
|
0692c5f2c1df7d1b66c62025200dd666f9ecd311 |
|
07-Feb-2015 |
reed <reed@chromium.org> |
Revert of Faster edge re-sort, drop trailing edges (patchset #2 id:20001 of https://codereview.chromium.org/907623002/) Reason for revert: still layout failures Original issue's description: > Faster edge re-sort, drop trailing edges > > (patchset #4 id:60001 of https://codereview.chromium.org/891613003/)" > > This reverts commit c319d075eab86cacfd7aba27859b72bbf8fc0a64. > > BUG=skia: > TBR= > > Committed: https://skia.googlesource.com/skia/+/2322115952c15c72a623837879cac1f85894b1b6 TBR= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/886503010
/external/skia/src/core/SkScan_Path.cpp
|
2322115952c15c72a623837879cac1f85894b1b6 |
|
07-Feb-2015 |
reed <reed@chromium.org> |
Faster edge re-sort, drop trailing edges (patchset #4 id:60001 of https://codereview.chromium.org/891613003/)" This reverts commit c319d075eab86cacfd7aba27859b72bbf8fc0a64. BUG=skia: TBR= Review URL: https://codereview.chromium.org/907623002
/external/skia/src/core/SkScan_Path.cpp
|
c319d075eab86cacfd7aba27859b72bbf8fc0a64 |
|
07-Feb-2015 |
reed <reed@chromium.org> |
Revert of faster edge re-sort, drop trailing edges (patchset #4 id:60001 of https://codereview.chromium.org/891613003/) Reason for revert: may be breaking layouttests... Original issue's description: > faster edge re-sort, drop trailing edges > > 1. drop edges that are wholly on the right (in the non-convex walker) > 2. scan and swap once, instead of swapping as we go during re-sort > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/38f1c00772539dcbeccbfa3c45d94bdc4acf3518 TBR=caryclark@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/910493002
/external/skia/src/core/SkScan_Path.cpp
|
38f1c00772539dcbeccbfa3c45d94bdc4acf3518 |
|
06-Feb-2015 |
reed <reed@google.com> |
faster edge re-sort, drop trailing edges 1. drop edges that are wholly on the right (in the non-convex walker) 2. scan and swap once, instead of swapping as we go during re-sort BUG=skia: Review URL: https://codereview.chromium.org/891613003
/external/skia/src/core/SkScan_Path.cpp
|
72c9faab45124e08c85f70ca38536914862d947c |
|
09-Jan-2015 |
mtklein <mtklein@chromium.org> |
Fix up all the easy virtual ... SK_OVERRIDE cases. This fixes every case where virtual and SK_OVERRIDE were on the same line, which should be the bulk of cases. We'll have to manually clean up the rest over time unless I level up in regexes. for f in (find . -type f); perl -p -i -e 's/virtual (.*)SK_OVERRIDE/\1SK_OVERRIDE/g' $f; end BUG=skia: Review URL: https://codereview.chromium.org/806653007
/external/skia/src/core/SkScan_Path.cpp
|
e8307dc0d0a568775e64515a8fff7b2a709f0834 |
|
15-Dec-2014 |
mtklein <mtklein@chromium.org> |
Add SK_OVERRIDE to a few places that are missing it. This was done automatically by running clang-modernize -add-override -override-macros. It's not clear to me whether include/ is already clean or I just can't get the tool to work for headers. BUG=skia: Review URL: https://codereview.chromium.org/808463002
/external/skia/src/core/SkScan_Path.cpp
|
a10742c69ce47d346e3cf23e7be909c9f29b401e |
|
18-Sep-2014 |
caryclark <caryclark@google.com> |
update to accommodate latest clang in chrome toolchain remove asserts for null pointers to references change var args signature to pointer instead of array R=mtklein@google.com, reed@android.com, reed@google.com, mtklein, reed Author: caryclark@google.com Review URL: https://codereview.chromium.org/577243002
/external/skia/src/core/SkScan_Path.cpp
|
49f085dddff10473b6ebf832a974288300224e60 |
|
05-Sep-2014 |
bsalomon <bsalomon@google.com> |
"NULL !=" = NULL R=reed@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/544233002
/external/skia/src/core/SkScan_Path.cpp
|
4e332f82fce0126045e9cb2ef0a2097a6c4c40a3 |
|
05-May-2014 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add rounding-using-doubles methods on SkScalar and SkRect Inspired by the excellent repro case for https://crbug.com/364224 patch from issue 265933010 BUG=skia: R=bungeman@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/267003002 git-svn-id: http://skia.googlecode.com/svn/trunk@14566 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
e16efc1882ab34a0bb3ae361a2d37f840044cf87 |
|
26-Jan-2013 |
skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Sanitizing source files in Skia_Periodic_House_Keeping git-svn-id: http://skia.googlecode.com/svn/trunk@7406 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
0f5891caf684b1d913b69d7a654f6ccb2a84ed8c |
|
15-Nov-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
remove (unused) debugging global git-svn-id: http://skia.googlecode.com/svn/trunk@6428 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
fbfcd5602128ec010c82cb733c9cdc0a3254f9f3 |
|
23-Aug-2012 |
rmistry@google.com <rmistry@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Result of running tools/sanitize_source_files.py (which was added in https://codereview.appspot.com/6465078/) This CL is part I of IV (I broke down the 1280 files into 4 CLs). Review URL: https://codereview.appspot.com/6485054 git-svn-id: http://skia.googlecode.com/svn/trunk@5262 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
0951ded8d887174a3ca575e3295daae547c3c6f7 |
|
03-Aug-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
tie slow sort (STD) to legacy AA, so that skia can use the fast one, and so that when chrome disables the legacy flag, it will automatically get the faster one. git-svn-id: http://skia.googlecode.com/svn/trunk@4955 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
5ee6491b7a1e7c177abc0186c2749ebe1f71fcf7 |
|
11-Jun-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Better fix for rev. 4214 (inverse-fill and clipping). This fix avoids changing the actual clipping bounds, which caused tiny differences in the scan converter. Also adding a gm (which I should have the first time.) Review URL: https://codereview.appspot.com/6297073 git-svn-id: http://skia.googlecode.com/svn/trunk@4227 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
97caebc7462c202ab0ec5cce4eb26a616930813e |
|
08-Jun-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Detect inverse-fill, and treat its bounds as huge (all of integer space) for the purposes of comparing w/ the clip-bounds, otherwise we can reject the draw if the bounds of the path are outside the bounds of the clip. Review URL: https://codereview.appspot.com/6302058 git-svn-id: http://skia.googlecode.com/svn/trunk@4214 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
0a71a9cc372c2fd42e3b1623321878aaa27aa103 |
|
09-May-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
experimental faster sort git-svn-id: http://skia.googlecode.com/svn/trunk@3872 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
9d5f76a250502620952d4aaa2926ff5bfeffc980 |
|
01-May-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
fix bug (and add test) for drawing an inverse-path whose bounds do intersect the clip, but whose edges do not (e.g. a curve). We used to overdraw a section (and assert). git-svn-id: http://skia.googlecode.com/svn/trunk@3809 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
0a9cc44a40a2bc101da1af89926152098ffcc44b |
|
06-Feb-2012 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
use macro SkFixedRoundToInt where necessary http://codereview.appspot.com/5617047/ git-svn-id: http://skia.googlecode.com/svn/trunk@3142 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
0c00f21fee3f5cfa3aa7e5d46ff94cb8cf340451 |
|
28-Dec-2011 |
tomhudson@google.com <tomhudson@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Add SkDEBUGFAIL to clean up use of SkASSERT(!"text"); catch a couple of latent SkASSERT("text") bugs. http://codereview.appspot.com/5504090/ git-svn-id: http://skia.googlecode.com/svn/trunk@2926 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
562a2ac95b8cd8b359574f8c4d6300b0475938db |
|
31-Oct-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
call blitRect in our convex scanconverter (next: take advantage of that in our region and soft-region builders, and in our supersampler) git-svn-id: http://skia.googlecode.com/svn/trunk@2563 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
fc5da9266eae18f1ee3635a061af27788ad4b62e |
|
31-Oct-2011 |
mike@reedtribe.org <mike@reedtribe.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
handle when initial edges don't agree on start-y git-svn-id: http://skia.googlecode.com/svn/trunk@2560 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
a6c7c4803e144f5c1d0a86a437ac1e2e8ff5e211 |
|
28-Oct-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add convex special case in scanconverter. about 10% faster for modest ovals and rrects git-svn-id: http://skia.googlecode.com/svn/trunk@2554 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
e3a83ec4e5c0abd2f5b756d7a6e7d58515969f18 |
|
25-Oct-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
check-point for convex scan-converter (disabled for now) git-svn-id: http://skia.googlecode.com/svn/trunk@2529 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
045e62d715f5ee9b03deb5af3c750f8318096179 |
|
24-Oct-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
enable soft clipping (yikes) git-svn-id: http://skia.googlecode.com/svn/trunk@2515 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
ec3ed6a5ebf6f2c406d7bcf94b6bc34fcaeb976e |
|
28-Jul-2011 |
epoger@google.com <epoger@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Automatic update of all copyright notices to reflect new license terms. I have manually examined all of these diffs and restored a few files that seem to require manual adjustment. The following files still need to be modified manually, in a separate CL: android_sample/SampleApp/AndroidManifest.xml android_sample/SampleApp/res/layout/layout.xml android_sample/SampleApp/res/menu/sample.xml android_sample/SampleApp/res/values/strings.xml android_sample/SampleApp/src/com/skia/sampleapp/SampleApp.java android_sample/SampleApp/src/com/skia/sampleapp/SampleView.java experimental/CiCarbonSampleMain.c experimental/CocoaDebugger/main.m experimental/FileReaderApp/main.m experimental/SimpleCocoaApp/main.m experimental/iOSSampleApp/Shared/SkAlertPrompt.h experimental/iOSSampleApp/Shared/SkAlertPrompt.m experimental/iOSSampleApp/SkiOSSampleApp-Base.xcconfig experimental/iOSSampleApp/SkiOSSampleApp-Debug.xcconfig experimental/iOSSampleApp/SkiOSSampleApp-Release.xcconfig gpu/src/android/GrGLDefaultInterface_android.cpp gyp/common.gypi gyp_skia include/ports/SkHarfBuzzFont.h include/views/SkOSWindow_wxwidgets.h make.bat make.py src/opts/memset.arm.S src/opts/memset16_neon.S src/opts/memset32_neon.S src/opts/opts_check_arm.cpp src/ports/SkDebug_brew.cpp src/ports/SkMemory_brew.cpp src/ports/SkOSFile_brew.cpp src/ports/SkXMLParser_empty.cpp src/utils/ios/SkImageDecoder_iOS.mm src/utils/ios/SkOSFile_iOS.mm src/utils/ios/SkStream_NSData.mm tests/FillPathTest.cpp Review URL: http://codereview.appspot.com/4816058 git-svn-id: http://skia.googlecode.com/svn/trunk@1982 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
948639b823dc76dbaa8cc68f32c1f7defcb8fb07 |
|
19-Jul-2011 |
mike@reedtribe.org <mike@reedtribe.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Remove dead edgebuilding code git-svn-id: http://skia.googlecode.com/svn/trunk@1893 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
1501803e93a9c76b4632086d05c2813cb475db27 |
|
11-Jul-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
limit clip to fixed-point range, so our edges don't overflow git-svn-id: http://skia.googlecode.com/svn/trunk@1835 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
99219d337f66cb6a8e566e1c6407bfb4b1b6cb8b |
|
09-Apr-2011 |
mike@reedtribe.org <mike@reedtribe.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
update coding style - no logic change git-svn-id: http://skia.googlecode.com/svn/trunk@1089 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
55b6b58d8f6e7529c9b9cea606a6e3637c8e2e39 |
|
02-Mar-2011 |
reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fix inverse scanconversion -- be sure to keep our calls to SkBlitter in scanline order (top to bottom), since the region blitter explicitly requires this. git-svn-id: http://skia.googlecode.com/svn/trunk@876 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
8cfdf01ff953b47fdd5c29ebd54fea8a7a9be83e |
|
06-Dec-2010 |
agl@chromium.org <agl@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Correctly handle SkPath::kInverseWinding_FillType Fix for http://code.google.com/p/skia/issues/detail?id=87 Even when SkPath::kInverseWinding_FillType is given, Skia left some lines not filled(cleared) in one case. Patch-by: morrita http://codereview.appspot.com/3443041 git-svn-id: http://skia.googlecode.com/svn/trunk@630 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
dca6a56b71b922aab32098d6a55bbb041f3a2b48 |
|
22-Feb-2010 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
explicitly pass bounds.top to the edgelist walker, so we don't leave any gaps when the path is in an inverse fillmode, and its top or bottom are on a fractional boundary. (thanks senorblanco) git-svn-id: http://skia.googlecode.com/svn/trunk@504 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
59ed9f6c8547cd11b23babbbf6377d98e5cee055 |
|
10-Dec-2009 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Eenable new chopping edgelist builder by default. If it sticks well, I'll remove the old code-path in a subsequent CL git-svn-id: http://skia.googlecode.com/svn/trunk@454 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
909994fbae0ffb532f42feac8859f8d86bbf64de |
|
18-Nov-2009 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
new scanconversion technique This technique geometrically clips all segments against the clip bounds, ensuring that we never send a value to the edgelist that might overflow in fixedpoint. Current disabled in SkScan_Path.cpp by a #define. There are a few minor pixel differences between this and the old technique, as found by the gm tool, so at the moment this new code is off by default. git-svn-id: http://skia.googlecode.com/svn/trunk@432 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
e72fee513a5f903d6aa17066d2f3b79ac31f05de |
|
16-Nov-2009 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
add onSendClickToChildren to views, so a view can capture all clicks. speedup some of the unittests that were too slow minor cleanup in SkScan_Path, in prep for larger changes git-svn-id: http://skia.googlecode.com/svn/trunk@426 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
5ebbe14f76da3028e5d4523c093a0f4a2cf8e982 |
|
05-Nov-2009 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
fix cheap calc of edgelist size git-svn-id: http://skia.googlecode.com/svn/trunk@419 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
800046eba45c9e982ecfe8964b2107f7713ed639 |
|
14-Oct-2009 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
fix new warnings from gcc 4.2 git-svn-id: http://skia.googlecode.com/svn/trunk@384 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
593847a0e063522bef780ebac4f4072cf4cae6d8 |
|
25-Aug-2009 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
fix overflow in qsort compare proc git-svn-id: http://skia.googlecode.com/svn/trunk@335 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
9da1ae3f35a6f25adf4f58ae2589129ceec6d11b |
|
22-Jul-2009 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
fix NaN in path iterator fix case where cubic is big/degenerate, and never returns a valid edge git-svn-id: http://skia.googlecode.com/svn/trunk@280 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
d252db03d9650013b545ef9781fe993c07f8f314 |
|
01-Apr-2009 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
API change: SkPath computeBounds -> getBounds git-svn-id: http://skia.googlecode.com/svn/trunk@140 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
c07d23a6e220c0aff36e3e4e06c1b685a440108e |
|
06-Feb-2009 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Chop quads exactly on the clip bounds, so we don't spend CPU cycles walking them when we're above or below the clip. Still to do: - chop in X to avoid 16.16. overflow in the edgelist - apply the same logic for cubics (tho much harder math) git-svn-id: http://skia.googlecode.com/svn/trunk@88 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
fc25abdabff76f913fb9d4f373418c10a1eca92b |
|
15-Jan-2009 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
fix warnings git-svn-id: http://skia.googlecode.com/svn/trunk@68 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|
8a1c16ff38322f0210116fa7293eb8817c7e477e |
|
17-Dec-2008 |
reed@android.com <reed@android.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
grab from latest android git-svn-id: http://skia.googlecode.com/svn/trunk@27 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkScan_Path.cpp
|