Cross Reference: /drivers/scsi/be2iscsi/be

History log of /drivers/scsi/be2iscsi/be_main.c
Revision	Date	Author	Comments (<<< Hide modified files) (Show modified files >>>)
d04baa157d1b35cbd27c87b4a13111d9675b61f3	10-Jan-2012	Linus Torvalds <torvalds@linux-foundation.org>	Merge tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6 SCSI updates for post 3.2 merge window * tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6: (67 commits) [SCSI] lpfc 8.3.28: Update driver version to 8.3.28 [SCSI] lpfc 8.3.28: Add Loopback support for SLI4 adapters [SCSI] lpfc 8.3.28: Critical Miscellaneous fixes [SCSI] Lpfc 8.3.28: FC and SCSI Discovery Fixes [SCSI] lpfc 8.3.28: Add support for ABTS failure handling [SCSI] lpfc 8.3.28: SLI fixes and added SLI4 support [SCSI] lpfc 8.3.28: Miscellaneous fixes in sysfs and mgmt interfaces [SCSI] mpt2sas: Removed redundant calling of _scsih_probe_devices() from _scsih_probe [SCSI] mac_scsi: Remove obsolete IRQ_FLG_* users [SCSI] qla4xxx: Update driver version to 5.02.00-k10 [SCSI] qla4xxx: check for FW alive before calling chip_reset [SCSI] qla4xxx: Fix qla4xxx_dump_buffer to dump buffer correctly [SCSI] qla4xxx: Fix the IDC locking mechanism [SCSI] qla4xxx: Wait for disable_acb before doing set_acb [SCSI] qla4xxx: Don't recover adapter if device state is FAILED [SCSI] qla4xxx: fix call trace on rmmod with ql4xdontresethba=1 [SCSI] qla4xxx: Fix CPU lockups when ql4xdontresethba set [SCSI] qla4xxx: Perform context resets in case of context failures. [SCSI] iscsi class: export pid of process that created [SCSI] mpt2sas: Remove unused duplicate diag_buffer_enable param ...
587a1f1659e8b330b8738ef4901832a2b63f0bed	24-Jul-2011	Al Viro <viro@zeniv.linux.org.uk>	switch ->is_visible() to returning umode_t Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> /drivers/scsi/be2iscsi/be_main.c
4053a4be525d3441cad6cd1ae207177f03eb9ce7	26-Sep-2011	Dan Carpenter <dan.carpenter@oracle.com>	[SCSI] be2iscsi: cleanup a min_t() call "sense_len" was declared as int type but actually it only stores a u16 value that comes from hardware. The cast to u16 in min_t() confuses static analysis because it truncates the int to u16 so I've fixed the declaration to reflect that "sense_len" is just a u16. Also there was a call to cpu_to_be16() which I've changed to be16_to_cpu(). The functions are equivalent, but obviously the hardware is big endian and we're doing the min_t() comparison on CPU endian values. This whole patch is just a cleanup and doesn't affect how the code works. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu> Acked-by: Jayamohan Kallickal <Jayamohan.kallickal@emulex.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com> /drivers/scsi/be2iscsi/be_main.c
acf3368ffb75fc4a83726655d697e79646fe4eb3	27-May-2011	Paul Gortmaker <paul.gortmaker@windriver.com>	scsi: Fix up files implicitly depending on module.h inclusion The module.h header was implicitly present everywhere, so files with no explicit include of the module infrastructure would build anyway. We are now removing the implicit include, and so we need to call out the module.h file that we need explicitly. Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> /drivers/scsi/be2iscsi/be_main.c
bd5354511d00cb9c81c64b0544786807a2209488	08-Oct-2011	Jayamohan Kallickal <jayamohan.kallickal@emulex.com>	[SCSI] be2iscsi: Fix for case where task->sc was cleanedup earlier This patch fixes a bug where the task->sc was cleaned up earlier on a different thread, possibly abort, and the completion comes later. This was causing a crash which has been reported in multiple places Signed-off-by: Jayamohan Kallickal <jayamohan.kallickal@emulex.com> Signed-off-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <JBottomley@Parallels.com> /drivers/scsi/be2iscsi/be_main.c
685e16fdcf4324fe75ff28940311598f01704eaa	08-Oct-2011	Jayamohan Kallickal <jayamohan.kallickal@emulex.com>	[SCSI] be2iscsi: Fix for wrong dmsg setting in wrb This patch fixes wrong dmsg setting when we send out wrb. If the ttt is not ISCSI_RESERVED_TAG then we should be setting dmsg=1 so that the completion is done without waiting for a iscsi level response from the target Signed-off-by: Jayamohan Kallickal <jayamohan.kallickal@emulex.com> Signed-off-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <JBottomley@Parallels.com> /drivers/scsi/be2iscsi/be_main.c
e528586079a20c3d28a490ec8e3271bb4348fc3e	08-Oct-2011	Jayamohan Kallickal <jayamohan.kallickal@emulex.com>	[SCSI] be2iscsi: Fix for kdump failure This patch fixes the Kdump failure reported by Redhat wich was caused by be2iscsi resetting the Chip when be2iscsi detects it is in crashdump mode. If be2net was loaded before be2iscsi then this leaves be2net driver hanging on to resources that the chip stopped recognising after the reset. This patch replaces chip reset with Function reset so that only the particular function and not the whole chip is affected Signed-off-by: Jayamohan Kallickal <jayamohan.kallickal@emulex.com> Signed-off-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <JBottomley@Parallels.com> /drivers/scsi/be2iscsi/be_main.c
8dce69ff481a8d17a7d1027f23595083f28b4556	22-Aug-2011	Jayamohan Kallickal <jayamohan.kallickal@emulex.com>	[SCSI] be2iscsi: Add pci_disable device This patch adds call to pci_disable_device during rmmod and shutdown. The lack of this call was causing hang in insmod - rmmod loop test Signed-off-by: Jayamohan Kallickal <jayamohan.kallickal@emulex.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com> /drivers/scsi/be2iscsi/be_main.c
25602c97f50e4b7fea84d2c81326dc5e372ca868	22-Aug-2011	Jayamohan Kallickal <jayamohan.kallickal@emulex.com>	[SCSI] be2iscsi: Adding a shutdown Routine This patch adds a shutdown routine. It fixes a bug where when be2net and be2iscsi are both used be2iscsi was not cleaning up its resources properly causing be2net to fail to get loaded when the system is rebooted. Signed-off-by: Jayamohan Kallickal <jayamohan.kallickal@emulex.com> Signed-off-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <JBottomley@Parallels.com> /drivers/scsi/be2iscsi/be_main.c
8fcfb21073ea4f4261c8ee3ccd2fde8e281a4f28	25-Aug-2011	Jayamohan Kallickal <jayamohan.kallickal@emulex.com>	[SCSI] be2iscsi: Fixing the /proc/interrupts problem V3 Fix be2iscsi driver to use a separate pointer for each irq action->name field and avoid display corruption in /proc/interrupts. The be2iscsi driver was using a single static array in a function for the irq action->name field. This results in garbage output from /proc/interrupts The pointer for action->name is garbage and scribbles the output on the screen. This patch fixes the problem: 156: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 PCI-MSI-X beiscsi_msix_0017 This patch is based on Prarit's patch here: http://www.spinics.net/lists/linux-scsi/msg52325.html but I have fixed up the failure paths and removed redundant check for !i suggested by Eike. Signed-off-by: Jayamohan Kallickal <jayamohan.kallickal@emulex.com> Signed-off-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <JBottomley@Parallels.com> /drivers/scsi/be2iscsi/be_main.c
f27fb2ef7bd88c9c5f67befe4d85e2155aa0e1a8	25-Jul-2011	Mike Christie <michaelc@cs.wisc.edu>	[SCSI] iscsi class: sysfs group is_visible callout for iscsi host attrs The iscsi class currently does not support writable sysfs attrs for LLD sysfs settings. This patch converts the iscsi class and driver's host attrs to use the attribute container sysfs group and the sysfs group's is_visible callout to be able to support readable or writable sysfs attrs. Signed-off-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <JBottomley@Parallels.com> /drivers/scsi/be2iscsi/be_main.c
1d063c17298d7cd26cfe350f1e93e1727b4aa53f	25-Jul-2011	Mike Christie <michaelc@cs.wisc.edu>	[SCSI] iscsi class: sysfs group is_visible callout for session attrs The iscsi class currently does not support writable sysfs attrs for LLD sysfs settings. This patch converts the iscsi class and driver's session attrs to use the attribute container sysfs group and the sysfs group's is_visible callout to be able to support readable or writable sysfs attrs. Signed-off-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <JBottomley@Parallels.com> /drivers/scsi/be2iscsi/be_main.c
3128c6c73cdf3df92c3165bfb785ae50114d18bf	25-Jul-2011	Mike Christie <michaelc@cs.wisc.edu>	[SCSI] iscsi cls: sysfs group is_visible callout for conn attrs The iscsi class currently does not support writable sysfs attrs for LLD sysfs settings. This patch converts the iscsi class and drivers to use the attribute container sysfs group and the sysfs group's is_visible callout to be able to support readable or writable sysfs attrs. Signed-off-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <JBottomley@Parallels.com> /drivers/scsi/be2iscsi/be_main.c
f457a46f179df41b0f6d80dee33b6e629945f276	24-Jun-2011	Mike Christie <michaelc@cs.wisc.edu>	[SCSI] iscsi_ibft, be2iscsi, iscsi_boot: fix boot kobj data lifetime management be2iscsi passes the boot functions its phba object which is allocated in the shost, but iscsi_ibft passes in a object allocated for each item to display. The problem is that iscsi_boot_sysfs was managing the lifetime of the object passed in and doing a kfree on release. This causes a double free for be2iscsi which frees the shost in its pci_remove. This patch fixes the problem by adding a release callback which the drivers can call kfree or a put() type of function (needed for be2iscsi which will do a get/put on the shost). Signed-off-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <JBottomley@Parallels.com> /drivers/scsi/be2iscsi/be_main.c
9d04516310aaef3970c642a54531a52123001178	24-Jun-2011	Mike Christie <michaelc@cs.wisc.edu>	[SCSI] iscsi_boot_sysfs: have this module check for null on destruction This moves the check for NULL boot_sets to the iscsi_boot_sysfs module instead of having the drivers do it. Signed-off-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <JBottomley@Parallels.com> /drivers/scsi/be2iscsi/be_main.c
516f43a2a555000e77c1d59b8298cb46aad9ecc1	17-Jun-2011	Andy Grover <agrover@redhat.com>	[SCSI] iscsi: Use struct scsi_lun in iscsi structs instead of u8[8] struct scsi_lun is also just a struct with an array of 8 octets (64 bits) but using it instead in iscsi structs lets us call scsilun_to_int without a cast, and also lets us copy it using assignment, instead of memcpy(). Signed-off-by: Andy Grover <agrover@redhat.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com> /drivers/scsi/be2iscsi/be_main.c
57d19e80f459dd845fb3cfeba8e6df8471bac142	23-May-2011	Linus Torvalds <torvalds@linux-foundation.org>	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (39 commits) b43: fix comment typo reqest -> request Haavard Skinnemoen has left Atmel cris: typo in mach-fs Makefile Kconfig: fix copy/paste-ism for dell-wmi-aio driver doc: timers-howto: fix a typo ("unsgined") perf: Only include annotate.h once in tools/perf/util/ui/browsers/annotate.c md, raid5: Fix spelling error in comment ('Ofcourse' --> 'Of course'). treewide: fix a few typos in comments regulator: change debug statement be consistent with the style of the rest Revert "arm: mach-u300/gpio: Fix mem_region resource size miscalculations" audit: acquire creds selectively to reduce atomic op overhead rtlwifi: don't touch with treewide double semicolon removal treewide: cleanup continuations and remove logging message whitespace ath9k_hw: don't touch with treewide double semicolon removal include/linux/leds-regulator.h: fix syntax in example code tty: fix typo in descripton of tty_termios_encode_baud_rate xtensa: remove obsolete BKL kernel option from defconfig m68k: fix comment typo 'occcured' arch:Kconfig.locks Remove unused config option. treewide: remove extra semicolons ...
665d6d94b73f1d706d6c006264cce7537ac708f4	29-Apr-2011	Jayamohan Kallickal <jayamohan.kallickal@emulex.com>	[SCSI] be2iscsi: fix boot hang due to interrupts not getting rearmed This patch fixes a bug where the interrupts were not rearmed if the Interrupt Mask was enabled. This patch checks for Interrupt mask enabled and still rearms interrupt generation even if the Interrupt mask was enabled Signed-off-by: Jayamohan Kallickal <jayamohan.kallickal@emulex.com> Signed-off-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <James.Bottomley@suse.de> /drivers/scsi/be2iscsi/be_main.c
1390b01b26300d42662e436d8f1d307c4e0903c7	25-Mar-2011	Jayamohan Kallickal <jayamohan.kallickal@emulex.com>	[SCSI] be2iscsi: Fix for proper setting of FW There was a bug in setting up type and dmsg for FW Signed-off-by: Jayamohan Kallickal <jayamohan.kallickal@emulex.com> Signed-off-by: James Bottomley <James.Bottomley@suse.de> /drivers/scsi/be2iscsi/be_main.c
0b1d3cbf51f75eaaabdb904f02362368487e2aa7	25-Mar-2011	Jayamohan Kallickal <jayamohan.kallickal@emulex.com>	[SCSI] be2iscsi: check boot_kset is created before destroying it Signed-off-by: Jayamohan Kallickal <jayamohan.kallickal@emulex.com> Signed-off-by: James Bottomley <James.Bottomley@suse.de> /drivers/scsi/be2iscsi/be_main.c
255fa9a3cce3e344ff245cf3b4fbb738bd7e3f48	25-Mar-2011	Jayamohan Kallickal <jayamohan.kallickal@emulex.com>	[SCSI] be2iscsi: change in copyright notice - Modifying copyright year to 2011 - Replacing Serverengines with Emulex as Serverengines Corp has been acquired by Emulex Corp Signed-off-by: Jayamohan Kallickal <jayamohan.kallickal@emulex.com> Signed-off-by: James Bottomley <James.Bottomley@suse.de> /drivers/scsi/be2iscsi/be_main.c
6eab04a87677a37cf15b52e2b4b4fd57917102ad	09-Apr-2011	Justin P. Mattock <justinmattock@gmail.com>	treewide: remove extra semicolons Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz> /drivers/scsi/be2iscsi/be_main.c
c55d267de274d308927b60c3e740c1a826832317	18-Mar-2011	Linus Torvalds <torvalds@linux-foundation.org>	Merge git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6 * git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6: (170 commits) [SCSI] scsi_dh_rdac: Add MD36xxf into device list [SCSI] scsi_debug: add consecutive medium errors [SCSI] libsas: fix ata list corruption issue [SCSI] hpsa: export resettable host attribute [SCSI] hpsa: move device attributes to avoid forward declarations [SCSI] scsi_debug: Logical Block Provisioning (SBC3r26) [SCSI] sd: Logical Block Provisioning update [SCSI] Include protection operation in SCSI command trace [SCSI] hpsa: fix incorrect PCI IDs and add two new ones (2nd try) [SCSI] target: Fix volume size misreporting for volumes > 2TB [SCSI] bnx2fc: Broadcom FCoE offload driver [SCSI] fcoe: fix broken fcoe interface reset [SCSI] fcoe: precedence bug in fcoe_filter_frames() [SCSI] libfcoe: Remove stale fcoe-netdev entries [SCSI] libfcoe: Move FCOE_MTU definition from fcoe.h to libfcoe.h [SCSI] libfc: introduce __fc_fill_fc_hdr that accepts fc_hdr as an argument [SCSI] fcoe, libfc: initialize EM anchors list and then update npiv EMs [SCSI] Revert "[SCSI] libfc: fix exchange being deleted when the abort itself is timed out" [SCSI] libfc: Fixing a memory leak when destroying an interface [SCSI] megaraid_sas: Version and Changelog update ... Fix up trivial conflicts due to whitespace differences in drivers/scsi/libsas/{sas_ata.c,sas_scsi_host.c}
c7f7fd5b7ea114e0f85fc4f2a853f6564410588d	16-Feb-2011	Mike Christie <michaelc@cs.wisc.edu>	[SCSI] be2iscsi: fix null ptr ref in conn get param The ep_disconnect function could be freeing the ep while beiscsi_conn_get_param is running. This has the driver use the get ep param callback instead of the get conn param to fix this. Signed-off-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <James.Bottomley@suse.de> /drivers/scsi/be2iscsi/be_main.c
278274d544e6c6b02312fee59817faa6e810b03a	01-Feb-2011	Tejun Heo <tj@kernel.org>	scsi/be2iscsi,qla2xxx: convert to alloc_workqueue() Switch to new workqueue interface alloc_workqueue(). These are identity conversions. Signed-off-by: Tejun Heo <tj@kernel.org> Acked-by: Madhuranath Iyengar <Madhu.Iyengar@qlogic.com> Cc: Jayamohan Kallickal <jayamohank@serverengines.com> Cc: Andrew Vasquez <andrew.vasquez@qlogic.com> Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com> Cc: linux-scsi@vger.kernel.org /drivers/scsi/be2iscsi/be_main.c
1227633a441363642cdbaf38c4241d071e917095	31-Dec-2010	Mike Christie <michaelc@cs.wisc.edu>	[SCSI] be2iscsi: fix null ptr when accessing task hdr If alloc_pdu fails then the task->hdr pointer may not be set. This adds a check for this case in the cleanup callback. Signed-off-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <James.Bottomley@suse.de> /drivers/scsi/be2iscsi/be_main.c
bc7accec8788ada4f459461194c2b8fad94ed239	31-Dec-2010	Mike Christie <michaelc@cs.wisc.edu>	[SCSI] be2iscsi: fix gfp use in alloc_pdu The pdu allication callout is called from a spin lock and in the IO path so we cannot use GFP_KERNEL. This has the driver use GFP_ATOMIC. Signed-off-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <James.Bottomley@suse.de> /drivers/scsi/be2iscsi/be_main.c
58ff4bd042adf8013c8f70fd03c2c0f8d022e387	06-Oct-2010	Jayamohan Kallickal <jayamohan.kallickal@emulex.com>	[SCSI] be2iscsi: SGE Len == 64K Signed-off-by: Jayamohan Kallickal <jayamohan.kallickal@emulex.com> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <James.Bottomley@suse.de> /drivers/scsi/be2iscsi/be_main.c
c7acc5b8f9a0e6cb17d313ebfbc5d392aa837ac7	22-Jul-2010	Jayamohan Kallickal <jayamohank@serverengines.com>	[SCSI] be2iscsi: Add support for iscsi boot This patch contains changes for adding support for iscsi_boot. Have modified to make read of mac address from chip as a function. The mac_address is being cached after teh first call as it is not expected to change Signed-off-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: Jayamohan Kallickal <jayamohank@serverengines.com> Signed-off-by: James Bottomley <James.Bottomley@suse.de> /drivers/scsi/be2iscsi/be_main.c
3cbb7a74a76e45f5e410367259844e8266fba6ec	22-Jul-2010	Jayamohan Kallickal <jayamohank@serverengines.com>	[SCSI] be2iscsi: Fix for premature buffer free This patch fixes a bug where the buffer was being freed as soon as submission to HW is done. Signed-off-by: Jayamohan Kallickal <jayamohank@serverengines.com> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <James.Bottomley@suse.de> /drivers/scsi/be2iscsi/be_main.c
0aa094331b19e54f928e2ac083285ff68d91c69b	22-Jul-2010	Jayamohan Kallickal <jayamohank@serverengines.com>	[SCSI] be2iscsi: Remove debug print in IO path This patch removes a Debug Print in the IO path Signed-off-by: Jayamohan Kallickal <jayamohank@serverengines.com> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <James.Bottomley@suse.de> /drivers/scsi/be2iscsi/be_main.c
d2cecf0dcb2eb066756e0303d9f162ebe20d0591	22-Jul-2010	Jayamohan Kallickal <jayamohank@serverengines.com>	[SCSI] be2iscsi: Maintain same ITT across login This patch ensures that the same ITT is maintained across all login pdu's Signed-off-by: Jayamohan Kallickal <jayamohank@serverengines.com> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <James.Bottomley@suse.de> /drivers/scsi/be2iscsi/be_main.c
e9b911935033ea9e28a2f7a274c9a81db1f8d91a	22-Jul-2010	Jayamohan Kallickal <jayamohank@serverengines.com>	[SCSI] be2iscsi: Adding crashdump support These changes allow the driver to support crashdump. We need to reset the chip incase of a crashdump Signed-off-by: Jayamohan Kallickal <jayamohank@serverengines.com> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <James.Bottomley@suse.de> /drivers/scsi/be2iscsi/be_main.c
4f5af07e1bc4ae64b7a7ead5bf60f40a3115ceeb	22-Jul-2010	Jayamohan Kallickal <jayamohank@serverengines.com>	[SCSI] be2iscsi: Fix to handle request_irq failure This patch handles request_irq failures by properly cleaning up Signed-off-by: Jayamohan Kallickal <jayamohank@serverengines.com> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <James.Bottomley@suse.de> /drivers/scsi/be2iscsi/be_main.c
238f6b7255c68d2774795c97b32701c09fd1e543	22-Jul-2010	Jayamohan Kallickal <jayamohank@serverengines.com>	[SCSI] be2iscsi: No return value for hwi_enable_intr hwi_enable_intr need not return any value. This patch fixes the that and removes code designed to handle a failure return value Signed-off-by: Jayamohan Kallickal <jayamohank@serverengines.com> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <James.Bottomley@suse.de> /drivers/scsi/be2iscsi/be_main.c
03a1231009927b7168d6d86a7a7f6c7f9b4be85a	22-Jul-2010	Jayamohan Kallickal <jayamohank@serverengines.com>	[SCSI] be2iscsi: Fixing the return type of functions Fixing some functions return values that did not match with the possible return values Signed-off-by: Jayamohan Kallickal <jayamohank@serverengines.com> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <James.Bottomley@suse.de> /drivers/scsi/be2iscsi/be_main.c
d3ad2bb31c26d7314fad98da8abb04f4fa24ed16	22-Jul-2010	Jayamohan Kallickal <jayamohank@serverengines.com>	[SCSI] be2iscsi: Fixing return values This patch fixes the return values as per comment from Mike Christie Signed-off-by: Jayamohan Kallickal <jayamohank@serverengines.com> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <James.Bottomley@suse.de> /drivers/scsi/be2iscsi/be_main.c
457ff3b7dc3796d8778286217ad304ff122e948f	22-Jul-2010	Jayamohan Kallickal <jayamohank@serverengines.com>	[SCSI] be2iscsi: Fix warnings from new checkpatch.pl The latest checkpatch.pl throws some new warnings. Fixing it to get rid of a bunch of warnings Signed-off-by: Jayamohan Kallickal <jayamohank@serverengines.com> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <James.Bottomley@suse.de> /drivers/scsi/be2iscsi/be_main.c
82284c09c5dc5c5a5046f3c852f2683dab60109c	10-Jun-2010	Dan Carpenter <error27@gmail.com>	[SCSI] be2iscsi: fix null dereference on error path "phba" is always null here so we can't dereference it. Signed-off-by: Dan Carpenter <error27@gmail.com> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <James.Bottomley@suse.de> /drivers/scsi/be2iscsi/be_main.c
1462b8ffd9a9e4798d4e0f9eaadbd1ac0373a11b	10-Jun-2010	Dan Carpenter <error27@gmail.com>	[SCSI] be2iscsi: fix memory leak on error path I added a kfree(pwrb_arr) in front of the return. Signed-off-by: Dan Carpenter <error27@gmail.com> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <James.Bottomley@suse.de> /drivers/scsi/be2iscsi/be_main.c