History log of /drivers/staging/comedi/drivers/usbduxfast.c
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
25985edcedea6396277003854657b5f3cb31a628 31-Mar-2011 Lucas De Marchi <lucas.demarchi@profusion.mobi> Fix common misspellings

Fixes generated by 'codespell' and manually reviewed.

Signed-off-by: Lucas De Marchi <lucas.demarchi@profusion.mobi>
/drivers/staging/comedi/drivers/usbduxfast.c
45f4d0243525b6bc747c946937ced437b135a84d 30-Oct-2010 Thomas Gleixner <tglx@linutronix.de> staging: Final semaphore cleanup

Fixup the last remaining users of DECLARE_MUTEX and init_MUTEX.

Scripted conversion, resulting code is binary equivalent.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
LKML-Reference: <20100907125057.278833764@linutronix.de>
/drivers/staging/comedi/drivers/usbduxfast.c
f69b0d6451679f1466381a46ac7ab671a7b5668c 12-Jul-2010 Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Staging: fix typos concerning "address"

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
94002c07ff0e207a883519ccc35c0b5390b29331 15-May-2010 Julia Lawall <julia@diku.dk> Staging: Use kmemdup

Use kmemdup when some other buffer is immediately copied into the
allocated region.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression from,to,size,flag;
statement S;
@@

- to = \(kmalloc\|kzalloc\)(size,flag);
+ to = kmemdup(from,size,flag);
if (to==NULL || ...) S
- memcpy(to, from, size);
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
643a5420f1df521e08efae7b15d377314b88cb70 05-May-2010 Greg Kroah-Hartman <gregkh@suse.de> Staging: comedi: usbduxfast.c: mark a function static

It does not need to be global.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
de55a7a5a2f17212c8e7c9a391db8ab5b0187c43 27-Feb-2010 Stewart Robertson <stewart_r@aliencamel.com> Staging: comedi: fix comments over 80 issue in usbduxfast.c

This is a patch to the usbduxfast.c file that fixes comments
over 80 warnings found by the checkpatch.pl tool

Signed-off-by: Stewart Robertson <stewart_r@aliencamel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
02c7b237f6a01f580319187d4bdbf712b27a5460 26-Feb-2010 Alessio Igor Bogani <abogani@texware.it> Staging: Cleanup useless headers

BKL isn't anymore present into these files thus it is no necessary still include smp_lock.h.

Signed-off-by: Alessio Igor Bogani <abogani@texware.it>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
9d220c6b54f3d0b141846321814ec1c4e4fbdc67 12-Jan-2010 Uwe Kleine-König <u.kleine-koenig@pengutronix.de> staging: fix typos "aquire" -> "acquire"

This patch was generated by

git grep -E -i -l '[Aa]quire' drivers/staging | xargs -r perl -p -i -e 's/([Aa])quire/$1cquire/'

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
a457732b836b970c82c7ba35b4cfc938c9c543f9 10-Jan-2010 Németh Márton <nm127@freemail.hu> staging: make USB device id constant

The id_table field of the struct usb_device_id is constant in <linux/usb.h>
so it is worth to make the initialization data also constant.

The semantic match that finds this kind of pattern is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
disable decl_init,const_decl_init;
identifier I1, I2, x;
@@
struct I1 {
...
const struct I2 *x;
...
};
@s@
identifier r.I1, y;
identifier r.x, E;
@@
struct I1 y = {
.x = E,
};
@c@
identifier r.I2;
identifier s.E;
@@
const struct I2 E[] = ... ;
@depends on !c@
identifier r.I2;
identifier s.E;
@@
+ const
struct I2 E[] = ...;
// </smpl>

Signed-off-by: Németh Márton <nm127@freemail.hu>
Cc: Julia Lawall <julia@diku.dk>
Cc: cocci@diku.dk
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
9ebfbd45f9d4ee9cd72529cf99e5f300eb398e67 29-Oct-2009 Johannes Berg <johannes@sipsolutions.net> firmware_class: make request_firmware_nowait more useful

Unfortunately, one cannot hold on to the struct firmware
that request_firmware_nowait() hands off, which is needed
in some cases. Allow this by requiring the callback to
free it (via release_firmware).

Additionally, give it a gfp_t parameter -- all the current
users call it from a GFP_KERNEL context so the GFP_ATOMIC
isn't necessary. This also marks an API break which is
useful in a sense, although that is obviously not the
primary purpose of this change.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Cc: Ming Lei <tom.leiming@gmail.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: David Woodhouse <David.Woodhouse@intel.com>
Cc: Pavel Roskin <proski@gnu.org>
Cc: Abhay Salunke <abhay_salunke@dell.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
0a85b6f0ab0d2edb0d41b32697111ce0e4f43496 08-Jun-2009 Mithlesh Thukral <mithlesh@linsyssoft.com> Staging: Comedi: Lindent changes to comdi driver in staging tree

Lindent changes to comdi driver in staging tree.
This patch is followed by the checkpatch.pl error fixes.
Did not make them part of this patch as the patch size is already huge.

Signed-off-by: Mithlesh Thukral <mithlesh@linsyssoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
efe8d60a923ddd00de394381cb30aab5114b71a4 24-May-2009 Bernd Porr <BerndPorr@f2s.com> Staging: comedi: usbdux: buffer overflow error handling

These changes guarantee that the URBs are not resubmitted in case of a
comedi buffer overflow. Otherwise this runs in the background even when
the userspace program has terminated.

From: Bernd Porr <BerndPorr@f2s.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
81874ff7895f332920621104308e803434a17183 17-Apr-2009 Bernd Porr <BerndPorr@f2s.com> Staging: comedi: convert usbdux* to use firmware_request

The firmware is now in the linux-firmware tree, so we can move these two
drivers to use the proper request_firmware infrastructure.


From: Bernd Porr <BerndPorr@f2s.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
70265d24e3404fe798b6edd55a02016b1edb49d7 26-Mar-2009 Jiri Slaby <jirislaby@gmail.com> staging: comedi, remove interrupt.h

Remove interrupt wraparound. Use defines from linux/interrupt.h
instead.

Change also parameter types of functions taking ISR to irq_handler_t.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: David Schleef <ds@schleef.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
0707bb04be89b18ee83b5a997e36cc585f0b988d 17-Mar-2009 Bill Pemberton <wfp5p@virginia.edu> Staging: comedi: Remove comedi_devconfig typedef

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
90035c0886b256d75bced13b3b3cea5234aff136 17-Mar-2009 Bill Pemberton <wfp5p@virginia.edu> Staging: comedi: Remove comedi_insn typedef

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
ea6d0d4cab4f4f2d6a88f3bce4707fe92696fd3f 17-Mar-2009 Bill Pemberton <wfp5p@virginia.edu> Staging: comedi: Remove comedi_cmd typedef

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
9ced1de69125b60f40127eddaa3be2a92bb0a1df 17-Mar-2009 Bill Pemberton <wfp5p@virginia.edu> Staging: comedi: Remove comedi_lrange typedef

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
139dfbdfacb02e3ef3df936d2fabd1ad5f14ea88 17-Mar-2009 Bill Pemberton <wfp5p@virginia.edu> Staging: comedi: Remove comedi_driver typedef

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
34c43922e62708d45e9660eee4b4f1fb7b4bf2c7 17-Mar-2009 Bill Pemberton <wfp5p@virginia.edu> Staging: comedi: Remove comedi_subdevice typedef

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
71b5f4f11971dea972832ad63a994c7e5b45db6b 17-Mar-2009 Bill Pemberton <wfp5p@virginia.edu> Staging: comedi: Remove comedi_device typedef

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
790c55415aa31f4c732729f94d2c3a54f7d3bfc2 17-Mar-2009 Bill Pemberton <wfp5p@virginia.edu> Staging: comedi: Remove lsampl_t and sampl_t typedefs

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
e57795a1a7ebf8ac91cfb82070cf19bf01ee4ac0 03-Mar-2009 Mariusz Kozlowski <m.kozlowski@tuxland.pl> Staging: comedi: usbduxfast: balance semaphores up/down in attach error path

Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Cc: Bernd Porr <BerndPorr@f2s.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: David Schleef <ds@schleef.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
3944969427e11f3081d676c16cebeff4060ce992 03-Mar-2009 Mariusz Kozlowski <m.kozlowski@tuxland.pl> Staging: comedi: usbduxfast: don't initialize semaphores on init

This patch removes usbduxfast semaphores initialization
from init function as they are initialized later on in
probe function. Also remove init_usb_devices() as it is
not needed anymore.

Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Cc: Bernd Porr <BerndPorr@f2s.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: David Schleef <ds@schleef.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
38c39e43f90fa7ab891a2590a59497fe0a10cee2 03-Mar-2009 Mariusz Kozlowski <m.kozlowski@tuxland.pl> Staging: comedi: usbduxfast: remove .bss variable initialization

This patch removes explicit zeroing of usbduxfastsub
variable on init because it is in .bss section.

Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Cc: Bernd Porr <BerndPorr@f2s.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: David Schleef <ds@schleef.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
d52a63bf6a298c4ffca6a5735926a585f3dd69e0 11-Mar-2009 Bernd Porr <BerndPorr@f2s.com> Staging: comedi: usbduxfast: fix run-time error

If debugging is enabled, this printk will oops, fix that issue.


From: Bernd Porr <BerndPorr@f2s.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: David Schleef <ds@schleef.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
6742c0af2ef2d8ff70e379ebf8a8541190ff44e6 09-Dec-2008 Bernd Porr <BerndPorr@f2s.com> Staging: comedi: usbdux[fast] firmware upload changes

usbdux and usbduxfast upload now their firmware via the firmware kernel
meachanism. No udev rules are needed for that except the default ones.
The firmware will usually be loaded from /lib/firmware. Upload via
comedi_config is still possible for static comedi devices
(comedi_num_legacy_minors>0).

Frank, thanks for the example code which sped up rewriting of the code
substantially.

From: Bernd Porr <BerndPorr@f2s.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: David Schleef <ds@schleef.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
3cd74e8693678a463b944c358cdb22f7bee533ba 06-Dec-2008 Frank Mori Hess <fmhess@users.sourceforge.net> Staging: comedi: usbduxfast bugfix

Fixed bug in firmware loading with multiple usbduxfast boards.

From: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: David Schleef <ds@schleef.org>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
7dcb582cd4b0c67e0053fbb87706bd0922d79027 16-Feb-2009 Mariusz Kozlowski <m.kozlowski@tuxland.pl> Staging: comedi: usbduxfast: annotate __init and __exit functions

This patch adds __init and __exit annotations to proper functions in the
usbduxfast driver.

Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Cc: Bernd Porr <BerndPorr@f2s.com>
Cc: David Schleef <ds@schleef.org>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
4e8ad0dca9bbd9724ffa395b9ab425c4f22e1346 16-Feb-2009 Mariusz Kozlowski <m.kozlowski@tuxland.pl> Staging: comedi: usbduxfast: fix checkpatch issues plus some style cleanups etc.

This patch is a major code rewrite to make checkpatch.pl happy and also
other minor things are fixed.

Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Cc: Bernd Porr <BerndPorr@f2s.com>
Cc: David Schleef <ds@schleef.org>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
0a3b8b642247b509d3308cd9c32156d21505fcb8 16-Feb-2009 Mariusz Kozlowski <m.kozlowski@tuxland.pl> Staging: comedi: usbduxfast: add comedi debug to Kconfig

This patch moves CONFIG_COMEDI_DEBUG to Kconfig and cleans up the code
as it didn't actually compile with debug enabled.

Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Cc: Bernd Porr <BerndPorr@f2s.com>
Cc: David Schleef <ds@schleef.org>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
6fffdb355c326b26482307d421b55fc00ee2abbc 16-Feb-2009 Mariusz Kozlowski <m.kozlowski@tuxland.pl> Staging: comedi: usbduxfast: remove kernel version checks

This patch removes kernel version checks from usbduxfast driver as the
driver is in the main kernel tree now.

Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Cc: Bernd Porr <BerndPorr@f2s.com>
Cc: David Schleef <ds@schleef.org>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
98ccdc56a067b267fc87f68c1d1ad1f2f237e217 26-Dec-2008 Julia Lawall <julia@diku.dk> Staging: comedi: Move a dereference below a NULL test

If the NULL test is necessary, then the dereference should be moved below
the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/).

// <smpl>
@disable is_null@
identifier f;
expression E;
identifier fld;
statement S;
@@

+ if (E == NULL) S
f(...,E->fld,...);
- if (E == NULL) S

@@
identifier f;
expression E;
identifier fld;
statement S;
@@

+ if (!E) S
f(...,E->fld,...);
- if (!E) S
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
b171041be02f171cd06712746b97a996f883ec10 25-Dec-2008 Julia Lawall <julia@diku.dk> Staging: comedi: introduce missing kfree

Error handling code following a kmalloc should free the allocated data.

The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,l;
position p1,p2;
expression *ptr != NULL;
@@

(
if ((x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...)) == NULL) S
|
x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
)
<... when != x
when != if (...) { <+...x...+> }
x->f = E
...>
(
return \(0\|<+...x...+>\|ptr\);
|
return@p2 ...;
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
8867635903ea4c52776820954ae7aaaca1e438cb 19-Nov-2008 Greg Kroah-Hartman <gregkh@suse.de> Staging: comedi: usbduxfast: remove comedi usb wrappers

Remove the comedi usb wrapper function usage in the usbduxfast driver as
they are no longer needed.

Cc: Bernd Porr <BerndPorr@f2s.com>
Cc: David Schleef <ds@schleef.org>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c
f47c697d130087831ac47bbbd2758c01de2e7081 14-Nov-2008 Bernd Porr <BerndPorr@f2s.com> Staging: comedi: add usb usbduxfast driver

ITL USB-DUXfast driver

From: Bernd Porr <BerndPorr@f2s.com>
Cc: David Schleef <ds@schleef.org>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
/drivers/staging/comedi/drivers/usbduxfast.c